[Koha-bugs] [Bug 24027] Adding multiple items is slow

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24027

--- Comment #2 from Andrew Nugged <nugged at gmail.com> ---
Created attachment 95414
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95414&action=edit
Bug 24027: (follow-up) ModZebra should be called once after all items added,
not on each item add

Why happened:
- call to ModZebra was done after EACH item added,
  but it was called only with main biblionumber only,
  so call was the same on each of requests
- and also time spent in that ModZebra sub increased with every
  next hundred items in DB for that element: so adding every next 100
  was slower and slower,

Solved:
- now it's called only once (by adding some extra parameter to "AddItem*" sub
set in postponed mode)
- and now adding of elements not so heavily depends from how much items was in
DB before.

Test plan / How to replicate the issue:
(test depends from how already populated DB and Zebra/Elasticsearch DBs
 so might be not so noticeably fast on empty DBs)

- go to one of bibliotitems cataloguing/additem.pl?biblionumber=XXX pages
- press button "add multiple copies of this item", put 1000 on slower machines,
5000 on faster
- start measuring time + submit page/form

It takes some serious amount of time even up to timeout.
After applying patch, same procedure for same number of items.
Also it much less slows down when number of items rises, more linearly.

But, again, it heavily depends how database is populated and indexes are
rebuild
but it's obvious that it will me much more efficient call "ModZebra" once after
1000 addings,
then 1000 times on each item copied.

-- 
You are receiving this mail because:
You are watching all bug changes.