[Koha-bugs] [Bug 24016] manager_id in Koha::Patron::Message->store should not depend on userenv alone

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24016

--- Comment #7 from Lari Taskula <lari.taskula at hypernova.fi> ---
(In reply to Joonas Kylmälä from comment #6)
> I think I'm missing some context from here. Why manager id should be
> overwrite-able even if defined in userenv?

The point is that userenv should not be the only way to set manager_id (or any
other values of Koha::Objects), because we can not expect userenv to be
defined. It breaks in REST API when you are using basic auth method.

Also, it's not a very nice idea to forcefully restrict developers using models
in such way. I think the use of userenv should only be a fall-back method of
accessing user data in Koha::Objects.

-- 
You are receiving this mail because:
You are watching all bug changes.