[Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260

--- Comment #19 from Agustín Moyano <agustinmoyano at theke.io> ---
(In reply to Christopher Brannon from comment #18)
> (In reply to Maryse Simard from comment #5)
> > Created attachment 93052 [details] [review] [review]
> > Bug 23260: Add anonymize items_last_borrower feature
> > 
> > This patch adds the feature to anonymize patrons from items_last_borrower
> > table. This code is run from batch_anonymize script, which is triggered from
> > a cron job.
> > 
> > To test:
> > 1) apply this patch and the previous one
> > 2) perl installer/data/mysql/updatedatabase.pl
> > 3) set StoreLastBorrower preference to Allow.
> > 4) Create a Check out followed by a Check in.
> > CHECK => a row should appear in items_last_borrower table with the borrower
> > and the item number.
> > 5) In mysql, update created_on date to one day earlier.
> > 6) set AnonymousPatron preference to a valid patron id
> > 7) perl misc/cronjobs/batch_anonymise.pl
> > SUCCESS => borrower number in items_last_borrower changed to AnonymousPatron
> > id
> > 8) repeat steps 4 and 5
> > 9) set AnonymousPatron preference to 0
> > 10) perl misc/cronjobs/batch_anonymise.pl
> > SUCCESS => borrower number in items_last_borrower changed to null
> > 11) prove t/db_dependent/Koha/Patrons.t
> > 12) Sign off
> > 
> > Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>
> 
> Your test plan has me concerned.  If you must first set the feature to allow
> (#3), which is what Koha currently does without this feature, it sounds like
> this feature is not on by default.  Is that true?  It should retain the
> current behavior of Koha by default.

Hi Christopher, thanks for checking this out.

This bug does not touch the StoreLastBorrower's default value (I had to change
it in my koha-testing-docker, so I asumed it came off by default).. It's just
to make sure that preference is set to Allow for the test to succeed.

Sorry if I didn't make this test plan clear.

-- 
You are receiving this mail because:
You are watching all bug changes.