[Koha-bugs] [Bug 23734] Defaults set during patron imports throws warnings
bugzilla-daemon at bugs.koha-community.org
bugzilla-daemon at bugs.koha-community.org
Tue Nov 19 12:40:27 CET 2019
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23734
--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
What you suggest do not remove the warning.
I linked this bug report with bug 21761 as we saw that already in another (but
similar) context.
I tried:
modified: Koha/Object.pm
───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
@ Object.pm:139 @ sub store {
} else {
# If cannot be null, get the default value
# What if cannot be null and does not have a default
value? Possible?
+ undef $self->{$col};
$self->$col($columns_info->{$col}->{default_value});
}
}
And get rid of of one of the 2 warnings.
There is 2 warnings per attributes: on ->set_column (called from ->store, see
previous diff), and a bit later, I guess in update_or_insert
The attributes are the tinyint and not null: privacy_guarantor_fines,
privacy_guarantor_checkouts and anonymized.
We could fix that at controller level but I feel like it must be fixed at
Koha::Object level.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
More information about the Koha-bugs
mailing list