[Koha-bugs] [Bug 23964] An item level hold when placed is set to Waiting, if ReservesNeedReturn is set to Automatic

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23964

--- Comment #13 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to Jonathan Druart from comment #11)
> 725     my $hold_1 = place_item_hold( $patron, $item, $library, $priority );
> 726     $hold = place_item_hold( $patron_2, $item, $library, $priority );
> 727     is( $hold->priority, 1, 'If ReservesNeedReturns is 0 but item
> already on hold priority must be set to 1' );
> 
> What about $hold_1->priority? Should not we have $hold_1->priority == 1
> instead of $hold->priority == 1?

The first hold should get set to waiting, the next hold on the item doesn't
because there is a hold already on the item

> 737     isnt( $hold->priority, 0, 'If ReservesNeedReturns is 0 but item in
> transit the hold must not be set to waiting' );
> 
> Test's description does not match the test.

I do not understand, I place a transfer before this test, the transfer means
the hold is not waiting. Changed to 'is' '1' in any case

-- 
You are receiving this mail because:
You are watching all bug changes.