[Koha-bugs] [Bug 24001] Cannot edit card template

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001

--- Comment #2 from Chris Nighswonger <cnighswonger at foundations.edu> ---
(In reply to Jonathan Druart from comment #1)
> This is even worst with strict_sql_modes turned on, the creation of a new
> template is impossible:
> 
> DBD::mysql::st execute failed: Incorrect integer value: '' for column
> 'profile_id' ... at
> /kohadevbox/koha/C4/Creators/Template.pm line 199.
> Database returned the following error: Incorrect integer value: '' for
> column 'profile_id' at row 1 at /kohadevbox/koha/C4/Creators/Template.pm
> line 201.
> 
> There is a logic issue in the controller, the printer profile list is not
> passed to the template (only passed when editing).

The default profile_id should be 0: http://tinyurl.com/smoh5g6

Which is overwritten here: http://tinyurl.com/s2pj4cs

Probably changing

profile_id      => scalar $cgi->param('profile_id'),

to

profile_id      => scalar $cgi->param('profile_id') || 0,

would fix the acute pain.

I suspect that there are many such issues lurking in the label/patroncard code
unfortunately.

-- 
You are receiving this mail because:
You are watching all bug changes.