[Koha-bugs] [Bug 24033] Fix column labelling on basket summary page (ecost)

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24033

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com

--- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Lisette Scheer from comment #7)
> (In reply to Katrin Fischer from comment #6)
> > Hi Lisette, nice patch!
> > 
> > Just some small things for your next one:
> > 
> > - The first line always needs to start with 'Bug xxxx:'. 
> > - Something seems to happen to the breaks in your patches - no problem, I've
> > fixed it. How do you write the commit message? Maybe try to add an extra
> > empty line after the first.
> 
> 
> Katrin, 
> Thanks for fixing it. 
> I'm using the devbox.
> I'll do:
> 1) git commit basket.tt
> 2) Write the commit notes, following the instructions on the wiki that I
> found here: https://wiki.koha-community.org/wiki/Commit_messages
> 3) :wq! to write and quit. 
> 4) git bz attach -e 24403 HEAD
> 5) Put all the line breaks back in and change the status.
> 
> I did think it was quirky that I had to put the line breaks in again. 
> That was also why I had 2 patches on this one. The first time I forgot to -e
> so I re-attached it after editing.

Hm something is odd there, you shouldn't have to do anything on bugzilla and it
doesn't really work well this way. It sounds like you are using vi in the
devbox. One can change the default editor for git via the config files for the
devbox, maybe this could improve things... but it SHOULD work with vi too :(

-- 
You are receiving this mail because:
You are watching all bug changes.