[Koha-bugs] [Bug 14680] when doing acquisitions from a staged file, MarcFieldsToOrder-syspref discounts are instead added.

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14680

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #6 from Nick Clemens <nick at bywatersolutions.com> ---
This is still valid, but I don't know if these code changes are the ones we
need

You can recreate this without MarcItemFieldsToOrder in fact.

1 - Stage a file
2 - Add to basket form a staged file
3 - For any of the titles check the box to add
4 - In the details set a price, replacement price, and discount
5 - Add the order
6 - ecost is set to price and rrp is the ecost plus dicsount
7 - Repeat but don't set a discount this time (and ensure bookseller has a
discount set)
8 - rrp is set to price, ecost is the rrp minus the discount

Why? It is from bug 7180, so ha been in place since 2014

There is much conversation on the bug, ending with:
"(In reply to mathieu saby from comment #96)
> To be clear : my main concern is the fact that Koha calculates a RRP price >
> 20 EUR from a record with "20.00 EUR" in 010$d field.

Forget the rrp value, it is not used by this patch."

RRP is not really used for anything, it just says the price the vendor set, but
we do have strange behaviour of sometimes the price field being the 'rrp' and
sometimes being the 'ecost'

I think ideally we should use the same display as when adding an order
manually, so the user can choose the fields to enter, and we discount the rrp
to generate ecost unless they specify.

Adding some CC's here

-- 
You are receiving this mail because:
You are watching all bug changes.