[Koha-bugs] [Bug 24114] modules must not warn

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Tue Nov 26 16:31:10 CET 2019


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24114

--- Comment #5 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Jonathan Druart from comment #2)
> I do not understand how to test properly this patch, why do not we have a
> separated flag for this task?
> 
> The following commit 2ca2585b1c5b61024351c32d84e605f61d04a418
>   Bug 21336: Adjust cleanup_database.pl
> says 
>     "Run cleanup_database.pl --logs (or any other flag) for the first time."
> 
> But it sounds wrong to me, I am expecting the script to do what I am asking
> it to do.

Underlying thought is we do not want to override the prefs here. If you run
cleanup, it will cleanup what the prefs control. Do we really need 30 options
or something like that in cleanup? For each simple task it does. I guess this
is again not the only place where this is done.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list