From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 00:55:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2019 22:55:07 +0000 Subject: [Koha-bugs] [Bug 23706] New: Item search CSV export doesn't include collection code Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23706 Bug ID: 23706 Summary: Item search CSV export doesn't include collection code Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: david.roberts at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com If you do an item search in the staff client and send the output to the screen, the collection column will be populated. However, if you export the same search to CSV, the column is present, but contains no data. After poking around, I found that the screen was outputting items.ccode, whereas the CSV was outputting biblioitems.collectiontitle. Both output formats should use items.ccode. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 00:55:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2019 22:55:19 +0000 Subject: [Koha-bugs] [Bug 23706] Item search CSV export doesn't include collection code In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23706 David Roberts changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |david.roberts at ptfs-europe.c |ity.org |om -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 00:55:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2019 22:55:35 +0000 Subject: [Koha-bugs] [Bug 23707] New: Z39.50 import goes to Basic Editor, even when Advanced editor is enabled Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23707 Bug ID: 23707 Summary: Z39.50 import goes to Basic Editor, even when Advanced editor is enabled Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: hayleymapley at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl When the EnableAdvancedCatalogingEditor is set to enabled, I expect that Z39.50 import in the Cataloguing module would take you into the Advanced Editor, as the Advanced Editor and New record buttons do. Here is what I think is expected: https://koha-community.org/manual/19.05/en/html/cataloging.html#advanced-editor-cataloging -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 01:19:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2019 23:19:11 +0000 Subject: [Koha-bugs] [Bug 23706] Item search CSV export doesn't include collection code In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23706 --- Comment #1 from David Roberts --- Created attachment 93335 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93335&action=edit Bug 23706: Item search CSV export doesn't include collection code -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 01:22:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2019 23:22:40 +0000 Subject: [Koha-bugs] [Bug 23706] Item search CSV export doesn't include collection code In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23706 --- Comment #2 from David Roberts --- To test: Perform an item search in the staff client Ensure your screen output contains data in the collection column. Export the same search to CSV, the collection column will not contain any results. Apply the patch Repeat the test. The collection column will now contain data which should match the output to the screen. Check that the CCODE authorised value description displays, instead of just the CCODE policy name -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 01:23:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2019 23:23:35 +0000 Subject: [Koha-bugs] [Bug 23706] Item search CSV export doesn't include collection code In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23706 David Roberts changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #3 from David Roberts --- To test: Perform an item search in the staff client Ensure your screen output contains data in the collection column. Export the same search to CSV, the collection column will not contain any results. Apply the patch Repeat the test. The collection column will now contain data which should match the output to the screen. Check that the CCODE authorised value description displays, instead of just the CCODE policy name -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 01:31:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2019 23:31:04 +0000 Subject: [Koha-bugs] [Bug 23706] Item search CSV export doesn't include collection code In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23706 David Roberts changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david.roberts at ptfs-europe.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 01:34:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2019 23:34:08 +0000 Subject: [Koha-bugs] [Bug 23706] Item search CSV export doesn't include collection code In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23706 --- Comment #4 from David Roberts --- This patch should live in koha-tmpl/intranet-tmpl/prog/en/includes/catalogue/itemsearch_item.csv.inc - I don't know what I've done wrong to get the wrong path in this patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 01:43:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2019 23:43:03 +0000 Subject: [Koha-bugs] [Bug 23706] Item search CSV export doesn't include collection code In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23706 --- Comment #5 from David Roberts --- Created attachment 93336 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93336&action=edit LLP: Bug 23706 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 01:46:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2019 23:46:22 +0000 Subject: [Koha-bugs] [Bug 23706] Item search CSV export doesn't include collection code In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23706 David Roberts changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93335|0 |1 is obsolete| | Attachment #93336|0 |1 is obsolete| | --- Comment #6 from David Roberts --- Created attachment 93337 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93337&action=edit Bug 23706: Item search CSV export doesn't include collection code -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 01:46:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Sep 2019 23:46:59 +0000 Subject: [Koha-bugs] [Bug 23706] Item search CSV export doesn't include collection code In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23706 --- Comment #7 from David Roberts --- I think I've fixed it now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 02:03:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 00:03:47 +0000 Subject: [Koha-bugs] [Bug 23706] Item search CSV export doesn't include collection code In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23706 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 04:26:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 02:26:35 +0000 Subject: [Koha-bugs] [Bug 23708] New: Cataloguing toolbar elements should have distinct IDs Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23708 Bug ID: 23708 Summary: Cataloguing toolbar elements should have distinct IDs Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: hayleymapley at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl To allow for libraries to make specific CSS choices, elements should have IDs. Elements in the cat-toolbar.inc are missing them. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 04:28:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 02:28:04 +0000 Subject: [Koha-bugs] [Bug 23708] Cataloguing toolbar elements should have distinct IDs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23708 Hayley Mapley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |hayleymapley at catalyst.net.n |ity.org |z -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 04:35:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 02:35:59 +0000 Subject: [Koha-bugs] [Bug 23708] Cataloguing toolbar elements should have distinct IDs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23708 --- Comment #1 from Hayley Mapley --- Created attachment 93338 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93338&action=edit Bug 23708: IDs added to links in Edit list in Biblio details.tt Test plan: Apply the patch and check that the elements in the Edit dropdown now all have IDs. Bonus points for confirming that these IDs have not been assigned to any other elements in Koha. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 04:36:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 02:36:30 +0000 Subject: [Koha-bugs] [Bug 23708] Biblio details toolbar elements should have distinct IDs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23708 Hayley Mapley changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Cataloguing toolbar |Biblio details toolbar |elements should have |elements should have |distinct IDs |distinct IDs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 04:59:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 02:59:56 +0000 Subject: [Koha-bugs] [Bug 23708] Biblio details toolbar elements should have distinct IDs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23708 --- Comment #2 from Hayley Mapley --- Created attachment 93339 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93339&action=edit Bug 23708: IDs added to tabs in menu in moredetail.tt Test plan: Same as first patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 05:01:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 03:01:50 +0000 Subject: [Koha-bugs] [Bug 23708] Biblio details toolbar elements should have distinct IDs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23708 Hayley Mapley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93339|0 |1 is obsolete| | --- Comment #3 from Hayley Mapley --- Created attachment 93340 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93340&action=edit Bug 23708: IDs added to tabs in menu in moredetail.tt Test plan: Same as first patch, except the tabs in the menu of the biblio details page instead. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 05:02:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 03:02:37 +0000 Subject: [Koha-bugs] [Bug 23708] Biblio details toolbar elements should have distinct IDs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23708 --- Comment #4 from Hayley Mapley --- Created attachment 93341 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93341&action=edit Bug 23708: IDs added to links in Edit list in Biblio details.tt Test plan: Apply the patch and check that the elements in the Edit dropdown now all have IDs. Bonus points for confirming that these IDs have not been assigned to any other elements in Koha. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 05:03:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 03:03:03 +0000 Subject: [Koha-bugs] [Bug 23708] Biblio details toolbar elements should have distinct IDs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23708 Hayley Mapley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93340|0 |1 is obsolete| | --- Comment #5 from Hayley Mapley --- Created attachment 93342 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93342&action=edit Bug 23708: IDs added to tabs in menu in moredetail.tt Test plan: Same as first patch, except the tabs in the menu of the biblio details page instead. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 05:04:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 03:04:00 +0000 Subject: [Koha-bugs] [Bug 23708] Biblio details toolbar elements should have distinct IDs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23708 Hayley Mapley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93338|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 08:41:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 06:41:23 +0000 Subject: [Koha-bugs] [Bug 23688] System preference uppercasesurnames broken by typo In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23688 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Attachment #93210|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 08:45:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 06:45:28 +0000 Subject: [Koha-bugs] [Bug 23658] WrongTransfer modal drops off specified checkin date on returns.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23658 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |liz at bywatersolutions.com |ity.org | CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 08:45:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 06:45:51 +0000 Subject: [Koha-bugs] [Bug 22804] OPAC Overdrive JavaScript contains untranslatable strings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22804 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 08:45:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 06:45:53 +0000 Subject: [Koha-bugs] [Bug 22804] OPAC Overdrive JavaScript contains untranslatable strings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22804 --- Comment #4 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 08:45:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 06:45:55 +0000 Subject: [Koha-bugs] [Bug 23679] Software error when trying to transfer an unknown barcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23679 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 08:45:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 06:45:57 +0000 Subject: [Koha-bugs] [Bug 23679] Software error when trying to transfer an unknown barcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23679 --- Comment #11 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 08:45:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 06:45:59 +0000 Subject: [Koha-bugs] [Bug 23688] System preference uppercasesurnames broken by typo In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23688 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 08:46:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 06:46:01 +0000 Subject: [Koha-bugs] [Bug 23688] System preference uppercasesurnames broken by typo In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23688 --- Comment #6 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 08:46:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 06:46:02 +0000 Subject: [Koha-bugs] [Bug 23689] Terminology: Branches limitations should be libraries limitations - Authorised Values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23689 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 08:46:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 06:46:05 +0000 Subject: [Koha-bugs] [Bug 23689] Terminology: Branches limitations should be libraries limitations - Authorised Values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23689 --- Comment #8 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 08:47:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 06:47:43 +0000 Subject: [Koha-bugs] [Bug 23447] Fix capitalization and other minor edits on patron batch edit template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23447 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 08:56:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 06:56:36 +0000 Subject: [Koha-bugs] [Bug 11514] Untranslatable "Uncertain" text in acq In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11514 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #9 from Nick Clemens --- I can't make the 'Uncertain' text appear before these patches, can you explain a little more? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 09:01:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 07:01:06 +0000 Subject: [Koha-bugs] [Bug 23694] Author "By" should have its own class In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23694 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 09:01:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 07:01:40 +0000 Subject: [Koha-bugs] [Bug 23694] Author "By" should have its own class In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23694 --- Comment #1 from Lucas Gass --- Created attachment 93343 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93343&action=edit Bug 23694: Author "By" should have its own class TEST PLAN: 1. Go to OPAC details and results on a record which inlcudes an author. Attempt to inspect the element of the "by" text/ 2. Notice it exists outside of a or
. 3. Apply patch. 4. Inscept the element again and it should be inside of a with a class of 'byAuthor'. 5. Add this CSS to the OPACUserCSS '.byAuthor { display: none;}'. 6. Reload the OPAC results/details and notice that the 'by' bit is now hidden. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 09:13:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 07:13:57 +0000 Subject: [Koha-bugs] [Bug 19618] Add 'Club Holds' feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19618 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 09:14:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 07:14:01 +0000 Subject: [Koha-bugs] [Bug 19618] Add 'Club Holds' feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19618 --- Comment #25 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 09:14:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 07:14:04 +0000 Subject: [Koha-bugs] [Bug 23447] Fix capitalization and other minor edits on patron batch edit template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23447 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 09:14:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 07:14:06 +0000 Subject: [Koha-bugs] [Bug 23447] Fix capitalization and other minor edits on patron batch edit template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23447 --- Comment #5 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 09:14:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 07:14:08 +0000 Subject: [Koha-bugs] [Bug 23648] The logged in link (class "loggedinusername") needs data-patroncategory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23648 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 09:14:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 07:14:12 +0000 Subject: [Koha-bugs] [Bug 23648] The logged in link (class "loggedinusername") needs data-patroncategory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23648 --- Comment #7 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 09:21:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 07:21:55 +0000 Subject: [Koha-bugs] [Bug 23709] New: Can't add new subfields to bibliographic frameworks Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23709 Bug ID: 23709 Summary: Can't add new subfields to bibliographic frameworks Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: corinne.hayet at progilone.fr QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl It only works if the subfield is connected to an Authorized values list. I created a subfield 099$m with a link with COUNTRY authorized values list and it's OK But, if I try to create a simple subfield 012$z and I've got the following error in logs : DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key constraint fails (`koha`.`marc_subfield_structure`, CONSTRAINT `marc_subfield_structure_ibfk_1` FOREIGN KEY (`authorised_value`) REFERENCES `authorised_value_categories` (`category_name`) ON DELETE SET NULL ON ) [for Statement "INSERT INTO `marc_subfield_structure` ( `authorised_value`, `authtypecode`, `defaultvalue`, `frameworkcode`, `hidden`, `isurl`, `kohafield`, `liblibrarian`, `libopac`, `link`, `mandatory`, `maxlength`, `repeatable`, `seealso`, `tab`, `tagfield`, `tagsubfield`, `value_builder`) VALUES ( ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ? )" with ParamValues: 0="", 1="", 2="", 3="", 4="0", 5=0, 6="", 7="test", 8="test", 9="", 10=0, 11="9999", 12=0, 13=undef, 14="0", 15="013", 16="x", 17=""] at /usr/local/share/perl5/DBIx/Class/Storage/DBI.pm line 1836. Best regards, Corinne -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 09:23:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 07:23:30 +0000 Subject: [Koha-bugs] [Bug 23709] Can't add new subfields to bibliographic frameworks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23709 Corinne Hayet changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23309 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23309 [Bug 23309] Can't add new subfields to bibliographic frameworks in strict mode -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 09:23:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 07:23:30 +0000 Subject: [Koha-bugs] [Bug 23309] Can't add new subfields to bibliographic frameworks in strict mode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23309 Corinne Hayet changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23709 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23709 [Bug 23709] Can't add new subfields to bibliographic frameworks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 09:34:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 07:34:45 +0000 Subject: [Koha-bugs] [Bug 23700] Fix output of koha-plack --restart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23700 Jesse Maseto changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 09:34:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 07:34:50 +0000 Subject: [Koha-bugs] [Bug 23700] Fix output of koha-plack --restart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23700 Jesse Maseto changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93244|0 |1 is obsolete| | --- Comment #3 from Jesse Maseto --- Created attachment 93344 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93344&action=edit Very nicely aligned now. Bug 23700 - Fix output of koha-plack --restart To test: - Run "sudo koha-plack restart kohadev" and verify the output is out of line. - Apply the patch - If you are on e.g. kohadevbox you need to copy koha-plack to /usr/sbin/ thus: sudo cp debian/scripts/koha-plack /usr/sbin/koha-plack - Run "sudo koha-plack restart kohadev" again and check that you get two lines of output, nicely aligned with the "OK" inside the square brackets. Signed-off-by: Jesse Maseto -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 09:48:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 07:48:34 +0000 Subject: [Koha-bugs] [Bug 14493] export_borrowers.pl - Export patron attributes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14493 Axelle Aix-Marseille Université changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |axelle.clarisse at univ-amu.fr --- Comment #11 from Axelle Aix-Marseille Université --- We try to test today : this patch doesn't apply on a sandbox (Biblibre n°1) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 10:01:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 08:01:18 +0000 Subject: [Koha-bugs] [Bug 23702] New UNIMARC XSLT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23702 Axelle Aix-Marseille Université changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |axelle.clarisse at univ-amu.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 10:10:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 08:10:38 +0000 Subject: [Koha-bugs] [Bug 20888] Allow use of boolean operator 'not' in item search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20888 Axelle Aix-Marseille Université changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |axelle.clarisse at univ-amu.fr --- Comment #12 from Axelle Aix-Marseille Université --- We try to test today : this patch doesn't apply on a sandbox (Biblibre n°1) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 10:37:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 08:37:26 +0000 Subject: [Koha-bugs] [Bug 23586] Issuing rules failing in 19.05 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23586 Andreas Jonsson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #6 from Andreas Jonsson --- I think that any library that have branch specific issuing rules will be affected by this, but the problem will be visible on any Koha-installation. I propose two test plans: 1. By code inspection: * Review commit 7d71d9507202ff667776bf9cb6de0bf2603ad0dd and note that it changes the parameter "$branch" passed to CalcDateDue from the return value of _GetCircControlBranch, which is a branchcode, to $circ_library, which is a library object. * Note that CalcDateDue will eventually call CalcHardDueDate with the library object as parameter, and that CalcHardDueDate expects a branchcode which it will pass as parameter to the database query. 2. By inspecting the query log in MySQL: - Enable query-logging in MySQL by editing /etc/mysql/my.cnf and restarting the mysql server: general_log_file = /var/log/mysql/mysql.log general_log = 1 - Perform an issue and grep for 'Koha::Library=HASH(' in /var/log/mysql/mysql.log - Apply patch - sudo truncate --size=0 /var/log/mysql/mysql.log - Perform an issue and grep for 'Koha::Library=HASH(' in /var/log/mysql/mysql.log -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 10:38:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 08:38:12 +0000 Subject: [Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both for library groups in advanced search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes at biblibre.com --- Comment #13 from sandboxes at biblibre.com --- Patch tested with a sandbox, by Amandine Zocca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 10:38:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 08:38:30 +0000 Subject: [Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both for library groups in advanced search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82138|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 10:38:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 08:38:36 +0000 Subject: [Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both for library groups in advanced search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83518|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 10:38:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 08:38:44 +0000 Subject: [Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both for library groups in advanced search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249 --- Comment #14 from sandboxes at biblibre.com --- Created attachment 93345 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93345&action=edit Bug 21249: New syspref controlling branch fields queried against selected library group value in advanced search This commit allows librarians to choose whether they want to query the homebranch, holdingbranch or homebranch AND holdingbranch when they set a library group search condition in the staff client and OPAC advanced searches. Test plan: 1. Apply patch and run ./updatedatabase.pl in the koha shell 2. Restart memcached and plack 3. In the staff client go to Administration->Global system preferences and search for the systempreference: AdvancedSearchBranchFieldToUse and notice by default it is set to 'homebranch and holdingbranch' 4. Create a library group. Create a subgroup from the library group and add several library branches to the sub group. 5. Note down the barcode of an item to use for testing searching. Make sure the items homebranch and holdingbranch are different and the items homebranch is a child of the sub group created in step 4 6. Perform an Advanced search in the staff client and write in the item barcode as the keyword and select the sub group in the 'Location and availability' section. 7. Submit the search query and notice the item with a homebranch existing in the selected sub group is returned. This proves that when the AdvancedSearchBranchFieldToUse syspref is set to 'homebranch and holdingbranch' the homebranch value is checked. Also note at the top of the search result page the search query is listed: Results of search with limit(s): '(homebranch: or holdingbranch: or homebranch: or holdingbranch: )' 8. Now edit the item making sure the homebranch branch is not in the sub group, and making sure the holdingbranch is in the sub group. This is to test that holdingbranch is indeed being checked when the AdvancedSearchBranchFieldToUse is set to 'homebranch and holdingbranch' 9. Repeat step 6 and notice the item with a holdingbranch existing in the selected library group is returned. 10. Change the value of the AdvancedSearchBranchFieldToUse syspref to 'holdingbranch' and repeat step 6 and again notice the item with a holdingbranch existing in the selected library group is returned. Also note the search query at the top of the page is: "Results of search with limit(s): '(holdingbranch: or holdingbranch: )'" this shows holdingbranch not homebranch is a condition in the query 11. Change the value of the AdvancedSearchBranchFieldToUse syspref to 'homebranch' 12. Change the item homebranch back to a branch that is in the sub group and change the holdingbranch value to a library branch that is not in the sub group. 13. Repeat step 6 and notice the item with the homebranch in the selected library group is returned, so we know the homebranch is being checked. Also note the search query at the top of the page is: " Results of search with limit(s): '(homebranch: or homebranch: )'" this shows homebranch not holdingbranch is a condition in the query. Sponsored-By: Brimbank Library Signed-off-by: Amandine Zocca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 10:38:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 08:38:48 +0000 Subject: [Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both for library groups in advanced search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249 --- Comment #15 from sandboxes at biblibre.com --- Created attachment 93346 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93346&action=edit Bug 21249: Made the SQL INSERT statement idempotent Sponsored-BY: Brimbank Library, Australia Signed-off-by: Amandine Zocca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 10:41:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 08:41:20 +0000 Subject: [Koha-bugs] [Bug 12949] changing child to adult doesn't remove link to guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12949 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki at biblibre.com --- Comment #12 from Arthur Suzuki --- merge conflict on master: Fusion automatique de members/moremember.pl CONFLIT (contenu) : Conflit de fusion dans members/moremember.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 10:47:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 08:47:15 +0000 Subject: [Koha-bugs] [Bug 23586] Issuing rules failing in 19.05 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23586 --- Comment #7 from Andreas Jonsson --- Since the problem is likely caused by the confusion caused by the fact that the variable name $branch is sometimes used for branchnumbers and sometimes for library objects I think that it is a good idea to change the variable names. Also, I think it would be a good idea to add to the coding standards how to name variables containing objects and object identities. These types of errors should really be caught by a type system at compile time. But in the absense of a type system, we can at least improve the situation by having a consistent variable naming scheme. The QA-team could also consider performing tests with the mysql query log enabled and querying for patterns like '=HASH(' which could catch some problems. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 10:59:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 08:59:40 +0000 Subject: [Koha-bugs] [Bug 21979] Add option to SIP2 config to send arbitrary item field in CR instead of collection code In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21979 Jesse Maseto changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jesse at bywatersolutions.com --- Comment #3 from Jesse Maseto --- Hi Kyle, There are a few merge conflicts with this patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 11:02:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 09:02:50 +0000 Subject: [Koha-bugs] [Bug 18309] UNIMARC update from IFLA In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18309 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93281|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 11:20:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 09:20:54 +0000 Subject: [Koha-bugs] [Bug 20888] Allow use of boolean operator 'not' in item search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20888 Matthias Meusburger changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85281|0 |1 is obsolete| | --- Comment #13 from Matthias Meusburger --- Created attachment 93347 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93347&action=edit Bug 20888: Allow use of boolean operator 'not' in item search Test plan: - Apply the patch - Check that you have a 'is not' option in the third box in item search - Check that you can exclude items from the search results with this 'is not' option - Check that you can still combine parameters with 'and' and 'or' - Check that the exclusion works for custom fields (see Administration > Item search fields) - Check that the exclusion works for custom fields linked to authorised values -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 11:21:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 09:21:42 +0000 Subject: [Koha-bugs] [Bug 20888] Allow use of boolean operator 'not' in item search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20888 --- Comment #14 from Matthias Meusburger --- The patch has been rebased, it should apply correctly on the sandboxes now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 11:23:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 09:23:49 +0000 Subject: [Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 11:23:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 09:23:54 +0000 Subject: [Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93247|0 |1 is obsolete| | Attachment #93248|0 |1 is obsolete| | Attachment #93249|0 |1 is obsolete| | Attachment #93250|0 |1 is obsolete| | Attachment #93251|0 |1 is obsolete| | --- Comment #53 from Nick Clemens --- Created attachment 93348 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93348&action=edit Bug 20589: Add field boosting and use query_string fields parameter Generate a list of fields for the query_string query fields parameter, with possible boosts, instead of using "_all"-field. Also add "search" flag in search_marc_to_field table so that certain mappings can be excluded from searches. Add option to include/exclude fields in query_string "fields" parameter depending on searching in OPAC or staff client. Refactor code to remove all other dependencies on "_all"-field. How to test: 1) Reindex authorities and biblios. 2) Search biblios and try to verify that this works as expected. 3) Search authorities and try to verify that this works as expected. 4) Go to "Search engine configuration" 5) Change some "Boost", "Staff client", and "OPAC" settings and save. 6) Verify that those settings where saved accordingly. 7) Click the "Biblios" or "Authorities" tab and change one or more "Searchable" settings 8) Verfiy that those settings where saved accordingly. 9) Try to verify that these settings has taken effect by peforming some biblios and/or authorities searches. Sponsorded-by: Gothenburg Univesity Library Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 11:24:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 09:24:07 +0000 Subject: [Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589 --- Comment #54 from Nick Clemens --- Created attachment 93349 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93349&action=edit Bug 20589: fix QueryBuilder tests Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 11:24:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 09:24:20 +0000 Subject: [Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589 --- Comment #55 from Nick Clemens --- Created attachment 93350 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93350&action=edit Bug 20589: Exclude boolean fields from search fields Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 11:24:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 09:24:34 +0000 Subject: [Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589 --- Comment #56 from Nick Clemens --- Created attachment 93351 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93351&action=edit Bug 20589: Add option for searching entire record if record stored as array Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 11:24:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 09:24:41 +0000 Subject: [Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589 --- Comment #57 from Nick Clemens --- Created attachment 93352 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93352&action=edit Bug 20589: DO NOT PUSH Schema changes Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 11:25:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 09:25:20 +0000 Subject: [Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589 --- Comment #58 from Nick Clemens --- Created attachment 93353 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93353&action=edit Bug 20589: Remove expanded_facet variable and fix tests Thi is a rebase from 14419 to remove an unused variable Also update tests to expect the new expected result Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 11:27:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 09:27:37 +0000 Subject: [Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589 --- Comment #59 from Nick Clemens --- Added minor followup Everything seems to work as expected. The authority searching changes seem to be an improvement: previously an 'exact' search matched any term, now it must match the entire field. Punctuation could be excluded in the future, but exact match should eb exact so I think good starts with searches and sorting are improved -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 11:30:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 09:30:23 +0000 Subject: [Koha-bugs] [Bug 22280] The ILL module assumes every status needs a next/previous status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22280 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 11:30:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 09:30:26 +0000 Subject: [Koha-bugs] [Bug 22280] The ILL module assumes every status needs a next/previous status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22280 --- Comment #14 from Magnus Enger --- Created attachment 93354 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93354&action=edit Bug 22280: Add a unit test This patch adds a unit test to t/db_dependent/Illrequests.t, where a new node without any next_actions or prev_actions is added to the core status graph. Running the tests show a lot of warnings about "no query in themelanguage", but that should not be related to the current bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 11:31:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 09:31:27 +0000 Subject: [Koha-bugs] [Bug 22280] The ILL module assumes every status needs a next/previous status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22280 --- Comment #15 from Magnus Enger --- OK, I tried to add a unit test. Hopes it makes sense! Also reset status to PQA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 11:32:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 09:32:07 +0000 Subject: [Koha-bugs] [Bug 22927] Item improperly marked returned when changing damaged or withdrawn status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22927 Claudie changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90443|0 |1 is obsolete| | --- Comment #3 from Claudie --- Created attachment 93355 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93355&action=edit Bug 22927: Do not check an already lost item when marked as withdrawn or damaged Due to how moredetail.pl was written it was hard to know which action was triggered. Test plan: - Set MarkLostItemsAsReturned to "from the items tab of the catalog module." - Check an item out to a patron - Use additem.pl to set that item to a lost status without returning it - go to moredetail.pl for that item - mark item as either damaged or withdrawn without interacting with the lost dropdown - note that item has not been returned Note for QA: Maybe we could have just tested if exists $item_changes->{'itemlost'} to call LostItem Signed-off-by: Claudie Trégouët -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 11:33:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 09:33:52 +0000 Subject: [Koha-bugs] [Bug 22927] Item improperly marked returned when changing damaged or withdrawn status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22927 Claudie changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |claudie.tregouet at biblibre.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 11:45:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 09:45:01 +0000 Subject: [Koha-bugs] [Bug 20334] Elasticsearch - Option for escaping slashes in search queries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334 Johanna Räisä changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |johanna.raisa at koha-suomi.fi --- Comment #37 from Johanna Räisä --- Is anything happening with this bug? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 11:45:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 09:45:19 +0000 Subject: [Koha-bugs] [Bug 14567] Browse interface for OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14567 Johanna Räisä changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |johanna.raisa at koha-suomi.fi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 11:46:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 09:46:24 +0000 Subject: [Koha-bugs] [Bug 23351] Clean up localization template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23351 Jesse Maseto changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 11:46:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 09:46:30 +0000 Subject: [Koha-bugs] [Bug 23351] Clean up localization template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23351 Jesse Maseto changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91853|0 |1 is obsolete| | --- Comment #3 from Jesse Maseto --- Created attachment 93356 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93356&action=edit Looks good with in my tests. Bug 23351: Clean up localization template This patch modifies the template used for translation of item type descriptions. It is updated with more consistent Bootstrap grid markup and improved handling of adding and removing rows from the DataTable. To test you should have more than one translation installed. - Apply the patch and go to Administration -> Item types. - Edit an item type. - Click the translate link. - Add a new translation. The table of translations should be updated with your new translation. - Test the "Delete" link corresponding to your new entry. It should work correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 11:46:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 09:46:49 +0000 Subject: [Koha-bugs] [Bug 14567] Browse interface for OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14567 Johanna Räisä changed: What |Removed |Added ---------------------------------------------------------------------------- CC|johanna.raisa at koha-suomi.fi | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 11:49:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 09:49:44 +0000 Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 --- Comment #1 from Andrew Isherwood --- It has become increasingly apparent that using authorised values for this is not the most appropriate way forward. The number of modifications and additions to AV was increasing the scope of the work too much, it was clear that AV was not the correct place for this. Therefore, I am intending creating a table specifically for Patron Restrictions and building the management UI for it, which will be placed probably under "Koha administration" > "Patrons and circulation" -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 11:54:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 09:54:24 +0000 Subject: [Koha-bugs] [Bug 22773] Bulk Close invoices and Filter invoice view (open/closed) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 Devinim changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 11:54:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 09:54:28 +0000 Subject: [Koha-bugs] [Bug 22773] Bulk Close invoices and Filter invoice view (open/closed) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 --- Comment #1 from Devinim --- Created attachment 93357 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93357&action=edit Bug 22773: Bulk Close invoices and Filter invoice view (open/closed) Test plan: 1)Verify that close tab occurse for closed invoices. 2)Try to select bulk invoices in open invoices tab and press button "Close selected invoices". Verify that your selected invoices moved to close invoices tab. 3)Try to select bulk invoices in close invoices tab and press button "Reopen selected invoices". Verify that your selected invoices moved to open invoices tab. 4)Check also when you check on "Show only subscriptions" checkbox you may see subscribed invoices in all tabs. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 11:59:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 09:59:46 +0000 Subject: [Koha-bugs] [Bug 23710] New: Holds broken, displays a JSON page with an error Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23710 Bug ID: 23710 Summary: Holds broken, displays a JSON page with an error Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: blocker Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: victor.grousset at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com == Test plan == 1. Try to place a hold on a record 2. You get an error 😱 {"errors":[{"message":"Expected object - got null.","path":"\/body"}],"status":400} It happened - on a DevBox of a colleague - a my koha-testing-docker - an instance of another colleague The sandbox throws a 404 not found and the URL is the following: http://pro.user01-koha.sandbox.biblibre.eu/api/v1/holds So definitely related. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 12:06:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 10:06:49 +0000 Subject: [Koha-bugs] [Bug 23252] Pressing enter should not submit form in item editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23252 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Missing input_marceditor |Pressing enter should not |class in item editor |submit form in item editor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 12:07:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 10:07:03 +0000 Subject: [Koha-bugs] [Bug 23252] Pressing enter should not submit form in item editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23252 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Alias| |Missing, input_marceditor, | |class, in, item, editor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 12:07:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 10:07:33 +0000 Subject: [Koha-bugs] [Bug 23252] Pressing enter should not submit form in item editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23252 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Alias|class, editor, in, | |input_marceditor, item, | |Missing | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 12:22:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 10:22:48 +0000 Subject: [Koha-bugs] [Bug 23252] Pressing enter should not submit form in item editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23252 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #12 from Katrin Fischer --- It looks like this is actually a regressen - we fixed it before in bug 8557. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 12:52:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 10:52:23 +0000 Subject: [Koha-bugs] [Bug 7074] Show subtitle, part and number of a record in list of checkins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7074 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 12:52:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 10:52:25 +0000 Subject: [Koha-bugs] [Bug 7074] Show subtitle, part and number of a record in list of checkins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7074 --- Comment #14 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 13:23:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 11:23:52 +0000 Subject: [Koha-bugs] [Bug 21979] Add option to SIP2 config to send arbitrary item field in CR instead of collection code In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21979 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83102|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall --- Created attachment 93358 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93358&action=edit Bug 21979: Add option to SIP2 config to send arbitrary item field in CR instead of collection code Some libraries need to send a different field as the collection code, depending on how the library catalogs items. We should allow any arbitrary item field to be used as the value for the CR field. Test Plan: 1) Apply this patch 2) Set the new option cr_item_field to 'shelving_location' 3) Restart the SIP server 3) Perform a checkin via SIP 4) Note the CR field contains the shelving location code in the response 5) Perform an item information request 6) Note the CR field contains the shelving location code in the response -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 13:28:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 11:28:54 +0000 Subject: [Koha-bugs] [Bug 22874] Limit to available items doesn't work with elasticsearch 6.x In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22874 Séverine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |severine.queune at bulac.fr --- Comment #2 from Séverine Queune --- Here are the 2 sandboxes I used with : - ES5 : http://pro.es5-koha.sandbox.biblibre.eu - ES6 : http://pro.es6-koha.sandbox.biblibre.eu Sorry Alex, they both failed... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 14:02:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 12:02:33 +0000 Subject: [Koha-bugs] [Bug 22259] If two catalogers work on same record, one overwrites the other In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22259 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #7 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 23705 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 14:02:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 12:02:33 +0000 Subject: [Koha-bugs] [Bug 23705] Add a syspref to enable record locking, so that when one record is opened to be edited, it's read only for other users In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23705 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |karin.hochschein at linklaters | |.com --- Comment #1 from Katrin Fischer --- *** Bug 22259 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 14:14:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 12:14:13 +0000 Subject: [Koha-bugs] [Bug 22874] Limit to available items doesn't work with elasticsearch 6.x In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22874 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off CC| |sandboxes at biblibre.com --- Comment #3 from sandboxes at biblibre.com --- Patch tested with a sandbox, by Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 14:14:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 12:14:28 +0000 Subject: [Koha-bugs] [Bug 22874] Limit to available items doesn't work with elasticsearch 6.x In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22874 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89506|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 14:14:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 12:14:38 +0000 Subject: [Koha-bugs] [Bug 22874] Limit to available items doesn't work with elasticsearch 6.x In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22874 --- Comment #4 from sandboxes at biblibre.com --- Created attachment 93359 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93359&action=edit Bug 22874 - use false instaed of 0 value for limiting on availability Test plan - Set up a elasticsearch 6 instance to work with Koha, - you may need to make koha works with ES 6 (see bug 20589), - make a search and limit it to available items only, => no result - Apply this patch, - make a search and limit it to available items only, - you should get some results - Do the same with ES 5.x Signed-off-by: Séverine QUEUNE Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 14:28:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 12:28:35 +0000 Subject: [Koha-bugs] [Bug 23710] Holds broken, displays a JSON page with an error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23710 --- Comment #1 from Martin Renvoize --- Created attachment 93360 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93360&action=edit Bug 23710: Revert to usng placerequest.pl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 14:29:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 12:29:59 +0000 Subject: [Koha-bugs] [Bug 23670] Load Koha::Exceptions::ElasticSearch module in Koha::SearchEngine::Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23670 Séverine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 14:30:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 12:30:03 +0000 Subject: [Koha-bugs] [Bug 23670] Load Koha::Exceptions::ElasticSearch module in Koha::SearchEngine::Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23670 Séverine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93132|0 |1 is obsolete| | --- Comment #2 from Séverine Queune --- Created attachment 93361 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93361&action=edit Bug 23670 Load Koha::Exceptions::ElasticSearch module in Koha::SearchEngine::Elasticsearch Prevent Koha::SearchEngine::Elasticsearch from dying when trying to run Koha::Exceptions::Elasticsearch::MARCFieldExprParseError->throw() Plan test: 1. Go to Administration -> Searchengine configuration, and add a mapping for 995Z, whatever the search field (I did it with local-classification), save 2. run $KOHA_PATH/misc/search_tools/rebuild_elasticsearch.pl -v -d -b 3. see it die asking for Koha::Exceptions::Elasticsearch 4. apply patch 5. rerun $KOHA_PATH/misc/search_tools/rebuild_elasticsearch.pl -v -d -b 6. see it throw: Invalid MARC field expression: 995Z Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 14:32:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 12:32:14 +0000 Subject: [Koha-bugs] [Bug 23710] Holds broken, displays a JSON page with an error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23710 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 14:33:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 12:33:10 +0000 Subject: [Koha-bugs] [Bug 23710] Holds broken, displays a JSON page with an error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23710 --- Comment #2 from Martin Renvoize --- This is a quick fix.. but it's made me wonder about the club holds feature more generally. Do we still need placerequest.pl if we're aiming to move to the API entirely as that patch attempted. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 14:38:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 12:38:03 +0000 Subject: [Koha-bugs] [Bug 23710] Holds broken, displays a JSON page with an error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23710 --- Comment #3 from Martin Renvoize --- To add detail to the failure, I could replicate it on Version 77.0.3865.90 (Official Build) Arch Linux (64-bit) I used a patron which should have blocked my hold but chose to hold anyway as you can. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 14:38:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 12:38:22 +0000 Subject: [Koha-bugs] [Bug 23710] Holds broken, displays a JSON page with an error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23710 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |agustinmoyano at theke.io |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 14:43:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 12:43:04 +0000 Subject: [Koha-bugs] [Bug 23710] Holds broken, displays a JSON page with an error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23710 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 14:43:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 12:43:06 +0000 Subject: [Koha-bugs] [Bug 23710] Holds broken, displays a JSON page with an error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23710 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93360|0 |1 is obsolete| | --- Comment #4 from Owen Leonard --- Created attachment 93362 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93362&action=edit Bug 23710: Revert to usng placerequest.pl Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 14:47:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 12:47:40 +0000 Subject: [Koha-bugs] [Bug 23711] New: Icons on staff main page should be font icons Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23711 Bug ID: 23711 Summary: Icons on staff main page should be font icons Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com On the staff main page we should use font icons (Font Awesome) instead of sprite.png. These are easier to adjust/customize with CSS than the sprites we currently use. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 14:48:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 12:48:16 +0000 Subject: [Koha-bugs] [Bug 23671] Elasticsearch shouldn't throw exception on an uppercase subfield identifier In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23671 Séverine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune at bulac.fr Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 14:50:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 12:50:14 +0000 Subject: [Koha-bugs] [Bug 18757] Problem when importing only items in MARC records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18757 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes at biblibre.com --- Comment #10 from sandboxes at biblibre.com --- Patch tested with a sandbox, by Amandine Zocca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 14:50:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 12:50:30 +0000 Subject: [Koha-bugs] [Bug 18757] Problem when importing only items in MARC records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18757 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64104|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 14:50:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 12:50:38 +0000 Subject: [Koha-bugs] [Bug 18757] Problem when importing only items in MARC records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18757 --- Comment #11 from sandboxes at biblibre.com --- Created attachment 93363 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93363&action=edit Bug 18757 - Problem when importing only items in MARC records When importing records with Stage MARC records for import, one can use matching rules to only import items into existing records. Those imported items are stored as XML to be staged. The bug is that when MARC Flavour is UNIMARC the XML serialization fails because its is looking in field 100$a which does not exist. You see in logs the error : Unsupported UNIMARC character encoding [] for XML output for UNIMARC; 100$a This patch adds the format "USMARC" to XML serialization, like in C4::Items::_get_unlinked_subfields_xml Test plan : - On a UNIMARC database - Define a maching rule on title 200$a - Select a record with items - Export it using : Save as > MARC (Unicode/UTF-8) - Delete all items - Go to Tools > Stage MARC records for import - Upload exported file - Select title matching rule - Select "Ingore incoming record" in "Action if matching record found :" - Select Yes and "Always add items" in "Check for embedded item record data?" - Click Stage for import => Without patch you get the error => With patch the import is staged - Import into the catalog and check item is well recreated Signed-off-by: Amandine Zocca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 15:01:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 13:01:31 +0000 Subject: [Koha-bugs] [Bug 23711] Icons on staff main page should be font icons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23711 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 15:01:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 13:01:35 +0000 Subject: [Koha-bugs] [Bug 23711] Icons on staff main page should be font icons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23711 --- Comment #1 from Lucas Gass --- Created attachment 93364 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93364&action=edit Bug 23711: Icons on staff main page should be font icons TEST PLAN: 1. GO to '/cgi-bin/koha/mainpage.pl' and observe the icons. 2. Apply the patch and clear the browser cache. 3. Refresh '/cgi-bin/koha/mainpage.pl' and make sure all the icons are still display. Note that some are not exactly the same as the old ones, but should be similar. Make sure you enable Course reserves and ILL so you can observe those icons as well. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 15:02:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 13:02:51 +0000 Subject: [Koha-bugs] [Bug 23586] Issuing rules failing in 19.05 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23586 --- Comment #8 from Katrin Fischer --- Thx Andreas :) Usually I'd expect something like: - Do this in Koha - Go there... click that - Verify it is broken - Apply patch - Repeat steps above - Verify it's working now! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 15:06:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 13:06:16 +0000 Subject: [Koha-bugs] [Bug 23586] Issuing rules failing in 19.05 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23586 --- Comment #9 from Katrin Fischer --- (In reply to Andreas Jonsson from comment #7) > Since the problem is likely caused by the confusion caused by the fact that > the variable name $branch is sometimes used for branchnumbers and sometimes > for library objects I think that it is a good idea to change the variable > names. > > Also, I think it would be a good idea to add to the coding standards how to > name variables containing objects and object identities. > > These types of errors should really be caught by a type system at compile > time. But in the absense of a type system, we can at least improve the > situation by having a consistent variable naming scheme. > > The QA-team could also consider performing tests with the mysql query log > enabled and querying for patterns like '=HASH(' which could catch some > problems. The issue is not the idea, but that this patch is marked for 19.05 - so the variable renaming would never make it into master. If we want to do that, we need to make sure there is a patch for master and a backport - it should probably be done on a separate bug report (but leaving to RM ;) ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 15:08:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 13:08:37 +0000 Subject: [Koha-bugs] [Bug 21799] Change wording for quantity input field on order receive page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21799 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_18_05_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 15:09:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 13:09:56 +0000 Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_19_11_candidate CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 15:10:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 13:10:01 +0000 Subject: [Koha-bugs] [Bug 20334] Elasticsearch - Option for escaping slashes in search queries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334 --- Comment #38 from Katrin Fischer --- Is there something we can do to help get this moving again? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 15:12:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 13:12:51 +0000 Subject: [Koha-bugs] [Bug 23671] Elasticsearch shouldn't throw exception on an uppercase subfield identifier In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23671 Séverine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93133|0 |1 is obsolete| | --- Comment #2 from Séverine Queune --- Created attachment 93365 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93365&action=edit Bug 23671: Elasticsearch shouldn't throw exception on an uppercase subfield identifier Prevent Elasticsearch from throwing an exception when the mappings include uppercase subfield identifier. Though forbidden in MARC21, It doesn't seem to be the case for Unimarc or ISO 2709 as a whole. It is also possible to define such a subfield identifier in the Koha MARC Framework and in the Elasticsearch mappings. Test plan: 1. add a 995Z subfield identifier in Elasticsearch mappings (Administration -> Search engine configuration) 2. run $KOHA_PATH/misc/search_tools/rebuild_elasticsearch.pl -v -d -b 3. see it throw: “Invalid MARC field expression: 995Z” 4. apply patch 5. rerun $KOHA_PATH/misc/search_tools/rebuild_elasticsearch.pl -v -d -b 6. sababa Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 15:13:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 13:13:57 +0000 Subject: [Koha-bugs] [Bug 19618] Add 'Club Holds' feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19618 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 15:14:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 13:14:28 +0000 Subject: [Koha-bugs] [Bug 20389] Indexing fields concatenated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20389 --- Comment #5 from Séverine Queune --- Just tried in master : concatenation works fine using parenthesis : 700(ab) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 15:17:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 13:17:19 +0000 Subject: [Koha-bugs] [Bug 23671] Elasticsearch shouldn't throw exception on an uppercase subfield identifier In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23671 Nicolas Legrand changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_19_11_candidate -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 15:18:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 13:18:17 +0000 Subject: [Koha-bugs] [Bug 23670] Load Koha::Exceptions::ElasticSearch module in Koha::SearchEngine::Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23670 Nicolas Legrand changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_19_11_candidate -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 15:18:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 13:18:27 +0000 Subject: [Koha-bugs] [Bug 18084] Language selector hidden in user menu on mobile interfaces In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18084 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 15:23:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 13:23:38 +0000 Subject: [Koha-bugs] [Bug 23586] Issuing rules failing in 19.05 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23586 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version|19.05 |master --- Comment #10 from Martin Renvoize --- This bug also applies at master to so I'm correcting the version to 'master' and will bring it to the attention of RMaints that it's required for a quick backport. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 15:26:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 13:26:31 +0000 Subject: [Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|martin at bugs.koha-community. |aleisha at catalyst.net.nz |org.xinxidi.net | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 15:28:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 13:28:18 +0000 Subject: [Koha-bugs] [Bug 19482] Elasticsearch - prevent removal / editing of required indexes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19482 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 15:28:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 13:28:32 +0000 Subject: [Koha-bugs] [Bug 19482] Elasticsearch - prevent removal / editing of required indexes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19482 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80817|0 |1 is obsolete| | Attachment #80818|0 |1 is obsolete| | Attachment #80819|0 |1 is obsolete| | Attachment #80820|0 |1 is obsolete| | --- Comment #27 from Nick Clemens --- Created attachment 93366 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93366&action=edit Bug 19482 - DB changes Signed-off-by: Nicolas Legrand -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 15:28:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 13:28:45 +0000 Subject: [Koha-bugs] [Bug 19482] Elasticsearch - prevent removal / editing of required indexes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19482 --- Comment #28 from Nick Clemens --- Created attachment 93367 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93367&action=edit Bug 19482 - Add support for defining 'mandatory' mappings To test: 1 - Apply patch 2 - ./installer/data/mysql/updatedatabase.pl 3 - Reset ES mapping: Administration->Search engine configuration , button at bottom of page 4 - 'issues' and 'title' mapping under 'search fields' should be mandatory and not editable 5 - On 'Bibliographic records' tab you should not be able to delete the single entry for issues 6 - You should be able to delete 'title' mappings, however, at the final one you should be stopped by javascript 7 - Bonus: force remove the last mapping from the page using developer tools - attempt to save and should be warned of missing mandatory mapping -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 15:28:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 13:28:49 +0000 Subject: [Koha-bugs] [Bug 19482] Elasticsearch - prevent removal / editing of required indexes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19482 --- Comment #29 from Nick Clemens --- Created attachment 93368 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93368&action=edit Bug 19482: SCHEMA CHANGES - DO NOT PUSH -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 15:29:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 13:29:53 +0000 Subject: [Koha-bugs] [Bug 18084] Language selector hidden in user menu on mobile interfaces In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18084 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 15:29:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 13:29:56 +0000 Subject: [Koha-bugs] [Bug 18084] Language selector hidden in user menu on mobile interfaces In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18084 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90578|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 93369 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93369&action=edit Bug 18084: Language selector hidden in user menu on mobile interfaces This patch updates templates and CSS so that the language-selection menu in the header will not be hidden if the browser width is too narrow. This patch also makes some more general improvements to the responsive adaptability of the header elements. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). Test the changes by viewing pages in the OPAC and adjusting your browser width, paying attention to how elements in the top menu adapt to different sizes. Test under varying conditions: - Logged in/not loggeed user - Search history enabled and disabled - OpacLangSelectorMode showing menu in header or not - opacuserlogin enabled or disabled -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 15:32:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 13:32:10 +0000 Subject: [Koha-bugs] [Bug 23293] OPACFineNoRenewals compares against 'balance' not 'outstanding' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23293 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_19_11_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 15:33:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 13:33:02 +0000 Subject: [Koha-bugs] [Bug 23293] OPACFineNoRenewals compares against 'balance' not 'outstanding' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23293 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 15:36:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 13:36:03 +0000 Subject: [Koha-bugs] [Bug 23586] Issuing rules failing in 19.05 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23586 --- Comment #11 from Katrin Fischer --- (In reply to Martin Renvoize from comment #10) > This bug also applies at master to so I'm correcting the version to 'master' > and will bring it to the attention of RMaints that it's required for a quick > backport. Withdrawing my complaint about variable renaming in this case :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 15:42:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 13:42:52 +0000 Subject: [Koha-bugs] [Bug 23566] Continue on device - with QR codes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23566 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 15:42:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 13:42:54 +0000 Subject: [Koha-bugs] [Bug 23566] Continue on device - with QR codes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23566 --- Comment #6 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 15:45:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 13:45:15 +0000 Subject: [Koha-bugs] [Bug 22280] The ILL module assumes every status needs a next/previous status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22280 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 15:45:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 13:45:17 +0000 Subject: [Koha-bugs] [Bug 22280] The ILL module assumes every status needs a next/previous status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22280 --- Comment #16 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 15:46:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 13:46:46 +0000 Subject: [Koha-bugs] [Bug 23684] Import items only with merging rule In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23684 --- Comment #3 from Katrin Fischer --- So your branchcode and collection code in Koha is 2250000 - correct? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 15:54:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 13:54:12 +0000 Subject: [Koha-bugs] [Bug 20888] Allow use of boolean operator 'not' in item search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20888 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sandboxes at biblibre.com Status|Needs Signoff |Signed Off --- Comment #15 from sandboxes at biblibre.com --- Patch tested with a sandbox, by Amandine Zocca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 15:54:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 13:54:33 +0000 Subject: [Koha-bugs] [Bug 20888] Allow use of boolean operator 'not' in item search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20888 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93347|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 15:54:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 13:54:43 +0000 Subject: [Koha-bugs] [Bug 20888] Allow use of boolean operator 'not' in item search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20888 --- Comment #16 from sandboxes at biblibre.com --- Created attachment 93370 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93370&action=edit Bug 20888: Allow use of boolean operator 'not' in item search Test plan: - Apply the patch - Check that you have a 'is not' option in the third box in item search - Check that you can exclude items from the search results with this 'is not' option - Check that you can still combine parameters with 'and' and 'or' - Check that the exclusion works for custom fields (see Administration > Item search fields) - Check that the exclusion works for custom fields linked to authorised values Signed-off-by: Amandine Zocca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 16:01:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 14:01:38 +0000 Subject: [Koha-bugs] [Bug 8778] Add Keyword phrase search to OPAC search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8778 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12291|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 16:02:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 14:02:48 +0000 Subject: [Koha-bugs] [Bug 8778] Add Keyword phrase search to OPAC search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8778 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #10 from Katrin Fischer --- The first patch was old and not needed for the suggested change. Remaining patch now applies cleanly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 16:08:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 14:08:36 +0000 Subject: [Koha-bugs] [Bug 19482] Elasticsearch - prevent removal / editing of required indexes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19482 Nicolas Legrand changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 16:08:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 14:08:43 +0000 Subject: [Koha-bugs] [Bug 19482] Elasticsearch - prevent removal / editing of required indexes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19482 Nicolas Legrand changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93366|0 |1 is obsolete| | --- Comment #30 from Nicolas Legrand --- Created attachment 93371 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93371&action=edit Bug 19482 - DB changes Signed-off-by: Nicolas Legrand -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 16:08:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 14:08:46 +0000 Subject: [Koha-bugs] [Bug 19482] Elasticsearch - prevent removal / editing of required indexes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19482 Nicolas Legrand changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93367|0 |1 is obsolete| | --- Comment #31 from Nicolas Legrand --- Created attachment 93372 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93372&action=edit Bug 19482 - Add support for defining 'mandatory' mappings To test: 1 - Apply patch 2 - ./installer/data/mysql/updatedatabase.pl 3 - Reset ES mapping: Administration->Search engine configuration , button at bottom of page 4 - 'issues' and 'title' mapping under 'search fields' should be mandatory and not editable 5 - On 'Bibliographic records' tab you should not be able to delete the single entry for issues 6 - You should be able to delete 'title' mappings, however, at the final one you should be stopped by javascript 7 - Bonus: force remove the last mapping from the page using developer tools - attempt to save and should be warned of missing mandatory mapping Signed-off-by: Nicolas Legrand -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 16:08:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 14:08:50 +0000 Subject: [Koha-bugs] [Bug 19482] Elasticsearch - prevent removal / editing of required indexes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19482 Nicolas Legrand changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93368|0 |1 is obsolete| | --- Comment #32 from Nicolas Legrand --- Created attachment 93373 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93373&action=edit Bug 19482: SCHEMA CHANGES - DO NOT PUSH Signed-off-by: Nicolas Legrand -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 16:12:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 14:12:44 +0000 Subject: [Koha-bugs] [Bug 13193] Make Memcached usage fork safe In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 16:13:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 14:13:02 +0000 Subject: [Koha-bugs] [Bug 18084] Language selector hidden in user menu on mobile interfaces In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18084 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 16:13:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 14:13:11 +0000 Subject: [Koha-bugs] [Bug 18084] Language selector hidden in user menu on mobile interfaces In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18084 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93369|0 |1 is obsolete| | --- Comment #3 from Lucas Gass --- Created attachment 93374 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93374&action=edit Bug 18084: Language selector hidden in user menu on mobile interfaces Owen, the language dropdown now looks great so I am signing off. Should the 'Clear' button in red have the same font-weight/font-size as rest of the navbar? This patch updates templates and CSS so that the language-selection menu in the header will not be hidden if the browser width is too narrow. This patch also makes some more general improvements to the responsive adaptability of the header elements. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). Test the changes by viewing pages in the OPAC and adjusting your browser width, paying attention to how elements in the top menu adapt to different sizes. Test under varying conditions: - Logged in/not loggeed user - Search history enabled and disabled - OpacLangSelectorMode showing menu in header or not - opacuserlogin enabled or disabled -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 16:15:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 14:15:00 +0000 Subject: [Koha-bugs] [Bug 13193] Make Memcached usage fork safe In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 16:15:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 14:15:05 +0000 Subject: [Koha-bugs] [Bug 13193] Make Memcached usage fork safe In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193 --- Comment #42 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 16:15:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 14:15:56 +0000 Subject: [Koha-bugs] [Bug 19482] Elasticsearch - prevent removal / editing of required indexes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19482 --- Comment #33 from Nicolas Legrand --- Thank you Nick! Tested with Unimarc, so there isn't any issues index defined for the Bibliographic records section. Everything went as it should for the rest of it. It could be puzzling for the Unimarc community, because our modifications will be blocked and we will see the message : “You attempted to delete all mappings for a required index, you must leave at least one mapping” until we add an issues index in Bibliographic records. I'm not sure this should be fixed here or in a mapping.yaml patch. Listing the name of the required field missing in the error message could be a nice improvement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 16:21:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 14:21:39 +0000 Subject: [Koha-bugs] [Bug 18309] UNIMARC update from IFLA In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18309 Sophie MEYNIEUX changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sophie.meynieux at biblibre.co | |m --- Comment #82 from Sophie MEYNIEUX --- Last update is adding field 214 https://www.ifla.org/files/assets/uca/unimarc_updates/BIBLIOGRAPHIC/u_b_214_update2019_online_final.pdf -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 16:22:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 14:22:46 +0000 Subject: [Koha-bugs] [Bug 13193] Make Memcached usage fork safe In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193 --- Comment #43 from Joonas Kylmälä --- Martin, oh noes, the dependency was not added yet to the Koha repositories? This needs to be reverted? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 16:23:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 14:23:59 +0000 Subject: [Koha-bugs] [Bug 22773] Bulk Close invoices and Filter invoice view (open/closed) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93357|0 |1 is obsolete| | --- Comment #2 from ByWater Sandboxes --- Created attachment 93375 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93375&action=edit Bug 22773: Bulk Close invoices and Filter invoice view (open/closed) Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 16:24:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 14:24:37 +0000 Subject: [Koha-bugs] [Bug 22773] Bulk Close invoices and Filter invoice view (open/closed) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |andrew at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 16:27:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 14:27:00 +0000 Subject: [Koha-bugs] [Bug 23705] Add a syspref to enable record locking, so that when one record is opened to be edited, it's read only for other users In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23705 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 16:37:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 14:37:03 +0000 Subject: [Koha-bugs] [Bug 13193] Make Memcached usage fork safe In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 16:37:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 14:37:20 +0000 Subject: [Koha-bugs] [Bug 13193] Make Memcached usage fork safe In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92926|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 16:37:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 14:37:35 +0000 Subject: [Koha-bugs] [Bug 13193] Make Memcached usage fork safe In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92931|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 16:39:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 14:39:10 +0000 Subject: [Koha-bugs] [Bug 23712] New: Silence warns from Koha/Illrequest/Logger.pm Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23712 Bug ID: 23712 Summary: Silence warns from Koha/Illrequest/Logger.pm Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: ILL Assignee: magnus at libriotech.no Reporter: magnus at libriotech.no If you run this: $ sudo koha-shell -c "prove t/db_dependent/Illrequests.t" kohadev you get a lot of errors like this: no query in themelanguage at /home/vagrant/kohaclone/C4/Templates.pm line 266. This is because C4::Templates::_get_template_file() is called with just two parameters, when it expects a CGI object as the third parameter: C4::Templates::_get_template_file('ill/log/', 'intranet'); Patch coming. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 16:40:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 14:40:16 +0000 Subject: [Koha-bugs] [Bug 23712] Silence warns from Koha/Illrequest/Logger.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23712 --- Comment #1 from Magnus Enger --- There are probably many ways to solve this, but I will propose to add a new CGI object and pass it along. Alternative solutions welcome! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 16:43:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 14:43:07 +0000 Subject: [Koha-bugs] [Bug 23713] New: Subscription add form broken for translations Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23713 Bug ID: 23713 Summary: Subscription add form broken for translations Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com It's not possible to add a new subscription using translated templates. What I see is: English template: var mana_enabled = [% IF (Koha.Preference('Mana') == 1 && mana_url) %]1[% ELSE %]0[% END %]; de-DE template: var mana_enabled = [% IF (Koha.Preference('Mana') == 1 && mana_url) %]1[% ELSE %][% END %]; We are also missing a semicolon in one of the lines, but this doesn't seem to effect the page functionality: var MSG_PATTERN_IRREG = _("Warning! Present pattern has planned irregularities. Click on 'Test prediction pattern' to check if it's still valid") Thx to Michael Hoffert and Alexander Arlt from koha-de for reporting it initially and figuring out the root of the issue! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 16:44:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 14:44:24 +0000 Subject: [Koha-bugs] [Bug 23712] Silence warns from Koha/Illrequest/Logger.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23712 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 16:44:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 14:44:26 +0000 Subject: [Koha-bugs] [Bug 23712] Silence warns from Koha/Illrequest/Logger.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23712 --- Comment #2 from Magnus Enger --- Created attachment 93376 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93376&action=edit Bug 23712 - Silence warns from Koha/Illrequest/Logger.pm To test: - Run: $ sudo koha-shell -c "prove t/db_dependent/Illrequests.t" kohadev - Observe the warnings about "no query in themelanguage" - Apply the patch - Run prove again - Observe the lack of warnings about "no query in themelanguage" (There will be a couple of other warnings, but they are not related to the present bug.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 16:48:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 14:48:12 +0000 Subject: [Koha-bugs] [Bug 23713] Subscription add form broken for translations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23713 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Serials |I18N/L10N CC| |frederic at tamil.fr -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 16:48:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 14:48:43 +0000 Subject: [Koha-bugs] [Bug 22997] Searching gives no results in auth_finder.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22997 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 16:48:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 14:48:57 +0000 Subject: [Koha-bugs] [Bug 22997] Searching gives no results in auth_finder.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22997 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91095|0 |1 is obsolete| | Attachment #92119|0 |1 is obsolete| | --- Comment #9 from Nick Clemens --- Created attachment 93377 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93377&action=edit Bug 22997: Searching gives no results in auth_finder.pl During cataloguing of an existing biblio, on an heading field, the use of tag editor fills authorities finder with existing value : Search main heading ($a only) Search main heading Default operator beeing 'contains'. Actually with Elasticsearch those search give no results. Example with heading : 200 $a Casaubon $b Isaac $f 1559-1614 Call to Elasticsearch : "query" : { "bool" : { "must" : [ { "query_string" : { "query" : "Casaubon*", "default_field" : "heading-main", } }, { "query_string" : { "query" : "(Isaac*) AND (1559-1614*)", "default_field" : "heading" } } ] } }, "sort" : [ { "heading__sort.phrase" : "asc" } ] } Patch adds to "query_string" : analyze_wildcard : true. Test plan : 1) Use Elasticsearch 2) Edit an existing biblio record 3) Use tag editor on a heading 4) Click search => You get correct results 5) Check also search in authorities-home.pl Signed-off-by: Kyle M Hall Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 16:49:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 14:49:01 +0000 Subject: [Koha-bugs] [Bug 22997] Searching gives no results in auth_finder.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22997 --- Comment #10 from Nick Clemens --- Created attachment 93378 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93378&action=edit Bug 22997: Unit test Run prove t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 16:49:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 14:49:25 +0000 Subject: [Koha-bugs] [Bug 23713] Subscription add form broken for translations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23713 --- Comment #1 from Katrin Fischer --- To give a bit more info, the Javascript we get from the wrong TT is: var mana_enabled = ; So this implodes. It should be: var mana_enabled = 0; -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 16:50:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 14:50:44 +0000 Subject: [Koha-bugs] [Bug 22997] Searching gives no results in auth_finder.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22997 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #11 from Nick Clemens --- The issue is searches with a '-' in the middle, like a date range 1906-1995 Square brackets '[]' actually break searching for biblios and authorities in general in ES and must be escaped, that hould be outside the scope here for the moment -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 16:52:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 14:52:26 +0000 Subject: [Koha-bugs] [Bug 22412] Elasticsearch - Second term of a boolean research is lost after applying a facet In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22412 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |RESOLVED Resolution|--- |DUPLICATE CC| |nick at bywatersolutions.com --- Comment #2 from Nick Clemens --- *** This bug has been marked as a duplicate of bug 22413 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 16:52:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 14:52:26 +0000 Subject: [Koha-bugs] [Bug 22413] Elasticsearch - Search settings are lost after sorting, faceting or paging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22413 --- Comment #16 from Nick Clemens --- *** Bug 22412 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 16:56:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 14:56:42 +0000 Subject: [Koha-bugs] [Bug 23714] New: Problem with ILLModuleUnmediated Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23714 Bug ID: 23714 Summary: Problem with ILLModuleUnmediated Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: ILL Assignee: koha-bugs at lists.koha-community.org Reporter: magnus at libriotech.no If you run this: $ sudo koha-shell -c "prove t/db_dependent/Illrequests.t" kohadev you get this: Use of uninitialized value in concatenation (.) or string at /home/vagrant/kohaclone/Koha/Illrequest.pm line 857. Use of uninitialized value in concatenation (.) or string at /home/vagrant/kohaclone/Koha/Illrequest.pm line 859 (Among some other warnings that are fixed on bug 23712.) Lines 857 and 859 look like this: my $intra_tmpl = join "/", $backend_tmpl, "intra-includes", $params->{method} . ".inc"; my $opac_tmpl = join "/", $backend_tmpl, "opac-includes", $params->{method} . ".inc"; $params->{method} is uninitialized because of these lines in Koha::Illrequest::backend_create(): if ( C4::Context->preference("ILLModuleUnmediated") && $permitted ) { my $unmediated_result = $self->_backend_capability( 'unmediated_ill', $args ); $result = $unmediated_result if $unmediated_result; } This replaces whatever was in $result. So before this code you can have a $result that looks like this: $VAR1 = { 'stage' => 'commit', 'method' => 'create', 'permitted' => 1 }; and after the code it looks like this: $VAR1 = { 'unmediated_ill' => 1 }; Is this the intended behaviour? If no, we should fix it (add 'unmediated_ill' => 1 to the existing data instead of replacing it?). If yes, we should make expandTemplate() handle a missing method more gracefully. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 17:03:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 15:03:34 +0000 Subject: [Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93348|0 |1 is obsolete| | --- Comment #60 from Alex Arnaud --- Created attachment 93379 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93379&action=edit Bug 20589: Add field boosting and use query_string fields parameter Generate a list of fields for the query_string query fields parameter, with possible boosts, instead of using "_all"-field. Also add "search" flag in search_marc_to_field table so that certain mappings can be excluded from searches. Add option to include/exclude fields in query_string "fields" parameter depending on searching in OPAC or staff client. Refactor code to remove all other dependencies on "_all"-field. How to test: 1) Reindex authorities and biblios. 2) Search biblios and try to verify that this works as expected. 3) Search authorities and try to verify that this works as expected. 4) Go to "Search engine configuration" 5) Change some "Boost", "Staff client", and "OPAC" settings and save. 6) Verify that those settings where saved accordingly. 7) Click the "Biblios" or "Authorities" tab and change one or more "Searchable" settings 8) Verfiy that those settings where saved accordingly. 9) Try to verify that these settings has taken effect by peforming some biblios and/or authorities searches. Sponsorded-by: Gothenburg Univesity Library Signed-off-by: Nick Clemens Signed-off-by: Alex Arnaud -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 17:03:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 15:03:43 +0000 Subject: [Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93349|0 |1 is obsolete| | --- Comment #61 from Alex Arnaud --- Created attachment 93380 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93380&action=edit Bug 20589: fix QueryBuilder tests Signed-off-by: Nick Clemens Signed-off-by: Alex Arnaud -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 17:03:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 15:03:52 +0000 Subject: [Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93350|0 |1 is obsolete| | --- Comment #62 from Alex Arnaud --- Created attachment 93381 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93381&action=edit Bug 20589: Exclude boolean fields from search fields Signed-off-by: Nick Clemens Signed-off-by: Alex Arnaud -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 17:03:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 15:03:59 +0000 Subject: [Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93351|0 |1 is obsolete| | --- Comment #63 from Alex Arnaud --- Created attachment 93382 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93382&action=edit Bug 20589: Add option for searching entire record if record stored as array Signed-off-by: Nick Clemens Signed-off-by: Alex Arnaud -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 17:04:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 15:04:07 +0000 Subject: [Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93352|0 |1 is obsolete| | --- Comment #64 from Alex Arnaud --- Created attachment 93383 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93383&action=edit Bug 20589: DO NOT PUSH Schema changes Signed-off-by: Nick Clemens Signed-off-by: Alex Arnaud -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 17:04:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 15:04:15 +0000 Subject: [Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93353|0 |1 is obsolete| | --- Comment #65 from Alex Arnaud --- Created attachment 93384 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93384&action=edit Bug 20589: Remove expanded_facet variable and fix tests Thi is a rebase from 14419 to remove an unused variable Also update tests to expect the new expected result Signed-off-by: Nick Clemens Signed-off-by: Alex Arnaud -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 17:06:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 15:06:24 +0000 Subject: [Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #66 from Alex Arnaud --- - Proposed features works - QA tools ok, - code ok, - work with ES 5.x and 6.x - also fix a relevance sorting issue. Great! Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 17:13:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 15:13:30 +0000 Subject: [Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |alex.arnaud at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 17:30:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 15:30:53 +0000 Subject: [Koha-bugs] [Bug 23711] Icons on staff main page should be font icons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23711 --- Comment #2 from Owen Leonard --- I'm curious why you didn't use 'fa-tag' for cataloging? And 'fa-gift' for acquisitions? Also: misc/interface_customization/staff-home-icons-sprite.svg can be removed too. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 18:00:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 16:00:37 +0000 Subject: [Koha-bugs] [Bug 23020] Standing Order basket not reflecting payment on order line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23020 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 18:02:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 16:02:08 +0000 Subject: [Koha-bugs] [Bug 19197] Lower case "or" results in broken ElasticSearch queries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19197 Séverine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune at bulac.fr Status|Needs Signoff |Failed QA --- Comment #8 from Séverine Queune --- The patch works perfectly with ElasticSearch, whatever I search, using the search group. But with Zebra, the search fails if "or" is a term I want to search (worked with ElasticSearch). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 18:02:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 16:02:28 +0000 Subject: [Koha-bugs] [Bug 23020] Standing Order basket not reflecting payment on order line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23020 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Joy Nelson --- *** This bug has been marked as a duplicate of bug 23522 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 18:02:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 16:02:28 +0000 Subject: [Koha-bugs] [Bug 23522] Actual price should be shown in basket In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23522 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy at bywatersolutions.com --- Comment #4 from Joy Nelson --- *** Bug 23020 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 18:22:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 16:22:53 +0000 Subject: [Koha-bugs] [Bug 23713] Subscription add form broken for translations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23713 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 18:22:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 16:22:58 +0000 Subject: [Koha-bugs] [Bug 23713] Subscription add form broken for translations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23713 --- Comment #2 from Owen Leonard --- Created attachment 93385 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93385&action=edit Bug 23713: Subscription add form broken for translations This patch makes a change to the subscription entry template as a workaround to a translation bug which is causing JavaScript errors when using translated templates. To test, apply the patch and update and install the de-DE template: > cd misc/translator > perl translate update de-DE > perl translate install de-DE - Go to Administration -> System preferences and enable the "Deutsch (de-DE)" language under I18N/L10N preferences -> language. - Switch to the "Deutsch" translation. - Go to Zeitschriften (Serials) -> Neues Abonnement (New subscription) and open the browser console. There should be no errors. - Links which trigger JavaScript events should work correctly: "Lieferant suchen," "Nach Datensatz suchen," etc. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 19:17:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 17:17:20 +0000 Subject: [Koha-bugs] [Bug 20986] MARC21 Supplement and Index Textual Holdings don't display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20986 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea at gmail.com --- Comment #15 from Liz Rea --- I don't feel like maybe this was a thing that should have been in stable releases - it changes the front end OPAC and that's shocking for users. I don't think we need to take it out, but do be careful of these ones in the future please? Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 20:23:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 18:23:23 +0000 Subject: [Koha-bugs] [Bug 23715] New: Batch item modification sets a value in incorrect field Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23715 Bug ID: 23715 Summary: Batch item modification sets a value in incorrect field Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org We have a scenario, in which we are removing a damaged status from a batch of items and setting a not for loan status. When we check to delete the Damaged status (which in this case has a value of 4), and set the Not for loan status (in this case, a status with the authorized value of -3), it deletes the Damaged status, but instead of setting the status of the Not for loan field, it assigns the authorized value of the Not for loan status to the Use restrictions field. So, all the items do not get the Not for loan status, and all the items show a -3 in the Use restrictions field. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 20:26:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 18:26:18 +0000 Subject: [Koha-bugs] [Bug 23710] Holds broken, displays a JSON page with an error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23710 --- Comment #5 from Agustín Moyano --- (In reply to Martin Renvoize from comment #2) > This is a quick fix.. but it's made me wonder about the club holds feature > more generally. > > Do we still need placerequest.pl if we're aiming to move to the API entirely > as that patch attempted. Sorry about this bug, at first I tried to move everything to the API, but then I thought it would be better to move common holds (holds for patron, not for clubs) in a following bug.. It seems I didn't Ctrl-z enough.. I'll now attach a patch that effectively uses API to place holds for patrons. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 20:27:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 18:27:19 +0000 Subject: [Koha-bugs] [Bug 23716] New: Batch item modification needs to let you continue with items Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23716 Bug ID: 23716 Summary: Batch item modification needs to let you continue with items Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org Once you have made modifications to a batch of items, if you notice you made a mistake, or if there is something more you have to do, you have to start over. This is particularly annoying if you scanned all the barcodes and are not working from a file. Technically, you can press the back button and make changes, but you have to remove all the changes made the first time before you make additional changes. I would suggest adding a button on the results page that says something like "Make more modifications to this batch", which would take you back to these items, but reset all the modification fields for a new set of changes. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 20:36:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 18:36:13 +0000 Subject: [Koha-bugs] [Bug 23715] Batch item modification sets a value in incorrect field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23715 --- Comment #1 from Christopher Brannon --- Please be aware that this issue happens when you are doing these things together. Changing the status of one field seems to work fine, but when doing them together, you get this result. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 20:37:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 18:37:50 +0000 Subject: [Koha-bugs] [Bug 23710] Holds broken, displays a JSON page with an error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23710 Agustín Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 20:37:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 18:37:54 +0000 Subject: [Koha-bugs] [Bug 23710] Holds broken, displays a JSON page with an error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23710 --- Comment #6 from Agustín Moyano --- Created attachment 93386 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93386&action=edit Bug 23710: Use API to place holds for patrons This patch effectively uses API to place holds for patrons. It adds a listener on submit event of the form in javascript, where it calls holds API. To test: 1. Place a hold on any biblio for a patron SUCCESS => hold is placed or rejected, but no blank page with JSON error is shown. 2. Place a multi hold for any patron SUCCESS => holds are placed or rejected, but no blank page with JSON error is shown. 3. Sign off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 20:39:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 18:39:11 +0000 Subject: [Koha-bugs] [Bug 23710] Holds broken, displays a JSON page with an error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23710 Agustín Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |agustinmoyano at theke.io -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 20:39:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 18:39:14 +0000 Subject: [Koha-bugs] [Bug 23710] Holds broken, displays a JSON page with an error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23710 Agustín Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93362|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 20:59:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 18:59:22 +0000 Subject: [Koha-bugs] [Bug 22844] Simplify the process of selecting database columns for system preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844 --- Comment #29 from Owen Leonard --- (In reply to Martin Renvoize from comment #28) > I would suggest splitting the `BorrowerMandatoryField` handling back out of > this bug So: I modify my original patch and remove the changes which modify the behavior of the BorrowerMandatoryField field and make the other patches obsolete. > Perhaps we could add the free text box itself into the bottom of the modal Is there any reason to do so in this patch if we're not concerned about patron attributes? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 21:21:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 19:21:18 +0000 Subject: [Koha-bugs] [Bug 23710] Holds broken, displays a JSON page with an error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23710 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93386|0 |1 is obsolete| | --- Comment #7 from ByWater Sandboxes --- Created attachment 93387 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93387&action=edit Bug 23710: Use API to place holds for patrons This patch effectively uses API to place holds for patrons. It adds a listener on submit event of the form in javascript, where it calls holds API. To test: 1. Place a hold on any biblio for a patron SUCCESS => hold is placed or rejected, but no blank page with JSON error is shown. 2. Place a multi hold for any patron SUCCESS => holds are placed or rejected, but no blank page with JSON error is shown. 3. Sign off Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 21:21:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 19:21:26 +0000 Subject: [Koha-bugs] [Bug 23710] Holds broken, displays a JSON page with an error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23710 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |lisetteslatah at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 21:30:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 19:30:47 +0000 Subject: [Koha-bugs] [Bug 22798] Double quote included in Publisher search on tag 264 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22798 Claudio changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |costalc at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 21:35:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 19:35:22 +0000 Subject: [Koha-bugs] [Bug 22798] Double quote included in Publisher search on tag 264 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22798 --- Comment #1 from Claudio --- Same problem in 19.05.04 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 21:39:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 19:39:26 +0000 Subject: [Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #40 from Blou --- 19.05 came and went. So will 19.11... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 21:41:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 19:41:44 +0000 Subject: [Koha-bugs] [Bug 23717] New: Login for Mana Content Knowledge Base Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23717 Bug ID: 23717 Summary: Login for Mana Content Knowledge Base Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Mana-kb Assignee: koha-bugs at lists.koha-community.org Reporter: kelly at bywatersolutions.com After successfully linking to Mana. The token appears on this site https://ui.mana-kb.koha-community.org/login Can Mana users have access to this Knowledgebase to look at subscriptions already existing? And if so, how does one get a login/password for it? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 22:02:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 20:02:23 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Maryse Simard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90470|0 |1 is obsolete| | --- Comment #91 from Maryse Simard --- Created attachment 93388 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93388&action=edit Bug 12446: Enable an adult to have a guarantor Conflicts have been fixed. Also attributes in system preference : AdditionalGuarantorField are now displayed correctly in all scenarios. I have rebased every patch. This includes all the features from the previous patches. Removed the dollar signs and stopped using C4::Category On the patron category page, there is a new field to specify whether patrons can be guarantee or not. The atomic update SQL script adds this new field and sets it to true for categories of type "C" and "P". 1) Apply the patch 2) Run updatedatabase.pl to add AdditionalGuarantorField to preferences and canbeguarantee to categories. 3) Go to patron category administration, edit a category and change the value of Can Be Guarantee to yes (for Child and Professional it should have been set by default) 4) See below to test various scenarios - Enable an adult to have a guarantor: 0.0) Create or edit a patron category of type 'A'. 0.1) Set the "Can be guarantee" field to "Yes" and save. 1) Select an adult patron -> details tab; 2) Click edit button; 3) validate "guarantor information" fieldset; - Shows guarantees' fines in the guarantor's page: 4) Click Set to patron button and select a guarantor; 5) Generate a fine; 6) Select guarantor patron -> details tab; 7) Validate guarantee's fine information. - Transfer some guarantor's information to the guarantee while adding a guarantee: 0) Select an adult patron; 1) Insert all information; 2) Click Add guarantee bouton; 3) Validate Garantor information/Main address/Contact fieldsets filled; - Transfer some guarantor's information to the guarantee while creating a new patron 0) Select an adult patron; 1) Insert all information; 2) Add a new adult patron; 3) Click "Set to patron" button; 4) Select the adult patron from 0); 5) Validate Garantor information/Main address/Contact fieldsets filled; - Transfer guarantor's alternate address/contact to the guarantee while creating a new patron: 0) Search AdditionalGuarantorField preference; 1) Insert some additional database columns from alternate address/contact to be transferred from guarantor; 2) Select an adult patron; 3) Insert all information; 4) Add a new adult patron; 5) Click "Set to patron" button; 6) Select the adult patron from 0); 7) Validate Garantor information/Main address/Contact fieldsets filled; 8) Validate Garantor additional alternate address/contact filled; - Transfer guarantor's alternate address/contact to the guarantee while adding a guarantee: 0) Search AdditionalGuarantorField preference; 1) Insert some additional database columns from alternate address/contact to be transferred from guarantor; 3) Select an adult patron; 4) Insert all information; 5) Click Add guarantee bouton; 6) Validate Garantor information/Main address/Contact fieldsets filled; 7) Validate Garantor additional alternate address/contact filled; Signed-off-by: Hayley Mapley -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 22:03:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 20:03:07 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Maryse Simard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90471|0 |1 is obsolete| | --- Comment #92 from Maryse Simard --- Created attachment 93389 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93389&action=edit Bug 12446: (QA follow-up) Cleaning, and fixing, old code carried accidentally Signed-off-by: Hayley Mapley -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 22:03:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 20:03:13 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Maryse Simard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90472|0 |1 is obsolete| | --- Comment #93 from Maryse Simard --- Created attachment 93390 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93390&action=edit Bug 12446: (follow-up) Show all guarantees on the guarantor detail page Only one guarantee is shown on the guarantor detail page. The guarantees list should be passed to the template as a ref. Signed-off-by: Hayley Mapley -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 22:03:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 20:03:19 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Maryse Simard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90473|0 |1 is obsolete| | --- Comment #94 from Maryse Simard --- Created attachment 93391 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93391&action=edit Bug 12446: (QA follow-up) QA tests fixing, cleaning code This patch does 3 things : - Remove old code in C4/Utils/DataTables/Members.pm. - Fix the AdditionalGuarantorField dead link for the borrowers table schema. - Remove unused variables so QA tests pass. Signed-off-by: Hayley Mapley -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 22:03:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 20:03:24 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 --- Comment #95 from Maryse Simard --- Created attachment 93392 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93392&action=edit Bug 12446: Schema update Category.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 22:03:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 20:03:30 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 --- Comment #96 from Maryse Simard --- Created attachment 93393 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93393&action=edit Bug 12446: (follow-up) Remove mandatory transfered values With the new system preference AdditionalGuarantorField, one can add data to be transfered to the guarantee, but cannot remove default ones. This patch renames the syspref to GuarantorFields and set hardcoded default values as the preference's default. To test: 1. After database update, check that the default value for the syspref GuarantorFields contains these columns: streetnumber|address|address2|city|state|zipcode|country| branchcode|phonepro|mobile|email|emailpro|fax 2. Set the value as empty 3. Try adding a guarantor to a patron (from the guarantor's page or the guarantee's): no values should be imported. 4. Check that it still works with different values for the preference. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 22:03:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 20:03:35 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 --- Comment #97 from Maryse Simard --- Created attachment 93394 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93394&action=edit Bug 12446: (follow-up) Code cleaning Some variable name change, put database update in a perl file, remove unused code and other small fixes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 22:07:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 20:07:35 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Maryse Simard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff CC| |maryse.simard at inlibro.com --- Comment #98 from Maryse Simard --- I rebased the patches. The code has changed a lot with bug 14570, please retest. I've also made some fixes and changed the new system preference AdditionalGuarantorField to GuarantorFields. This way, the system can be set so no information is transfered to the guarantee while adding a guarantor. The test plan for this change is in the patch's commit message. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 22:41:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Oct 2019 20:41:52 +0000 Subject: [Koha-bugs] [Bug 23080] Item search: To Call Number Search Not Inclusive In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23080 Aguayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |azucena.aguayo at uvu.edu --- Comment #6 from Aguayo --- Our library also noticed another issue. If we search from call number E75 to call number E99 the results will display E700s, E800s, and E900 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 04:29:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 02:29:28 +0000 Subject: [Koha-bugs] [Bug 23654] Patron Cards - Bar code and image do not show up In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23654 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #4 from David Cook --- I've been experiencing some problems with patron cards in an older version of Koha, and I think maybe our problems are linked. It's difficult to explain. With the Template, there is Page height/width and Card height/width. When I am creating a Layout, I expect the top of my Y axis to be the top of the Card height. However, the top of my Y axis seems to actually be the top of my Page height (minus the top page margin). Yet, when the label batch is exported, the layout seems relative to the Card and not the Page. I'm specifying a Lower left Y coordinate of 274mm but that's actually placing the text at the Lower left Y coordinate of about 44mm on the card. I'm sure my explanation makes no sense, but basically... I think there is something very wrong with the patron card creator - at least when using SI Millimeters for both the Template and Layout... If you set all your X/Y coordinates to 0 and then move incrementally from there, I think you'll see what I mean. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 04:30:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 02:30:27 +0000 Subject: [Koha-bugs] [Bug 23654] Patron Cards - Bar code and image do not show up In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23654 --- Comment #5 from David Cook --- Haven't looked at the code yet myself as I have a number of other priorities. Plus I have a feeling that the fix will actually break a lot of existing layouts... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 04:35:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 02:35:28 +0000 Subject: [Koha-bugs] [Bug 23654] Patron Cards - Bar code and image do not show up In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23654 --- Comment #6 from David Cook --- Actually, after I changed my Images data that's caused the X/Y axis for my Text fields to completely change. I'd say there's a number of factors regarding units that are wrong here... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 07:00:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 05:00:14 +0000 Subject: [Koha-bugs] [Bug 23705] Add a syspref to enable record locking, so that when one record is opened to be edited, it's read only for other users In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23705 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 08:27:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 06:27:43 +0000 Subject: [Koha-bugs] [Bug 23713] Subscription add form broken for translations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23713 --- Comment #3 from Katrin Fischer --- Thx, Owen! Was going to tackle it this morning in a similar fashion! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 08:33:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 06:33:58 +0000 Subject: [Koha-bugs] [Bug 23715] Batch item modification sets a value in incorrect field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23715 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #2 from Katrin Fischer --- Hi Christopher, we just fixed a bug like this (waiting for Rmaints currently): bug 18710. Marking duplicate, please check and change back if I am mistaken! *** This bug has been marked as a duplicate of bug 18710 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 08:33:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 06:33:58 +0000 Subject: [Koha-bugs] [Bug 18710] Wrong subfield modified in batch item modification In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18710 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon at cdalibrary.org --- Comment #19 from Katrin Fischer --- *** Bug 23715 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 09:14:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 07:14:31 +0000 Subject: [Koha-bugs] [Bug 23711] Icons on staff main page should be font icons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23711 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93364|0 |1 is obsolete| | --- Comment #3 from Lucas Gass --- Created attachment 93395 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93395&action=edit Bug 23711: Icons on staff main page should be font icons TEST PLAN: 1. GO to '/cgi-bin/koha/mainpage.pl' and observe the icons. 2. Apply the patch and clear the browser cache. 3. Refresh '/cgi-bin/koha/mainpage.pl' and make sure all the icons are still display. Note that some are not exactly the same as the old ones, but should be similar. Make sure you enable Course reserves and ILL so you can observe those icons as well. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 09:14:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 07:14:37 +0000 Subject: [Koha-bugs] [Bug 23711] Icons on staff main page should be font icons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23711 --- Comment #4 from Lucas Gass --- Created attachment 93396 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93396&action=edit Bug 23711: Change icons and remove unused SVG -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 09:33:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 07:33:39 +0000 Subject: [Koha-bugs] [Bug 23586] Issuing rules failing in 19.05 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23586 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |RESOLVED Resolution|--- |DUPLICATE --- Comment #12 from Martin Renvoize --- *** This bug has been marked as a duplicate of bug 23382 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 09:33:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 07:33:39 +0000 Subject: [Koha-bugs] [Bug 23382] Hourly rental fees are not charged In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andreas.jonsson at kreablo.se --- Comment #16 from Martin Renvoize --- *** Bug 23586 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 09:34:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 07:34:16 +0000 Subject: [Koha-bugs] [Bug 23382] Issuing rules failing in 19.05 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Hourly rental fees are not |Issuing rules failing in |charged |19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 09:36:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 07:36:06 +0000 Subject: [Koha-bugs] [Bug 23382] Issuing rules failing in 19.05 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 --- Comment #17 from Martin Renvoize --- Changed title to reflect the severity and scope of bug when merged with bug 23586. "Hourly rental fees are not charged" => "Issuing rules failing after bug 20912" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 09:36:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 07:36:14 +0000 Subject: [Koha-bugs] [Bug 23382] Issuing rules failing after bug 20912 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Issuing rules failing in |Issuing rules failing after |19.05 |bug 20912 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 09:36:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 07:36:26 +0000 Subject: [Koha-bugs] [Bug 23382] Issuing rules failing after bug 20912 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |critical -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 09:39:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 07:39:42 +0000 Subject: [Koha-bugs] [Bug 23713] Subscription add form broken for translations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23713 --- Comment #4 from Katrin Fischer --- Great test plan! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 10:01:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 08:01:11 +0000 Subject: [Koha-bugs] [Bug 22426] Elasticsearch - Index location is missing in advanced search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22426 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes at biblibre.com --- Comment #9 from sandboxes at biblibre.com --- Patch tested with a sandbox, by Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 10:01:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 08:01:29 +0000 Subject: [Koha-bugs] [Bug 22426] Elasticsearch - Index location is missing in advanced search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22426 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89378|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 10:01:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 08:01:34 +0000 Subject: [Koha-bugs] [Bug 22426] Elasticsearch - Index location is missing in advanced search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22426 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90670|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 10:01:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 08:01:44 +0000 Subject: [Koha-bugs] [Bug 22426] Elasticsearch - Index location is missing in advanced search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22426 --- Comment #10 from sandboxes at biblibre.com --- Created attachment 93397 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93397&action=edit Bug 22426: Elasticsearch - Index location is missing in advanced search Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 10:01:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 08:01:48 +0000 Subject: [Koha-bugs] [Bug 22426] Elasticsearch - Index location is missing in advanced search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22426 --- Comment #11 from sandboxes at biblibre.com --- Created attachment 93398 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93398&action=edit Bug 22426: (alternate) Elasticsearch fix location limit in advanced search A search made on Shelving location tab in advanced search gives 0 result. Test plan : Without patch: - in advanced search, choose a location in shelving location tab and start search (opac-search.pl?idx=kw&op=and&idx=kw&op=and&idx=kw&do=Search&limit=mc-loc) - 0 result - check that location exist by doing a simple search and filtering on the location facet - have some results With patch: - in advanced search, choose a location in shelving location tab and start search (opac-search.pl?idx=kw&op=and&idx=kw&op=and&idx=kw&do=Search&limit=mc-loc) - found results Signed-off-by: Séverine QUEUNE Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 10:02:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 08:02:06 +0000 Subject: [Koha-bugs] [Bug 23706] Item search CSV export doesn't include collection code In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23706 Amandine Zocca changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |azocca at ville-montauban.fr --- Comment #8 from Amandine Zocca --- We try to test today : this patch doesn't apply on a sandbox (Biblibre n°1) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 10:04:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 08:04:45 +0000 Subject: [Koha-bugs] [Bug 16111] RSS feed for OPAC search results has wrong content type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #82 from Lucas Gass --- backported to 18.11.x for 18.11.11 thanks for helping with merge conflicts Victor! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 10:07:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 08:07:01 +0000 Subject: [Koha-bugs] [Bug 16111] RSS feed for OPAC search results has wrong content type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 10:25:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 08:25:44 +0000 Subject: [Koha-bugs] [Bug 22540] Add ability to place holds using SIP CLI emulator In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22540 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de QA Contact|testopia at bugs.koha-communit |nick at bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 10:43:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 08:43:53 +0000 Subject: [Koha-bugs] [Bug 19465] Allow choosing Elasticsearch server on instance creation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19465 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |nick at bywatersolutions.com |y.org | CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 10:45:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 08:45:21 +0000 Subject: [Koha-bugs] [Bug 22508] Add the ability to prefill 856$u with the direct URL of the file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22508 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 10:47:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 08:47:13 +0000 Subject: [Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20589 Status|Signed Off |ASSIGNED QA Contact| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 10:47:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 08:47:13 +0000 Subject: [Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20388 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 10:49:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 08:49:32 +0000 Subject: [Koha-bugs] [Bug 20588] Elasticsearch - Apply dataTable on search fields and mapping tables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20588 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Searching - Elasticsearch |Templates Status|Signed Off |BLOCKED QA Contact| |testopia at bugs.koha-communit | |y.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 10:56:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 08:56:11 +0000 Subject: [Koha-bugs] [Bug 22913] https://mana-kb.koha-community.org/ should not return a 404 error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22913 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 10:59:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 08:59:42 +0000 Subject: [Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|josef.moravec at gmail.com |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 11:24:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 09:24:30 +0000 Subject: [Koha-bugs] [Bug 23713] Subscription add form broken for translations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23713 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93385|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 93399 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93399&action=edit Bug 23713: Subscription add form broken for translations This patch makes a change to the subscription entry template as a workaround to a translation bug which is causing JavaScript errors when using translated templates. To test, apply the patch and update and install the de-DE template: > cd misc/translator > perl translate update de-DE > perl translate install de-DE - Go to Administration -> System preferences and enable the "Deutsch (de-DE)" language under I18N/L10N preferences -> language. - Switch to the "Deutsch" translation. - Go to Zeitschriften (Serials) -> Neues Abonnement (New subscription) and open the browser console. There should be no errors. - Links which trigger JavaScript events should work correctly: "Lieferant suchen," "Nach Datensatz suchen," etc. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 11:24:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 09:24:34 +0000 Subject: [Koha-bugs] [Bug 23713] Subscription add form broken for translations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23713 --- Comment #6 from Katrin Fischer --- Created attachment 93400 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93400&action=edit Bug 23713: (follow-up) Add missing semicolon Adds a missing semicolon to one of the lines with translated messages. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 11:30:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 09:30:16 +0000 Subject: [Koha-bugs] [Bug 23713] Subscription add form broken for translations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23713 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 11:31:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 09:31:25 +0000 Subject: [Koha-bugs] [Bug 23718] New: New REST route for get and modify patron notifications preferences Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23718 Bug ID: 23718 Summary: New REST route for get and modify patron notifications preferences Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Web services Assignee: koha-bugs at lists.koha-community.org Reporter: claire.hernandez at biblibre.com QA Contact: testopia at bugs.koha-community.org Created attachment 93401 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93401&action=edit Notifications preferenes in Staff Koha interface I would like that an external application would be able to GET and PUT the preferences for notifications of a user. (see screenshots) This data can be modified by a member in is account or a librarian in member modification (members/memberentry.pl) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 11:31:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 09:31:27 +0000 Subject: [Koha-bugs] [Bug 23589] Discharge notice does not show non-latin characters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23589 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dpavlin at rot13.org Assignee|koha-bugs at lists.koha-commun |dpavlin at rot13.org |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 11:32:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 09:32:11 +0000 Subject: [Koha-bugs] [Bug 23718] New REST route for get and modify patron notifications preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23718 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 11:33:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 09:33:59 +0000 Subject: [Koha-bugs] [Bug 23589] Discharge notice does not show non-latin characters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23589 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 11:34:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 09:34:02 +0000 Subject: [Koha-bugs] [Bug 23589] Discharge notice does not show non-latin characters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23589 --- Comment #3 from Dobrica Pavlinusic --- Created attachment 93402 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93402&action=edit Bug 23589: Discharge notice does not show non-latin characters It seems that discarge notices never got support for truetype fonts, so notices are missing non-latin characters. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 11:37:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 09:37:04 +0000 Subject: [Koha-bugs] [Bug 23589] Discharge notice does not show non-latin characters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23589 --- Comment #4 from Dobrica Pavlinusic --- I had similar problem and here is a fix. You have to have truetype fonts defined in koha-conf.xml for this to work. If it does, I would appreciate sign-off :-) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 11:49:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 09:49:58 +0000 Subject: [Koha-bugs] [Bug 23711] Icons on staff main page should be font icons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23711 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #5 from Fridolin SOMERS --- Created attachment 93403 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93403&action=edit Screenshot -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 11:58:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 09:58:32 +0000 Subject: [Koha-bugs] [Bug 22508] Add the ability to prefill 856$u with the direct URL of the file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22508 --- Comment #46 from Katrin Fischer --- I've set this to Failed QA since Marcel and Nick agree that a different approach might be better here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 11:59:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 09:59:34 +0000 Subject: [Koha-bugs] [Bug 23667] Add API route for listing items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23667 Jesse Maseto changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 11:59:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 09:59:40 +0000 Subject: [Koha-bugs] [Bug 23667] Add API route for listing items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23667 Jesse Maseto changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93129|0 |1 is obsolete| | --- Comment #8 from Jesse Maseto --- Created attachment 93404 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93404&action=edit Bug 23667: Add spec Signed-off-by: Jesse Maseto -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 12:00:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 10:00:07 +0000 Subject: [Koha-bugs] [Bug 23667] Add API route for listing items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23667 Jesse Maseto changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93230|0 |1 is obsolete| | --- Comment #9 from Jesse Maseto --- Created attachment 93405 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93405&action=edit Bug 23667: Add route to GET /items This patchset introduces a route to fetch items. It relies on the already implemented code/mappings to get a single item. To test: - Apply this patches - Run: $ kshell k$ prove t/db_dependent/api/v1/items.t => SUCCESS: Tests pass! - Try the endpoint with your favourite API tool (Postman?) - Sign off :-D Note: to do exact searching on barcode, you need to build the query like this: GET /api/v1/items?external_id=&_match=exact Signed-off-by: Jesse Maseto -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 12:01:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 10:01:18 +0000 Subject: [Koha-bugs] [Bug 23718] New REST route for get and modify patron notifications preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23718 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18595, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17505 CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Hi Claire, I think this could be a possible duplicate of bug 17505 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 12:01:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 10:01:18 +0000 Subject: [Koha-bugs] [Bug 18595] Move C4::Members::Messaging to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18595 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23718 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 12:01:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 10:01:18 +0000 Subject: [Koha-bugs] [Bug 17505] Add routes for messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17505 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23718 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 12:05:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 10:05:12 +0000 Subject: [Koha-bugs] [Bug 21824] Add ability to format dates in various formats in templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21824 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91363|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 12:05:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 10:05:17 +0000 Subject: [Koha-bugs] [Bug 21824] Add ability to format dates in various formats in templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21824 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91364|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 12:06:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 10:06:36 +0000 Subject: [Koha-bugs] [Bug 23626] Add a system preference to limit the number of rows of data used when charting or exporting report results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23626 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 12:07:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 10:07:07 +0000 Subject: [Koha-bugs] [Bug 23626] Add a system preference to limit the number of rows of data used when charting or exporting report results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23626 --- Comment #34 from Nick Clemens --- Created attachment 93406 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93406&action=edit Bug 23626: [alternate] Only fetch full chart data if requested This patchset prevents the full return of report data unless explicitly requested by the user for charting purposes Additionally the user is warned if requesting more than 1000 rows of data To test: 1 - Create a report that returns over 1000 rows of data 2 - Run the report 3 - Note you have two buttons now 'Chart data' and 'Fetch all data for chart' 4 - Click chart data 5 - Note the note that you are only charting visible data 6 - Create the chart and confirm it works 7 - Close the chart 8 - Click 'Fetch all data' 9 - Note the confirm window 10 - Click 'cancel', note there is no change 11 - Repeat and click ok 12 - Fetch all data button is gone 13 - Page to next data, note fetch all does not return 14 - Click 'Chart data' 15 - Note you now have checkbox option to use all data in report 16 - Click it 17 - Create chart 18 - Confirm it works as expected -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 12:10:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 10:10:40 +0000 Subject: [Koha-bugs] [Bug 23626] Add a system preference to limit the number of rows of data used when charting or exporting report results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23626 --- Comment #35 from Nick Clemens --- Hi Paul, We talked at the hackfest, people prefer retaining the ability to fetch full data when charting. I have provided an alternate patch that prevents loading the full data on initial report load and adds a button to load the data if requested. There is a warning when fetching over 1000 rows. The button could also be hidden if you never want to use additional rows. Can you test this and confirm it works as needed? The issues with exporting should probably be filed on a new separate bug to assess. Thanks, Nick -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 12:21:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 10:21:35 +0000 Subject: [Koha-bugs] [Bug 23382] Issuing rules failing after bug 20912 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92273|0 |1 is obsolete| | --- Comment #18 from Martin Renvoize --- Created attachment 93407 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93407&action=edit Bug 23382: Improve test coverage -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 12:21:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 10:21:38 +0000 Subject: [Koha-bugs] [Bug 23382] Issuing rules failing after bug 20912 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92274|0 |1 is obsolete| | --- Comment #19 from Martin Renvoize --- Created attachment 93408 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93408&action=edit Bug 23382: Add tests for hourly calculations -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 12:21:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 10:21:41 +0000 Subject: [Koha-bugs] [Bug 23382] Issuing rules failing after bug 20912 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92275|0 |1 is obsolete| | --- Comment #20 from Martin Renvoize --- Created attachment 93409 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93409&action=edit Bug 23382: Add hourly tests for Circulation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 12:21:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 10:21:44 +0000 Subject: [Koha-bugs] [Bug 23382] Issuing rules failing after bug 20912 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92276|0 |1 is obsolete| | --- Comment #21 from Martin Renvoize --- Created attachment 93410 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93410&action=edit Bug 23382: Fix logic in C4::Circulation::CanBookBeIssued It looks like over progressive rebases of bug 20912 a clause was lost within CanBookBeIssued such that a fatal error may be triggered if an item with no corresponding itemtype was passed into the routine. Additionally the we were passing a Koha::Library object to CalcDateDue rather than a branchcode which resulted in a different duedate being used in 'CanBookBeIssued' when compared to 'AddIssue'. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 12:21:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 10:21:48 +0000 Subject: [Koha-bugs] [Bug 23382] Issuing rules failing after bug 20912 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 --- Comment #22 from Martin Renvoize --- Created attachment 93411 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93411&action=edit Bug 23382: (follow-up) Clarify variable names This patch updates the variable name '$branch' to '$branchcode' in a number of places to make it clearer what the variable contains. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 12:21:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 10:21:51 +0000 Subject: [Koha-bugs] [Bug 23382] Issuing rules failing after bug 20912 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 --- Comment #23 from Martin Renvoize --- Created attachment 93412 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93412&action=edit Bug 23382: (follow-up) Ensure tests pass on Wednesdays -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 12:24:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 10:24:17 +0000 Subject: [Koha-bugs] [Bug 22382] Online fine payment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22382 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #2 from Martin Renvoize --- Erm... What's this bug for? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 12:24:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 10:24:39 +0000 Subject: [Koha-bugs] [Bug 23589] Discharge notice does not show non-latin characters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23589 --- Comment #5 from Theodoros Theodoropoulos --- Hi Dobrica, Thanks for your patch! Indeed it fixes the output. I will try to properly sign it off later. Having said that, there I'm now at 18.11 and there is another issue (that exists regardless of your patch). The generated pdf file in /tmp/ is proper pdf, the one that gets downloaded when I click discharge is CORRUPTED (has html code appended in the bottom of the pdf file). Did you also have this issue? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 12:24:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 10:24:52 +0000 Subject: [Koha-bugs] [Bug 22382] Online fine payment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22382 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 12:25:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 10:25:16 +0000 Subject: [Koha-bugs] [Bug 23382] Issuing rules failing after bug 20912 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #24 from Martin Renvoize --- Tests now pass. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 12:27:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 10:27:18 +0000 Subject: [Koha-bugs] [Bug 23710] Holds broken, displays a JSON page with an error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23710 --- Comment #8 from Martin Renvoize --- Excellent work, thankyou for the updated patchset Agustín -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 12:44:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 10:44:11 +0000 Subject: [Koha-bugs] [Bug 23589] Discharge notice does not show non-latin characters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23589 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes at biblibre.com --- Comment #6 from sandboxes at biblibre.com --- Patch tested with a sandbox, by Theodoros Theodoropoulos -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 12:44:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 10:44:25 +0000 Subject: [Koha-bugs] [Bug 23589] Discharge notice does not show non-latin characters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23589 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93402|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 12:44:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 10:44:34 +0000 Subject: [Koha-bugs] [Bug 23589] Discharge notice does not show non-latin characters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23589 --- Comment #7 from sandboxes at biblibre.com --- Created attachment 93413 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93413&action=edit Bug 23589: Discharge notice does not show non-latin characters It seems that discarge notices never got support for truetype fonts, so notices are missing non-latin characters. Signed-off-by: Theodoros Theodoropoulos -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 12:51:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 10:51:26 +0000 Subject: [Koha-bugs] [Bug 23589] Discharge notice does not show non-latin characters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23589 --- Comment #8 from Theodoros Theodoropoulos --- Maybe you could also test (and sign off if it works for you) a patch I submitted for BZ23514 here? https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23514 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 13:00:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 11:00:38 +0000 Subject: [Koha-bugs] [Bug 23170] in j2a.pl when a patron passes to an adult the name and surname of Guarantor stay on account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23170 Jesse Maseto changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jesse at bywatersolutions.com Status|Needs Signoff |Failed QA --- Comment #4 from Jesse Maseto --- Patch doesn't apply. Merge conflicts. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 13:17:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 11:17:00 +0000 Subject: [Koha-bugs] [Bug 23719] New: Record matching for authorities using defined fields is broken under ES Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23719 Bug ID: 23719 Summary: Record matching for authorities using defined fields is broken under ES Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Searching - Elasticsearch Assignee: nick at bywatersolutions.com Reporter: nick at bywatersolutions.com build_auth_query_compat for ES accepts only a few marclist parameters. In Zebra we pass through any indexes that we have not mapped. ES should do the same -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 13:20:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 11:20:14 +0000 Subject: [Koha-bugs] [Bug 23719] Record matching for authorities using defined fields is broken under ES In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23719 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 13:20:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 11:20:20 +0000 Subject: [Koha-bugs] [Bug 23719] Record matching for authorities using defined fields is broken under ES In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23719 --- Comment #1 from Nick Clemens --- Created attachment 93414 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93414&action=edit Bug 23719: Allow searching specific fields for matching authorities in ES To test: 1 - Export your authorities via Tools->Export data 2 - Define a record matching rule in Admin->Record matchign rules Use index: LC-card-number field: 010$a 3 - Stage the exported records for import and use the rule created above for matching 4 - The process does not complete 5 - Check intranet error logs - exception on unknown marclist 6 - Apply patch 7 - Repeat 8 - Success! 9 - prove -v t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 13:38:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 11:38:45 +0000 Subject: [Koha-bugs] [Bug 23522] Actual price should be shown in basket In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23522 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED CC| |katrin.fischer at bsz-bw.de --- Comment #5 from Katrin Fischer --- Blocked by dependency bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 13:50:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 11:50:00 +0000 Subject: [Koha-bugs] [Bug 20434] Updating Unimarc existing frameworks with IFLA updates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20434 --- Comment #4 from Julian Maurice --- Created attachment 93415 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93415&action=edit Bug 20434: Update UNIMARC framework - defaults -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 13:50:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 11:50:06 +0000 Subject: [Koha-bugs] [Bug 20434] Updating Unimarc existing frameworks with IFLA updates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20434 --- Comment #5 from Julian Maurice --- Created attachment 93416 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93416&action=edit Bug 20434: Update UNIMARC framework - authorised values -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 13:50:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 11:50:24 +0000 Subject: [Koha-bugs] [Bug 20434] Updating Unimarc existing frameworks with IFLA updates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20434 --- Comment #6 from Julian Maurice --- Created attachment 93417 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93417&action=edit Bug 20434: Update UNIMARC framework - biblio -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 13:50:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 11:50:29 +0000 Subject: [Koha-bugs] [Bug 20434] Updating Unimarc existing frameworks with IFLA updates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20434 --- Comment #7 from Julian Maurice --- Created attachment 93418 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93418&action=edit Bug 20434: Update UNIMARC framework - authtypes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 13:50:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 11:50:34 +0000 Subject: [Koha-bugs] [Bug 20434] Updating Unimarc existing frameworks with IFLA updates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20434 --- Comment #8 from Julian Maurice --- Created attachment 93419 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93419&action=edit Bug 20434: Update UNIMARC framework - auth (default) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 13:50:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 11:50:49 +0000 Subject: [Koha-bugs] [Bug 20434] Updating Unimarc existing frameworks with IFLA updates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20434 --- Comment #9 from Julian Maurice --- Created attachment 93420 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93420&action=edit Bug 20434: Update UNIMARC framework - auth (CLASS) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 13:50:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 11:50:57 +0000 Subject: [Koha-bugs] [Bug 20434] Updating Unimarc existing frameworks with IFLA updates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20434 --- Comment #10 from Julian Maurice --- Created attachment 93421 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93421&action=edit Bug 20434: Update UNIMARC framework - auth (CO) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 13:51:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 11:51:00 +0000 Subject: [Koha-bugs] [Bug 20434] Updating Unimarc existing frameworks with IFLA updates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20434 --- Comment #11 from Julian Maurice --- Created attachment 93422 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93422&action=edit Bug 20434: Update UNIMARC framework - auth (EXP) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 13:51:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 11:51:06 +0000 Subject: [Koha-bugs] [Bug 20434] Updating Unimarc existing frameworks with IFLA updates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20434 --- Comment #12 from Julian Maurice --- Created attachment 93423 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93423&action=edit Bug 20434: Update UNIMARC framework - auth (FAM) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 13:51:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 11:51:10 +0000 Subject: [Koha-bugs] [Bug 20434] Updating Unimarc existing frameworks with IFLA updates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20434 --- Comment #13 from Julian Maurice --- Created attachment 93424 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93424&action=edit Bug 20434: Update UNIMARC framework - auth (GENRE/FORM) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 13:51:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 11:51:15 +0000 Subject: [Koha-bugs] [Bug 20434] Updating Unimarc existing frameworks with IFLA updates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20434 --- Comment #14 from Julian Maurice --- Created attachment 93425 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93425&action=edit Bug 20434: Update UNIMARC framework - auth (NP) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 13:51:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 11:51:22 +0000 Subject: [Koha-bugs] [Bug 20434] Updating Unimarc existing frameworks with IFLA updates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20434 --- Comment #15 from Julian Maurice --- Created attachment 93426 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93426&action=edit Bug 20434: Update UNIMARC framework - auth (NTEXP) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 13:51:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 11:51:28 +0000 Subject: [Koha-bugs] [Bug 20434] Updating Unimarc existing frameworks with IFLA updates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20434 --- Comment #16 from Julian Maurice --- Created attachment 93427 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93427&action=edit Bug 20434: Update UNIMARC framework - auth (NTWORK) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 13:51:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 11:51:32 +0000 Subject: [Koha-bugs] [Bug 20434] Updating Unimarc existing frameworks with IFLA updates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20434 --- Comment #17 from Julian Maurice --- Created attachment 93428 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93428&action=edit Bug 20434: Update UNIMARC framework - auth (PA) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 13:51:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 11:51:35 +0000 Subject: [Koha-bugs] [Bug 20434] Updating Unimarc existing frameworks with IFLA updates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20434 --- Comment #18 from Julian Maurice --- Created attachment 93429 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93429&action=edit Bug 20434: Update UNIMARC framework - auth (PERS) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 13:51:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 11:51:42 +0000 Subject: [Koha-bugs] [Bug 20434] Updating Unimarc existing frameworks with IFLA updates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20434 --- Comment #19 from Julian Maurice --- Created attachment 93430 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93430&action=edit Bug 20434: Update UNIMARC framework - auth (PUB) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 13:51:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 11:51:49 +0000 Subject: [Koha-bugs] [Bug 20434] Updating Unimarc existing frameworks with IFLA updates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20434 --- Comment #20 from Julian Maurice --- Created attachment 93431 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93431&action=edit Bug 20434: Update UNIMARC framework - auth (SAUTTIT) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 13:51:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 11:51:55 +0000 Subject: [Koha-bugs] [Bug 20434] Updating Unimarc existing frameworks with IFLA updates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20434 --- Comment #21 from Julian Maurice --- Created attachment 93432 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93432&action=edit Bug 20434: Update UNIMARC framework - auth (SNC) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 13:52:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 11:52:03 +0000 Subject: [Koha-bugs] [Bug 20434] Updating Unimarc existing frameworks with IFLA updates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20434 --- Comment #22 from Julian Maurice --- Created attachment 93433 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93433&action=edit Bug 20434: Update UNIMARC framework - auth (SNG) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 13:52:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 11:52:08 +0000 Subject: [Koha-bugs] [Bug 20434] Updating Unimarc existing frameworks with IFLA updates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20434 --- Comment #23 from Julian Maurice --- Created attachment 93434 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93434&action=edit Bug 20434: Update UNIMARC framework - auth (TM) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 13:52:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 11:52:15 +0000 Subject: [Koha-bugs] [Bug 20434] Updating Unimarc existing frameworks with IFLA updates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20434 --- Comment #24 from Julian Maurice --- Created attachment 93435 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93435&action=edit Bug 20434: Update UNIMARC framework - auth (TU) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 13:52:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 11:52:21 +0000 Subject: [Koha-bugs] [Bug 20434] Updating Unimarc existing frameworks with IFLA updates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20434 --- Comment #25 from Julian Maurice --- Created attachment 93436 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93436&action=edit Bug 20434: Update UNIMARC framework - auth (WORK) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 13:52:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 11:52:27 +0000 Subject: [Koha-bugs] [Bug 20434] Updating Unimarc existing frameworks with IFLA updates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20434 --- Comment #26 from Julian Maurice --- Created attachment 93437 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93437&action=edit Bug 20434: Update UNIMARC framework - translations -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 13:52:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 11:52:32 +0000 Subject: [Koha-bugs] [Bug 20434] Updating Unimarc existing frameworks with IFLA updates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20434 --- Comment #27 from Julian Maurice --- Created attachment 93438 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93438&action=edit Bug 20434: Update UNIMARC framework - script Test plan: 1. Take a look at files in misc/migration_tools/ifla/data. It contains all data that will be inserted into Koha. Its content is based on the previous patches. 2. Run the script misc/migration_tools/ifla/update.pl and verify that it effectively added the new fields, subfields, authorised values and authority types. 3. Run the script again and see that it doesn't update existing fields 4. Run with --force and verify that it update existing fields (you can modify unimarc_ifla.yml to see changes) 5. Run with --force --po-file misc/migration_tools/ifla/language/fr.po and verify that the labels are now in french There is a POT file in misc/migration_tools/ifla/language/template.pot, use it to create PO files for other languages. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 13:53:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 11:53:27 +0000 Subject: [Koha-bugs] [Bug 23711] Icons on staff main page should be font icons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23711 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 13:53:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 11:53:30 +0000 Subject: [Koha-bugs] [Bug 23711] Icons on staff main page should be font icons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23711 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93395|0 |1 is obsolete| | --- Comment #6 from Fridolin SOMERS --- Created attachment 93439 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93439&action=edit Bug 23711: Icons on staff main page should be font icons Signed-off-by: Fridolin Somers -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 13:53:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 11:53:57 +0000 Subject: [Koha-bugs] [Bug 23711] Icons on staff main page should be font icons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23711 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93396|0 |1 is obsolete| | --- Comment #7 from Fridolin SOMERS --- Created attachment 93440 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93440&action=edit Bug 23711: Change icons and remove unused SVG Signed-off-by: Fridolin Somers -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 13:58:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 11:58:29 +0000 Subject: [Koha-bugs] [Bug 20434] Updating Unimarc existing frameworks with IFLA updates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20434 --- Comment #28 from Julian Maurice --- I split the big patch into smaller patches so that they can be attached on bugzilla. Also, I converted the translations file from YAML to PO. Strings are in english by default, french translations are available as a PO file. So now, if needed, the POT file can be integrated into Pootle. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 14:00:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 12:00:44 +0000 Subject: [Koha-bugs] [Bug 23551] problem while renew the checkout books in koha 19.05.03 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23551 Fiona Borthwick changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fiona.borthwick at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 14:02:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 12:02:14 +0000 Subject: [Koha-bugs] [Bug 23551] problem while renew the checkout books in koha 19.05.03 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23551 --- Comment #5 from Fiona Borthwick --- Can we try to pursue a fix for this soon please? Renewals work ok from the patron record but lots of our customers use this Renew option when they just want to renew a single item. It is a problem at 18.11 also. We have now had 3 customers report the same issue in the space of 3 days. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 14:04:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 12:04:35 +0000 Subject: [Koha-bugs] [Bug 23710] Holds broken, displays a JSON page with an error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23710 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Signed Off |Failed QA --- Comment #9 from Nick Clemens --- Hi Augustin, This works very well, but there are a few issues I spotted: 1 - The error messages are not translated from the return values to human readable. i.e. cannotReserveFromOtherBranches = Patron is from different library 2 - If 'AllowHoldsPolicyOverride' is enabled behvaiour can be strange To test: in Circ rules set Default Holds Policy by Item Type to 'From home library' find a patron from one library and a book with items from another attempt to place a single hold - for a single hold you get the error and cannot confirm/override do a search and attempt multiple holds, with some allowed, some not - the error message appear to pop up in yellow, but you are sent to next page and no error is indicated though the hold is not placed where it violates policy I think that is all I caught -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 14:05:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 12:05:10 +0000 Subject: [Koha-bugs] [Bug 23712] Silence warns from Koha/Illrequest/Logger.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23712 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 14:05:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 12:05:13 +0000 Subject: [Koha-bugs] [Bug 23712] Silence warns from Koha/Illrequest/Logger.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23712 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93376|0 |1 is obsolete| | --- Comment #3 from Brendan Gallagher --- Created attachment 93441 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93441&action=edit Bug 23712 - Silence warns from Koha/Illrequest/Logger.pm To test: - Run: $ sudo koha-shell -c "prove t/db_dependent/Illrequests.t" kohadev - Observe the warnings about "no query in themelanguage" - Apply the patch - Run prove again - Observe the lack of warnings about "no query in themelanguage" (There will be a couple of other warnings, but they are not related to the present bug.) Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 14:10:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 12:10:50 +0000 Subject: [Koha-bugs] [Bug 14493] export_borrowers.pl - Export patron attributes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14493 Séverine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune at bulac.fr Status|Needs Signoff |Patch doesn't apply --- Comment #12 from Séverine Queune --- Bug 14493 - export_borrowers.pl - Export patron attributes 41341 - export_borrowers.pl changed to support patron attributes 89574 - Bug 14493: export_borrowers.pl - Export patron attributes Apply? [(y)es, (n)o, (i)nteractive] y Applying: export_borrowers.pl changed to support patron attributes Using index info to reconstruct a base tree... M misc/export_borrowers.pl Falling back to patching base and 3-way merge... Auto-merging misc/export_borrowers.pl CONFLICT (content): Merge conflict in misc/export_borrowers.pl Failed to merge in the changes. Patch failed at 0001 export_borrowers.pl changed to support patron attributes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 14:18:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 12:18:39 +0000 Subject: [Koha-bugs] [Bug 18309] UNIMARC update from IFLA In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18309 --- Comment #83 from Julian Maurice --- Created attachment 93442 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93442&action=edit Bug 18309: Add UNIMARC field 214 and its subfields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 14:20:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 12:20:07 +0000 Subject: [Koha-bugs] [Bug 23551] Problem with renewal period when using the renewal tab in 19.05.03 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23551 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|problem while renew the |Problem with renewal period |checkout books in koha |when using the renewal tab |19.05.03 |in 19.05.03 Severity|normal |major -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 14:21:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 12:21:02 +0000 Subject: [Koha-bugs] [Bug 23551] Problem with renewal period when using the renewal tab in 19.05.03 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23551 --- Comment #6 from Katrin Fischer --- I think until 2 days ago we were missing the final clue - the difference is between the renewal tab and the other renewal features. I updated the severity and changed the title. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 14:23:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 12:23:34 +0000 Subject: [Koha-bugs] [Bug 23720] New: Move cover images to the left side of results page Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23720 Bug ID: 23720 Summary: Move cover images to the left side of results page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Most libraries seem to prefer to having cover images on the OPAC results page appear to the left of the text, this is would also make the OPAC results conform with the results in the staff interface. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 14:23:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 12:23:43 +0000 Subject: [Koha-bugs] [Bug 23720] Move cover images to the left side of results page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23720 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 14:24:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 12:24:01 +0000 Subject: [Koha-bugs] [Bug 23697] autocompletion search in patron module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23697 --- Comment #1 from Matthias Meusburger --- Created attachment 93443 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93443&action=edit Bug 23697: Add autocompletion search in patron module Test plan: - Apply the patch - Go to "Patrons" (members/members-home.pl) - Check that autocomplete is enabled for patron search -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 14:24:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 12:24:19 +0000 Subject: [Koha-bugs] [Bug 23123] Status AVAILABLE and ORDERED for suggestions are not translated in the templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23123 Claudie Trégouët changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91514|0 |1 is obsolete| | --- Comment #4 from Claudie Trégouët --- Created attachment 93444 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93444&action=edit Bug 23123: Add missing suggestion status to template for translation This completes suggestion status options in the templates in 2 places so all values can be translated and show correctly. To test: - Create 2 suggestions - Accept them - Create a basket and order those 2 from suggestions - Close the basket - Receive shipment and receive one of the 2 suggestions - Go back to suggestions: - Look at the status column in the suggestions table for both - Verify that it shows AVAILABLE - View both suggestions - Verify that the Status: is empty - Apply patch - Repeat test from above, it should all show nicely now Signed-off-by: Claudie Trégouët -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 14:24:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 12:24:26 +0000 Subject: [Koha-bugs] [Bug 23697] autocompletion search in patron module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23697 Matthias Meusburger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matthias.meusburger at biblibr | |e.com Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 14:24:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 12:24:55 +0000 Subject: [Koha-bugs] [Bug 23123] Status AVAILABLE and ORDERED for suggestions are not translated in the templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23123 Claudie Trégouët changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |claudie.tregouet at biblibre.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 14:25:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 12:25:00 +0000 Subject: [Koha-bugs] [Bug 23697] autocompletion search in patron module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23697 Matthias Meusburger changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |matthias.meusburger at biblibr |ity.org |e.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 14:29:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 12:29:34 +0000 Subject: [Koha-bugs] [Bug 22773] Bulk Close invoices and Filter invoice view (open/closed) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_19_11_candidate CC| |katrin.fischer at bsz-bw.de Status|Signed Off |Failed QA --- Comment #3 from Katrin Fischer --- This works really well, but can please do a minor follow-up? - Capitalization on the tab names and the new button is wrong: only the first word should begin with a capital letter (attaching a follow-up for this) - The buttons don't align - we are missing: margin: .5em 0 0; on the second button. They should also be using: btn btn-default classes instead of submit. - The alignment on the 'closed inovices' table seems a bit off. It's much smaller than my other table in testing and aligns 'center'. The data is almost indentical, so I think it's not that. - It would be nice if there is a message when you don't check anything and click on the button (we do that in other places, like when selecting records for merging). (not blocker) Please keep in touch - labelling this as 19.11 candidate for now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 14:33:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 12:33:00 +0000 Subject: [Koha-bugs] [Bug 23720] Move cover images to the left side of results page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23720 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- I wonder about usability here. If your covers have different sizes and or you are missing some, it might get a little harder to read the titles for quick orientation. For academic libraries we often only have a few covers per page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 14:33:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 12:33:23 +0000 Subject: [Koha-bugs] [Bug 23720] Move cover images to the left side of results page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23720 --- Comment #2 from Katrin Fischer --- Could we make this an optional change somehow? (using CSS or even a pref?) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 14:35:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 12:35:58 +0000 Subject: [Koha-bugs] [Bug 13881] Add desk management In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13881 Nicolas Legrand changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 14:36:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 12:36:01 +0000 Subject: [Koha-bugs] [Bug 13881] Add desk management In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13881 --- Comment #19 from Nicolas Legrand --- Created attachment 93445 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93445&action=edit Bug 13881: Schema file DO NOT PUSH! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 14:36:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 12:36:04 +0000 Subject: [Koha-bugs] [Bug 13881] Add desk management In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13881 --- Comment #20 from Nicolas Legrand --- Created attachment 93446 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93446&action=edit Bug 13881: kohastructure and atomic update -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 14:36:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 12:36:08 +0000 Subject: [Koha-bugs] [Bug 13881] Add desk management In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13881 Nicolas Legrand changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43664|0 |1 is obsolete| | --- Comment #21 from Nicolas Legrand --- Created attachment 93447 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93447&action=edit Bug 13881: Add desk management Add a desk and linked it to a library (branch). That's it. In the future it'll have super features like being able to link waiting reserve to a specific desk. Test plan: 1. go to the administration page and notice there isn't any mention of desk whatsoever 2. apply patches 3. ./installer/data/mysql/updatedatabase.pl 4. you now have desks links in admin-home and admin-menu 5. click the link 6. add a desk 7. add another one 8. delete one 9. you should have a fair list of all current desks defined 10. Done -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 14:36:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 12:36:13 +0000 Subject: [Koha-bugs] [Bug 23123] Status AVAILABLE and ORDERED for suggestions are not translated in the templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23123 --- Comment #5 from Katrin Fischer --- Thank you, Claudie! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 14:38:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 12:38:23 +0000 Subject: [Koha-bugs] [Bug 13881] Add desk management In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13881 Nicolas Legrand changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune at bulac.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 14:39:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 12:39:51 +0000 Subject: [Koha-bugs] [Bug 22773] Bulk Close invoices and Filter invoice view (open/closed) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 --- Comment #4 from Katrin Fischer --- Created attachment 93448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93448&action=edit Bug 22773: (follow-up) Fix capitalization -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 14:40:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 12:40:16 +0000 Subject: [Koha-bugs] [Bug 21903] koha-dump be able to include koha-upload In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21903 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m --- Comment #7 from Brendan Gallagher --- Just a note here for those that are using Vagrant installs (kohadevbox) you need to run reset_all for the /usr/sbin/koha-dump and /usr/share/koha/bin/koha-functions.sh to get the updated flags. After that I get matching messages for regular koha-dump: Dumping Koha site kohadev: * DB to /var/spool/koha/kohadev/kohadev-2019-10-02.sql.gz * configs, files, logs to /var/spool/koha/kohadev/kohadev-2019-10-02.tar.gz Done. But at last after I try to run the koha-dump --uploaded_files kohadev (I get) Error: invalid option switch (--uploaded_files) SO maybe I am wrong and this needs to be tested on a regular debian package. (I'll ping Tomas and see if he understands a little more about the vagrant installs). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 14:42:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 12:42:54 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Séverine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #276 from Séverine Queune --- The sandbox you've requested is not ready. Some problems occurred applying patches from bug 11708:

Something went wrong !

Applying: Bug 11708: Change aqbasketgroups.closed to closeddate Warning: commit message did not conform to UTF-8. You may want to amend it after fixing the message, or set the config variable i18n.commitencoding to the encoding your project uses. Applying: Bug 11708: New page for basket groups Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/includes/datatables.inc M koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt M koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basketgroup.tt M koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt M koha-tmpl/intranet-tmpl/prog/js/datatables.js Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/js/datatables.js CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/js/datatables.js Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basketgroup.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basketgroup.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/datatables.inc error: Failed to merge in the changes. Patch failed at 0001 Bug 11708: New page for basket groups -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 14:44:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 12:44:42 +0000 Subject: [Koha-bugs] [Bug 20434] Updating Unimarc existing frameworks with IFLA updates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20434 --- Comment #29 from Julian Maurice --- Created attachment 93449 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93449&action=edit Bug 20434: Add UNIMARC field 214 and its subfields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 14:48:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 12:48:14 +0000 Subject: [Koha-bugs] [Bug 23351] Clean up localization template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23351 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 14:48:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 12:48:25 +0000 Subject: [Koha-bugs] [Bug 23351] Clean up localization template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23351 --- Comment #4 from Katrin Fischer --- Created attachment 93450 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93450&action=edit Bug 23351: Clean up localization template This patch modifies the template used for translation of item type descriptions. It is updated with more consistent Bootstrap grid markup and improved handling of adding and removing rows from the DataTable. To test you should have more than one translation installed. - Apply the patch and go to Administration -> Item types. - Edit an item type. - Click the translate link. - Add a new translation. The table of translations should be updated with your new translation. - Test the "Delete" link corresponding to your new entry. It should work correctly. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 14:49:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 12:49:32 +0000 Subject: [Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 14:49:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 12:49:35 +0000 Subject: [Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589 --- Comment #67 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 14:50:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 12:50:16 +0000 Subject: [Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589 --- Comment #68 from Martin Renvoize --- Thanks all, great enhancement -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 14:50:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 12:50:28 +0000 Subject: [Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Manual, | |release-notes-needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 14:52:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 12:52:56 +0000 Subject: [Koha-bugs] [Bug 23351] Clean up localization template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23351 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93450|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 93451 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93451&action=edit Bug 23351: Clean up localization template This patch modifies the template used for translation of item type descriptions. It is updated with more consistent Bootstrap grid markup and improved handling of adding and removing rows from the DataTable. To test you should have more than one translation installed. - Apply the patch and go to Administration -> Item types. - Edit an item type. - Click the translate link. - Add a new translation. The table of translations should be updated with your new translation. - Test the "Delete" link corresponding to your new entry. It should work correctly. Signed-off-by: Jesse Maseto Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 14:52:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 12:52:58 +0000 Subject: [Koha-bugs] [Bug 23351] Clean up localization template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23351 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Attachment #93356|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 14:53:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 12:53:12 +0000 Subject: [Koha-bugs] [Bug 13881] Add desk management In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13881 Nicolas Legrand changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93445|0 |1 is obsolete| | --- Comment #22 from Nicolas Legrand --- Created attachment 93452 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93452&action=edit Bug 13881: Schema file DO NOT PUSH! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 14:53:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 12:53:16 +0000 Subject: [Koha-bugs] [Bug 13881] Add desk management In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13881 Nicolas Legrand changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93446|0 |1 is obsolete| | --- Comment #23 from Nicolas Legrand --- Created attachment 93453 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93453&action=edit Bug 13881: kohastructure and atomic update -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 14:53:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 12:53:22 +0000 Subject: [Koha-bugs] [Bug 13881] Add desk management In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13881 Nicolas Legrand changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93447|0 |1 is obsolete| | --- Comment #24 from Nicolas Legrand --- Created attachment 93454 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93454&action=edit Bug 13881: Add desk management Add a desk and linked it to a library (branch). That's it. In the future it'll have super features like being able to link waiting reserve to a specific desk. Test plan: 1. go to the administration page and notice there isn't any mention of desk whatsoever 2. apply patches 3. ./installer/data/mysql/updatedatabase.pl 4. you now have desks links in admin-home and admin-menu 5. click the link 6. add a desk 7. add another one 8. delete one 9. you should have a fair list of all current desks defined 10. Done -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 14:53:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 12:53:48 +0000 Subject: [Koha-bugs] [Bug 20334] Elasticsearch - Option for escaping slashes in search queries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334 --- Comment #39 from Ere Maijala --- David, are you able to work on this? I'd really like to get this in 19.11, so let my know if you need a hand here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 14:53:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 12:53:54 +0000 Subject: [Koha-bugs] [Bug 23351] Clean up localization template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23351 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 14:53:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 12:53:57 +0000 Subject: [Koha-bugs] [Bug 23351] Clean up localization template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23351 --- Comment #6 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 14:56:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 12:56:11 +0000 Subject: [Koha-bugs] [Bug 23015] Create a "GetPickupLocation" endpoint for the ILS-DI Service In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23015 Christophe Croullebois changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 14:56:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 12:56:16 +0000 Subject: [Koha-bugs] [Bug 23015] Create a "GetPickupLocation" endpoint for the ILS-DI Service In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23015 Christophe Croullebois changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90195|0 |1 is obsolete| | --- Comment #2 from Christophe Croullebois --- Created attachment 93455 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93455&action=edit Bug 23015 : Implements a new ILS-DI service to get available pickup libraries for an item or record test plan : 1 / Set a library A as available pickup location in the intranet 2 / query ILS-DI service with any record which has at least an item in A or an item which can be transfered to A => should send all informations about A 3 / Remove A from available pickup locations from the item in the intranet then repeat 2 => should give empty reply 4 / Try with unexisting patron, unexisting item or unexisting record, should throw an explicit error Signed-off-by: Christophe Croullebois -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 14:59:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 12:59:15 +0000 Subject: [Koha-bugs] [Bug 18309] UNIMARC update from IFLA In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18309 --- Comment #84 from Julian Maurice --- Created attachment 93456 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93456&action=edit Bug 18309: Fix INSERT sql query in unimarc_framework_DEFAULT.sql -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 15:04:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 13:04:19 +0000 Subject: [Koha-bugs] [Bug 21301] Restriction of the informations given by GetRecords ILS-DI service In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21301 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 15:04:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 13:04:48 +0000 Subject: [Koha-bugs] [Bug 21301] Restriction of the informations given by GetRecords ILS-DI service In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21301 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |critical -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 15:06:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 13:06:06 +0000 Subject: [Koha-bugs] [Bug 23612] If no columns in a table can be toggled, don't show columns button In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23612 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 15:06:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 13:06:20 +0000 Subject: [Koha-bugs] [Bug 23612] If no columns in a table can be toggled, don't show columns button In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23612 --- Comment #3 from Katrin Fischer --- Created attachment 93457 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93457&action=edit Bug 23612: If no columns in a table can be toggled, don't show columns button This patch makes a change to the JavaScript setup for DataTables button controls so that if there are no toggle-able buttons (or there is no columns configuration at all) the column selection menu button will not appear. To test, apply the patch and go to Administration -> Columns settings. - In the Administration section, find the section for the "libraries" table. - In the "Cannot be toggled" column, check all the checkboxes. - Save. - Go to Administration -> Libraries. - At the top of the table there should be no "Columns" button, only "Clear filter" and "Export" buttons. Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 15:11:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 13:11:44 +0000 Subject: [Koha-bugs] [Bug 23720] Move cover images to the left side of results page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23720 --- Comment #3 from Lucas Gass --- Created attachment 93458 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93458&action=edit search results with cover image -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 15:12:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 13:12:13 +0000 Subject: [Koha-bugs] [Bug 23720] Move cover images to the left side of results page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23720 --- Comment #4 from Lucas Gass --- Katrin, I think this could be done much easier with CSS if we added a new
wrapper around the title and summary information. A common problem now is that results with too much information end up overflowing like the attached image. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 15:12:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 13:12:29 +0000 Subject: [Koha-bugs] [Bug 23611] Add export option to authorized values administration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23611 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Signed Off |Failed QA --- Comment #4 from Katrin Fischer --- The patch appears to break sorting on the individual category pages (like HINGS_PF for example) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 15:12:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 13:12:46 +0000 Subject: [Koha-bugs] [Bug 21301] Restriction of the informations given by GetRecords ILS-DI service In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21301 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jean-manuel.broust at univ-lyo | |n2.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 15:13:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 13:13:29 +0000 Subject: [Koha-bugs] [Bug 21301] Restriction of the informations given by GetRecords ILS-DI service In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21301 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|wizzyrea at gmail.com |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 15:13:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 13:13:40 +0000 Subject: [Koha-bugs] [Bug 21301] Restriction of the informations given by GetRecords ILS-DI service In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21301 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 15:17:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 13:17:49 +0000 Subject: [Koha-bugs] [Bug 23720] Move cover images to the left side of results page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23720 --- Comment #5 from Lucas Gass --- Created attachment 93459 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93459&action=edit Bug 23720: Move cover images to the left side of results page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 15:19:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 13:19:18 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92378|0 |1 is obsolete| | --- Comment #277 from Julian Maurice --- Created attachment 93460 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93460&action=edit Bug 11708: Change aqbasketgroups.closed to closeddate Signed-off-by: juliette levast Signed-off-by: Paola Rossi Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 15:19:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 13:19:38 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92379|0 |1 is obsolete| | --- Comment #278 from Julian Maurice --- Created attachment 93461 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93461&action=edit Bug 11708: New page for basket groups This patch moves the code responsible for displaying a list of basket groups into its own Perl script (acqui/basketgroups.pl), making the code in basketgroup.pl and basketgroup.tt a little bit easier to read. basketgroups.pl displays all basket groups in a single table (as bug 13371 for vendors) where rows are grouped by bookseller. This patch also adds 3 columns: - No. of ordered titles - No. of received titles - Date closed It also adds a wrapper around the new DataTable() constructor to be able to use it with the same defaults than the previous dataTable() constructor Test plan: 0. Create a bunch of booksellers and basketgroups 1. Go back to acquisitions home page and click on "Basket groups" link on the left 2. Play with the table (sort, filter) and try every possible actions (Edit, Close and export as PDF, View, Reopen, Export as CSV) 3. Go to a specific vendor page and click on "Basket groups" tab 4. Check that only the vendor's basket groups are displayed 5. prove t/db_dependent/Koha/Acquisition/Basket.t Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 15:20:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 13:20:03 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92380|0 |1 is obsolete| | --- Comment #279 from Julian Maurice --- Created attachment 93462 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93462&action=edit Bug 11708: Add missing POD in Koha::Acquisition::Basket -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 15:20:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 13:20:18 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92381|0 |1 is obsolete| | --- Comment #280 from Julian Maurice --- Created attachment 93463 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93463&action=edit Bug 11708: Use bootstrap grid instead of yui -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 15:20:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 13:20:38 +0000 Subject: [Koha-bugs] [Bug 19036] Number payment receipts / payment slips In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036 --- Comment #3 from Katrin Fischer --- As I understood this is a legal requirement in some countries, possibly relating to anti-corruption laws, where they have to keep a tight track of all the monetary transactions. I believe the number has to be sequential to avoid problems (like getting asked about missing receipts for missing numbers). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 15:20:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 13:20:58 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92382|0 |1 is obsolete| | --- Comment #281 from Julian Maurice --- Created attachment 93464 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93464&action=edit Bug 11708: Fix PDF export -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 15:22:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 13:22:17 +0000 Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous payments in a POS fashion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93116|0 |1 is obsolete| | --- Comment #40 from Martin Renvoize --- Created attachment 93465 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93465&action=edit Bug 23354: Add a Point Of Sale 'pay' screen This patch adds a new Point Of Sale module to Koha's staff client front page. The module button leads directly to a 'Pay' page giving the staff user the ability to record anonymous payments for items that would not normally require a patron to be registered at the library. Test plan: 1) Enable `UseCashRegisters` via the system preferences. 2) Ensure your user has the 'manage_cash_registers' permission. 3) Add a cash register for your current branch. 4) Add at least one 'MANUAL_INV' authorized value. 5) Navigate to the new 'POS' pay page via the main menu. 6) Add an item to the 'sale' by clicking 'add' from the right side of the screen. 7) Note that said item was added to the table of items this sale on the left. 8) At this point you should be able to 'click to edit' the quantity or price of the item in the table on the left. 9) Enter an amount greater than the price of the item into the 'amount collected from patron' box. 10) Click 'Confirm' 11) Varify that the same change to give modal from the paycollect pages appears here. 12) Click 'Confirm' 13) Payment will have been recorded (check the database) and you will be back at a fresh 'Pay' page ready for the next transaction. 14) Signoff Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 15:22:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 13:22:20 +0000 Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous payments in a POS fashion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93117|0 |1 is obsolete| | --- Comment #41 from Martin Renvoize --- Created attachment 93466 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93466&action=edit Bug 23354: Add receipting to Pay page This patch adds receipt printing to the new Point of Sale pay page. Test plan: 1) Apply patch and run database update 2) Enable automatic receipt printing via the `` system preference. 3) Make a payment for an item via the new POS pay page. 4) Note that a receipt printing dialogue is shown automatically after payment. 5) Note that a new notice is available under tools where you can alter the content of the receipt. 6) Signoff Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 15:22:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 13:22:24 +0000 Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous payments in a POS fashion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93118|0 |1 is obsolete| | --- Comment #42 from Martin Renvoize --- Created attachment 93467 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93467&action=edit Bug 23354: Add ability to remove items This patch adds the ability to remove items from a transactions on the new Point of Sale pay page. Test plan: 1) Populate a transaction with at least one item. 2) Note the new button to 'Remove item' on the items table. 3) Click the button and confirm the item is removed 4) Signoff Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 15:22:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 13:22:26 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 15:22:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 13:22:28 +0000 Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous payments in a POS fashion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93119|0 |1 is obsolete| | --- Comment #43 from Martin Renvoize --- Created attachment 93468 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93468&action=edit Bug 23354: (follow-up) Responses to feedback This patch impliments a number of refinements requested after the first round of feedback from the sponsors. 1) Fix padding on pay page 2) Switch 'items to add' from right to left on the page 3) Fix editable columns on pay page 4) Add explanitory text to pay page Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 15:22:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 13:22:32 +0000 Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous payments in a POS fashion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93120|0 |1 is obsolete| | --- Comment #44 from Martin Renvoize --- Created attachment 93469 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93469&action=edit Bug 23354: Add permissions Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 15:22:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 13:22:36 +0000 Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous payments in a POS fashion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93121|0 |1 is obsolete| | --- Comment #45 from Martin Renvoize --- Created attachment 93470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93470&action=edit Bug 23354: Add tests for Koha::Charges::Sales Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 15:22:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 13:22:40 +0000 Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous payments in a POS fashion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93122|0 |1 is obsolete| | --- Comment #46 from Martin Renvoize --- Created attachment 93471 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93471&action=edit Bug 23354: (follow-up) Add till icon -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 15:22:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 13:22:43 +0000 Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous payments in a POS fashion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93123|0 |1 is obsolete| | --- Comment #47 from Martin Renvoize --- Created attachment 93472 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93472&action=edit Bug 23354: (follow-up) Input type on jEditable Update the jEditable plugin to a maintained version and use the new 'number' type to enable increment arrows on click and remap onblur event to submit. Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 15:22:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 13:22:47 +0000 Subject: [Koha-bugs] [Bug 23720] Move cover images to the left side of results page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23720 --- Comment #6 from Lucas Gass --- TEST PLAN: 1. Apply this patch and turn on some cover images. 2. Add this CSS: '.bibliocol {display: flex;}.coverimages {padding-right:20px;}' to the OPACUserCSS. 3. Notice covers on left. 4. Remove CSS and notice covers should look normal on the right side. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 15:22:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 13:22:47 +0000 Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous payments in a POS fashion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93124|0 |1 is obsolete| | --- Comment #48 from Martin Renvoize --- Created attachment 93473 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93473&action=edit Bug 23354: (follow-up) Use 'format_price' for totals Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 15:22:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 13:22:48 +0000 Subject: [Koha-bugs] [Bug 19036] Number payment receipts / payment slips In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036 --- Comment #4 from Katrin Fischer --- Ah, also accountlines_id is on the wrong level I think - we want to number the payments - a payment might include changes to multiple accountlines. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 15:23:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 13:23:07 +0000 Subject: [Koha-bugs] [Bug 23720] Move cover images to the left side of results page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23720 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 15:25:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 13:25:46 +0000 Subject: [Koha-bugs] [Bug 21301] Restriction of the informations given by GetRecords ILS-DI service In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21301 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18081 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18081 [Bug 18081] [omnibus] GDPR (General Data Protection Regulation) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 15:25:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 13:25:46 +0000 Subject: [Koha-bugs] [Bug 18081] [omnibus] GDPR (General Data Protection Regulation) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18081 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |21301 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21301 [Bug 21301] Restriction of the informations given by GetRecords ILS-DI service -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 15:31:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 13:31:38 +0000 Subject: [Koha-bugs] [Bug 17268] Advanced cataloging editor - rancor - macros are lost when browser storage cleared In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 --- Comment #8 from Nick Clemens --- Created attachment 93474 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93474&action=edit Bug 17268: Add macros table and permissions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 15:32:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 13:32:19 +0000 Subject: [Koha-bugs] [Bug 23531] ILS-DI doesn't implement needed_before_date and pickup_expiry_date parameters. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531 Christophe Croullebois changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 15:32:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 13:32:28 +0000 Subject: [Koha-bugs] [Bug 23531] ILS-DI doesn't implement needed_before_date and pickup_expiry_date parameters. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531 Christophe Croullebois changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92538|0 |1 is obsolete| | --- Comment #2 from Christophe Croullebois --- Created attachment 93475 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93475&action=edit bug23531 : fix ILSDI non-implemented but documented parameters test plan : 1/ Submit a hold through ILSDI with needed_before_date and pickup_expiry_date parameters 2/ Verify in Koha those parameters are not applied to the newly created reserve. Delete reserve. 3/ Apply patch and repeat 1. 4/ Verify the reserve created by same request as 1 now has both dates applied and visible in Koha. Signed-off-by: Christophe Croullebois -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 15:33:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 13:33:22 +0000 Subject: [Koha-bugs] [Bug 17268] Advanced cataloging editor - rancor - macros are lost when browser storage cleared In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 --- Comment #9 from Nick Clemens --- Working on moving the macros into the DB I think we should add a REST route for CRUD and new permissions for public macros Please file a new bug for mapping macros to hotkeys :-) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 15:33:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 13:33:56 +0000 Subject: [Koha-bugs] [Bug 18969] _all field is deprecated - should use copy_to to prepare for ES6 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18969 Alex Sassmannshausen changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |MOVED CC| |alex at komputilo.eu Status|Needs Signoff |RESOLVED --- Comment #36 from Alex Sassmannshausen --- It was generally agreed that bug20589 renders this patch obsolete. bug20589 is now in master, so we can close this bug. Closing after checking with Alex & Nick. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 15:33:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 13:33:57 +0000 Subject: [Koha-bugs] [Bug 20196] [Omnibus] Prepare Koha to ElasticSearch6 - ES6 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20196 Bug 20196 depends on bug 18969, which changed state. Bug 18969 Summary: _all field is deprecated - should use copy_to to prepare for ES6 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18969 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |MOVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 15:35:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 13:35:23 +0000 Subject: [Koha-bugs] [Bug 23697] autocompletion search in patron module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23697 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 15:35:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 13:35:27 +0000 Subject: [Koha-bugs] [Bug 23697] autocompletion search in patron module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23697 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93443|0 |1 is obsolete| | --- Comment #2 from Lucas Gass --- Created attachment 93476 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93476&action=edit Bug 23697: Add autocompletion search in patron module Test plan: - Apply the patch - Go to "Patrons" (members/members-home.pl) - Check that autocomplete is enabled for patron search Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 15:41:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 13:41:07 +0000 Subject: [Koha-bugs] [Bug 21701] Have PayPal optionally return to originating OPAC url rather than OPACBaseURL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21701 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 15:41:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 13:41:10 +0000 Subject: [Koha-bugs] [Bug 21701] Have PayPal optionally return to originating OPAC url rather than OPACBaseURL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21701 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82103|0 |1 is obsolete| | --- Comment #4 from Brendan Gallagher --- Created attachment 93477 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93477&action=edit Bug 21701: Have PayPal optionally return to originating OPAC url rather than OPACBaseURL This enhancement will allow a library to choose whether to use the alias of the current OPAC or the value of OPACBaseURL as the return url when making payments via PayPal. To test: Note: you need to have PayPal enabled on your system (either Sandbox mode or Live) and be using an alias URL for your OPAC. 1. Apply the patch. 2. With the option "PayPalReturnURL" set to "OPACBaseURL", log into a card via the OPAC and start the process to pay in PayPal (you can either complete the payment or cancel from the PayPal page). When you are returned to the OPAC, the domain will be the value of OPACBaseURL. 3. With the option "PayPalReturnURL" set to "OPAC's alias", repeat the above sequence to make a payment in PayPal. When you are returned to the OPAC, the domain will be your current alias. Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 15:50:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 13:50:34 +0000 Subject: [Koha-bugs] [Bug 6879] Actual price should show correctly on order line and basket summary In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6879 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #16 from Nick Clemens --- Duplicate of 23522? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 15:55:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 13:55:01 +0000 Subject: [Koha-bugs] [Bug 23711] Icons on staff main page should be font icons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23711 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 15:59:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 13:59:59 +0000 Subject: [Koha-bugs] [Bug 20334] Elasticsearch - Option for escaping slashes in search queries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85129|0 |1 is obsolete| | --- Comment #40 from David Gustafsson --- Created attachment 93478 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93478&action=edit Bug 20334 - Option for escaping slashes in search queries Add "QueryRegexEscapeOption" system preference to provide option to escape Elasticsearch regexp delimiters (/) within queries, or alternativly to unescape escaped slashes (\/) while escaping unescaped slashes, in effect making "\/" the new regexp delimiter. How to test: 1) Run tests in ./t/Koha/SearchEngine/ElasticSearch/QueryBuilder.t 2) All tests should succeed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 16:01:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 14:01:17 +0000 Subject: [Koha-bugs] [Bug 20334] Elasticsearch - Option for escaping slashes in search queries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334 --- Comment #41 from David Gustafsson --- Hi! I have not made any changes to the patch, but I had a more recent rebase of this branch locally that had not submitted, So patch should at least apply now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 16:03:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 14:03:20 +0000 Subject: [Koha-bugs] [Bug 20334] Elasticsearch - Option for escaping slashes in search queries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334 --- Comment #42 from Katrin Fischer --- Ere and David, are more changes needed? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 16:06:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 14:06:36 +0000 Subject: [Koha-bugs] [Bug 23606] Add columns configuration and export options to item types administration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23606 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 16:08:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 14:08:16 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #282 from sandboxes at biblibre.com --- Patch tested with a sandbox, by Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 16:09:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 14:09:12 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93460|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 16:09:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 14:09:17 +0000 Subject: [Koha-bugs] [Bug 23711] Icons on staff main page should be font icons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23711 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93439|0 |1 is obsolete| | --- Comment #8 from Lucas Gass --- Created attachment 93479 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93479&action=edit Bug 23711: Icons on staff main page should be font icons Signed-off-by: Fridolin Somers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 16:09:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 14:09:23 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93461|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 16:09:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 14:09:28 +0000 Subject: [Koha-bugs] [Bug 23711] Icons on staff main page should be font icons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23711 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93440|0 |1 is obsolete| | --- Comment #9 from Lucas Gass --- Created attachment 93480 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93480&action=edit Bug 23711: Change icons and remove unused SVG Signed-off-by: Fridolin Somers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 16:09:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 14:09:35 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93462|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 16:09:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 14:09:39 +0000 Subject: [Koha-bugs] [Bug 23711] Icons on staff main page should be font icons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23711 --- Comment #10 from Lucas Gass --- Created attachment 93481 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93481&action=edit Bug 23711: Fix bad path -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 16:09:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 14:09:46 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93463|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 16:09:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 14:09:57 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93464|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 16:10:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 14:10:10 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 --- Comment #283 from sandboxes at biblibre.com --- Created attachment 93482 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93482&action=edit Bug 11708: Change aqbasketgroups.closed to closeddate Signed-off-by: juliette levast Signed-off-by: Paola Rossi Signed-off-by: Séverine QUEUNE Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 16:10:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 14:10:16 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 --- Comment #284 from sandboxes at biblibre.com --- Created attachment 93483 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93483&action=edit Bug 11708: New page for basket groups This patch moves the code responsible for displaying a list of basket groups into its own Perl script (acqui/basketgroups.pl), making the code in basketgroup.pl and basketgroup.tt a little bit easier to read. basketgroups.pl displays all basket groups in a single table (as bug 13371 for vendors) where rows are grouped by bookseller. This patch also adds 3 columns: - No. of ordered titles - No. of received titles - Date closed It also adds a wrapper around the new DataTable() constructor to be able to use it with the same defaults than the previous dataTable() constructor Test plan: 0. Create a bunch of booksellers and basketgroups 1. Go back to acquisitions home page and click on "Basket groups" link on the left 2. Play with the table (sort, filter) and try every possible actions (Edit, Close and export as PDF, View, Reopen, Export as CSV) 3. Go to a specific vendor page and click on "Basket groups" tab 4. Check that only the vendor's basket groups are displayed 5. prove t/db_dependent/Koha/Acquisition/Basket.t Signed-off-by: Séverine QUEUNE Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 16:10:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 14:10:23 +0000 Subject: [Koha-bugs] [Bug 23606] Add columns configuration and export options to item types administration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23606 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 16:10:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 14:10:25 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 --- Comment #285 from sandboxes at biblibre.com --- Created attachment 93484 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93484&action=edit Bug 11708: Add missing POD in Koha::Acquisition::Basket Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 16:10:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 14:10:34 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 --- Comment #286 from sandboxes at biblibre.com --- Created attachment 93485 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93485&action=edit Bug 11708: Use bootstrap grid instead of yui Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 16:10:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 14:10:35 +0000 Subject: [Koha-bugs] [Bug 23606] Add columns configuration and export options to item types administration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23606 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93049|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 93486 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93486&action=edit Bug 23606: Add columns configuration and export options to item types administration This patch adds column configuration to the table of item types in administration. No new defaults for the table are defined. To test, apply the patch and clear your browser cache if necessary. - Go to Administration -> Item types. - Test that the "Column visibility" button works to show and hide columns. The "actions" column should be excluded. - Test that export options (Excel, CSV, etc) exclude the "actions" column. - Go to Administration -> Columns settings and edit the default configuration of the item types table. Confirm that these changes are reflected in item tyeps administration. Test with noItemTypeImages on and off. Signed-off-by: Maryse Simard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 16:10:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 14:10:40 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 --- Comment #287 from sandboxes at biblibre.com --- Created attachment 93487 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93487&action=edit Bug 11708: Fix PDF export Signed-off-by: Séverine QUEUNE Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 16:11:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 14:11:57 +0000 Subject: [Koha-bugs] [Bug 23720] Add div wrapper to search results to make moving cover images easier In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23720 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Move cover images to the |Add div wrapper to search |left side of results page |results to make moving | |cover images easier -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 16:16:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 14:16:32 +0000 Subject: [Koha-bugs] [Bug 23721] New: Names of exported basketgroup files should be uniformised Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23721 Bug ID: 23721 Summary: Names of exported basketgroup files should be uniformised Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: severine.queune at bulac.fr QA Contact: testopia at bugs.koha-community.org When exporting a basket group, the names of the files are different depending on the format chosen : if pdf, the aqbasketgroup.name is used ; if csv, it's the aqbasketgroup.id. I think it would be clearer for the users if names could be the same. My preference goes to the aqbasketgroup.name as it's the name chosen by librarians to ease acquisition management. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 16:21:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 14:21:19 +0000 Subject: [Koha-bugs] [Bug 20816] Add ability to send custom field(s) containing patron information in SIP patron responses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20816 Jesse Maseto changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jesse at bywatersolutions.com --- Comment #2 from Jesse Maseto --- Patch does not apply. Merge conflicts. Using index info to reconstruct a base tree... M C4/SIP/ILS/Patron.pm M C4/SIP/Sip.pm M C4/SIP/Sip/MsgType.pm M etc/SIPconfig.xml Falling back to patching base and 3-way merge... Auto-merging etc/SIPconfig.xml CONFLICT (content): Merge conflict in etc/SIPconfig.xml Auto-merging C4/SIP/Sip/MsgType.pm CONFLICT (content): Merge conflict in C4/SIP/Sip/MsgType.pm Auto-merging C4/SIP/Sip.pm Auto-merging C4/SIP/ILS/Patron.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 20816: Add ability to define custom templated fields in SIP patron responses The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-20816-Add-ability-to-define-custom-templated-f-a8rxuw.patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 16:22:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 14:22:49 +0000 Subject: [Koha-bugs] [Bug 22706] Add plugin hooks to enable Norwegian national patron database In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22706 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 16:22:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 14:22:52 +0000 Subject: [Koha-bugs] [Bug 22706] Add plugin hooks to enable Norwegian national patron database In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22706 --- Comment #1 from Magnus Enger --- Created attachment 93488 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93488&action=edit Bug 22706 - Add plugin hooks for Norwegian national patron database The main point of this patch is to make it possible to integrate Koha with the Norwegian national patron database. Code for this was earlier introduced in Bug 11401 and removed again in Bug 21068. To test this is mainly a question of spotting regressions, it should still be possible to set and change a password in all possible ways: - Setting a password for a new user - Changing a password in the staff client - Changing a password in the OPAC If these work as expected, everything should be OK. A nice side effect of this work is that it will allow for plugins that validate passwords. I have created a tiny plugin that enforces PIN codes of 4 digits. (Yeah, I know, those are the worst passwords, but some libraries do require them.) It is published here: https://github.com/Libriotech/koha-plugin-pin To test this way, install the plugin and try to change the password of an exsisting user to something that is not a 4 digit PIN. You should get an error that says "The password was rejected by a plugin". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 16:28:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 14:28:00 +0000 Subject: [Koha-bugs] [Bug 22706] Add plugin hooks to enable Norwegian national patron database In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22706 --- Comment #2 from Magnus Enger --- So let me just repeat that I think integration with the Norwegian national patron database is the main point of this patch, and that testing for regressions should be sufficient to sign off. The password checking is a nice side effect, but it can and should be extended and improved in some other bug than this. And yes, this makes it possible to create a plugin that steals passwords. But I think plugins are pretty powerfull already, and we should always inspect the contents of plugins before we install them. :-) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 16:28:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 14:28:40 +0000 Subject: [Koha-bugs] [Bug 23686] Check onsite checkout when the last checkout was an onsite one In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23686 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 16:28:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 14:28:50 +0000 Subject: [Koha-bugs] [Bug 23686] Check onsite checkout when the last checkout was an onsite one In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23686 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93203|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 93489 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93489&action=edit Bug 23686: Check onsite checkout when the last checkout was an onsite one Prevent from checking again and again the onsite checkout box when doing onsite checkouts in batches. If preceding checkout was an onsite one, the box will be checked. Test plan: 1. enable OnSiteCheckouts 2. make your circulation rules able to checkout onsite 3. onsite checkout a document 4. you should return to the checkout page, the box isn't checked 5. apply patch 6. updatedatabase.pl 7. redo steps 3, it should again print a checkout page with an unchecked onsite checkout box 8. enable OnSiteCheckoutAutoCheck system preference 9. redo step 3 10. when returning to the checkout page, the onsite checkout box should be already checked Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 16:28:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 14:28:57 +0000 Subject: [Koha-bugs] [Bug 23686] Check onsite checkout when the last checkout was an onsite one In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23686 --- Comment #4 from Katrin Fischer --- Created attachment 93490 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93490&action=edit Bug 23686: (QA follow-up) Fix updatedatabase and make descriptions consistent -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 16:31:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 14:31:49 +0000 Subject: [Koha-bugs] [Bug 17179] Advanced editor: Add keyboard shortcuts to repeat (duplicate) a field, and cut text In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17179 Alex Sassmannshausen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alex at komputilo.eu Status|Needs Signoff |Failed QA --- Comment #14 from Alex Sassmannshausen --- Hi Nick, As discussed, I'm failing this because of an error on the Shift-Ctrl-{C,X} keyboard shortcuts. When they are used, console logs errors that curCursor is not a function. Also, as a suggested improvement, possibly addressing some of the useability issues raised, it'd be amazing if any cut or copy operation resulted in the latest item in the clipboard being selected immediately. This would allow users to cut/copy & paste fields and subfields quickly without having to switch to the mouse to select the last copied/cut content and then focusing on the right location in the editor again. Hth, Alex -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 16:34:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 14:34:24 +0000 Subject: [Koha-bugs] [Bug 23710] Holds broken, displays a JSON page with an error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23710 Agustín Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 16:34:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 14:34:32 +0000 Subject: [Koha-bugs] [Bug 23710] Holds broken, displays a JSON page with an error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23710 --- Comment #10 from Agustín Moyano --- Created attachment 93491 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93491&action=edit Bug 23710: (follow-up) Human readable error messages in request.tt, check AllowHoldPolicyOverride and AllowHoldDateInFuture in Koha::REST::V1::Holds.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 16:36:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 14:36:42 +0000 Subject: [Koha-bugs] [Bug 23706] Item search CSV export doesn't include collection code In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23706 Séverine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |severine.queune at bulac.fr --- Comment #9 from Séverine Queune --- The sandbox you've requested is not ready. Some problems occurred applying patches from bug 23706:

Something went wrong !

Applying: LLP: Bug 23706 Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/includes/catalogue/itemsearch_item.csv.inc Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/catalogue/itemsearch_item.csv.inc CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/includes/catalogue/itemsearch_item.csv.inc error: Failed to merge in the changes. Patch failed at 0001 LLP: Bug 23706 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 16:38:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 14:38:18 +0000 Subject: [Koha-bugs] [Bug 18084] Language selector hidden in user menu on mobile interfaces In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18084 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 16:51:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 14:51:19 +0000 Subject: [Koha-bugs] [Bug 13881] Add desk management In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13881 Séverine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #25 from Séverine Queune --- I notices several problems : - the creation form make me think I can choose the desk ID, but I can't : it has to be a number. If I write something else, it's replaced. - if I delete a desk and then create a new one, I can re-use the desk ID of the deleted desk. I don't know if it can lead to problems linking datas, but to me, it's seems a curious behaviour. - if I create a new desk using, by mistake, an existing desk ID, it updates the existing desk. My conclusion is that desk ID should not be an editable field. Except these points, it works fine :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 16:52:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 14:52:20 +0000 Subject: [Koha-bugs] [Bug 14669] Search orders by managing library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14669 Alex Sassmannshausen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alex at komputilo.eu Status|Needs Signoff |Failed QA --- Comment #13 from Alex Sassmannshausen --- Tests pass, but filtering does not seem to work. I've created baskets with orders. One is managed by centerville the other by none. Standard search returns both results, but search filtered by managed by centerville also returns both. I would expect to only return those managed by centerville. Managing library is also not displayed in the basket overview datatable. Hth, Alex -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 16:53:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 14:53:14 +0000 Subject: [Koha-bugs] [Bug 18084] Language selector hidden in user menu on mobile interfaces In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18084 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 16:53:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 14:53:17 +0000 Subject: [Koha-bugs] [Bug 18084] Language selector hidden in user menu on mobile interfaces In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18084 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93374|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 93492 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93492&action=edit Bug 18084: Language selector hidden in user menu on mobile interfaces This patch updates templates and CSS so that the language-selection menu in the header will not be hidden if the browser width is too narrow. This patch also makes some more general improvements to the responsive adaptability of the header elements. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). Test the changes by viewing pages in the OPAC and adjusting your browser width, paying attention to how elements in the top menu adapt to different sizes. Test under varying conditions: - Logged in/not loggeed user - Search history enabled and disabled - OpacLangSelectorMode showing menu in header or not - opacuserlogin enabled or disabled Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 16:54:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 14:54:29 +0000 Subject: [Koha-bugs] [Bug 20816] Add ability to send custom field(s) containing patron information in SIP patron responses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20816 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90813|0 |1 is obsolete| | --- Comment #3 from Nick Clemens --- Created attachment 93493 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93493&action=edit Bug 20816: Add ability to define custom templated fields in SIP patron responses To test: 1 - You will need to enable SIP on your testing instance cp etc/SIPconfig.xml /etc/koha/sites/kohadev/ sudo koha-start-sip add a user listed in the SIPconfig to your system and give them permissions (superlibrarian works) 2 - If you copied the above file you should be set to get custom field DE with dateexpiry 3 - send a status test using the sip cli tester: perl misc/sip_cli_emulator.pl -a 127.0.0.1 -p 6001 -su lpl-sc-beacock -sp xyzzy -l LPL --patron nick -m patron_status_request 4 - send an information test using the sip cli tester: perl misc/sip_cli_emulator.pl -a 127.0.0.1 -p 6001 -su lpl-sc-beacock -sp xyzzy -l LPL --patron nick -m patron_information 5 - confirm you receive the DE field with a dateexpiry 6 - Add your own custom fields and confirm it works with several 7 - prove -v t/db_dependent/SIP/Patron.t 8 - prove -v t/db_dependent/SIP/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 16:54:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 14:54:37 +0000 Subject: [Koha-bugs] [Bug 20816] Add ability to send custom field(s) containing patron information in SIP patron responses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20816 --- Comment #4 from Nick Clemens --- Created attachment 93494 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93494&action=edit Bug 20816: Make SIP tests pass under ES -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 16:56:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 14:56:37 +0000 Subject: [Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Séverine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #91 from Séverine Queune --- The sandbox you've requested is not ready. Some problems occurred applying patches from bug 14715:

Something went wrong !

Applying: Bug 14715: results per page setting for catalog search Using index info to reconstruct a base tree... M C4/Search.pm M catalogue/search.pl M koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt M koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt M opac/opac-search.pl Falling back to patching base and 3-way merge... Auto-merging opac/opac-search.pl CONFLICT (content): Merge conflict in opac/opac-search.pl Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt Auto-merging catalogue/search.pl CONFLICT (content): Merge conflict in catalogue/search.pl Auto-merging C4/Search.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 14715: results per page setting for catalog search -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 17:03:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 15:03:06 +0000 Subject: [Koha-bugs] [Bug 21301] Restriction of the informations given by GetRecords ILS-DI service In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21301 --- Comment #1 from Fridolin SOMERS --- Created attachment 93495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93495&action=edit Bug 21301: Remove patron informations in issues for GetRecords ILS-DI service Actually, the GetRecords service gives many information : bibliographic data (marcxml field) item data (items field) issue data (issues field) The issue data should not be sent by these service, its a privacy problem. Biblio title and author are redundant. This patch changes to use Koha::Checkouts to get issues informations with only the addition of item barcode. Test plan : 1) Enable ILS-DI webservice 2) Checkout an item 3) Go to {opac}/cgi-bin/koha/ilsdi.pl?service=GetRecords&id={biblionumber} 4) Check the issues tag content -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 17:27:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 15:27:42 +0000 Subject: [Koha-bugs] [Bug 23715] Batch item modification sets a value in incorrect field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23715 --- Comment #3 from Christopher Brannon --- (In reply to Katrin Fischer from comment #2) > Hi Christopher, we just fixed a bug like this (waiting for Rmaints > currently): bug 18710. Marking duplicate, please check and change back if I > am mistaken! > > *** This bug has been marked as a duplicate of bug 18710 *** Yep, that's the culprit. Hope they will backport it. I consider it critical since it will do unwanted things to mass records. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 17:28:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 15:28:33 +0000 Subject: [Koha-bugs] [Bug 18783] Allow automatic claims for serials In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18783 Laurence Rault changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |laurence.rault at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 17:28:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 15:28:43 +0000 Subject: [Koha-bugs] [Bug 18710] Wrong subfield modified in batch item modification In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18710 --- Comment #20 from Christopher Brannon --- Please push this to stable and old stable. I consider this a critical bug that can do damage in mass. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 17:31:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 15:31:35 +0000 Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 Séverine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |severine.queune at bulac.fr --- Comment #179 from Séverine Queune --- On step 6 : when I edit the rule, the "Preset" field comes back to the first value "Custom" : I think it's a disturbing and the value registred should be kept. On step 7 : there are gaps into the buttons, like if icons where missing, and they don't seem to have the same css (can send a screenshot if needed). Behaviours of both buttons are correct. On step 13 : once the rule is saved, the filter displays "intranet" but when creating the rule, it's "Staff client MARC editor". Maybe it should be uniformised ? Tested using a sandbox so can't run tests on step 15. Hope this feedback will be helpfull ! Except these points, the feature works fine and will be very useful ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 17:33:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 15:33:45 +0000 Subject: [Koha-bugs] [Bug 23711] Icons on staff main page should be font icons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23711 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93479|0 |1 is obsolete| | Attachment #93480|0 |1 is obsolete| | Attachment #93481|0 |1 is obsolete| | --- Comment #11 from Owen Leonard --- Created attachment 93496 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93496&action=edit Bug 23711: Icons on staff main page should be font icons Signed-off-by: Fridolin Somers Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 17:33:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 15:33:49 +0000 Subject: [Koha-bugs] [Bug 23711] Icons on staff main page should be font icons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23711 --- Comment #12 from Owen Leonard --- Created attachment 93497 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93497&action=edit Bug 23711: Change icons and remove unused SVG Signed-off-by: Fridolin Somers Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 17:33:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 15:33:54 +0000 Subject: [Koha-bugs] [Bug 23711] Icons on staff main page should be font icons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23711 --- Comment #13 from Owen Leonard --- Created attachment 93498 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93498&action=edit Bug 23711: Fix bad path Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 17:33:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 15:33:56 +0000 Subject: [Koha-bugs] [Bug 18745] Serial claims: save supplier info on serial-level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18745 Laurence Rault changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |laurence.rault at biblibre.com --- Comment #18 from Laurence Rault --- Applying: Bug 18745: kohastructure.sql: Move aqbooksellers above serial Applying: Bug 18745: Add foreign key constraint on subscription.aqbooksellerid fatal: sha1 information is lacking or useless (C4/Serials.pm). error: could not build fake ancestor Patch failed at 0001 Bug 18745: Add foreign key constraint on subscription.aqbooksellerid -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 17:35:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 15:35:31 +0000 Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #180 from Séverine Queune --- Created attachment 93499 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93499&action=edit Buttons difference -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 17:40:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 15:40:24 +0000 Subject: [Koha-bugs] [Bug 23543] Adding withdrawn to the item search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23543 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Adding Withdrawn to the |Adding withdrawn to the |Item Search |item search QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 17:43:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 15:43:32 +0000 Subject: [Koha-bugs] [Bug 23543] Adding withdrawn to the item search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23543 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 17:43:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 15:43:36 +0000 Subject: [Koha-bugs] [Bug 23543] Adding withdrawn to the item search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23543 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93163|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer --- Created attachment 93500 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93500&action=edit Bug 23543: Adding Withdrawn to the Item Search This patch adds "Withdrawn" status to the item search form and item search results. To test you should have one or more items in your catalog which have a 'Withdrawn' status. Perform an item search and limit to a widthdrawn status. Verify that the search returns the correct results and that the withdrawn column in search results shows the correct information. Test the "Export results to CSV" button. The resulting file should contain the correct data, including withdrawn status. Signed-off-by: joe Signed-off-by: David Roberts Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 17:48:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 15:48:48 +0000 Subject: [Koha-bugs] [Bug 23626] Add a system preference to limit the number of rows of data used when charting or exporting report results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23626 Séverine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune at bulac.fr Status|Needs Signoff |Patch doesn't apply --- Comment #36 from Séverine Queune --- The sandbox you've requested is not ready. Some problems occurred applying patches from bug 23626:

Something went wrong !

Applying: Limit memory consumption when exporting, too fatal: sha1 information is lacking or useless (installer/data/mysql/atomicupdate/bug_23626.perl). error: could not build fake ancestor Patch failed at 0001 Limit memory consumption when exporting, too -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 17:50:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 15:50:51 +0000 Subject: [Koha-bugs] [Bug 20888] Allow use of boolean operator 'not' in item search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20888 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #17 from Katrin Fischer --- Wondering: If is translates to "like", should "not" not translate to "not like"? Currently it will be != which doesn't allow for truncation. Example would be a search for: Title does not contain a certain keyword. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 17:51:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 15:51:40 +0000 Subject: [Koha-bugs] [Bug 23697] Auto complete for patron search in patron module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23697 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Summary|autocompletion search in |Auto complete for patron |patron module |search in patron module -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 17:54:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 15:54:00 +0000 Subject: [Koha-bugs] [Bug 23051] Optionally renew fine accruing items when all fines on item are paid off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23051 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Keywords| |rel_19_11_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 17:54:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 15:54:26 +0000 Subject: [Koha-bugs] [Bug 23611] Add export option to authorized values administration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23611 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 17:54:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 15:54:29 +0000 Subject: [Koha-bugs] [Bug 23611] Add export option to authorized values administration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23611 --- Comment #5 from Owen Leonard --- Created attachment 93501 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93501&action=edit Bug 23611: (follow-up) Correct ID of table The DataTable configuration wasn't working on the table showing an individual category's authorized values because of a mismatch in the table id. This patch corrects it. To test, apply the patch and view the "Authorized values" page. The initial list of categories should be displayed as a DataTable. Click through to see the values defined for any category. The resulting table of values should also be a functioning DataTable. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 18:03:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 16:03:14 +0000 Subject: [Koha-bugs] [Bug 23697] Auto complete for patron search in patron module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23697 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |oleonard at myacpl.org --- Comment #3 from Katrin Fischer --- This works fine! Just have a little 'but': For the patron auto-complete we got a system preference to turn the feature off: CircAutocompl So my question would be: Should we also use this pref here? Does it need a pref? I am setting 'Failed QA' - let's discuss this quickly tomorrow. Also adding Owen in CC as he might know about the reasoning behind the pref in circulation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 18:17:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 16:17:54 +0000 Subject: [Koha-bugs] [Bug 23697] Auto complete for patron search in patron module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23697 --- Comment #4 from Katrin Fischer --- After discussing with Owen, I think it would be best if we use the pref for this as well and update the wording of the pref a little bit to cover both. Matts, could you provide a follow-up please? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 18:28:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 16:28:17 +0000 Subject: [Koha-bugs] [Bug 23706] Item search CSV export doesn't include collection code In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23706 --- Comment #10 from David Roberts --- That looks like it's trying to apply an obsolete patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 19:05:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 17:05:20 +0000 Subject: [Koha-bugs] [Bug 23706] Item search CSV export doesn't include collection code In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23706 --- Comment #11 from David Roberts --- Actually, it looks like this might have already been fixed in https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22424 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 19:29:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 17:29:59 +0000 Subject: [Koha-bugs] [Bug 21114] Select multiple item rows with Ctrl+click and Shift+click In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21114 Sarah Cornell changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sbcornell at cityofportsmouth. | |com --- Comment #1 from Sarah Cornell --- I just had a staff request this feature. Best case scenario, we'd like to be able to select groups of items or patrons wherever this style of list occurs, not just in the batch item modification tool. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 19:31:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 17:31:40 +0000 Subject: [Koha-bugs] [Bug 23710] Holds broken, displays a JSON page with an error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23710 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com QA Contact|testopia at bugs.koha-communit |nick at bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 20:22:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 18:22:36 +0000 Subject: [Koha-bugs] [Bug 23589] Discharge notice does not show non-latin characters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23589 --- Comment #9 from Dobrica Pavlinusic --- (In reply to Theodoros Theodoropoulos from comment #5) > Hi Dobrica, > > Thanks for your patch! Indeed it fixes the output. I will try to properly > sign it off later. > > Having said that, there I'm now at 18.11 and there is another issue (that > exists regardless of your patch). The generated pdf file in /tmp/ is proper > pdf, the one that gets downloaded when I click discharge is CORRUPTED (has > html code appended in the bottom of the pdf file). Did you also have this > issue? You are absolutely right. We indeed emit html (and headers) after pdf. I never noticed this before. This is on 19.05 for me. However, on current master I don't see anything after pdf. I thinks this is difference in configuration and not versions. 19.05 for me (with html junk) is running via plack while my development is plain cgi. Are you also running plack? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 20:57:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 18:57:32 +0000 Subject: [Koha-bugs] [Bug 23722] New: Document allow_empty_passwords in the example SIP config file Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23722 Bug ID: 23722 Summary: Document allow_empty_passwords in the example SIP config file Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: SIP2 Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com The example SIP config file in Koha is kind of a kitchen sink document where all available SIP2 options should be demonstrated. The allow_empty_passwords flag should be included in it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 20:57:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 18:57:36 +0000 Subject: [Koha-bugs] [Bug 23722] Document allow_empty_passwords in the example SIP config file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23722 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 20:57:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 18:57:44 +0000 Subject: [Koha-bugs] [Bug 23722] Document allow_empty_passwords in the example SIP config file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23722 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 20:57:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 18:57:49 +0000 Subject: [Koha-bugs] [Bug 23722] Document allow_empty_passwords in the example SIP config file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23722 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18755 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18755 [Bug 18755] Allow empty password fields in Patron Info requests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 20:57:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 18:57:49 +0000 Subject: [Koha-bugs] [Bug 18755] Allow empty password fields in Patron Info requests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18755 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23722 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23722 [Bug 23722] Document allow_empty_passwords in the example SIP config file -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 20:59:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 18:59:41 +0000 Subject: [Koha-bugs] [Bug 23722] Document allow_empty_passwords in the example SIP config file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23722 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 20:59:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 18:59:43 +0000 Subject: [Koha-bugs] [Bug 23722] Document allow_empty_passwords in the example SIP config file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23722 --- Comment #1 from Kyle M Hall --- Created attachment 93502 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93502&action=edit Bug 23722 - Document allow_empty_passwords in the example SIP config file The example SIP config file in Koha is kind of a kitchen sink document where all available SIP2 options should be demonstrated. The allow_empty_passwords flag should be included in it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 21:02:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 19:02:50 +0000 Subject: [Koha-bugs] [Bug 19325] Enable padding of printed barcodes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19325 Charles Farmer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #14 from Charles Farmer --- > This is much better handled at the template level. We don't want to give syspref permissions to the volunteer who prints labels. But I'm not asking you to, I'm saying that most libraries we work with have a systematic approach to printing barcodes. They configure it once and forget about it, I don't understand which use case you're describing where every barcode printed has to be padded differently. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 21:05:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 19:05:11 +0000 Subject: [Koha-bugs] [Bug 23722] Document allow_empty_passwords in the example SIP config file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23722 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 21:05:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 19:05:14 +0000 Subject: [Koha-bugs] [Bug 23722] Document allow_empty_passwords in the example SIP config file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23722 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93502|0 |1 is obsolete| | --- Comment #2 from Liz Rea --- Created attachment 93503 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93503&action=edit Bug 23722 - Document allow_empty_passwords in the example SIP config file The example SIP config file in Koha is kind of a kitchen sink document where all available SIP2 options should be demonstrated. The allow_empty_passwords flag should be included in it. Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 21:10:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 19:10:56 +0000 Subject: [Koha-bugs] [Bug 23589] Discharge notice does not show non-latin characters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23589 --- Comment #10 from Dobrica Pavlinusic --- I can confirm that this is plack problem. If I implement something similar to safe_exit in C4::Auth it doesn't emit extra html after pdf. However, this is not the only place where we have exit and while some code flows would exit anyway (since under plack exit doesn't work) I'm sure we have more places in code which should be fixed (ater redirects is one obvious one -- it would seem to work, but we are probably sending Location: header and whole html after it). This will have to be another bug since it will touch many places and isn't really related to this one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 21:31:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 19:31:27 +0000 Subject: [Koha-bugs] [Bug 23723] New: using exit to stop sending output to browser doesn't work under plack Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23723 Bug ID: 23723 Summary: using exit to stop sending output to browser doesn't work under plack Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: dpavlin at rot13.org QA Contact: testopia at bugs.koha-community.org When fixing Bug 23589 Theodoros Theodoropoulos noticed that we are sending headers and html after pdf output to browser. It seems that using just exit isn't enough to stop plack from generating headers and html page. This was noticed back in 2011 with Bug 5630 which added safe_exit in C4::Auth. It seems that we need to use something similar throughout all code which gets invoked with plack to fix this. I'm opening this bug as placeholder until I do more testing and figure out which parts need change and we have a lot of exit; in code: git grep 'exit;' | wc -l 352 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 21:32:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 19:32:08 +0000 Subject: [Koha-bugs] [Bug 23723] using exit to stop sending output to browser doesn't work under plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23723 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23589 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 21:32:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 19:32:09 +0000 Subject: [Koha-bugs] [Bug 23589] Discharge notice does not show non-latin characters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23589 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23723 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 21:32:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 19:32:32 +0000 Subject: [Koha-bugs] [Bug 23723] using exit to stop sending output to browser doesn't work under plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23723 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=5630 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 21:32:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 19:32:32 +0000 Subject: [Koha-bugs] [Bug 5630] CAS improvements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5630 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23723 -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 21:51:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 19:51:11 +0000 Subject: [Koha-bugs] [Bug 23676] Elasticsearch - 0 is not a valid boolean for suppress In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23676 Michal Denar changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23 at gmail.com --- Comment #2 from Michal Denar --- Hello Nick, can you rebase this patch on master? CONFLICT (content): Merge conflict in Koha/SearchEngine/Elasticsearch/QueryBuilder.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 23676: Use 'false' for opac suppression Thank you. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 22:55:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 20:55:11 +0000 Subject: [Koha-bugs] [Bug 23723] using exit to stop sending output to browser doesn't work under plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23723 --- Comment #1 from Dobrica Pavlinusic --- Problem occurs only if we use exit inside eval block like: eval { warn "in eval"; exit; }; warn "after eval"; Under CGI, this would print just "in eval". Bacause of interaction of CGI::Compile which wraps system exit under plack we get both lines. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 22:55:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 20:55:38 +0000 Subject: [Koha-bugs] [Bug 23723] using exit inside eval to stop sending output to browser doesn't work under plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23723 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|using exit to stop sending |using exit inside eval to |output to browser doesn't |stop sending output to |work under plack |browser doesn't work under | |plack -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 23:38:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 21:38:32 +0000 Subject: [Koha-bugs] [Bug 16631] Show groups/categories of reports to authorized staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16631 Daniel Gaghan changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |daniel.gaghan at pueblolibrary | |.org --- Comment #4 from Daniel Gaghan --- Having the ability to limit who can see which reports would help a lot at PCCLD. It would certainly clean up the report module and make relevant reports easier for staff to find. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 2 23:52:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 21:52:18 +0000 Subject: [Koha-bugs] [Bug 23710] Holds broken, displays a JSON page with an error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23710 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #11 from Tomás Cohen Arazi --- We need tests for the behavior. Also, we shouldn't fallback to undef. Just return bad request explaining what went wrong -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 00:18:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 22:18:34 +0000 Subject: [Koha-bugs] [Bug 23654] Patron Cards - Bar code and image do not show up In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23654 --- Comment #7 from Chris Nighswonger --- (In reply to David Cook from comment #6) > Actually, after I changed my Images data that's caused the X/Y axis for my > Text fields to completely change. > > I'd say there's a number of factors regarding units that are wrong here... Just FTR: 1. A lot of code has run off of the keyboard since I wrote this stuff over nine years ago, so there may be changes I'm unaware of and resulting bugs. 2. There may indeed be something buggy about the unit conversion code that I originally wrote. The library I did the work for uses Imperial units and that was my focus. I would definitely check there first. Everything is converted to post script points. 3. The fundamental coordinate system is taken from the PDF ISO 32000-1 standard published by Adobe and has its origin at the lower left corner of the page. In other terms, the page is the first quadrant of the Cartesian Coordinate system. I'd look at the unit conversion code first to see if there's something going on there. Beyond that, I'm not sure what to suggest as it still works in the library here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 00:35:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 22:35:21 +0000 Subject: [Koha-bugs] [Bug 14862] Upgrade jQuery from 1.7 to 3.4.1 in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14862 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |martin.renvoize at ptfs-europe | |.com --- Comment #4 from Martin Renvoize --- I've checked out the branch (and rebased it to check it still applies simply). All seems to work well, no obvious regressions.. signing off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 00:39:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 22:39:07 +0000 Subject: [Koha-bugs] [Bug 22545] C4::Matcher::get_matches aggressive isbn and issn search don't give any results with ES In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22545 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion CC| |martin.renvoize at ptfs-europe | |.com --- Comment #8 from Martin Renvoize --- It would be great to get an answer to the above Johanna, I'm very interested to know whether this bug is resolved for you with that alternative implementation or whether we still need to work here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 00:45:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 22:45:15 +0000 Subject: [Koha-bugs] [Bug 16631] Show groups/categories of reports to authorized staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16631 --- Comment #5 from Christopher Brannon --- (In reply to Cab Vinton from comment #3) > Would also be nice to limit access to reports by the home library of the > staff. > > Some reports are specific to the needs of just one library. Some reports are > in development for a while. And so on. > > As reports proliferate over time, libraries would welcome any option that > reduces the number of reports visible to them. +1 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 00:45:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 22:45:38 +0000 Subject: [Koha-bugs] [Bug 16631] Show groups/categories of reports to authorized staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16631 --- Comment #6 from Christopher Brannon --- (In reply to Daniel Gaghan from comment #4) > Having the ability to limit who can see which reports would help a lot at > PCCLD. It would certainly clean up the report module and make relevant > reports easier for staff to find. +1 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 00:46:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 22:46:33 +0000 Subject: [Koha-bugs] [Bug 21343] Automatic renewal cronjob doesn't send notices according to patron language preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21343 --- Comment #3 from Martin Renvoize --- Created attachment 93504 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93504&action=edit Bug 21343: Automatic renewal notice will now respect patron language preference. To test: 1) Set up different automatic renewal notices for Default and one other language 2) Make sure you have checkouts due for auto-renewal to patrons with non-Default language pref 3) Run automatic_renewals.pl . All patrons will get the default-language notice 4) Apply patch. 5) Repeat 2) 6) Run automatic_renewals.pl . Patrons will receive notices according to their language preference. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 00:48:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 22:48:47 +0000 Subject: [Koha-bugs] [Bug 16631] Show groups/categories of reports to authorized staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16631 --- Comment #7 from Christopher Brannon --- Perhaps a branch field and a borrower field could be added. If the field is empty, it applies to everyone. Otherwise, it would be limited to matching borrower IDs or branches. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 00:49:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 22:49:17 +0000 Subject: [Koha-bugs] [Bug 21343] Automatic renewal cronjob doesn't send notices according to patron language preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21343 --- Comment #4 from Martin Renvoize --- Created attachment 93505 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93505&action=edit Bug 21343: Respect patron language preference in automtic renewals To test: 1) Set up different automatic renewal notices for Default and one other language 2) Make sure you have checkouts due for auto-renewal to patrons with non-Default language pref 3) Run automatic_renewals.pl . All patrons will get the default-language notice 4) Apply patch. 5) Repeat 2) 6) Run automatic_renewals.pl . Patrons will receive notices according to their language preference. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 00:49:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 22:49:38 +0000 Subject: [Koha-bugs] [Bug 21343] Automatic renewal cronjob doesn't send notices according to patron language preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21343 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Attachment #78630|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 00:49:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 22:49:52 +0000 Subject: [Koha-bugs] [Bug 21343] Automatic renewal cronjob doesn't send notices according to patron language preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21343 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93504|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 00:50:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 22:50:04 +0000 Subject: [Koha-bugs] [Bug 21343] Automatic renewal cronjob doesn't send notices according to patron language preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21343 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 00:51:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 22:51:22 +0000 Subject: [Koha-bugs] [Bug 21343] Automatic renewal cronjob doesn't send notices according to patron language preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21343 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #5 from Martin Renvoize --- All works as expected, a great first patch Björn, Signing off. The bug states it's sponsored, could we get the sponsor name so we can add it to the patch for proper attribution? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 00:57:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 22:57:41 +0000 Subject: [Koha-bugs] [Bug 23252] Pressing enter should not submit form in item editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23252 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #13 from Martin Renvoize --- This looks solid to me, I've noted Marcelr's comment but believe we're safe here given the responses and a look at the code myself.. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 01:00:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 23:00:44 +0000 Subject: [Koha-bugs] [Bug 21985] Test t/db_dependent/Circulation.t fails if SearchEngine is set to elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21985 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 01:01:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 23:01:08 +0000 Subject: [Koha-bugs] [Bug 21985] Test t/db_dependent/Circulation.t fails if SearchEngine is set to elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21985 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 01:01:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 23:01:41 +0000 Subject: [Koha-bugs] [Bug 21985] Test t/db_dependent/Circulation.t fails if SearchEngine is set to elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21985 --- Comment #15 from Martin Renvoize --- Works well, thanks Jonathan. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 01:02:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 23:02:33 +0000 Subject: [Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_19_11_candidate CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 01:05:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 23:05:51 +0000 Subject: [Koha-bugs] [Bug 22913] https://mana-kb.koha-community.org/ should not return a 404 error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22913 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #14 from Martin Renvoize --- This all looks reasonable and sane to me at this point and I don't believe it leads to any breaking changes. Passing QA, please go ahead and merge it into the project at your convenience Alex. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 01:06:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 23:06:59 +0000 Subject: [Koha-bugs] [Bug 23075] Incorrect URL should have a meaningful error message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_19_11_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 01:07:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 23:07:26 +0000 Subject: [Koha-bugs] [Bug 23075] Incorrect URL should have a meaningful error message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Needs Signoff Keywords|rel_19_11_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 01:07:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Oct 2019 23:07:36 +0000 Subject: [Koha-bugs] [Bug 23075] Incorrect URL should have a meaningful error message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_19_11_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 02:09:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 00:09:12 +0000 Subject: [Koha-bugs] [Bug 23654] Patron Cards - Bar code and image do not show up In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23654 --- Comment #8 from David Cook --- (In reply to Chris Nighswonger from comment #7) > > I'd look at the unit conversion code first to see if there's something going > on there. Beyond that, I'm not sure what to suggest as it still works in the > library here. Yeah, I think I probably won't work on this, as I just did a workaround to get the cards to display as desired. I don't have a lot of libraries using patron cards, especially with images, so not too much of a priority over here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 04:50:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 02:50:37 +0000 Subject: [Koha-bugs] [Bug 23543] Adding withdrawn to the item search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23543 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93500|0 |1 is obsolete| | --- Comment #7 from ByWater Sandboxes --- Created attachment 93506 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93506&action=edit Bug 23543: Adding Withdrawn to the Item Search This patch adds "Withdrawn" status to the item search form and item search results. To test you should have one or more items in your catalog which have a 'Withdrawn' status. Perform an item search and limit to a widthdrawn status. Verify that the search returns the correct results and that the withdrawn column in search results shows the correct information. Test the "Export results to CSV" button. The resulting file should contain the correct data, including withdrawn status. Signed-off-by: joe Signed-off-by: David Roberts Signed-off-by: Katrin Fischer Signed-off-by: Kelly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 05:55:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 03:55:06 +0000 Subject: [Koha-bugs] [Bug 23724] New: Toolbars should have distinct IDs Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23724 Bug ID: 23724 Summary: Toolbars should have distinct IDs Change sponsored?: --- Product: Koha Version: 19.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: hayleymapley at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl The Cataloguing and Serials toolbars both have the ID of toolbar. IDs should be distinct to allow for easier styling. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 05:55:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 03:55:21 +0000 Subject: [Koha-bugs] [Bug 23708] Biblio details toolbar elements should have distinct IDs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23708 Hayley Mapley changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23724 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 05:55:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 03:55:21 +0000 Subject: [Koha-bugs] [Bug 23724] Toolbars should have distinct IDs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23724 Hayley Mapley changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23708 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 05:55:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 03:55:37 +0000 Subject: [Koha-bugs] [Bug 23724] Toolbars should have distinct IDs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23724 Hayley Mapley changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |hayleymapley at catalyst.net.n |ity.org |z -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 05:57:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 03:57:12 +0000 Subject: [Koha-bugs] [Bug 23724] Toolbars should have distinct IDs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23724 Hayley Mapley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 06:03:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 04:03:50 +0000 Subject: [Koha-bugs] [Bug 23724] Toolbars and toolbar buttons should have distinct IDs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23724 Hayley Mapley changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Toolbars should have |Toolbars and toolbar |distinct IDs |buttons should have | |distinct IDs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 06:10:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 04:10:43 +0000 Subject: [Koha-bugs] [Bug 23724] Toolbars and toolbar buttons should have distinct IDs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23724 --- Comment #1 from Hayley Mapley --- Created attachment 93507 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93507&action=edit Bug 23724: Added IDs to Cataloging toolbar and buttons Test plan: Check that the buttons or div buttons now have IDs which will allow the buttons to be hidden. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 07:28:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 05:28:08 +0000 Subject: [Koha-bugs] [Bug 23589] Discharge notice does not show non-latin characters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23589 --- Comment #11 from Theodoros Theodoropoulos --- Indeed, I can verify that I'm using plack too. The new bug sounds a bit (more) critical... Although the fix would be fairly straight forward (replacing exit with safe_exit), identifying where is needed and testing that the patch does the trick might be tricky... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 07:29:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 05:29:33 +0000 Subject: [Koha-bugs] [Bug 23723] using exit inside eval to stop sending output to browser doesn't work under plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23723 Theodoros Theodoropoulos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |theod at lib.auth.gr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 08:19:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 06:19:40 +0000 Subject: [Koha-bugs] [Bug 20334] Elasticsearch - Option for escaping slashes in search queries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #43 from Ere Maijala --- Looks like this should do it! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 08:48:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 06:48:10 +0000 Subject: [Koha-bugs] [Bug 23320] Neworderempty has unused 'close' parameter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23320 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes at biblibre.com --- Comment #6 from sandboxes at biblibre.com --- Patch tested with a sandbox, by Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 08:48:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 06:48:24 +0000 Subject: [Koha-bugs] [Bug 23320] Neworderempty has unused 'close' parameter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23320 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93110|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 08:48:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 06:48:32 +0000 Subject: [Koha-bugs] [Bug 23320] Neworderempty has unused 'close' parameter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23320 --- Comment #7 from sandboxes at biblibre.com --- Created attachment 93508 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93508&action=edit Bug 23320 - Removed unused close parameter in neworderempty To test: 1 - Add to basket 2 - Note the options on the page 3 - Add &close=1 to the url 4 - Note some inputs are disabled 5 - Save anyway, note it is a regular order 6 - Add another order to basket 7 - Save it 8 - Modify 9 - Add close to the url again 10 - Save changes 11 - No functional change 12 - Apply patch 13 - Note close parameter has no effect now 14 - Confirm you can place and confirm orders as before Signed-off-by: Séverine QUEUNE Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 09:01:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 07:01:25 +0000 Subject: [Koha-bugs] [Bug 23163] HoldsSplitQueueNumbering requires "modify_holds_priority" permission to work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23163 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23501 CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 09:01:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 07:01:25 +0000 Subject: [Koha-bugs] [Bug 23501] Drag-and-drop hold reordering in the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23501 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23163 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 09:20:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 07:20:57 +0000 Subject: [Koha-bugs] [Bug 23711] Icons on staff main page should be font icons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23711 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 09:21:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 07:21:02 +0000 Subject: [Koha-bugs] [Bug 23711] Icons on staff main page should be font icons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23711 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93496|0 |1 is obsolete| | --- Comment #14 from Katrin Fischer --- Created attachment 93509 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93509&action=edit Bug 23711: Icons on staff main page should be font icons Signed-off-by: Fridolin Somers Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 09:21:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 07:21:06 +0000 Subject: [Koha-bugs] [Bug 23711] Icons on staff main page should be font icons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23711 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93497|0 |1 is obsolete| | --- Comment #15 from Katrin Fischer --- Created attachment 93510 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93510&action=edit Bug 23711: Change icons and remove unused SVG Signed-off-by: Fridolin Somers Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 09:21:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 07:21:10 +0000 Subject: [Koha-bugs] [Bug 23711] Icons on staff main page should be font icons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23711 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93498|0 |1 is obsolete| | --- Comment #16 from Katrin Fischer --- Created attachment 93511 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93511&action=edit Bug 23711: Fix bad path Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 09:23:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 07:23:24 +0000 Subject: [Koha-bugs] [Bug 23611] Add export option to authorized values administration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23611 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #6 from Katrin Fischer --- Hi Owen, last request (I hope) - can you please remove the action buttons from the print view and other export options? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 09:24:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 07:24:03 +0000 Subject: [Koha-bugs] [Bug 23011] AuthenticatePatron could alert if password is not safe In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23011 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 09:24:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 07:24:07 +0000 Subject: [Koha-bugs] [Bug 23011] AuthenticatePatron could alert if password is not safe In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23011 --- Comment #1 from Arthur Suzuki --- Created attachment 93512 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93512&action=edit Bug23011 : Add new tests (AuthenticatePatron error codes) This bug add new tests to the AuthenticatePatron ILS-DI service. It tests new error codes patron might get when successfully connecting but with a password which doesn't match Koha security rules. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 09:24:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 07:24:41 +0000 Subject: [Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #3 from Martin Renvoize --- Created attachment 93513 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93513&action=edit Bug 23049: Add debit_type * Add account_debit_types table * Add account_debit_types defaults * Add Koha::Account::DebitType and Koha::Account::DebitTypes * Prevent deletion of defaults * Update database to insert existing values -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 09:24:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 07:24:43 +0000 Subject: [Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #4 from Martin Renvoize --- Created attachment 93514 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93514&action=edit Bug 23049: Add branch limitations tables -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 09:24:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 07:24:46 +0000 Subject: [Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #5 from Martin Renvoize --- Created attachment 93515 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93515&action=edit Bug 23049: Update DBIC Classes for branch limitations -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 09:24:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 07:24:49 +0000 Subject: [Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #6 from Martin Renvoize --- Created attachment 93516 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93516&action=edit Bug 23049: Add CHECK constraint to accountlines -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 09:24:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 07:24:52 +0000 Subject: [Koha-bugs] [Bug 23011] AuthenticatePatron could alert if password is not safe In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23011 --- Comment #2 from Arthur Suzuki --- Created attachment 93517 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93517&action=edit Bug23011 : Have AuthenticatePatron method send more information We want AuthenticatePatron to send some more information upon successful login, especially in the case where password is not safe and should be renewed. The goal is to let a third-party app catch thoses codes and display a warning to the users. Test plan : 1 / apply tests patch 2 / run tests, verify failure 3 / apply C4/ILSDI/Service.pm patch 4 / run tests again, verify green -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 09:24:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 07:24:52 +0000 Subject: [Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #7 from Martin Renvoize --- Created attachment 93518 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93518&action=edit Bug 23049: Account types configuration - Admin page Test plan: 1) Go to admin home, note there is new Debit types page in Accounting section 2) Go to any other admin page and confirm there is link to Debit types in the admin menu as well 3) Go to Debit types page 4) You should see a datatable listing existing debit types, ensure they are working as expected. 5) Try to create, edit and delete some debit types. Note: Some debit types cannot be deleted as they are needed for koha functionality. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 09:24:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 07:24:55 +0000 Subject: [Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #8 from Martin Renvoize --- Created attachment 93519 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93519&action=edit Bug 23049: Update maninvoice to reference debit types -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 09:24:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 07:24:58 +0000 Subject: [Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #9 from Martin Renvoize --- Created attachment 93520 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93520&action=edit Bug 23049: Use debit_type in staff client views -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 09:25:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 07:25:01 +0000 Subject: [Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #10 from Martin Renvoize --- Created attachment 93521 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93521&action=edit Bug 23049: Update existing accounttype values -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 09:25:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 07:25:04 +0000 Subject: [Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #11 from Martin Renvoize --- Created attachment 93522 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93522&action=edit Bug 23049: Split system and local types Test plan 1) Apply patches up to this point 2) View the new debit types management page and comment whether the split table view is clearer/better. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 09:25:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 07:25:07 +0000 Subject: [Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #12 from Martin Renvoize --- Created attachment 93523 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93523&action=edit Bug 23049: Add tests Test plan: prove t/db_dependent/Koha/Account/DebitType.t prove t/db_dependent/Koha/Account/DebitTypes.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 09:25:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 07:25:13 +0000 Subject: [Koha-bugs] [Bug 23204] Script for exporting Elasticsearch mappings to YAML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23204 --- Comment #10 from Alex Arnaud --- Created attachment 93524 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93524&action=edit Bug 23204: sort search fields by name -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 09:26:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 07:26:06 +0000 Subject: [Koha-bugs] [Bug 23722] Document allow_empty_passwords in the example SIP config file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23722 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 09:26:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 07:26:10 +0000 Subject: [Koha-bugs] [Bug 23722] Document allow_empty_passwords in the example SIP config file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23722 --- Comment #3 from Katrin Fischer --- Created attachment 93525 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93525&action=edit Bug 23722: Document allow_empty_passwords in the example SIP config file The example SIP config file in Koha is kind of a kitchen sink document where all available SIP2 options should be demonstrated. The allow_empty_passwords flag should be included in it. Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 09:27:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 07:27:10 +0000 Subject: [Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 09:28:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 07:28:02 +0000 Subject: [Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #13 from Martin Renvoize --- I discussed translations with Katrin and she preferred I do a dependant bug rather than role it in here.. that's my next target so this patchset is ready to test. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 09:28:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 07:28:20 +0000 Subject: [Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 09:29:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 07:29:39 +0000 Subject: [Koha-bugs] [Bug 22706] Add plugin hooks to enable Norwegian national patron database In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22706 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 09:29:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 07:29:41 +0000 Subject: [Koha-bugs] [Bug 22706] Add plugin hooks to enable Norwegian national patron database In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22706 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93488|0 |1 is obsolete| | --- Comment #3 from Brendan Gallagher --- Created attachment 93526 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93526&action=edit Bug 22706 - Add plugin hooks for Norwegian national patron database The main point of this patch is to make it possible to integrate Koha with the Norwegian national patron database. Code for this was earlier introduced in Bug 11401 and removed again in Bug 21068. To test this is mainly a question of spotting regressions, it should still be possible to set and change a password in all possible ways: - Setting a password for a new user - Changing a password in the staff client - Changing a password in the OPAC If these work as expected, everything should be OK. A nice side effect of this work is that it will allow for plugins that validate passwords. I have created a tiny plugin that enforces PIN codes of 4 digits. (Yeah, I know, those are the worst passwords, but some libraries do require them.) It is published here: https://github.com/Libriotech/koha-plugin-pin To test this way, install the plugin and try to change the password of an exsisting user to something that is not a 4 digit PIN. You should get an error that says "The password was rejected by a plugin". Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 09:39:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 07:39:09 +0000 Subject: [Koha-bugs] [Bug 22545] C4::Matcher::get_matches aggressive isbn and issn search don't give any results with ES In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22545 --- Comment #9 from Johanna Räisä --- (In reply to Nick Clemens from comment #7) > I went about this in a different way on Bug 23322, rather than enabling > QueryParser solution I fixed the Non-QP solution > > Can you check if the patch there solves your issue and makes sense? I tested this and it solves my bug, awesome! Your solution makes more sense than mine. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 09:40:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 07:40:16 +0000 Subject: [Koha-bugs] [Bug 23723] using exit inside eval to stop sending output to browser doesn't work under plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23723 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 09:40:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 07:40:19 +0000 Subject: [Koha-bugs] [Bug 23723] using exit inside eval to stop sending output to browser doesn't work under plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23723 --- Comment #2 from Dobrica Pavlinusic --- Created attachment 93527 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93527&action=edit Bug 23723: using exit inside eval to stop sending output to browser doesn't work under plack When fixing Bug 23589 Theodoros Theodoropoulos noticed that we are sending headers and html after pdf output to browser. Using exit inside eval block doesn't stop plack from generating headers and html page after exit since CGI::Compile will catch exit but doesn't stop emiting output. Example is: eval { warn "in eval"; exit; }; warn "after eval"; Under CGI, this would print just "in eval", but under plack we get both lines and thus generate additional header and html after we already sent pdf data. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 09:40:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 07:40:45 +0000 Subject: [Koha-bugs] [Bug 23723] using exit inside eval to stop sending output to browser doesn't work under plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23723 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |dpavlin at rot13.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 09:40:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 07:40:54 +0000 Subject: [Koha-bugs] [Bug 20888] Allow use of boolean operator 'not' in item search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20888 --- Comment #18 from Matthias Meusburger --- I think we should rename "is" to "is like" then. This way it will be consistent, with the following options: - is like - is not An "is" and/or "is not like" option may be added in the future, and it will still be consistent. What do you think? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 09:41:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 07:41:51 +0000 Subject: [Koha-bugs] [Bug 23723] using exit inside eval to stop sending output to browser doesn't work under plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23723 --- Comment #3 from Dobrica Pavlinusic --- I did check all places in code where we use eval and it seems that only place where we have also exit is this one, so situation is not as bad as I though initially. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 09:46:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 07:46:03 +0000 Subject: [Koha-bugs] [Bug 23697] Auto complete for patron search in patron module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23697 --- Comment #5 from Matthias Meusburger --- Any hint on what the syspref should be renamed to? PatronAutoCompl? And why not PatronAutoCompletion, since truncated words are ugly and may me meaningless to some people? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 09:54:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 07:54:39 +0000 Subject: [Koha-bugs] [Bug 20888] Allow use of boolean operator 'not' in item search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20888 --- Comment #19 from Katrin Fischer --- (In reply to Matthias Meusburger from comment #18) > I think we should rename "is" to "is like" then. This way it will be > consistent, with the following options: > > - is like > - is not > > An "is" and/or "is not like" option may be added in the future, and it will > still be consistent. > > What do you think? One problem we see with item search is that people expect it to work like the bibliographic search. For example, when searching for "Title is some words", they expect results to come up, but often forget to put the truncation. If the title actually is "these some words" the search will only find it if you use: Title is %some words". I think that's the reason, why we should not change the wording, we do use the SQL operator "like" and unless you use truncation, it works like an exact search. But it gives you the option to use the truncation. And I think we want the same behavior for adding the 'not' operator: If the libraries don't add truncation characters it will actually behave like !=, but they have the option to add them to make search a bit broader. Also: The hint below the search options will then be accurate, otherwise it would be misleading: You can use the following wildcard characters: % _ % matches any number of characters _ matches only a single character -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 09:56:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 07:56:51 +0000 Subject: [Koha-bugs] [Bug 20888] Allow use of boolean operator 'not' in item search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20888 --- Comment #20 from Matthias Meusburger --- Ok, understood. I'll submit a new patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 10:01:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 08:01:47 +0000 Subject: [Koha-bugs] [Bug 23697] Auto complete for patron search in patron module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23697 --- Comment #6 from Katrin Fischer --- (In reply to Matthias Meusburger from comment #5) > Any hint on what the syspref should be renamed to? > > PatronAutoCompl? > > And why not PatronAutoCompletion, since truncated words are ugly and may me > meaningless to some people? I actually meant only correcting the description (although you have a point about it being a bit ugly :) ) Now: [Don't try|Try] to guess the patron being entered while typing a patron search on the circulation screen. Only returns the first 10 results at a time. Maybe change to: [Don't try|Try] to guess the patron being entered while typing a patron search for circulation or patron search. Only returns the first 10 results at a time. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 10:24:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 08:24:45 +0000 Subject: [Koha-bugs] [Bug 14862] Upgrade jQuery from 1.7 to 3.4.1 in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14862 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |katrin.fischer at bsz-bw.de --- Comment #5 from Katrin Fischer --- Ready to pass QA from testing - Pages all look good and behave well for me. Just one thing: Although the file has the .min. in the name, it's not actually minified. Can you please check and follow-up? If you want, you can already add my sign-off line :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 10:28:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 08:28:14 +0000 Subject: [Koha-bugs] [Bug 23713] Subscription add form broken for translations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23713 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 10:29:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 08:29:50 +0000 Subject: [Koha-bugs] [Bug 23384] Calling Koha::Article::Status::* without "use" in Patron.pm can cause breakage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23384 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at libriotech.no --- Comment #4 from Magnus Enger --- (In reply to Andrew Isherwood from comment #3) > - Edit "use Illrequests;" to the top of C4/Circulation.pm You mean Koha::Illrequests, right? I still cant reproduce the problem. I did this: $ git diff diff --git a/C4/Circulation.pm b/C4/Circulation.pm index 014c018628..ae3e1bbc0e 100644 --- a/C4/Circulation.pm +++ b/C4/Circulation.pm @@ -24,6 +24,7 @@ use strict; use DateTime; use POSIX qw( floor ); use Koha::DateUtils; +use Koha::Illrequests; use C4::Context; use C4::Stats; use C4::Reserves; Did a restart_all in kohadevbox. But nothing obviously bad happens. I can still check out a book, for example. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 10:35:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 08:35:49 +0000 Subject: [Koha-bugs] [Bug 23011] AuthenticatePatron could alert if password is not safe In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23011 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |julian.maurice at biblibre.com --- Comment #3 from Julian Maurice --- Tests are failing, but it's just the number of tests that is wrong > Parse errors: Bad plan. You planned 9 tests but ran 10. QA tool reports some errors as well: > FAIL C4/ILSDI/Services.pm > FAIL forbidden patterns > forbidden pattern: tab char (line 382) > forbidden pattern: tab char (line 386) > forbidden pattern: tab char (line 384) > forbidden pattern: tab char (line 383) > forbidden pattern: tab char (line 385) > > Commit title does not start with 'Bug XXXXX: ' - de967f9fc0 > Commit title does not start with 'Bug XXXXX: ' - 23cd5391bc Otherwise it works well, but I'm a bit concerned by the fact that the patch duplicates the password regexp. If someone modify it in is_password_valid, there are high chances that they will forgot to modify it in ILSDI code. Also, it's not the only thing checked in is_password_valid (there is also a check on whitespaces). Is it really needed to return the regexp ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 10:36:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 08:36:08 +0000 Subject: [Koha-bugs] [Bug 23247] Simplify visibility logic in opac-MARCdetail.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23247 Jesse Maseto changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 10:36:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 08:36:45 +0000 Subject: [Koha-bugs] [Bug 23247] Simplify visibility logic in opac-MARCdetail.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23247 Jesse Maseto changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91253|0 |1 is obsolete| | --- Comment #9 from Jesse Maseto --- Created attachment 93528 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93528&action=edit Hi Tomas. Looks good. Signing this patch off. JesseM Bug 23247: Simplify visibility logic used in opac-MARCdetail.pl This patch uses the OO code, with prefetching and all, to make decisions on visibility. It shouldn't change any behaviour, unless you are counting DB queries, execution time, etc. To test: - Find a known record, go to the OPAC MARC page of it. - Play with several options in OpacHiddenItems, refreshing it - Play with OpacHiddenItemsExceptions as well => SUCCESS: Things work as expected - Apply this patch - Repeate the tests above => SUCCESS: Things work as expected! - Sign off :-D Signed-off-by: Jesse Maseto -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 10:37:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 08:37:40 +0000 Subject: [Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #14 from Martin Renvoize --- Created attachment 93529 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93529&action=edit Bug 23049: Use a filtered table instead of two tables Test Plan * Apply this patch and comment on new page design. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 10:40:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 08:40:54 +0000 Subject: [Koha-bugs] [Bug 23112] Circulation of ILL items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 --- Comment #20 from Magnus Enger --- (In reply to Andrew Isherwood from comment #15) > Created attachment 92000 [details] [review] > Bug 23122: Add CirculateILL syspref > > Sponsored-by: Loughborough University There is a typo in the bug number. It should be 23112, not 23122. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 10:41:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 08:41:18 +0000 Subject: [Koha-bugs] [Bug 23224] Inconsistent behaviour between memberentry.pl and the update-child.pl when updating child patron to Adult In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23224 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Signed Off |Failed QA --- Comment #10 from Katrin Fischer --- I am sorry, but I've managed to make this explode :( 1) Searched for a child patron 2) Added a guarantor 3) Edit patron 4) Switch patron category to "Patron" (Adult) 5) No property guarantorid for Koha::Patron at /usr/share/perl5/Exception/Class/Base.pm line 88 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 10:43:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 08:43:35 +0000 Subject: [Koha-bugs] [Bug 23697] Auto complete for patron search in patron module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23697 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #7 from David Nind --- How about: [Don't try|Try] to guess the patron when typing a name in the circulation check out and patron search screens. Only shows the first 10 results. Like the idea of making the preference name PatronAutoCompletion. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 10:44:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 08:44:47 +0000 Subject: [Koha-bugs] [Bug 23112] Circulation of ILL items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 --- Comment #21 from Magnus Enger --- (In reply to Magnus Enger from comment #20) > (In reply to Andrew Isherwood from comment #15) > > Created attachment 92000 [details] [review] [review] > > Bug 23122: Add CirculateILL syspref > > > > Sponsored-by: Loughborough University > > There is a typo in the bug number. It should be 23112, not 23122. Never mind, looks like I can fix it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 10:45:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 08:45:02 +0000 Subject: [Koha-bugs] [Bug 12502] Add columns for note, order number and ISBN to late orders page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502 --- Comment #37 from Séverine Queune --- I have some questions. If I use the Export option at the top of the table, only the displayed datas are exported (hide columns / perform a search). If I use the Export option at the bottom, all datas for the selected orders are exported even the hidden ones. Is that the expected behaviour ? The "Save notes" button now seems useless as datas are automatically saved using the modal, can you confirm ? I agree with Pierre-Marc : the label of "Add / Edit note" should not be exported. I will open a new ticket to fix it on the basket export because it adds work for the staff working on acquisition to suppress these informations before sending the file to the vendor. Will you agree to suppress it in the present patch ? Except these points, patch works fine ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 10:48:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 08:48:33 +0000 Subject: [Koha-bugs] [Bug 23112] Circulation of ILL items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 --- Comment #22 from Andrew Isherwood --- Created attachment 93530 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93530&action=edit Bug 23112: Add CirculateILL syspref Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 10:48:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 08:48:36 +0000 Subject: [Koha-bugs] [Bug 23112] Circulation of ILL items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92001|0 |1 is obsolete| | --- Comment #23 from Andrew Isherwood --- Created attachment 93531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93531&action=edit Bug 23112: Add circulation to ILL requests This patch adds the ability to circulate ILL requests. Once a request has a suitable status, a "Check out" button is displayed on the "Manage request" toolbar. Clicking this will enable the user to check out the item either to the user who made the request or an in-house statistical user. A due date can be specified, but if not circ rules are used. Prior to the check out, an item is created which is attached to the biblio record that was created when the request was added Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 10:48:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 08:48:39 +0000 Subject: [Koha-bugs] [Bug 23112] Circulation of ILL items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92002|0 |1 is obsolete| | --- Comment #24 from Andrew Isherwood --- Created attachment 93532 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93532&action=edit Bug 23112: Add permission checks We only want the ILL circulation functionality to be available if the appropriate syspref and perm are available, this patch adds those checks. Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 10:48:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 08:48:42 +0000 Subject: [Koha-bugs] [Bug 23112] Circulation of ILL items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92003|0 |1 is obsolete| | --- Comment #25 from Andrew Isherwood --- Created attachment 93533 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93533&action=edit Bug 23112: Update request status on return This patch updates a request's status to RET upon return Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 10:48:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 08:48:46 +0000 Subject: [Koha-bugs] [Bug 23112] Circulation of ILL items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92004|0 |1 is obsolete| | --- Comment #26 from Andrew Isherwood --- Created attachment 93534 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93534&action=edit Bug 23112: Add unit tests This patch adds unit test for the new Koha::Illrequest::check_out method Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 10:49:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 08:49:14 +0000 Subject: [Koha-bugs] [Bug 23112] Circulation of ILL items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92000|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 10:49:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 08:49:43 +0000 Subject: [Koha-bugs] [Bug 23112] Circulation of ILL items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 --- Comment #27 from Andrew Isherwood --- Thanks for that Magnus, the bug number is now fixed, as it the failure to apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 10:50:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 08:50:46 +0000 Subject: [Koha-bugs] [Bug 12502] Add columns for note, order number and ISBN to late orders page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502 Séverine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 10:56:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 08:56:50 +0000 Subject: [Koha-bugs] [Bug 21979] Add option to SIP2 config to send arbitrary item field in CR instead of collection code In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21979 Jesse Maseto changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 10:57:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 08:57:15 +0000 Subject: [Koha-bugs] [Bug 21979] Add option to SIP2 config to send arbitrary item field in CR instead of collection code In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21979 Jesse Maseto changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93358|0 |1 is obsolete| | --- Comment #5 from Jesse Maseto --- Created attachment 93535 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93535&action=edit Works as expected. Thanks. -JesseM Bug 21979: Add option to SIP2 config to send arbitrary item field in CR instead of collection code Some libraries need to send a different field as the collection code, depending on how the library catalogs items. We should allow any arbitrary item field to be used as the value for the CR field. Test Plan: 1) Apply this patch 2) Set the new option cr_item_field to 'shelving_location' 3) Restart the SIP server 3) Perform a checkin via SIP 4) Note the CR field contains the shelving location code in the response 5) Perform an item information request 6) Note the CR field contains the shelving location code in the response Signed-off-by: Jesse Maseto -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 11:02:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 09:02:48 +0000 Subject: [Koha-bugs] [Bug 23320] Neworderempty has unused 'close' parameter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23320 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #8 from Katrin Fischer --- There is a QA script fail here, can you please check? FAIL acqui/neworderempty.pl FAIL critic # Variables::ProhibitUnusedVariables: Got 1 violation(s). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 11:03:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 09:03:08 +0000 Subject: [Koha-bugs] [Bug 23713] Subscription add form broken for translations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23713 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com QA Contact|testopia at bugs.koha-communit |julian.maurice at biblibre.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 11:03:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 09:03:19 +0000 Subject: [Koha-bugs] [Bug 23320] Neworderempty has unused 'close' parameter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23320 --- Comment #9 from Katrin Fischer --- Also please fix the commit message! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 11:04:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 09:04:37 +0000 Subject: [Koha-bugs] [Bug 22630] Allow to change homebranch in course reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 11:10:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 09:10:48 +0000 Subject: [Koha-bugs] [Bug 23725] New: Indexes defined but not used - Number-govt-pub Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23725 Bug ID: 23725 Summary: Indexes defined but not used - Number-govt-pub Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching - Zebra Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com If you do a git grep for: Number-govt-pub You can see it is defined as an index, 086 is mapped there, but the CCL properties line is commented out. Is there a reason/cost for limiting our defined properties, or is this simply an oversight? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 11:12:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 09:12:18 +0000 Subject: [Koha-bugs] [Bug 20334] Elasticsearch - Option for escaping slashes in search queries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334 Séverine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune at bulac.fr Status|Needs Signoff |Patch doesn't apply --- Comment #44 from Séverine Queune --- The sandbox you've requested is not ready. Some problems occurred applying patches from bug 20334:

Something went wrong !

Applying: Bug 20334: Improve syspref description and set more sensible defaults fatal: sha1 information is lacking or useless (installer/data/mysql/atomicupdate/bug_20334-add-syspref-QueryRegexEscapeOptions.sql). error: could not build fake ancestor Patch failed at 0001 Bug 20334: Improve syspref description and set more sensible defaults -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 11:16:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 09:16:41 +0000 Subject: [Koha-bugs] [Bug 17661] Differences in field ending (whitespace, punctuation) cause duplicate facets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17661 Niamh changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |niamh.walker-headon at it-tall | |aght.ie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 11:17:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 09:17:26 +0000 Subject: [Koha-bugs] [Bug 22913] https://mana-kb.koha-community.org/ should not return a 404 error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22913 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |19.11.00 released in| | --- Comment #15 from Martin Renvoize --- Merged into upstream project -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 11:19:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 09:19:03 +0000 Subject: [Koha-bugs] [Bug 18309] UNIMARC update from IFLA In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18309 --- Comment #85 from anne-cecile.bories at iepg.fr --- Hello, Thanks for this work ! But it miss the fields IFLA belows : 018 [Reserved for other International Standard Numbers] 033 - Other System Persistent Record Identifier 183 - Coded Data Field: Type of Carrier 203 - Content Form and Media Type 231 - Digital File Characteristics 283 - Carrier Type 338 - Funding Information Note -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 11:19:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 09:19:33 +0000 Subject: [Koha-bugs] [Bug 23713] Subscription add form broken for translations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23713 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93399|0 |1 is obsolete| | --- Comment #7 from Julian Maurice --- Created attachment 93536 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93536&action=edit Bug 23713: Subscription add form broken for translations This patch makes a change to the subscription entry template as a workaround to a translation bug which is causing JavaScript errors when using translated templates. To test, apply the patch and update and install the de-DE template: > cd misc/translator > perl translate update de-DE > perl translate install de-DE - Go to Administration -> System preferences and enable the "Deutsch (de-DE)" language under I18N/L10N preferences -> language. - Switch to the "Deutsch" translation. - Go to Zeitschriften (Serials) -> Neues Abonnement (New subscription) and open the browser console. There should be no errors. - Links which trigger JavaScript events should work correctly: "Lieferant suchen," "Nach Datensatz suchen," etc. Reported-by: Katrin Fischer Thanks-to: Michael Hoffert and Alexander Arlt from koha-de for reporting it initially and figuring out the root of the issue Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 11:19:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 09:19:54 +0000 Subject: [Koha-bugs] [Bug 23713] Subscription add form broken for translations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23713 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93400|0 |1 is obsolete| | --- Comment #8 from Julian Maurice --- Created attachment 93537 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93537&action=edit Bug 23713: (follow-up) Add missing semicolon Adds a missing semicolon to one of the lines with translated messages. Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 11:20:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 09:20:51 +0000 Subject: [Koha-bugs] [Bug 23112] Circulation of ILL items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 --- Comment #28 from Magnus Enger --- Thanks for fixing the number the applicability! Sorry, I get an error on step 5: "Create a new FreeForm request": Template process failed: undef error - Undefined subroutine &Koha::Illrequest::Logger::GetAuthorisedValues called at /home/vagrant/kohaclone/Koha/Illrequest/Logger.pm line 213. at /home/vagrant/kohaclone/C4/Templates.pm line 122 This happens when I click on "New ILL request", fill in the form an click on "Create". It does not happen on current master. It does seem weird though, since the patches on the current bug do not seem to touch Koha/Illrequest/Logger.pm? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 11:21:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 09:21:28 +0000 Subject: [Koha-bugs] [Bug 23713] Subscription add form broken for translations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23713 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 11:21:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 09:21:33 +0000 Subject: [Koha-bugs] [Bug 23713] Subscription add form broken for translations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23713 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93536|0 |1 is obsolete| | Attachment #93537|0 |1 is obsolete| | --- Comment #9 from Nick Clemens --- Created attachment 93538 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93538&action=edit Bug 23713: Subscription add form broken for translations This patch makes a change to the subscription entry template as a workaround to a translation bug which is causing JavaScript errors when using translated templates. To test, apply the patch and update and install the de-DE template: > cd misc/translator > perl translate update de-DE > perl translate install de-DE - Go to Administration -> System preferences and enable the "Deutsch (de-DE)" language under I18N/L10N preferences -> language. - Switch to the "Deutsch" translation. - Go to Zeitschriften (Serials) -> Neues Abonnement (New subscription) and open the browser console. There should be no errors. - Links which trigger JavaScript events should work correctly: "Lieferant suchen," "Nach Datensatz suchen," etc. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 11:21:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 09:21:36 +0000 Subject: [Koha-bugs] [Bug 23713] Subscription add form broken for translations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23713 --- Comment #10 from Nick Clemens --- Created attachment 93539 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93539&action=edit Bug 23713: (follow-up) Add missing semicolon Adds a missing semicolon to one of the lines with translated messages. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 11:23:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 09:23:44 +0000 Subject: [Koha-bugs] [Bug 22667] Framework cannot override syspref for cn_source when receiving serials In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22667 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 11:23:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 09:23:48 +0000 Subject: [Koha-bugs] [Bug 22667] Framework cannot override syspref for cn_source when receiving serials In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22667 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89148|0 |1 is obsolete| | --- Comment #3 from Brendan Gallagher --- Created attachment 93540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93540&action=edit Bug 22667: Pick default value from framework for cn_source If the cn_source has a default value defined in the framework it will not be used when ordering or receiving serials. Test plan: Set the pref DefaultClassificationSource to Library of congress Define a default value=ddc (for Dewey) for the ACQ and default framework Receive an order (AcqCreateItem=on ordering) and confirm that Dewey is selected by default (the default value from the ACQ framework is used) Receive a serial and confirm that Dewey is selected by default Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 11:25:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 09:25:42 +0000 Subject: [Koha-bugs] [Bug 23112] Circulation of ILL items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #29 from Magnus Enger --- Same thing happes when I go to "View ILL requests" an then click on "Manage request": Template process failed: undef error - Undefined subroutine &Koha::Illrequest::Logger::GetAuthorisedValues called at /home/vagrant/kohaclone/Koha/Illrequest/Logger.pm line 213. at /home/vagrant/kohaclone/C4/Templates.pm line 122 Again, it does not happen on master without the current patches. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 11:26:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 09:26:33 +0000 Subject: [Koha-bugs] [Bug 18309] UNIMARC update from IFLA In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18309 --- Comment #86 from Corinne Hayet --- Hello, Indeed, my update was done in 2017 and there was two others updates since it :) Best regards, Corinne -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 11:28:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 09:28:01 +0000 Subject: [Koha-bugs] [Bug 23722] Document allow_empty_passwords in the example SIP config file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23722 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Attachment #93503|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 11:31:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 09:31:55 +0000 Subject: [Koha-bugs] [Bug 21985] Test t/db_dependent/Circulation.t fails if SearchEngine is set to elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21985 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 11:31:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 09:31:57 +0000 Subject: [Koha-bugs] [Bug 21985] Test t/db_dependent/Circulation.t fails if SearchEngine is set to elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21985 --- Comment #16 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 11:31:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 09:31:59 +0000 Subject: [Koha-bugs] [Bug 23252] Pressing enter should not submit form in item editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23252 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 11:32:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 09:32:00 +0000 Subject: [Koha-bugs] [Bug 23252] Pressing enter should not submit form in item editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23252 --- Comment #14 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 11:32:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 09:32:02 +0000 Subject: [Koha-bugs] [Bug 23713] Subscription add form broken for translations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23713 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 11:32:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 09:32:05 +0000 Subject: [Koha-bugs] [Bug 23713] Subscription add form broken for translations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23713 --- Comment #11 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 11:32:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 09:32:07 +0000 Subject: [Koha-bugs] [Bug 23722] Document allow_empty_passwords in the example SIP config file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23722 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 11:32:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 09:32:08 +0000 Subject: [Koha-bugs] [Bug 23722] Document allow_empty_passwords in the example SIP config file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23722 --- Comment #4 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 11:32:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 09:32:18 +0000 Subject: [Koha-bugs] [Bug 23204] Script for exporting Elasticsearch mappings to YAML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23204 Séverine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune at bulac.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 11:33:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 09:33:43 +0000 Subject: [Koha-bugs] [Bug 23726] New: Give class to No Items Available text on OPAC results page Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23726 Bug ID: 23726 Summary: Give class to No Items Available text on OPAC results page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org In the OPAC search results if an item is unavailable the text "No Items Available" appears but is not inside of an HTML element and can be hard to change or apply CSS to. This should be inside a element. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 11:33:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 09:33:49 +0000 Subject: [Koha-bugs] [Bug 23727] New: Editing course reserve items is broken Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 Bug ID: 23727 Summary: Editing course reserve items is broken Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Course reserves Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org Adding an item to course reserves and trying to edit any values in a second step does not work. Values are not saved and the table shows all values as "Unchanged". To test: - Create a new course - Find an item, make sure it has a location set - Add the item to the course, leave all values unchanged - Edit the course item - Change all the values - Verify the table still says "Unchanged" - Verify the table doesn't show the location - Edit the item again - Verify the changed values don't show -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 11:34:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 09:34:40 +0000 Subject: [Koha-bugs] [Bug 23727] Editing course reserve items is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22630 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 [Bug 22630] Allow to change homebranch in course reserves -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 11:34:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 09:34:40 +0000 Subject: [Koha-bugs] [Bug 22630] Allow to change homebranch in course reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23727 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 [Bug 23727] Editing course reserve items is broken -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 11:35:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 09:35:27 +0000 Subject: [Koha-bugs] [Bug 22630] Allow to change homebranch in course reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED Keywords|Academy |rel_19_11_candidate --- Comment #44 from Katrin Fischer --- The behaviour when editing items is really weird atm, I have filed a new bug 23727 - once this if fixed, this should be pretty straight forward. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 11:36:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 09:36:05 +0000 Subject: [Koha-bugs] [Bug 22630] Allow to change homebranch in course reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 --- Comment #45 from Katrin Fischer --- Tiny thing: Capitalization on course summary page needs to be fixed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 11:36:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 09:36:59 +0000 Subject: [Koha-bugs] [Bug 23723] using exit inside eval to stop sending output to browser doesn't work under plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23723 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 11:37:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 09:37:02 +0000 Subject: [Koha-bugs] [Bug 23723] using exit inside eval to stop sending output to browser doesn't work under plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23723 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93527|0 |1 is obsolete| | --- Comment #4 from Brendan Gallagher --- Created attachment 93541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93541&action=edit Bug 23723: using exit inside eval to stop sending output to browser doesn't work under plack When fixing Bug 23589 Theodoros Theodoropoulos noticed that we are sending headers and html after pdf output to browser. Using exit inside eval block doesn't stop plack from generating headers and html page after exit since CGI::Compile will catch exit but doesn't stop emiting output. Example is: eval { warn "in eval"; exit; }; warn "after eval"; Under CGI, this would print just "in eval", but under plack we get both lines and thus generate additional header and html after we already sent pdf data. Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 11:37:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 09:37:22 +0000 Subject: [Koha-bugs] [Bug 23713] Subscription add form broken for translations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23713 --- Comment #12 from Katrin Fischer --- Thx all! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 11:39:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 09:39:20 +0000 Subject: [Koha-bugs] [Bug 22988] Visible reduction in image quality In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22988 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #8 from Magnus Enger --- Setting to FQA since the problem was not solved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 11:39:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 09:39:58 +0000 Subject: [Koha-bugs] [Bug 17851] Add elasticsearch config to koha-conf.xml In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17851 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 11:40:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 09:40:04 +0000 Subject: [Koha-bugs] [Bug 17851] Add elasticsearch config to koha-conf.xml In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17851 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91288|0 |1 is obsolete| | Attachment #91289|0 |1 is obsolete| | --- Comment #7 from Nick Clemens --- Created attachment 93542 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93542&action=edit Bug 17851 - Add elasticsearch config to koha-conf.xml Missing installer for debian packages. Sponsored-by: Koha-Suomi Oy Signed-off-by: Johanna Raisa Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 11:40:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 09:40:13 +0000 Subject: [Koha-bugs] [Bug 17851] Add elasticsearch config to koha-conf.xml In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17851 --- Comment #8 from Nick Clemens --- Created attachment 93543 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93543&action=edit Bug 17851 - Add elasticsearch config to koha-conf.xml - Add missing entries to koha-install-log Sponsored-by: Koha-Suomi Oy Signed-off-by: Johanna Raisa Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 11:41:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 09:41:22 +0000 Subject: [Koha-bugs] [Bug 23551] Problem with renewal period when using the renewal tab in 19.05.03 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23551 Holly changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hc at interleaf.ie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 11:41:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 09:41:46 +0000 Subject: [Koha-bugs] [Bug 23726] Give class to No Items Available text on OPAC results page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23726 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 11:41:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 09:41:52 +0000 Subject: [Koha-bugs] [Bug 23726] Give class to No Items Available text on OPAC results page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23726 --- Comment #1 from Lucas Gass --- Created attachment 93544 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93544&action=edit Bug 23726: Give class to No Items Available text on OPAC results page TEST PLAN: 1. Make an item unvailable and find the text "No Items Available" in the search results. 2. Inspect the element and notice it does not have its own class. 3. Apply patch, 4. add this CSS to the OPACUserCSS: ".noitems{color:red;font-size:large;}" 5. Notice that the text "No Items Available" is now big and red. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 11:42:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 09:42:14 +0000 Subject: [Koha-bugs] [Bug 23612] If no columns in a table can be toggled, don't show columns button In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23612 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 11:42:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 09:42:19 +0000 Subject: [Koha-bugs] [Bug 23726] Give class to No Items Available text on OPAC results page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23726 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 11:43:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 09:43:54 +0000 Subject: [Koha-bugs] [Bug 23612] If no columns in a table can be toggled, don't show columns button In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23612 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92865|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 11:47:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 09:47:03 +0000 Subject: [Koha-bugs] [Bug 23723] using exit inside eval to stop sending output to browser doesn't work under plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23723 --- Comment #5 from Theodoros Theodoropoulos --- Dobrica, in the patch you submitted, you tackle the issue only in opac-discharge.pl The same code exists also in discharge.pl (where it was originally discovered). Please include the fix for that as well in your patch in order to sign it off. Thanks in advance! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 11:47:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 09:47:57 +0000 Subject: [Koha-bugs] [Bug 23320] Neworderempty has unused 'close' parameter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23320 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 11:47:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 09:47:59 +0000 Subject: [Koha-bugs] [Bug 23320] Neworderempty has unused 'close' parameter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23320 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93508|0 |1 is obsolete| | --- Comment #10 from Nick Clemens --- Created attachment 93545 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93545&action=edit Bug 23320: Removed unused close parameter in neworderempty To test: 1 - Add to basket 2 - Note the options on the page 3 - Add &close=1 to the url 4 - Note some inputs are disabled 5 - Save anyway, note it is a regular order 6 - Add another order to basket 7 - Save it 8 - Modify 9 - Add close to the url again 10 - Save changes 11 - No functional change 12 - Apply patch 13 - Note close parameter has no effect now 14 - Confirm you can place and confirm orders as before Signed-off-by: Séverine QUEUNE Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 11:48:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 09:48:03 +0000 Subject: [Koha-bugs] [Bug 23320] Neworderempty has unused 'close' parameter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23320 --- Comment #11 from Nick Clemens --- Created attachment 93546 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93546&action=edit Bug 23320: (follow-up) Remove unused budget_name variable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 11:57:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 09:57:23 +0000 Subject: [Koha-bugs] [Bug 17851] Add elasticsearch config to koha-conf.xml In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17851 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93542|0 |1 is obsolete| | Attachment #93543|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer --- Created attachment 93547 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93547&action=edit Bug 17851: Add elasticsearch config to koha-conf.xml Missing installer for debian packages. Sponsored-by: Koha-Suomi Oy Signed-off-by: Johanna Raisa Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 11:57:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 09:57:35 +0000 Subject: [Koha-bugs] [Bug 17851] Add elasticsearch config to koha-conf.xml In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17851 --- Comment #10 from Katrin Fischer --- Created attachment 93548 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93548&action=edit Bug 17851: Add Elasticsearch config to koha-conf.xml - Add missing entries to koha-install-log Sponsored-by: Koha-Suomi Oy Signed-off-by: Johanna Raisa Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 11:58:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 09:58:16 +0000 Subject: [Koha-bugs] [Bug 17851] Add elasticsearch config to koha-conf.xml In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17851 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #11 from Katrin Fischer --- Fixed commit messages (Bug XXXX:) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 11:59:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 09:59:39 +0000 Subject: [Koha-bugs] [Bug 21903] koha-dump be able to include koha-upload In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21903 --- Comment #8 from Matthias Meusburger --- Thanks for the feedback. My bad, I somehow messed up when submitting the patch. It should be ok now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 11:59:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 09:59:48 +0000 Subject: [Koha-bugs] [Bug 23389] Add 'All' option to report value dropdowns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23389 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 12:00:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 10:00:03 +0000 Subject: [Koha-bugs] [Bug 17247] ILS-DI HoldTitle and HoldItem should check if patron is debarred In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17247 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 12:00:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 10:00:07 +0000 Subject: [Koha-bugs] [Bug 17247] ILS-DI HoldTitle and HoldItem should check if patron is debarred In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17247 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89653|0 |1 is obsolete| | --- Comment #19 from Brendan Gallagher --- Created attachment 93549 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93549&action=edit Bug 17247 : Check if patron is debarred in HoldItem and HoldTitle Test plan : Make sure a debarred patron cannot hold a title or item through ILS-DI. Response from the WebService should be "PatronDebarred". Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 12:01:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 10:01:32 +0000 Subject: [Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Séverine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune at bulac.fr Status|Needs Signoff |Failed QA --- Comment #15 from Séverine Queune --- Not a critical point, but column name "Account type code" is different in the creation/modification form where it's "Account debit type code". The "Account type code" is supposed to accept 16 letters, but blocks after 5. If I use letters, currency symbols or comma for the "Default amount", the data is set to 0.00 after saving : I think it could be better if we could have a control field (don't know if it the correct term) that only accept numbers and the autorized decimal separator. Other behaviors seemed good to me, the design is clear and the options (filter / search) efficient ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 12:02:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 10:02:06 +0000 Subject: [Koha-bugs] [Bug 21903] koha-dump be able to include koha-upload In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21903 Matthias Meusburger changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88867|0 |1 is obsolete| | --- Comment #9 from Matthias Meusburger --- Created attachment 93550 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93550&action=edit Bug 21903: koha-dump can export uploaded and temporary uploaded files Sponsored-by: Orex Test plan: - Apply the patch - Try using koha-dump without any option - Try using koha-dump with --uploaded_files - Try using koha-dump with --uploaded_temp_files - Try using koha-dump with both of the options above Expected results: the .tar.gz dump will include uploaded and/or temporary uploaded files if requested. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 12:02:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 10:02:08 +0000 Subject: [Koha-bugs] [Bug 18084] Language selector hidden in user menu on mobile interfaces In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18084 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 12:02:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 10:02:10 +0000 Subject: [Koha-bugs] [Bug 18084] Language selector hidden in user menu on mobile interfaces In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18084 --- Comment #5 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 12:02:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 10:02:12 +0000 Subject: [Koha-bugs] [Bug 23543] Adding withdrawn to the item search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23543 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 12:02:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 10:02:14 +0000 Subject: [Koha-bugs] [Bug 23543] Adding withdrawn to the item search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23543 --- Comment #8 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 12:02:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 10:02:16 +0000 Subject: [Koha-bugs] [Bug 23612] If no columns in a table can be toggled, don't show columns button In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23612 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 12:02:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 10:02:18 +0000 Subject: [Koha-bugs] [Bug 23612] If no columns in a table can be toggled, don't show columns button In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23612 --- Comment #4 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 12:02:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 10:02:20 +0000 Subject: [Koha-bugs] [Bug 23686] Check onsite checkout when the last checkout was an onsite one In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23686 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 12:02:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 10:02:22 +0000 Subject: [Koha-bugs] [Bug 23686] Check onsite checkout when the last checkout was an onsite one In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23686 --- Comment #5 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 12:02:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 10:02:23 +0000 Subject: [Koha-bugs] [Bug 23711] Icons on staff main page should be font icons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23711 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 12:02:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 10:02:25 +0000 Subject: [Koha-bugs] [Bug 23711] Icons on staff main page should be font icons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23711 --- Comment #17 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 12:08:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 10:08:27 +0000 Subject: [Koha-bugs] [Bug 23723] using exit inside eval to stop sending output to browser doesn't work under plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23723 Theodoros Theodoropoulos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93541|0 |1 is obsolete| | --- Comment #6 from Theodoros Theodoropoulos --- Created attachment 93551 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93551&action=edit Bug 23723: using exit inside eval to stop sending output to browser doesn't work under plack Also fixes ./src/members/discharge.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 12:09:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 10:09:05 +0000 Subject: [Koha-bugs] [Bug 22913] https://mana-kb.koha-community.org/ should not return a 404 error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22913 --- Comment #16 from Alex Arnaud --- https://mana-kb.koha-community.org and https://mana-test.koha-community.org are up-to-date with the related patches -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 12:15:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 10:15:27 +0000 Subject: [Koha-bugs] [Bug 23723] using exit inside eval to stop sending output to browser doesn't work under plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23723 Theodoros Theodoropoulos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #7 from Theodoros Theodoropoulos --- Extending the patch was trivial, so I gave it a go myself. Please check if it works for you too (it worked for me). Brendan, I'm changing status to "Needs Sign Off" (the original patch indeed tackled the problem, but not in all places). [I'm not a senior koha dev (like most of you), so please forgive me if I did something wrong. Full credits for identifying the real cause and fixing the problem go to Dobrica!] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 12:23:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 10:23:32 +0000 Subject: [Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #16 from Kyle M Hall --- (In reply to Séverine Queune from comment #15) > Not a critical point, but column name "Account type code" is different in > the creation/modification form where it's "Account debit type code". > > The "Account type code" is supposed to accept 16 letters, but blocks after 5. Actually, it should be 80 based on bug 23539 > If I use letters, currency symbols or comma for the "Default amount", the > data is set to 0.00 after saving : I think it could be better if we could > have a control field (don't know if it the correct term) that only accept > numbers and the autorized decimal separator. Agreed, an html5 pattern like ^\d+\.\d{2}$ should do it! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 12:30:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 10:30:16 +0000 Subject: [Koha-bugs] [Bug 23382] Issuing rules failing after bug 20912 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED --- Comment #25 from Nick Clemens --- Discussed with Martin, checkout calculations are coming up short -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 12:50:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 10:50:52 +0000 Subject: [Koha-bugs] [Bug 23723] using exit inside eval to stop sending output to browser doesn't work under plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23723 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93551|0 |1 is obsolete| | --- Comment #8 from Dobrica Pavlinusic --- Created attachment 93552 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93552&action=edit Bug 23723: using exit inside eval to stop sending output to browser doesn't work under plack When fixing Bug 23589 Theodoros Theodoropoulos noticed that we are sending headers and html after pdf output to browser. Using exit inside eval block doesn't stop plack from generating headers and html page after exit since CGI::Compile will catch exit but doesn't stop emiting output. Example is: eval { warn "in eval"; exit; }; warn "after eval"; Under CGI, this would print just "in eval", but under plack we get both lines and thus generate additional header and html after we already sent pdf data. Current status: Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 12:52:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 10:52:10 +0000 Subject: [Koha-bugs] [Bug 23723] using exit inside eval to stop sending output to browser doesn't work under plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23723 --- Comment #9 from Dobrica Pavlinusic --- Patch should include also commit message, so I replaced it with full version which you can now sign-off :-) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 13:07:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 11:07:51 +0000 Subject: [Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 13:07:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 11:07:56 +0000 Subject: [Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86051|0 |1 is obsolete| | --- Comment #41 from Nick Clemens --- Created attachment 93553 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93553&action=edit Bug 17140: fix rounding errors when paying fines Whenever a fine (accountlines in DB) has a precision longer than two floating points, it becomes very hard for a user to clear it. Ex: 1.035 will be displayed as 1.04 or 1.03 depending on the screen. But entering any of those value in Pay Fine will not clear it. The user has no way to know the exact value to enter. This fix makes sure that the intent of the user is met, by matching the EXACT needed sum when the difference is less than 0.01. TEST 1) Create a 1.035 fine - Go to a Patron screen - Fines tab on the left - Create manual invoice 2) go to Pay fines, click Pay amount on bottom left. 3) It will show 1.03 as Total, and as Collect from patron. Click confirm. 4) An error message will appear. 5) Apply patch, do again. Signed-off-by: Hayley Mapley Signed-off-by: Josef Moravec Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 13:08:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 11:08:03 +0000 Subject: [Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140 --- Comment #42 from Nick Clemens --- Created attachment 93554 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93554&action=edit Bug 17140: Make rounding syspref controlled Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 13:09:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 11:09:47 +0000 Subject: [Koha-bugs] [Bug 23389] Add 'All' option to report value dropdowns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23389 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 13:09:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 11:09:53 +0000 Subject: [Koha-bugs] [Bug 23389] Add 'All' option to report value dropdowns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23389 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91887|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer --- Created attachment 93555 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93555&action=edit Bug 23389: Add 'All' option to report dropdowns This patch optionally adds an 'all' option to report dropdowns Note you will need to use 'LIKE' instead of '=' to allow 'All' to work To test: 1 - Write a report: SELECT branchname FROM branches WHERE branchcode LIKE <> 2 - Run it 3 - Select a branch 4 - You get one branch info 5 - Note you cannot select all 6 - Apply patch 7 - Run report 8 - No change 9 - Update report like: SELECT branchname FROM branches WHERE branchcode LIKE <> 10 - Run report 11 - Select 'All' 12 - You get all branches 13 - Select one branch 14 - You get one branch 15 - Test with other authorised categories (itemtypes, YES_NO, etc.) 16 - Confirm it works as expected 17 - Prove -v t/db_dependent/Reports/Guided.t Signed-off-by: Lisette Scheer Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 13:10:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 11:10:04 +0000 Subject: [Koha-bugs] [Bug 23389] Add 'All' option to report value dropdowns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23389 --- Comment #8 from Katrin Fischer --- Love! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 13:12:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 11:12:15 +0000 Subject: [Koha-bugs] [Bug 22970] Allow to change homebranch in batch add course reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22970 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED Assignee|koha-bugs at lists.koha-commun |julian.maurice at biblibre.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 13:12:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 11:12:59 +0000 Subject: [Koha-bugs] [Bug 23728] New: Rounding code should be moved to a Koha module so code can be centralised Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23728 Bug ID: 23728 Summary: Rounding code should be moved to a Koha module so code can be centralised Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org When OrderPriceRounding was added the code was all Acquisitions related. Bug 17140 faces a similar issue. Ideally the code would be available in a Koha module for reuse in all areas involving funds. It would also allow for specifiying different rounds for diferent vendors which is needed by some -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 13:13:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 11:13:21 +0000 Subject: [Koha-bugs] [Bug 23728] Rounding code should be moved to a Koha module so code can be centralised In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23728 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17140 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140 [Bug 17140] Incorrect rounding in total fines calculations, part 2 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 13:13:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 11:13:21 +0000 Subject: [Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23728 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23728 [Bug 23728] Rounding code should be moved to a Koha module so code can be centralised -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 13:13:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 11:13:24 +0000 Subject: [Koha-bugs] [Bug 21959] Batch item modification - ability to apply regular expression on text fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21959 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 13:16:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 11:16:03 +0000 Subject: [Koha-bugs] [Bug 21959] Batch item modification - ability to apply regular expression on text fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21959 Michal Denar changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 13:17:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 11:17:13 +0000 Subject: [Koha-bugs] [Bug 21959] Batch item modification - ability to apply regular expression on text fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21959 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #22 from Katrin Fischer --- Can you please rebase? Should be easy, but don't want to risk it: Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 21959: Batch item modification - ability to apply regular expression on text fields Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt error: Failed to merge in the changes. Patch failed at 0001 Bug 21959: Batch item modification - ability to apply regular expression on text fields The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-21959-Batch-item-modification---ability-to-app-HQtELZ.patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 13:18:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 11:18:12 +0000 Subject: [Koha-bugs] [Bug 23723] using exit inside eval to stop sending output to browser doesn't work under plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23723 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93552|0 |1 is obsolete| | --- Comment #10 from ByWater Sandboxes --- Created attachment 93556 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93556&action=edit Bug 23723: using exit inside eval to stop sending output to browser doesn't work under plack When fixing Bug 23589 Theodoros Theodoropoulos noticed that we are sending headers and html after pdf output to browser. Using exit inside eval block doesn't stop plack from generating headers and html page after exit since CGI::Compile will catch exit but doesn't stop emiting output. Example is: eval { warn "in eval"; exit; }; warn "after eval"; Under CGI, this would print just "in eval", but under plack we get both lines and thus generate additional header and html after we already sent pdf data. Signed-off-by: Theodoros Theodoropoulos -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 13:21:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 11:21:44 +0000 Subject: [Koha-bugs] [Bug 23680] Perl string '0' evaluated as javascript boolean triggers window.close() when should not In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23680 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |glasklas at gmail.com |ity.org | CC| |katrin.fischer at bsz-bw.de --- Comment #5 from Katrin Fischer --- Please don't forget to assign the bug to you when you start working on it! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 13:29:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 11:29:40 +0000 Subject: [Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #17 from Martin Renvoize --- Created attachment 93557 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93557&action=edit Bug 23049: (follow-up) Impliment feedback -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 13:31:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 11:31:10 +0000 Subject: [Koha-bugs] [Bug 23475] Search context is lost when simple search leads to a single record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23475 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes at biblibre.com --- Comment #3 from sandboxes at biblibre.com --- Patch tested with a sandbox, by Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 13:31:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 11:31:23 +0000 Subject: [Koha-bugs] [Bug 23475] Search context is lost when simple search leads to a single record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23475 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92357|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 13:31:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 11:31:31 +0000 Subject: [Koha-bugs] [Bug 23475] Search context is lost when simple search leads to a single record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23475 --- Comment #4 from sandboxes at biblibre.com --- Created attachment 93558 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93558&action=edit Bug 23475: Use cookies to preserve simple search values Signed-off-by: Séverine QUEUNE Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 13:31:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 11:31:31 +0000 Subject: [Koha-bugs] [Bug 23680] Perl string '0' evaluated as javascript boolean triggers window.close() when should not In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23680 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 13:32:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 11:32:12 +0000 Subject: [Koha-bugs] [Bug 23680] Perl string '0' evaluated as javascript boolean triggers window.close() when should not In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23680 --- Comment #6 from Katrin Fischer --- (In reply to David Nind from comment #4) > I tested this with the latest Firefox and Google Chrome browsers on Ubuntu > 18.04. > > With pop ups allowed for both browsers: > > - On Firefox the behaviour identified didn't occur, that is: the window > opened fine in a new tab (both before and after the patch) > > - On Google Chrome the behaviour identified occurred and the patch fixed it. Thx for the hints about Browsers, David! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 13:33:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 11:33:46 +0000 Subject: [Koha-bugs] [Bug 23475] Search context is lost when simple search leads to a single record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23475 Séverine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune at bulac.fr --- Comment #5 from Séverine Queune --- Finally worked cleaning the cookies ! I just had a little encoding issue with the last 'é' (see screenshot) but I don't know it if comes from the patch I'm not sure it comes form the patch so I signed it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 13:34:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 11:34:19 +0000 Subject: [Koha-bugs] [Bug 22884] Remove ending . from XSLT templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22884 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 13:34:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 11:34:22 +0000 Subject: [Koha-bugs] [Bug 22884] Remove ending . from XSLT templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22884 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92204|0 |1 is obsolete| | --- Comment #22 from Nick Clemens --- Created attachment 93559 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93559&action=edit Bug 22884: Remove field ending . from XSLT templates Currently Koha very inconsistently adds a . at the end when outputting MARC fields on the detail views. This patch removes the few cases where we add in . Keeping the end user in mind, I believe it's not needed and the added consistency will be nice. ISBD should be added on cataloguing or by templates, but we should not mix when possible. To test: Catalog the following fields, if repeatable, add more than one: - 020 - 022 - 111 - 242 - 245 - 246 - 250 - 300 - 440 - 490 - 700/710/711 with $i - 700/710/711 ind.2 = 2 Verify both on staff and OPAC detail pages that there is no additional . at the end of the line. Signed-off-by: Hayley Mapley Signed-off-by: frederik Signed-off-by: Hayley Mapley Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 13:34:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 11:34:25 +0000 Subject: [Koha-bugs] [Bug 22884] Remove ending . from XSLT templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22884 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92205|0 |1 is obsolete| | --- Comment #23 from Nick Clemens --- Created attachment 93560 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93560&action=edit Bug 22884: (follow-up) Remove ending . from 440 in OPAC detail Signed-off-by: Hayley Mapley Signed-off-by: frederik Signed-off-by: Hayley Mapley Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 13:34:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 11:34:28 +0000 Subject: [Koha-bugs] [Bug 22884] Remove ending . from XSLT templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22884 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92206|0 |1 is obsolete| | --- Comment #24 from Nick Clemens --- Created attachment 93561 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93561&action=edit Bug 22884: Show separator between 440 and 490 fields This adds a ; as separator between 440 and 490 fields used in the same record. Currently we loop first 440 and then 490. 490 is displayed depending on the indicator. So after we finish the first loop, we check for existence of 490 on the same record now to decide if a separator is needed. To test: - Look at various records using one or multiple 440 and 490 fields - Verify the display is correct, especially when both appar on the same record in both OPAC and staff Signed-off-by: Hayley Mapley Signed-off-by: Hayley Mapley Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 13:34:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 11:34:46 +0000 Subject: [Koha-bugs] [Bug 23475] Search context is lost when simple search leads to a single record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23475 --- Comment #6 from Séverine Queune --- Created attachment 93562 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93562&action=edit Little issue with the final é -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 13:34:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 11:34:56 +0000 Subject: [Koha-bugs] [Bug 23680] Perl string '0' evaluated as javascript boolean triggers window.close() when should not In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23680 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 13:35:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 11:35:07 +0000 Subject: [Koha-bugs] [Bug 23680] Perl string '0' evaluated as javascript boolean triggers window.close() when should not In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23680 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93176|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer --- Created attachment 93563 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93563&action=edit Bug 23680: Incorrect conversion of Perl boolean to js A Perl boolean value is on the server side converted to a JS string (resulting in the values '0' or '1). Since the string '0' is a truthy value in JS this incorrectly triggers window.close() on the client in many instances, for example when adding a new item. To test: 1. Go to a bibliographic record in the staff client. 2. Expand the "New" menu and open "New item" in new tab. 3. The new tab will immediately close. 4. Apply the patch. 5. Perform steps 1-2 again. 6. The tab should now remain open. Sponsored-by: Gothenburg University Library Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 13:35:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 11:35:38 +0000 Subject: [Koha-bugs] [Bug 23723] using exit inside eval to stop sending output to browser doesn't work under plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23723 Theodoros Theodoropoulos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #11 from Theodoros Theodoropoulos --- I used ByWater Solutions' sandboxes because they seem to use Plack (required for the bug to appear). Seems to work OK, but QA may complain that there is no test plan for the patch. Because the bug relates only to code found in discharges, I would propose something like: 1/ make sure Plack is used in the system 2/ go to System Preferences and set useDischarge: Allow 3/ create a patron (or select a patron) and go to discharges -> generate discharge 4/ the produced file is not a proper PDF as is contains headers and html code in the end 5/ Apply patch (restart starman/apache ?) 6/ go to discharges-> generate discharge 7/ the bug is fixed and produced file is proper PDF (Something similar could be described for opac-discharge) ByWater Solutions' sandbox sign-off procedure did not change the status to Signed off... Doing it manually. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 13:38:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 11:38:48 +0000 Subject: [Koha-bugs] [Bug 23723] using exit inside eval to stop sending output to browser doesn't work under plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23723 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #12 from Katrin Fischer --- Thx Dobrica (missing you here in Marseille) and Theodoros! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 13:39:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 11:39:21 +0000 Subject: [Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93557|0 |1 is obsolete| | --- Comment #18 from Martin Renvoize --- Created attachment 93564 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93564&action=edit Bug 23049: (follow-up) Impliment feedback -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 13:39:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 11:39:24 +0000 Subject: [Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #19 from Martin Renvoize --- Created attachment 93565 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93565&action=edit Bug 23049: (follow-up) Remove MANUAL_INV from AV -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 13:42:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 11:42:21 +0000 Subject: [Koha-bugs] [Bug 21343] Automatic renewal cronjob doesn't send notices according to patron language preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21343 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 13:42:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 11:42:24 +0000 Subject: [Koha-bugs] [Bug 21343] Automatic renewal cronjob doesn't send notices according to patron language preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21343 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93505|0 |1 is obsolete| | --- Comment #6 from Nick Clemens --- Created attachment 93566 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93566&action=edit Bug 21343: Respect patron language preference in automtic renewals To test: 1) Set up different automatic renewal notices for Default and one other language 2) Make sure you have checkouts due for auto-renewal to patrons with non-Default language pref 3) Run automatic_renewals.pl . All patrons will get the default-language notice 4) Apply patch. 5) Repeat 2) 6) Run automatic_renewals.pl . Patrons will receive notices according to their language preference. Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 13:43:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 11:43:39 +0000 Subject: [Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #20 from Martin Renvoize --- Thankyou for the fast feedback Séverine, I believe I've resolved those issues now with the followup :). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 13:47:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 11:47:08 +0000 Subject: [Koha-bugs] [Bug 23723] Using exit inside eval to stop sending output to the browser doesn't work under Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23723 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|using exit inside eval to |Using exit inside eval to |stop sending output to |stop sending output to the |browser doesn't work under |browser doesn't work under |plack |Plack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 13:52:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 11:52:12 +0000 Subject: [Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sandboxes at biblibre.com Status|Needs Signoff |Signed Off --- Comment #21 from sandboxes at biblibre.com --- Patch tested with a sandbox, by Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 13:53:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 11:53:04 +0000 Subject: [Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93513|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 13:53:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 11:53:10 +0000 Subject: [Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93514|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 13:53:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 11:53:15 +0000 Subject: [Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93515|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 13:53:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 11:53:20 +0000 Subject: [Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93516|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 13:53:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 11:53:26 +0000 Subject: [Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93518|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 13:53:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 11:53:31 +0000 Subject: [Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93519|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 13:53:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 11:53:37 +0000 Subject: [Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93520|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 13:53:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 11:53:42 +0000 Subject: [Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93521|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 13:53:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 11:53:47 +0000 Subject: [Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93522|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 13:53:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 11:53:53 +0000 Subject: [Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93523|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 13:53:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 11:53:58 +0000 Subject: [Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93529|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 13:54:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 11:54:04 +0000 Subject: [Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93564|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 13:54:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 11:54:09 +0000 Subject: [Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93565|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 13:54:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 11:54:18 +0000 Subject: [Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #22 from sandboxes at biblibre.com --- Created attachment 93567 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93567&action=edit Bug 23049: Add debit_type * Add account_debit_types table * Add account_debit_types defaults * Add Koha::Account::DebitType and Koha::Account::DebitTypes * Prevent deletion of defaults * Update database to insert existing values Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 13:54:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 11:54:21 +0000 Subject: [Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #23 from sandboxes at biblibre.com --- Created attachment 93568 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93568&action=edit Bug 23049: Add branch limitations tables Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 13:54:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 11:54:24 +0000 Subject: [Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #24 from sandboxes at biblibre.com --- Created attachment 93569 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93569&action=edit Bug 23049: Update DBIC Classes for branch limitations Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 13:54:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 11:54:28 +0000 Subject: [Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #25 from sandboxes at biblibre.com --- Created attachment 93570 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93570&action=edit Bug 23049: Add CHECK constraint to accountlines Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 13:54:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 11:54:31 +0000 Subject: [Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #26 from sandboxes at biblibre.com --- Created attachment 93571 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93571&action=edit Bug 23049: Account types configuration - Admin page Test plan: 1) Go to admin home, note there is new Debit types page in Accounting section 2) Go to any other admin page and confirm there is link to Debit types in the admin menu as well 3) Go to Debit types page 4) You should see a datatable listing existing debit types, ensure they are working as expected. 5) Try to create, edit and delete some debit types. Note: Some debit types cannot be deleted as they are needed for koha functionality. Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 13:54:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 11:54:34 +0000 Subject: [Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #27 from sandboxes at biblibre.com --- Created attachment 93572 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93572&action=edit Bug 23049: Update maninvoice to reference debit types Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 13:54:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 11:54:37 +0000 Subject: [Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #28 from sandboxes at biblibre.com --- Created attachment 93573 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93573&action=edit Bug 23049: Use debit_type in staff client views Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 13:54:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 11:54:40 +0000 Subject: [Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #29 from sandboxes at biblibre.com --- Created attachment 93574 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93574&action=edit Bug 23049: Update existing accounttype values Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 13:54:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 11:54:43 +0000 Subject: [Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #30 from sandboxes at biblibre.com --- Created attachment 93575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93575&action=edit Bug 23049: Split system and local types Test plan 1) Apply patches up to this point 2) View the new debit types management page and comment whether the split table view is clearer/better. Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 13:54:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 11:54:46 +0000 Subject: [Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #31 from sandboxes at biblibre.com --- Created attachment 93576 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93576&action=edit Bug 23049: Add tests Test plan: prove t/db_dependent/Koha/Account/DebitType.t prove t/db_dependent/Koha/Account/DebitTypes.t Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 13:54:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 11:54:49 +0000 Subject: [Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #32 from sandboxes at biblibre.com --- Created attachment 93577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93577&action=edit Bug 23049: Use a filtered table instead of two tables Test Plan * Apply this patch and comment on new page design. Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 13:54:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 11:54:52 +0000 Subject: [Koha-bugs] [Bug 23723] Using exit inside eval to stop sending output to the browser doesn't work under Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23723 --- Comment #13 from Katrin Fischer --- I must be missing something - because my PDF look great without the patch :( -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 13:54:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 11:54:53 +0000 Subject: [Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #33 from sandboxes at biblibre.com --- Created attachment 93578 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93578&action=edit Bug 23049: (follow-up) Impliment feedback Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 13:54:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 11:54:56 +0000 Subject: [Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #34 from sandboxes at biblibre.com --- Created attachment 93579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93579&action=edit Bug 23049: (follow-up) Remove MANUAL_INV from AV Signed-off-by: Séverine QUEUNE Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 13:55:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 11:55:47 +0000 Subject: [Koha-bugs] [Bug 23626] Add a system preference to limit the number of rows of data used when charting or exporting report results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23626 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93204|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 13:56:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 11:56:23 +0000 Subject: [Koha-bugs] [Bug 23626] Add a system preference to limit the number of rows of data used when charting or exporting report results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23626 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #37 from Nick Clemens --- (In reply to Séverine Queune from comment #36) > The sandbox you've requested is not ready. > Some problems occurred applying patches from bug 23626: >

Something went wrong !

Applying: Limit memory consumption when > exporting, too > fatal: sha1 information is lacking or useless > (installer/data/mysql/atomicupdate/bug_23626.perl). > error: could not build fake ancestor > Patch failed at 0001 Limit memory consumption when exporting, too I obsoleted the original to allow this to apply on a sandbox -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 14:00:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 12:00:14 +0000 Subject: [Koha-bugs] [Bug 23589] Discharge notice does not show non-latin characters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23589 --- Comment #12 from Theodoros Theodoropoulos --- Test plan for QA 1/ If using Plack, make sure https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23723 is applied. Otherwise, produced PDF may not be properly encoded. 2/ Go to System Preferences and set useDischarge: Allow 3/ Create (or edit) a patron, entering non-latin characters for example in Surname and/or First Name 4/ In Tools->Notices & slips, make sure you use standard notice settings in DISCHARGE, OR at least make sure you print <> and/or <> 5/ Goto Patron page -> discharges -> generate discharge 6/ Produced PDF shows no data where <> and/or <> should have appeared. 7/ apply patch 8/ Goto Patron page -> discharges -> generate discharge 9/ Produced PDF properly shows the data from <> and/or <> columns -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 14:01:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 12:01:03 +0000 Subject: [Koha-bugs] [Bug 20334] Elasticsearch - Option for escaping slashes in search queries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334 --- Comment #45 from David Gustafsson --- Realized screwed up when attaching the last patch (using an older version, so mismatch between commits etc). Will restore and rebase again. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 14:01:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 12:01:35 +0000 Subject: [Koha-bugs] [Bug 23670] Load Koha::Exceptions::ElasticSearch module in Koha::SearchEngine::Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23670 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Assignee|koha-bugs at lists.koha-commun |nicolas.legrand at bulac.fr |ity.org | --- Comment #3 from Katrin Fischer --- Nicolas, please remember to add youself as Assignee on your bugs :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 14:02:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 12:02:24 +0000 Subject: [Koha-bugs] [Bug 23671] Elasticsearch shouldn't throw exception on an uppercase subfield identifier In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23671 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nicolas.legrand at bulac.fr |ity.org | CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 14:02:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 12:02:42 +0000 Subject: [Koha-bugs] [Bug 23400] Add --status to koha-indexer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23400 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Assignee|koha-bugs at lists.koha-commun |magnus at libriotech.no |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 14:04:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 12:04:41 +0000 Subject: [Koha-bugs] [Bug 23723] Using exit inside eval to stop sending output to the browser doesn't work under Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23723 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 14:04:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 12:04:44 +0000 Subject: [Koha-bugs] [Bug 23723] Using exit inside eval to stop sending output to the browser doesn't work under Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23723 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93556|0 |1 is obsolete| | --- Comment #14 from Nick Clemens --- Created attachment 93580 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93580&action=edit Bug 23723: using exit inside eval to stop sending output to browser doesn't work under plack When fixing Bug 23589 Theodoros Theodoropoulos noticed that we are sending headers and html after pdf output to browser. Using exit inside eval block doesn't stop plack from generating headers and html page after exit since CGI::Compile will catch exit but doesn't stop emiting output. Example is: eval { warn "in eval"; exit; }; warn "after eval"; Under CGI, this would print just "in eval", but under plack we get both lines and thus generate additional header and html after we already sent pdf data. Signed-off-by: Theodoros Theodoropoulos Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 14:06:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 12:06:39 +0000 Subject: [Koha-bugs] [Bug 23723] Using exit inside eval to stop sending output to the browser doesn't work under Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23723 --- Comment #15 from Theodoros Theodoropoulos --- Katrin, try to open it in Notepad++ or vi (or another editor). You will see the headers and html at the end of the file. With the patch, the resulting file has no such garbage and it has 1/3 of the size In 18.11 (and earlier versions) the resulting file was not even readable by a PDF reader. For some reason in master the added garbage do not invalidate the produced PDF. Maybe has to do with some perl module update? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 14:07:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 12:07:43 +0000 Subject: [Koha-bugs] [Bug 8778] Add Keyword phrase search to OPAC search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8778 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 14:07:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 12:07:47 +0000 Subject: [Koha-bugs] [Bug 8778] Add Keyword phrase search to OPAC search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8778 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92328|0 |1 is obsolete| | --- Comment #11 from Nick Clemens --- Created attachment 93581 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93581&action=edit Bug 8778: Add Keyword phrase to OPAC advanced search Adds a new search index to the advanced search in OPAC: Keyword phrase The new search option displays when the "More options" are selected. To test: - Apply patch - Go to Advanced search in OPAC - Look at the search pull downs - Verify everything looks correct - Click "More options" - Verify the Keyword phrase search option shows - Test if it works correctly Signed-off-by: Lucas Gass Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 14:11:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 12:11:02 +0000 Subject: [Koha-bugs] [Bug 20334] Elasticsearch - Option for escaping slashes in search queries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85129|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 14:11:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 12:11:17 +0000 Subject: [Koha-bugs] [Bug 20334] Elasticsearch - Option for escaping slashes in search queries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93478|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 14:13:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 12:13:22 +0000 Subject: [Koha-bugs] [Bug 23123] Status AVAILABLE and ORDERED for suggestions are not translated in the templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23123 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93444|0 |1 is obsolete| | --- Comment #6 from Nick Clemens --- Created attachment 93582 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93582&action=edit Bug 23123: Add missing suggestion status to template for translation This completes suggestion status options in the templates in 2 places so all values can be translated and show correctly. To test: - Create 2 suggestions - Accept them - Create a basket and order those 2 from suggestions - Close the basket - Receive shipment and receive one of the 2 suggestions - Go back to suggestions: - Look at the status column in the suggestions table for both - Verify that it shows AVAILABLE - View both suggestions - Verify that the Status: is empty - Apply patch - Repeat test from above, it should all show nicely now Signed-off-by: Claudie Trégouët Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 14:17:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 12:17:27 +0000 Subject: [Koha-bugs] [Bug 19884] Improve performance of GetItem In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19884 Séverine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune at bulac.fr Status|Needs Signoff |Patch doesn't apply --- Comment #51 from Séverine Queune --- Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 19884: Add benchmark script to compare DBIC vs plain SQL Using index info to reconstruct a base tree... M Koha/Item.pm Falling back to patching base and 3-way merge... Auto-merging Koha/Item.pm CONFLICT (content): Merge conflict in Koha/Item.pm Failed to merge in the changes. Patch failed at 0001 Bug 19884: Add benchmark script to compare DBIC vs plain SQL About the test plan, is there something else to test or the only thing to do is run t/db_dependent/Items.t ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 14:21:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 12:21:13 +0000 Subject: [Koha-bugs] [Bug 14669] Search orders by managing library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14669 Alex Sassmannshausen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 14:21:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 12:21:16 +0000 Subject: [Koha-bugs] [Bug 14669] Search orders by managing library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14669 Alex Sassmannshausen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92343|0 |1 is obsolete| | --- Comment #14 from Alex Sassmannshausen --- Created attachment 93583 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93583&action=edit Bug 14669: Add search option for managing library to orders search Currently the order search can't be limited by managing library. The patch adds the search option to the order history search form and a column for the managing library to the search results table. To test: - Create some baskets with orders - Set managing library for some, but also have some without - Apply patch - prove t/db_dependent/Acquisition.t - Go to Aquisition > Orders search tab on top > Advanced search link - Search for orders without limiting Orders with and without managing library set should show up - Limit search to a specific managing library - Verify results match expectations -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 14:25:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 12:25:08 +0000 Subject: [Koha-bugs] [Bug 20334] Elasticsearch - Option for escaping slashes in search queries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85129|0 |1 is obsolete| | --- Comment #46 from David Gustafsson --- Created attachment 93584 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93584&action=edit Bug 20334 - Option for escaping slashes in search queries Add "QueryRegexEscapeOption" system preference to provide option to escape Elasticsearch regexp delimiters (/) within queries, or alternativly to unescape escaped slashes (\/) while escaping unescaped slashes, in effect making "\/" the new regexp delimiter. How to test: 1) Run tests in ./t/Koha/SearchEngine/ElasticSearch/QueryBuilder.t 2) All tests should succeed Signed-off-by: Nicolas Legrand Signed-off-by: Maksim Sen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 14:25:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 12:25:12 +0000 Subject: [Koha-bugs] [Bug 20334] Elasticsearch - Option for escaping slashes in search queries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85130|0 |1 is obsolete| | --- Comment #47 from David Gustafsson --- Created attachment 93585 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93585&action=edit Bug 20334: Improve syspref description and set more sensible defaults -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 14:25:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 12:25:16 +0000 Subject: [Koha-bugs] [Bug 20334] Elasticsearch - Option for escaping slashes in search queries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85131|0 |1 is obsolete| | --- Comment #48 from David Gustafsson --- Created attachment 93586 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93586&action=edit Bug 20334: Move new system preferene into right spot in alphabet -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 14:26:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 12:26:27 +0000 Subject: [Koha-bugs] [Bug 14669] Search orders by managing library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14669 Alex Sassmannshausen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 14:26:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 12:26:31 +0000 Subject: [Koha-bugs] [Bug 14669] Search orders by managing library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14669 Alex Sassmannshausen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93583|0 |1 is obsolete| | --- Comment #15 from Alex Sassmannshausen --- Created attachment 93587 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93587&action=edit Bug 14669: Add search option for managing library to orders search Currently the order search can't be limited by managing library. The patch adds the search option to the order history search form and a column for the managing library to the search results table. To test: - Create some baskets with orders - Set managing library for some, but also have some without - Apply patch - prove t/db_dependent/Acquisition.t - Go to Aquisition > Orders search tab on top > Advanced search link - Search for orders without limiting Orders with and without managing library set should show up - Limit search to a specific managing library - Verify results match expectations Signed-off-by: Alex Sassmannshausen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 14:28:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 12:28:17 +0000 Subject: [Koha-bugs] [Bug 23123] Status AVAILABLE and ORDERED for suggestions are not translated in the templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23123 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 14:53:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 12:53:40 +0000 Subject: [Koha-bugs] [Bug 23473] Allow passwords to be imported/overwritten using the patron import tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23473 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Signed Off |Failed QA --- Comment #4 from Katrin Fischer --- I am sorry, tests are not looking good on this one for me: Processing additional checks OK! kohadev-koha at kohadevbox:/home/vagrant/kohaclone$ prove t/db_dependent/Koha/Patrons/Import.t t/db_dependent/Koha/Patrons/Import.t .. 9/158 Argument "" isn't numeric in numeric eq (==) at /usr/share/perl5/DBIx/Class/Row.pm line 1018, <$handle_3a> line 2. Argument "" isn't numeric in numeric eq (==) at /usr/share/perl5/DBIx/Class/Row.pm line 1018, <$handle_3a> line 2. Argument "" isn't numeric in numeric eq (==) at /usr/share/perl5/DBIx/Class/Row.pm line 1018, <$handle_3a> line 2. Argument "" isn't numeric in numeric eq (==) at /usr/share/perl5/DBIx/Class/Row.pm line 1018. Argument "" isn't numeric in numeric eq (==) at /usr/share/perl5/DBIx/Class/Row.pm line 1018. Argument "" isn't numeric in numeric eq (==) at /usr/share/perl5/DBIx/Class/Row.pm line 1018. Argument "" isn't numeric in numeric eq (==) at /usr/share/perl5/DBIx/Class/Row.pm line 1018, <$handle_2> line 2. Argument "" isn't numeric in numeric eq (==) at /usr/share/perl5/DBIx/Class/Row.pm line 1018, <$handle_2> line 2. Argument "" isn't numeric in numeric eq (==) at /usr/share/perl5/DBIx/Class/Row.pm line 1018, <$handle_2> line 2. Argument "" isn't numeric in numeric eq (==) at /usr/share/perl5/DBIx/Class/Row.pm line 1018. Argument "" isn't numeric in numeric eq (==) at /usr/share/perl5/DBIx/Class/Row.pm line 1018. Argument "" isn't numeric in numeric eq (==) at /usr/share/perl5/DBIx/Class/Row.pm line 1018. # Looks like you planned 4 tests but ran 2. # Failed test 'test_import_with_password_overwrite' # at t/db_dependent/Koha/Patrons/Import.t line 468. [Password is too weak]# Looks like your test exited with 255 just after 151. t/db_dependent/Koha/Patrons/Import.t .. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 8/158 subtests Test Summary Report ------------------- t/db_dependent/Koha/Patrons/Import.t (Wstat: 65280 Tests: 151 Failed: 1) Failed test: 151 Non-zero exit status: 255 Parse errors: Bad plan. You planned 158 tests but ran 151. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 14:55:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 12:55:11 +0000 Subject: [Koha-bugs] [Bug 23542] SRU import encoding issue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23542 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sandboxes at biblibre.com Status|Needs Signoff |Signed Off --- Comment #4 from sandboxes at biblibre.com --- Patch tested with a sandbox, by Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 14:55:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 12:55:25 +0000 Subject: [Koha-bugs] [Bug 23542] SRU import encoding issue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23542 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92606|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 14:55:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 12:55:33 +0000 Subject: [Koha-bugs] [Bug 23542] SRU import encoding issue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23542 --- Comment #5 from sandboxes at biblibre.com --- Created attachment 93588 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93588&action=edit Bug 23542: fix SRU import ending issue When importing records from a SRU server, the diacritics have bad encoding. I reproduce with BNF server so it may be a UNIMARC issue. Looks like this does not affect autorities import for SRU server. In C4::Breeding::_handle_one_result(), in case of a Z39.50 server, when creating MARC::Record MarcToUTF8Record() is called which calls SetMarcUnicodeFlag(). This ensures that leader indicates UTF-8 encoding. Looking at MARC::Record->encoding() shows that encoding depends on leader even for UNIMARC. So this patch adds a call to SetMarcUnicodeFlag() in cas of a SRU server in C4::Breeding::_handle_one_result(). Test plan : 1) Use a UNIMARC database 2) Configure a connexion to a UNIMARC SRU, for example BNF, see https://doc.biblibre.com/koha/autour_de_koha/serveurs_z3950_sru#serveur_de_la_bnf 3) Go to cataloguing module 4) Click on 'New from Z39.50/SRU' 5) Choose only the SRU target 6) Search for ISBN 2266072889 7) Confirm you see good encoding : diacritic on 'a' of title 'Strate-a-gemmes' 8) Click on 'Marc preview' 9) Confirm you see good encoding 10) Click import 11) Confirm you see good encoding 12) Check SRU connexion on a MARC21 database is still OK Signed-off-by: Séverine QUEUNE Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 14:55:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 12:55:41 +0000 Subject: [Koha-bugs] [Bug 23729] New: Move CSS from moremember.tt template to staff global CSS Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23729 Bug ID: 23729 Summary: Move CSS from moremember.tt template to staff global CSS Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com trival patch but should move some CSS that is in the moremember.tt into the staff global CSS file. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 14:55:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 12:55:45 +0000 Subject: [Koha-bugs] [Bug 23589] Discharge notice does not show non-latin characters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23589 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #13 from Katrin Fischer --- (In reply to Theodoros Theodoropoulos from comment #12) > Test plan for QA > > 1/ If using Plack, make sure > https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23723 is applied. > Otherwise, produced PDF may not be properly encoded. > 2/ Go to System Preferences and set useDischarge: Allow > 3/ Create (or edit) a patron, entering non-latin characters for example in > Surname and/or First Name > 4/ In Tools->Notices & slips, make sure you use standard notice settings in > DISCHARGE, OR at least make sure you print <> and/or > <> > 5/ Goto Patron page -> discharges -> generate discharge > 6/ Produced PDF shows no data where <> and/or > <> should have appeared. > > 7/ apply patch > > 8/ Goto Patron page -> discharges -> generate discharge > 9/ Produced PDF properly shows the data from <> and/or > <> columns Perfect, thank you! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 14:55:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 12:55:54 +0000 Subject: [Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589 --- Comment #69 from David Gustafsson --- Wonderful, thanks everyone! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 15:00:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 13:00:44 +0000 Subject: [Koha-bugs] [Bug 23626] Add a system preference to limit the number of rows of data used when charting or exporting report results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23626 --- Comment #38 from Nick Clemens --- Created attachment 93589 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93589&action=edit Bug 23262: Use correct parameter in URL -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 15:01:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 13:01:19 +0000 Subject: [Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589 --- Comment #70 from Martin Renvoize --- Hmm, I think it's this one that causing a fair few breaks in tests on master right now.. I've narrowed down some of the issues.. for example I don't think we need the Koha::SearchFields->weighted_fields tests at all any more (you've removed the method entirely in your patch but missed this test). But, there are some more I'm less confident about.. can you guys take a look please? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 15:03:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 13:03:47 +0000 Subject: [Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589 --- Comment #71 from Martin Renvoize --- Created attachment 93590 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93590&action=edit Bug 20589: (RM follow-up) Fix Koha::SearchField.t This patch removes the unit test for the weighted_fields method which this bug removed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 15:06:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 13:06:43 +0000 Subject: [Koha-bugs] [Bug 23729] Move CSS from moremember.tt template to staff global CSS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23729 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 15:06:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 13:06:50 +0000 Subject: [Koha-bugs] [Bug 23729] Move CSS from moremember.tt template to staff global CSS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23729 --- Comment #1 from Lucas Gass --- Created attachment 93591 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93591&action=edit Bug 23729: Move CSS from moremember.tt template to staff global CSS TEST PLAN: 1. Make sure the system preference 'patronimages' is set to Allow. 2. Look at the patron details page. 3. Take note of the look of the page. 4. Open the patron image upload tool. 5. Make sure everything looks the same as it did before apply the patch. This patch should change nothing. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 15:07:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 13:07:28 +0000 Subject: [Koha-bugs] [Bug 22522] API authentication breaks with updated Mojolicious version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22522 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 15:07:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 13:07:33 +0000 Subject: [Koha-bugs] [Bug 22522] API authentication breaks with updated Mojolicious version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22522 --- Comment #7 from Magnus Enger --- Created attachment 93592 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93592&action=edit Bug 22522 - Update API specs' access in Auth.pm With newer versions of Mojolicious and its plugins, endpoints' specs could no longer be accessed, thus bypassing authorization checks and failing to validate query parameters. Test plan: 1. Without being logged in to Koha, access an endpoint directly (such as /api/v1/patrons/{patron_id}) 2. Notice results are received (which is bad since we're not authenticated) 3. Try again with an endpoint that accepts query parameters (such as /api/v1/patrons?firstname=something) 4. Notice that the query is not accepted (even with correct parameters) 5. Apply the patch 6. Repeat step 1 7. Notice that the access is denied 8. Login as a user with proper access rights 9. Repeat step 1 10. Notice that you can now get results 11. Repeat step 3 12. Notice that the query is now accepted 13. Repeat step 3 but with an absurd parameter 14. Notice the query is correctly rejected 15. Ideally, check if other API calls were not broken Signed-off-by: Magnus Enger Upgraded modules with: $ sudo cpanm Mojolicious JSON::Validator Mojolicious::Plugin::OpenAPI at 2.14 Before the patch data is returned without being logged in. Not good! After the patch: {"error":"Authentication failure."} -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 15:07:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 13:07:55 +0000 Subject: [Koha-bugs] [Bug 18309] UNIMARC update from IFLA In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18309 --- Comment #87 from Julian Maurice --- Created attachment 93593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93593&action=edit Bug 18309: Add missing fields in biblio framework 018 - [Reserved for other International Standard Numbers] 033 - Other System Persistent Record Identifier 183 - Coded Data Field: Type of Carrier 203 - Content Form and Media Type 231 - Digital File Characteristics 283 - Carrier Type 338 - Funding Information Note -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 15:09:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 13:09:15 +0000 Subject: [Koha-bugs] [Bug 23473] Allow passwords to be imported/overwritten using the patron import tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23473 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 15:09:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 13:09:19 +0000 Subject: [Koha-bugs] [Bug 23473] Allow passwords to be imported/overwritten using the patron import tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23473 --- Comment #5 from Nick Clemens --- Created attachment 93594 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93594&action=edit Bug 23473: (follow-up) Make passwords 'secure' for tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 15:11:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 13:11:53 +0000 Subject: [Koha-bugs] [Bug 19618] Add 'Club Holds' feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19618 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23710 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23710 [Bug 23710] Holds broken, displays a JSON page with an error -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 15:11:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 13:11:53 +0000 Subject: [Koha-bugs] [Bug 23710] Holds broken, displays a JSON page with an error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23710 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |19618 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19618 [Bug 19618] Add 'Club Holds' feature -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 15:17:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 13:17:40 +0000 Subject: [Koha-bugs] [Bug 20434] Updating Unimarc existing frameworks with IFLA updates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20434 Koha Team University Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha at univ-lyon3.fr --- Comment #30 from Koha Team University Lyon 3 --- I have an error while executing misc/migration_tools/ifla/update.pl DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key c onstraint fails (`koha_kohadev`.`auth_tag_structure`, CONSTRAINT `auth_tag_struc ture_ibfk_1` FOREIGN KEY (`authtypecode`) REFERENCES `auth_types` (`authtypecode `) ON DELETE CASCADE ON UPDATE CASCADE) [for Statement "INSERT INTO `auth_tag_st ructure` ( `authorised_value`, `authtypecode`, `liblibrarian`, `libopac`, `manda tory`, `repeatable`, `tagfield`) VALUES ( ?, ?, ?, ?, ?, ?, ? )" with ParamValue s: 0=undef, 1="CO", 2="PPN", 3="", 4="0", 5="0", 6="009"] at /usr/share/perl5/DB Ix/Class/Storage/DBI.pm line 1832. DBIx::Class::Storage::DBI::_dbh_execute(): Cannot add or update a child row: a f oreign key constraint fails (`koha_kohadev`.`auth_tag_structure`, CONSTRAINT `au th_tag_structure_ibfk_1` FOREIGN KEY (`authtypecode`) REFERENCES `auth_types` (` authtypecode`) ON DELETE CASCADE ON UPDATE CASCADE) at misc/migration_tools/ifla /update.pl line 285 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 15:17:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 13:17:48 +0000 Subject: [Koha-bugs] [Bug 23589] Discharge notice does not show non-latin characters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23589 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 15:17:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 13:17:57 +0000 Subject: [Koha-bugs] [Bug 23589] Discharge notice does not show non-latin characters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23589 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93413|0 |1 is obsolete| | --- Comment #14 from Katrin Fischer --- Created attachment 93595 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93595&action=edit Bug 23589: Discharge notice does not show non-latin characters It seems that discarge notices never got support for truetype fonts, so notices are missing non-latin characters. Signed-off-by: Theodoros Theodoropoulos Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 15:20:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 13:20:06 +0000 Subject: [Koha-bugs] [Bug 23473] Allow passwords to be imported/overwritten using the patron import tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23473 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Command-line Utilities |Tools -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 15:20:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 13:20:15 +0000 Subject: [Koha-bugs] [Bug 23473] Allow passwords to be imported/overwritten using the patron import tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23473 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 15:21:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 13:21:29 +0000 Subject: [Koha-bugs] [Bug 23730] New: Exporting reports is broken Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23730 Bug ID: 23730 Summary: Exporting reports is broken Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: blocker Priority: P5 - low Component: Reports Assignee: nick at bywatersolutions.com Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org bug 23390 changed the return values of get_prepped_report, I missed a call though -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 15:22:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 13:22:52 +0000 Subject: [Koha-bugs] [Bug 23730] Exporting reports is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23730 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 15:22:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 13:22:54 +0000 Subject: [Koha-bugs] [Bug 23730] Exporting reports is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23730 --- Comment #1 from Nick Clemens --- Created attachment 93596 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93596&action=edit Bug 23730: Fix export of reports To test: 1 - Run a saved report 2 - Attempt to export results 3 - It fails 4 - Apply patch 5 - It succeeds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 15:29:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 13:29:43 +0000 Subject: [Koha-bugs] [Bug 23731] New: Staff & OPAC both will display the DDC call number in XSLT but can't display the LC call number Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23731 Bug ID: 23731 Summary: Staff & OPAC both will display the DDC call number in XSLT but can't display the LC call number Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Bibliographic data support Assignee: koha-bugs at lists.koha-community.org Reporter: kelly at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Created attachment 93597 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93597&action=edit staff view When looking at the display of the Bib record in both the staff and OPAC, the DDC number will display by default. However, there is no way for an LC number to display. It would be nice if they both displayed and the library could choose to hide one or both. Currently, it appears that it is displaying the 082 and 084, we would like to see it also display the 090 or 050 (or both) by default. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 15:32:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 13:32:08 +0000 Subject: [Koha-bugs] [Bug 23732] New: Hold rules checker: show matched rules and syspref values to help understand why a hold is possible or not Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23732 Bug ID: 23732 Summary: Hold rules checker: show matched rules and syspref values to help understand why a hold is possible or not Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: victor.grousset at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 15:34:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 13:34:10 +0000 Subject: [Koha-bugs] [Bug 23039] Hold found modal on checkin screen ( circulation.pl ) obscures Check in message info In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23039 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 15:34:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 13:34:13 +0000 Subject: [Koha-bugs] [Bug 23039] Hold found modal on checkin screen ( circulation.pl ) obscures Check in message info In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23039 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93047|0 |1 is obsolete| | Attachment #93048|0 |1 is obsolete| | --- Comment #18 from Kyle M Hall --- Created attachment 93598 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93598&action=edit Bug 23039: Hold found modal on checkin screen ( circulation.pl ) obscures Check in message info This patch modifies the checkin process so that any errors or messages related to the current checkin are displayed in any hold/transit modal which is displayed. This prevents any information from being hidden by the modal. This patch also adds an "information" button to the checkout form which the user can click to redisplay the last modal which was dismissed (unless confirming the modal reloads the page). To test, apply the patch and rebuild the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Test the checkin process with various types of items: - Item not checked out - Item not checked out, on hold - Item not checked out, needs to be transferred - Item is marked lost, needs to be transferred - Item checked out, patron has waiting holds (with WaitingNotifyAtCheckin enabled) - Item checked out, patron has outstanding fines (with FineNotifyAtCheckin enabled) - Test that the modal redisplay button works in cases where the modal is dismissed without triggering a page reload: - Hold confirmation -> Ignore - Transfer confirmation -> OK Signed-off-by: Nick Clemens Signed-off-by: Bouzid Fergani Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 15:34:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 13:34:37 +0000 Subject: [Koha-bugs] [Bug 23039] Hold found modal on checkin screen ( circulation.pl ) obscures Check in message info In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23039 --- Comment #19 from Kyle M Hall --- Created attachment 93599 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93599&action=edit Bug 23039: Don't hide the checkin dialogs Signed-off-by: Nick Clemens Signed-off-by: Bouzid Fergani Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 15:36:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 13:36:52 +0000 Subject: [Koha-bugs] [Bug 23730] Exporting reports is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23730 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 15:36:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 13:36:58 +0000 Subject: [Koha-bugs] [Bug 23730] Exporting reports is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23730 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93596|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer --- Created attachment 93600 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93600&action=edit Bug 23730: Fix export of reports To test: 1 - Run a saved report 2 - Attempt to export results 3 - It fails 4 - Apply patch 5 - It succeeds Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 15:38:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 13:38:55 +0000 Subject: [Koha-bugs] [Bug 23730] Exporting reports is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23730 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 15:41:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 13:41:45 +0000 Subject: [Koha-bugs] [Bug 17179] Advanced editor: Add keyboard shortcuts to repeat (duplicate) a field, and cut text In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17179 Alex Sassmannshausen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 15:41:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 13:41:48 +0000 Subject: [Koha-bugs] [Bug 17179] Advanced editor: Add keyboard shortcuts to repeat (duplicate) a field, and cut text In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17179 Alex Sassmannshausen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92406|0 |1 is obsolete| | --- Comment #15 from Alex Sassmannshausen --- Created attachment 93601 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93601&action=edit Bug 17179: Add keyboard shortcuts to repeat (duplicate) a field, and cut text This patchset introduces an internal clipboard to the advanced editor and provides some new functionality to make use of this, default shortcuts are provided but can be edited per bug 21411 The default shortcuts for new/changed functions are: Changed: Ctrl-X: Now cuts a line into the clipboard area Shift-Ctrl-X: Now cuts current subfield into clipboard area Added: Ctrl-C: Copies a line into the clipboard area Shift-Ctrl-C: Copies current subfield into clipboard area Ctrl-P: Pastes the selected item from the clipboard at cursor Ctrl-I: Copies the current line and inserts onto a new line below To test: Verify all functionality above and confirm it behaves as expected Note: Ctrl-v pastes from the system clipboard - codemirror does not have access and this is why we use our "Clipboard" For browser cut/paste please use mouse right click or context menus Ctrl-P can be accessed as print by focusing outside the editor window Signed-off-by: Alex Sassmannshausen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 15:42:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 13:42:53 +0000 Subject: [Koha-bugs] [Bug 17179] Advanced editor: Add keyboard shortcuts to repeat (duplicate) a field, and cut text In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17179 --- Comment #16 from Alex Sassmannshausen --- Created attachment 93602 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93602&action=edit Bug 17179: (follow-up) Correct typos, add default select. Correct error whereby object curCursor was invoked as a function. Added action whereby the most recent entry in the clipboard is selected after all copy and cut operations. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 15:44:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 13:44:01 +0000 Subject: [Koha-bugs] [Bug 23733] New: Passwort import explodes when password is to 'weak' Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23733 Bug ID: 23733 Summary: Passwort import explodes when password is to 'weak' Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org This appears to be a recent change - the patron import explodes on a password too weak, even as it's not set to overwrite them. [Password is too weak] at /usr/share/perl5/Exception/Class/Base.pm line 88 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 15:44:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 13:44:23 +0000 Subject: [Koha-bugs] [Bug 23733] Passwort import explodes when password is too 'weak' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23733 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Passwort import explodes |Passwort import explodes |when password is to 'weak' |when password is too 'weak' -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 15:45:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 13:45:52 +0000 Subject: [Koha-bugs] [Bug 21301] Restriction of the informations given by GetRecords ILS-DI service In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21301 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 15:45:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 13:45:55 +0000 Subject: [Koha-bugs] [Bug 21301] Restriction of the informations given by GetRecords ILS-DI service In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21301 --- Comment #2 from Fridolin SOMERS --- Created attachment 93603 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93603&action=edit Bug 21301: Remove patron informations in reserves for GetRecords ILS-DI service Actually, the GetRecords service gives many information : borrowernumber (reserves field) The issue data should not be sent by these service, its a privacy problem. Test plan : 1) Enable ILS-DI webservice 2) Place hold on an item 3) Go to {opac}/cgi-bin/koha/ilsdi.pl?service=GetRecords&id={biblionumber} 4) Check the reserves tag content -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 15:47:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 13:47:46 +0000 Subject: [Koha-bugs] [Bug 23733] Passwort import explodes when password is too 'weak' and doesn't allow empty passwords anymore In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23733 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major Summary|Passwort import explodes |Passwort import explodes |when password is too 'weak' |when password is too 'weak' | |and doesn't allow empty | |passwords anymore --- Comment #1 from Katrin Fischer --- Addition: I turned off RequireStrongPassword and tried importing an empty password and it also explodes: Password length (0) is shorter than required (3) at /usr/share/perl5/Exception/Class/Base.pm line 88 There is a use case for importing patrons without a password. Instead of setting some potentially unsafe or unknown default password, you can then have them set their own in the opac using the password reset feature. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 15:47:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 13:47:59 +0000 Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous payments in a POS fashion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93465|0 |1 is obsolete| | --- Comment #49 from Martin Renvoize --- Created attachment 93604 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93604&action=edit Bug 23354: Add a Point Of Sale 'pay' screen This patch adds a new Point Of Sale module to Koha's staff client front page. The module button leads directly to a 'Pay' page giving the staff user the ability to record anonymous payments for items that would not normally require a patron to be registered at the library. Test plan: 1) Enable `UseCashRegisters` via the system preferences. 2) Ensure your user has the 'manage_cash_registers' permission. 3) Add a cash register for your current branch. 4) Add at least one 'MANUAL_INV' authorized value. 5) Navigate to the new 'POS' pay page via the main menu. 6) Add an item to the 'sale' by clicking 'add' from the right side of the screen. 7) Note that said item was added to the table of items this sale on the left. 8) At this point you should be able to 'click to edit' the quantity or price of the item in the table on the left. 9) Enter an amount greater than the price of the item into the 'amount collected from patron' box. 10) Click 'Confirm' 11) Varify that the same change to give modal from the paycollect pages appears here. 12) Click 'Confirm' 13) Payment will have been recorded (check the database) and you will be back at a fresh 'Pay' page ready for the next transaction. 14) Signoff Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 15:48:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 13:48:03 +0000 Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous payments in a POS fashion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93466|0 |1 is obsolete| | --- Comment #50 from Martin Renvoize --- Created attachment 93605 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93605&action=edit Bug 23354: Add receipting to Pay page This patch adds receipt printing to the new Point of Sale pay page. Test plan: 1) Apply patch and run database update 2) Enable automatic receipt printing via the `` system preference. 3) Make a payment for an item via the new POS pay page. 4) Note that a receipt printing dialogue is shown automatically after payment. 5) Note that a new notice is available under tools where you can alter the content of the receipt. 6) Signoff Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 15:48:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 13:48:07 +0000 Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous payments in a POS fashion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93467|0 |1 is obsolete| | --- Comment #51 from Martin Renvoize --- Created attachment 93606 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93606&action=edit Bug 23354: Add ability to remove items This patch adds the ability to remove items from a transactions on the new Point of Sale pay page. Test plan: 1) Populate a transaction with at least one item. 2) Note the new button to 'Remove item' on the items table. 3) Click the button and confirm the item is removed 4) Signoff Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 15:48:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 13:48:10 +0000 Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous payments in a POS fashion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93468|0 |1 is obsolete| | --- Comment #52 from Martin Renvoize --- Created attachment 93607 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93607&action=edit Bug 23354: (follow-up) Responses to feedback This patch impliments a number of refinements requested after the first round of feedback from the sponsors. 1) Fix padding on pay page 2) Switch 'items to add' from right to left on the page 3) Fix editable columns on pay page 4) Add explanitory text to pay page Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 15:48:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 13:48:14 +0000 Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous payments in a POS fashion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93469|0 |1 is obsolete| | --- Comment #53 from Martin Renvoize --- Created attachment 93608 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93608&action=edit Bug 23354: Add permissions Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 15:48:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 13:48:17 +0000 Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous payments in a POS fashion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93470|0 |1 is obsolete| | --- Comment #54 from Martin Renvoize --- Created attachment 93609 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93609&action=edit Bug 23354: Add tests for Koha::Charges::Sales Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 15:48:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 13:48:21 +0000 Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous payments in a POS fashion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93472|0 |1 is obsolete| | --- Comment #55 from Martin Renvoize --- Created attachment 93610 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93610&action=edit Bug 23354: (follow-up) Input type on jEditable Update the jEditable plugin to a maintained version and use the new 'number' type to enable increment arrows on click and remap onblur event to submit. Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 15:48:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 13:48:25 +0000 Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous payments in a POS fashion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93473|0 |1 is obsolete| | --- Comment #56 from Martin Renvoize --- Created attachment 93611 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93611&action=edit Bug 23354: (follow-up) Use 'format_price' for totals Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 15:48:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 13:48:28 +0000 Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous payments in a POS fashion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 --- Comment #57 from Martin Renvoize --- Created attachment 93612 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93612&action=edit Bug 23354: Add Icon for POS system -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 15:49:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 13:49:09 +0000 Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous payments in a POS fashion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93471|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 15:54:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 13:54:53 +0000 Subject: [Koha-bugs] [Bug 17229] ILS-DI HoldTitle and HoldItem should check if patron is expired In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |BLOCKED Depends on| |23710 CC| |magnus at libriotech.no --- Comment #35 from Magnus Enger --- This can not really be tested before this bug is fixed: Bug 23710 - Holds broken, displays a JSON page with an error Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23710 [Bug 23710] Holds broken, displays a JSON page with an error -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 15:54:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 13:54:53 +0000 Subject: [Koha-bugs] [Bug 23710] Holds broken, displays a JSON page with an error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23710 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17229 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229 [Bug 17229] ILS-DI HoldTitle and HoldItem should check if patron is expired -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 15:54:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 13:54:54 +0000 Subject: [Koha-bugs] [Bug 23444] Terminology: Use library instead of branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23444 Alex Sassmannshausen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 15:54:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 13:54:59 +0000 Subject: [Koha-bugs] [Bug 23444] Terminology: Use library instead of branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23444 Alex Sassmannshausen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92136|0 |1 is obsolete| | --- Comment #3 from Alex Sassmannshausen --- Created attachment 93613 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93613&action=edit Bug 23444: Terminology - Use library instead of branch This changes some strings in the templates for: - Receiving orders (creating items on receive) Home branch -> Home library Holding branch -> Current location (matches item display in staff) - Callnumber browser item value builder plugin Branch -> Library - Accounts wizard in reports Transaction branch -> Transaction library - Serials wizard in reports Branch -> Library Also fixes 2 capitalization issues: Subscription id -> Subscription ID Call Number -> Call number Signed-off-by: Alex Sassmannshausen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 15:57:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 13:57:58 +0000 Subject: [Koha-bugs] [Bug 23473] Allow passwords to be imported/overwritten using the patron import tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23473 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #6 from Katrin Fischer --- No matter if the checkbox is checked or not, the password is overwritten. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 15:58:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 13:58:52 +0000 Subject: [Koha-bugs] [Bug 20434] Updating Unimarc existing frameworks with IFLA updates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20434 --- Comment #31 from Julian Maurice --- Created attachment 93614 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93614&action=edit Bug 20434: Add missing authority types -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 16:00:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 14:00:21 +0000 Subject: [Koha-bugs] [Bug 20434] Updating Unimarc existing frameworks with IFLA updates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20434 --- Comment #32 from Julian Maurice --- (In reply to Koha Team University Lyon 3 from comment #30) > I have an error while executing misc/migration_tools/ifla/update.pl The last patch should fix this. Please test again -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 16:01:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 14:01:45 +0000 Subject: [Koha-bugs] [Bug 23611] Add export option to authorized values administration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23611 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 16:01:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 14:01:47 +0000 Subject: [Koha-bugs] [Bug 23611] Add export option to authorized values administration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23611 --- Comment #7 from Owen Leonard --- Created attachment 93615 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93615&action=edit Bug 23611: (follow-up) Exclude "actions" column from export This patch adds a missing "noExport" class to ensure that the "actions" column isn't included in export and print views. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 16:02:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 14:02:22 +0000 Subject: [Koha-bugs] [Bug 23734] New: Defaults set during patron imports throws warnings Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23734 Bug ID: 23734 Summary: Defaults set during patron imports throws warnings Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org To recreate: Create a small import file, with minimal columns, tail the logs, import and note warnings IN DBIX/Class/Row: elsif ($self->_is_column_numeric($col)) { # do a numeric comparison if datatype allows it return $old == $new; But in Koha/Patrons/Import.pm We assume "" for all defaults Even if we pass defaults of '0' for these columns elsif ( $defaults->{$key} ) { won't be triggered by a 0 value, it should be 'exists' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 16:02:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 14:02:38 +0000 Subject: [Koha-bugs] [Bug 23734] Defaults set during patron imports throws warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23734 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de, | |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 16:04:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 14:04:45 +0000 Subject: [Koha-bugs] [Bug 23677] Add route to get a bibliographic record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23677 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki at biblibre.com --- Comment #10 from Arthur Suzuki --- Hi Tomas, Here are the results for the qa-tools, over than that everything (unit test and manual testing) working perfectly thanks! curl http://localhost:8080/api/v1/biblios/4 \ -H 'Accept: application/json' > Gives back expected results :) testing 4 commit(s) (applied to 98e4b5c '4a Bug 23537: Overdrive won't show co') Processing files before patches |========================>| 4 / 4 (100.00%) Processing files after patches |========================>| 4 / 4 (100.00%) OK C4/Installer/PerlDependencies.pm OK critic OK forbidden patterns OK git manipulation OK pod OK pod coverage OK spelling OK valid FAIL Koha/REST/V1/Biblios.pm FAIL critic # Variables::ProhibitConditionalDeclarations: Got 1 violation(s). OK forbidden patterns OK git manipulation OK pod OK pod coverage OK spelling OK valid OK Koha/Schema/Result/Biblio.pm OK critic OK forbidden patterns OK git manipulation OK pod OK pod coverage OK spelling OK valid OK t/db_dependent/api/v1/biblios.t OK critic OK forbidden patterns OK git manipulation OK pod OK spelling OK valid -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 16:05:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 14:05:45 +0000 Subject: [Koha-bugs] [Bug 21892] Robin Sheat is not a typo In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21892 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at libriotech.no Status|Needs Signoff |Failed QA --- Comment #18 from Magnus Enger --- Looks like the main patch here was pushed, then reverted. If that is correct, the status should probably not be NSO. Resetting to FQA. Feel free to correct me. :-) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 16:10:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 14:10:23 +0000 Subject: [Koha-bugs] [Bug 20884] Stale data remaining in cache after koha-remove In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20884 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |magnus at libriotech.no --- Comment #6 from Magnus Enger --- I dont like "memcached restart" for this. We have many Koha instances on the same server, all using the same memcached instance. We also have SessionStorage = memcached. This means that if we remove an instance, memcached will be restarted and every user of every Koha instance will be logged out. If it is possible to just flush the cash of the removed site that would be much better. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 16:11:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 14:11:49 +0000 Subject: [Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551 Eric Bégin changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |eric.begin at inLibro.com --- Comment #19 from Eric Bégin --- Test during hackfest 2019 error: sha1 information is lacking or useless (Koha/Exporter/Record.pm). error: could not build fake ancestor Patch failed at 0001 Bug 20551: Rename "marcflavour" field to "schema" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 16:16:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 14:16:52 +0000 Subject: [Koha-bugs] [Bug 23533] Reindent patron entry form (memberentrygen.tt) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23533 Jesse Maseto changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jesse at bywatersolutions.com --- Comment #6 from Jesse Maseto --- Patch did not apply. Merge conflicts. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 16:20:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 14:20:46 +0000 Subject: [Koha-bugs] [Bug 23611] Add export option to authorized values administration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23611 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 16:21:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 14:21:04 +0000 Subject: [Koha-bugs] [Bug 23611] Add export option to authorized values administration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23611 --- Comment #8 from Katrin Fischer --- Created attachment 93616 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93616&action=edit Bug 23611: Add export option to authorized values administration This patch changes the authorized values DataTables configuration to add export options. To test apply the patch and go to Administration -> Authorized values. Test the "Export" button and confirm that the data is exported correctly with each option. Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 16:21:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 14:21:15 +0000 Subject: [Koha-bugs] [Bug 23611] Add export option to authorized values administration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23611 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93501|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer --- Created attachment 93617 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93617&action=edit Bug 23611: (follow-up) Correct ID of table The DataTable configuration wasn't working on the table showing an individual category's authorized values because of a mismatch in the table id. This patch corrects it. To test, apply the patch and view the "Authorized values" page. The initial list of categories should be displayed as a DataTable. Click through to see the values defined for any category. The resulting table of values should also be a functioning DataTable. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 16:21:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 14:21:18 +0000 Subject: [Koha-bugs] [Bug 23611] Add export option to authorized values administration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23611 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93615|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer --- Created attachment 93618 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93618&action=edit Bug 23611: (follow-up) Exclude "actions" column from export This patch adds a missing "noExport" class to ensure that the "actions" column isn't included in export and print views. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 16:22:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 14:22:23 +0000 Subject: [Koha-bugs] [Bug 23521] ES 6 - limit terms with many words can make the search inaccurate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23521 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #2 from Fridolin SOMERS --- See doc : https://www.elastic.co/guide/en/elasticsearch/reference/6.8/query-dsl-query-string-query.html -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 16:23:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 14:23:11 +0000 Subject: [Koha-bugs] [Bug 23521] ES 6 - limit terms with many words can make the search inaccurate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23521 --- Comment #3 from Fridolin SOMERS --- (In reply to Fridolin SOMERS from comment #2) > See doc : > > https://www.elastic.co/guide/en/elasticsearch/reference/6.8/query-dsl-query- > string-query.html You see an example of query containing parenthesis ofr terms with many words -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 16:24:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 14:24:44 +0000 Subject: [Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90184|0 |1 is obsolete| | --- Comment #20 from David Gustafsson --- Created attachment 93619 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93619&action=edit Bug 20551: Add option for including deleted records in export_records.pl Add option "--include_deleted" to include deleted biblios in export_records.pl as marc records with record status (in leader) set to "d" and "--deleted_only" to export only deleted biblios. How to test: 1) Run tests in t/db_dependent/Exporter/Record.t 2) All tests should pass 3) Delete a biblio record in Koha 4) Run the export script as: `export_records.pl --date= --include_deleted` 5) Open the generated koha.mrc, and verify that contains the recently deleted record, and that the record header has record status "d". 6) Perform the same check with: `export_records.pl --date= --include_deleted --format=xml` 7) Run: `export_records.pl --date= --deleted_only --format=xml` and verify that only the deleted biblio was included in the export. Sponsored-by: Gothenburg University Library -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 16:24:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 14:24:49 +0000 Subject: [Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90190|0 |1 is obsolete| | --- Comment #21 from David Gustafsson --- Created attachment 93620 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93620&action=edit Bug 20551: Fix option name in pod -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 16:24:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 14:24:52 +0000 Subject: [Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90220|0 |1 is obsolete| | --- Comment #22 from David Gustafsson --- Created attachment 93621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93621&action=edit Bug 20551: Rename "marcflavour" field to "schema" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 16:25:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 14:25:25 +0000 Subject: [Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #23 from David Gustafsson --- Should now be rebased against master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 16:30:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 14:30:26 +0000 Subject: [Koha-bugs] [Bug 23677] Add route to get a bibliographic record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23677 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 16:30:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 14:30:28 +0000 Subject: [Koha-bugs] [Bug 23677] Add route to get a bibliographic record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23677 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93174|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 16:30:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 14:30:31 +0000 Subject: [Koha-bugs] [Bug 23677] Add route to get a bibliographic record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23677 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93175|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 16:30:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 14:30:48 +0000 Subject: [Koha-bugs] [Bug 23677] Add route to get a bibliographic record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23677 --- Comment #11 from Tomás Cohen Arazi --- Created attachment 93622 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93622&action=edit Bug 23677: Controller method and dependencies tweak -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 16:30:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 14:30:55 +0000 Subject: [Koha-bugs] [Bug 23677] Add route to get a bibliographic record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23677 --- Comment #12 from Tomás Cohen Arazi --- Created attachment 93623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93623&action=edit Bug 23677: Unit tests This patch introduces tests for the GET /biblios/{biblio_id} endpoint. It tries to cover all the use cases. To test: - Apply this patchset - Run: $ kshell k$ prove t/db_dependent/api/v1/biblios.t => SUCCESS: Tests pass! - Use Postman (or your favourite tool) to test the API => SUCCESS: Works as expected! - Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 16:31:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 14:31:38 +0000 Subject: [Koha-bugs] [Bug 23677] Add route to get a bibliographic record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23677 --- Comment #13 from Tomás Cohen Arazi --- (In reply to Arthur Suzuki from comment #10) > Hi Tomas, > Here are the results for the qa-tools, over than that everything (unit test > and manual testing) working perfectly thanks! > > curl http://localhost:8080/api/v1/biblios/4 \ -H 'Accept: application/json' > > > Gives back expected results :) Awesome! Thanks! > FAIL Koha/REST/V1/Biblios.pm > FAIL critic > # Variables::ProhibitConditionalDeclarations: Got 1 violation(s). Fixed! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 16:32:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 14:32:30 +0000 Subject: [Koha-bugs] [Bug 17005] REST API: add routes to list checkouts history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 --- Comment #58 from Katrin Fischer --- Patch still applies - pinging Tomas about this one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 16:34:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 14:34:35 +0000 Subject: [Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 --- Comment #175 from Katrin Fischer --- Patches still apply, what do we need to be able to continue here? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 16:42:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 14:42:26 +0000 Subject: [Koha-bugs] [Bug 21858] RFC: Notices and slips documentation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21858 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |WONTFIX --- Comment #3 from Katrin Fischer --- We discussed this at a meeting and if I remember correctly we had voted for the manual instead of having a separate file. Closing this as a WONTFIX for now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 16:42:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 14:42:43 +0000 Subject: [Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589 --- Comment #72 from Nick Clemens --- Created attachment 93624 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93624&action=edit Bug 20589: (follow-up) Fix tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 16:44:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 14:44:18 +0000 Subject: [Koha-bugs] [Bug 21580] Order creation for EDIFACT vendor fails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21580 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Summary|Order creation for edifact |Order creation for EDIFACT |vendor fails |vendor fails -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 16:44:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 14:44:46 +0000 Subject: [Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589 --- Comment #73 from Nick Clemens --- (In reply to Martin Renvoize from comment #70) > Hmm, I think it's this one that causing a fair few breaks in tests on master > right now.. > > I've narrowed down some of the issues.. for example I don't think we need > the Koha::SearchFields->weighted_fields tests at all any more (you've > removed the method entirely in your patch but missed this test). > > But, there are some more I'm less confident about.. can you guys take a look > please? I attached a patch, I think the mappings test is probably not the best, but I think we should delete/replace it on its own bug, this gets things running again for now -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 16:50:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 14:50:59 +0000 Subject: [Koha-bugs] [Bug 14293] Error in the calculation of the suspension of users per day In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14293 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23382 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 16:50:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 14:50:59 +0000 Subject: [Koha-bugs] [Bug 23382] Issuing rules failing after bug 20912 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14293 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 16:52:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 14:52:55 +0000 Subject: [Koha-bugs] [Bug 21245] Move 'Last patron' button inside of the 'breadcrumb' bar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21245 Eric Bégin changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eric.begin at inLibro.com Status|Needs Signoff |Signed Off --- Comment #8 from Eric Bégin --- To test : - Apply the patch - Make sure your showLastPatron syspref is set to Show - Update the CSS using 'yarn build' command to update the CSS from the SCSS - Access a patron account - Go on the home page You should now see the Last patron's button. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 16:54:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 14:54:16 +0000 Subject: [Koha-bugs] [Bug 18309] UNIMARC update from IFLA In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18309 Koha Team University Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93291|0 |1 is obsolete| | --- Comment #88 from Koha Team University Lyon 3 --- Created attachment 93625 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93625&action=edit Bug 18309: UNIMARC update from IFLA - authority (fr) (default framework) Signed-off-by: Sonia BOUIS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 16:54:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 14:54:23 +0000 Subject: [Koha-bugs] [Bug 18309] UNIMARC update from IFLA In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18309 Koha Team University Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93292|0 |1 is obsolete| | --- Comment #89 from Koha Team University Lyon 3 --- Created attachment 93626 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93626&action=edit Bug 18309: UNIMARC update from IFLA - authority (fr) (CLASS) Signed-off-by: Sonia BOUIS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 16:54:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 14:54:29 +0000 Subject: [Koha-bugs] [Bug 18309] UNIMARC update from IFLA In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18309 Koha Team University Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93293|0 |1 is obsolete| | --- Comment #90 from Koha Team University Lyon 3 --- Created attachment 93627 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93627&action=edit Bug 18309: UNIMARC update from IFLA - authority (fr) (CO) Signed-off-by: Sonia BOUIS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 16:54:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 14:54:35 +0000 Subject: [Koha-bugs] [Bug 18309] UNIMARC update from IFLA In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18309 Koha Team University Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93294|0 |1 is obsolete| | --- Comment #91 from Koha Team University Lyon 3 --- Created attachment 93628 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93628&action=edit Bug 18309: UNIMARC update from IFLA - authority (fr) (EXP) Signed-off-by: Sonia BOUIS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 16:54:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 14:54:40 +0000 Subject: [Koha-bugs] [Bug 18309] UNIMARC update from IFLA In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18309 Koha Team University Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93295|0 |1 is obsolete| | --- Comment #92 from Koha Team University Lyon 3 --- Created attachment 93629 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93629&action=edit Bug 18309: UNIMARC update from IFLA - authority (fr) (NTEXP) Signed-off-by: Sonia BOUIS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 16:54:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 14:54:45 +0000 Subject: [Koha-bugs] [Bug 18309] UNIMARC update from IFLA In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18309 Koha Team University Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93296|0 |1 is obsolete| | --- Comment #93 from Koha Team University Lyon 3 --- Created attachment 93630 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93630&action=edit Bug 18309: UNIMARC update from IFLA - authority (fr) (NTWORK) Signed-off-by: Sonia BOUIS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 16:54:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 14:54:50 +0000 Subject: [Koha-bugs] [Bug 18309] UNIMARC update from IFLA In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18309 Koha Team University Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93297|0 |1 is obsolete| | --- Comment #94 from Koha Team University Lyon 3 --- Created attachment 93631 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93631&action=edit Bug 18309: UNIMARC update from IFLA - authority (fr) (PERS) Signed-off-by: Sonia BOUIS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 16:54:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 14:54:59 +0000 Subject: [Koha-bugs] [Bug 18309] UNIMARC update from IFLA In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18309 Koha Team University Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93298|0 |1 is obsolete| | --- Comment #95 from Koha Team University Lyon 3 --- Created attachment 93632 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93632&action=edit Bug 18309: UNIMARC update from IFLA - authority (fr) (PUB) Signed-off-by: Sonia BOUIS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 16:55:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 14:55:04 +0000 Subject: [Koha-bugs] [Bug 18309] UNIMARC update from IFLA In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18309 Koha Team University Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93299|0 |1 is obsolete| | --- Comment #96 from Koha Team University Lyon 3 --- Created attachment 93633 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93633&action=edit Bug 18309: UNIMARC update from IFLA - authority (fr) (TU) Signed-off-by: Sonia BOUIS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 16:55:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 14:55:08 +0000 Subject: [Koha-bugs] [Bug 18309] UNIMARC update from IFLA In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18309 Koha Team University Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93300|0 |1 is obsolete| | --- Comment #97 from Koha Team University Lyon 3 --- Created attachment 93634 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93634&action=edit Bug 18309: UNIMARC update from IFLA - authority (fr) (WORK) Signed-off-by: Sonia BOUIS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 16:55:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 14:55:17 +0000 Subject: [Koha-bugs] [Bug 18309] UNIMARC update from IFLA In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18309 Koha Team University Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93301|0 |1 is obsolete| | Attachment #93303|0 |1 is obsolete| | --- Comment #98 from Koha Team University Lyon 3 --- Created attachment 93635 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93635&action=edit Bug 18309: UNIMARC update from IFLA - authority (fr) (FAM) Signed-off-by: Sonia BOUIS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 16:55:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 14:55:22 +0000 Subject: [Koha-bugs] [Bug 18309] UNIMARC update from IFLA In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18309 Koha Team University Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93302|0 |1 is obsolete| | --- Comment #99 from Koha Team University Lyon 3 --- Created attachment 93636 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93636&action=edit Bug 18309: UNIMARC update from IFLA - authority (fr) (GENRE/FORM) Signed-off-by: Sonia BOUIS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 16:55:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 14:55:27 +0000 Subject: [Koha-bugs] [Bug 18309] UNIMARC update from IFLA In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18309 --- Comment #100 from Koha Team University Lyon 3 --- Created attachment 93637 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93637&action=edit Bug 18309: UNIMARC update from IFLA - authority (fr) (FAM) Signed-off-by: Sonia BOUIS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 16:55:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 14:55:31 +0000 Subject: [Koha-bugs] [Bug 18309] UNIMARC update from IFLA In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18309 Koha Team University Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93304|0 |1 is obsolete| | --- Comment #101 from Koha Team University Lyon 3 --- Created attachment 93638 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93638&action=edit Bug 18309: UNIMARC update from IFLA - authority (fr) (NP) Signed-off-by: Sonia BOUIS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 16:55:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 14:55:36 +0000 Subject: [Koha-bugs] [Bug 18309] UNIMARC update from IFLA In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18309 Koha Team University Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93305|0 |1 is obsolete| | --- Comment #102 from Koha Team University Lyon 3 --- Created attachment 93639 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93639&action=edit Bug 18309: UNIMARC update from IFLA - authority (fr) (PA) Signed-off-by: Sonia BOUIS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 16:55:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 14:55:41 +0000 Subject: [Koha-bugs] [Bug 18309] UNIMARC update from IFLA In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18309 Koha Team University Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93306|0 |1 is obsolete| | --- Comment #103 from Koha Team University Lyon 3 --- Created attachment 93640 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93640&action=edit Bug 18309: UNIMARC update from IFLA - authority (fr) (SAUTTIT) Signed-off-by: Sonia BOUIS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 16:55:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 14:55:46 +0000 Subject: [Koha-bugs] [Bug 18309] UNIMARC update from IFLA In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18309 Koha Team University Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93307|0 |1 is obsolete| | --- Comment #104 from Koha Team University Lyon 3 --- Created attachment 93641 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93641&action=edit Bug 18309: UNIMARC update from IFLA - authority (fr) (SNC) Signed-off-by: Sonia BOUIS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 16:55:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 14:55:51 +0000 Subject: [Koha-bugs] [Bug 18309] UNIMARC update from IFLA In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18309 Koha Team University Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93309|0 |1 is obsolete| | --- Comment #105 from Koha Team University Lyon 3 --- Created attachment 93642 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93642&action=edit Bug 18309: UNIMARC update from IFLA - authority (fr) (SNG) Signed-off-by: Sonia BOUIS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 16:55:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 14:55:58 +0000 Subject: [Koha-bugs] [Bug 18309] UNIMARC update from IFLA In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18309 Koha Team University Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93310|0 |1 is obsolete| | --- Comment #106 from Koha Team University Lyon 3 --- Created attachment 93643 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93643&action=edit Bug 18309: UNIMARC update from IFLA - authority (fr) (TM) Signed-off-by: Sonia BOUIS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 16:56:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 14:56:02 +0000 Subject: [Koha-bugs] [Bug 18309] UNIMARC update from IFLA In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18309 Koha Team University Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93311|0 |1 is obsolete| | --- Comment #107 from Koha Team University Lyon 3 --- Created attachment 93644 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93644&action=edit Bug 18309: UNIMARC update from IFLA - authority (fr) (AUTTIT) Signed-off-by: Sonia BOUIS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 16:56:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 14:56:07 +0000 Subject: [Koha-bugs] [Bug 18309] UNIMARC update from IFLA In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18309 Koha Team University Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93312|0 |1 is obsolete| | --- Comment #108 from Koha Team University Lyon 3 --- Created attachment 93645 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93645&action=edit Bug 18309: UNIMARC update from IFLA - authority (fr) (CO_UNI_TI) Signed-off-by: Sonia BOUIS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 16:56:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 14:56:12 +0000 Subject: [Koha-bugs] [Bug 18309] UNIMARC update from IFLA In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18309 Koha Team University Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93313|0 |1 is obsolete| | --- Comment #109 from Koha Team University Lyon 3 --- Created attachment 93646 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93646&action=edit Bug 18309: UNIMARC update from IFLA - authority (fr) (FA) Signed-off-by: Sonia BOUIS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 16:56:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 14:56:18 +0000 Subject: [Koha-bugs] [Bug 18309] UNIMARC update from IFLA In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18309 Koha Team University Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93314|0 |1 is obsolete| | --- Comment #110 from Koha Team University Lyon 3 --- Created attachment 93647 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93647&action=edit Bug 18309: UNIMARC update from IFLA - authority (fr) (SAUT) Signed-off-by: Sonia BOUIS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 16:56:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 14:56:23 +0000 Subject: [Koha-bugs] [Bug 18309] UNIMARC update from IFLA In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18309 Koha Team University Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93315|0 |1 is obsolete| | --- Comment #111 from Koha Team University Lyon 3 --- Created attachment 93648 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93648&action=edit Bug 18309: UNIMARC update from IFLA - authority (fr) (SCO) Signed-off-by: Sonia BOUIS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 16:56:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 14:56:28 +0000 Subject: [Koha-bugs] [Bug 18309] UNIMARC update from IFLA In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18309 Koha Team University Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93316|0 |1 is obsolete| | --- Comment #112 from Koha Team University Lyon 3 --- Created attachment 93649 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93649&action=edit Bug 18309: UNIMARC update from IFLA - authority (fr) (STU) Signed-off-by: Sonia BOUIS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 16:56:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 14:56:33 +0000 Subject: [Koha-bugs] [Bug 18309] UNIMARC update from IFLA In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18309 Koha Team University Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93317|0 |1 is obsolete| | --- Comment #113 from Koha Team University Lyon 3 --- Created attachment 93650 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93650&action=edit Bug 18309: UNIMARC update from IFLA - biblio UNIMARC complet (en) Signed-off-by: Sonia BOUIS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 16:56:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 14:56:39 +0000 Subject: [Koha-bugs] [Bug 18309] UNIMARC update from IFLA In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18309 Koha Team University Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93442|0 |1 is obsolete| | --- Comment #114 from Koha Team University Lyon 3 --- Created attachment 93651 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93651&action=edit Bug 18309: Add UNIMARC field 214 and its subfields Signed-off-by: Sonia BOUIS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 16:56:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 14:56:43 +0000 Subject: [Koha-bugs] [Bug 18309] UNIMARC update from IFLA In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18309 Koha Team University Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93456|0 |1 is obsolete| | --- Comment #115 from Koha Team University Lyon 3 --- Created attachment 93652 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93652&action=edit Bug 18309: Fix INSERT sql query in unimarc_framework_DEFAULT.sql Signed-off-by: Sonia BOUIS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 16:56:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 14:56:48 +0000 Subject: [Koha-bugs] [Bug 18309] UNIMARC update from IFLA In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18309 Koha Team University Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93593|0 |1 is obsolete| | --- Comment #116 from Koha Team University Lyon 3 --- Created attachment 93653 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93653&action=edit Bug 18309: Add missing fields in biblio framework 018 - [Reserved for other International Standard Numbers] 033 - Other System Persistent Record Identifier 183 - Coded Data Field: Type of Carrier 203 - Content Form and Media Type 231 - Digital File Characteristics 283 - Carrier Type 338 - Funding Information Note Signed-off-by: Sonia BOUIS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 16:57:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 14:57:34 +0000 Subject: [Koha-bugs] [Bug 18421] Make Coce cover images available for staff search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 16:57:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 14:57:48 +0000 Subject: [Koha-bugs] [Bug 18421] Make Coce cover images available for staff search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91786|0 |1 is obsolete| | --- Comment #51 from Katrin Fischer --- Created attachment 93654 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93654&action=edit Bug 18421: Add Coce to the staff intranet TEST PLAN: 1) Apply the patch with git-bz 2) Run updatedatabase.pl 2.1) Console output should confirm database modification 3) Visit the 'Enhanced Content' tab of admin/syspref 3.1) ressource is /cgi-bin/koha/admin/preferences.pl?tab=enhanced_content 3.2) You should see that the previous preference, Coce, is now CoceOPAC, and that a new preference was added, CoceIntranet 4) Activate CoceIntranet 5) Do a search for a book for which you have a Coce cover 5.1) The cover image url should now point to a provider you defined in Coce 5.2) Your Coce log should show a query 6) Click on the book's name to visit the detail.pl page 6.1) The book's cover should also be provided by Coce on that page Signed-off-by: Owen Leonard Signed-off-by: Alex Buckley Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 3 16:58:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Oct 2019 14:58:03 +0000 Subject: [Koha-bugs] [Bug 18421] Make Coce cover images available for staff search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91787|0 |1 is obsolete| | --- Comment #52 from Katrin Fischer --- Created attachment 93655 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93655&action=edit Bug 18421: (follow-up) QA fixes Use the community's terminology, change coce.js's path, update