.
3. Apply patch.
4. Inscept the element again and it should be inside of a
with a class
of 'byAuthor'.
5. Add this CSS to the OPACUserCSS '.byAuthor { display: none;}'.
6. Reload the OPAC results/details and notice that the 'by' bit is now hidden.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 09:13:57 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 07:13:57 +0000
Subject: [Koha-bugs] [Bug 19618] Add 'Club Holds' feature
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19618
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Passed QA |Pushed to master
Version(s)| |19.11.00
released in| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 09:14:01 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 07:14:01 +0000
Subject: [Koha-bugs] [Bug 19618] Add 'Club Holds' feature
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19618
--- Comment #25 from Martin Renvoize ---
Nice work!
Pushed to master for 19.11.00
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 09:14:04 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 07:14:04 +0000
Subject: [Koha-bugs] [Bug 23447] Fix capitalization and other minor edits on
patron batch edit template
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23447
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Passed QA |Pushed to master
Version(s)| |19.11.00
released in| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 09:14:06 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 07:14:06 +0000
Subject: [Koha-bugs] [Bug 23447] Fix capitalization and other minor edits on
patron batch edit template
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23447
--- Comment #5 from Martin Renvoize ---
Nice work!
Pushed to master for 19.11.00
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 09:14:08 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 07:14:08 +0000
Subject: [Koha-bugs] [Bug 23648] The logged in link (class
"loggedinusername") needs data-patroncategory
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23648
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Passed QA |Pushed to master
Version(s)| |19.11.00
released in| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 09:14:12 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 07:14:12 +0000
Subject: [Koha-bugs] [Bug 23648] The logged in link (class
"loggedinusername") needs data-patroncategory
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23648
--- Comment #7 from Martin Renvoize ---
Nice work!
Pushed to master for 19.11.00
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 09:21:55 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 07:21:55 +0000
Subject: [Koha-bugs] [Bug 23709] New: Can't add new subfields to
bibliographic frameworks
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23709
Bug ID: 23709
Summary: Can't add new subfields to bibliographic frameworks
Change sponsored?: ---
Product: Koha
Version: 18.11
Hardware: All
OS: All
Status: NEW
Severity: critical
Priority: P5 - low
Component: Cataloging
Assignee: koha-bugs at lists.koha-community.org
Reporter: corinne.hayet at progilone.fr
QA Contact: testopia at bugs.koha-community.org
CC: m.de.rooy at rijksmuseum.nl
It only works if the subfield is connected to an Authorized values list.
I created a subfield 099$m with a link with COUNTRY authorized values list and
it's OK
But, if I try to create a simple subfield 012$z and I've got the following
error in logs :
DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key
constraint fails (`koha`.`marc_subfield_structure`,
CONSTRAINT `marc_subfield_structure_ibfk_1` FOREIGN KEY
(`authorised_value`) REFERENCES `authorised_value_categories`
(`category_name`) ON DELETE SET NULL ON ) [for Statement "INSERT INTO
`marc_subfield_structure` ( `authorised_value`, `authtypecode`, `defaultvalue`,
`frameworkcode`, `hidden`, `isurl`, `kohafield`, `liblibrarian`, `libopac`,
`link`, `mandatory`, `maxlength`, `repeatable`, `seealso`, `tab`, `tagfield`,
`tagsubfield`,
`value_builder`) VALUES ( ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?
)" with ParamValues: 0="", 1="", 2="", 3="", 4="0", 5=0, 6="", 7="test",
8="test", 9="", 10=0, 11="9999", 12=0, 13=undef, 14="0", 15="013", 16="x",
17=""] at /usr/local/share/perl5/DBIx/Class/Storage/DBI.pm line 1836.
Best regards,
Corinne
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 09:23:30 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 07:23:30 +0000
Subject: [Koha-bugs] [Bug 23709] Can't add new subfields to bibliographic
frameworks
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23709
Corinne Hayet changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on| |23309
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23309
[Bug 23309] Can't add new subfields to bibliographic frameworks in strict mode
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 09:23:30 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 07:23:30 +0000
Subject: [Koha-bugs] [Bug 23309] Can't add new subfields to bibliographic
frameworks in strict mode
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23309
Corinne Hayet changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |23709
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23709
[Bug 23709] Can't add new subfields to bibliographic frameworks
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 09:34:45 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 07:34:45 +0000
Subject: [Koha-bugs] [Bug 23700] Fix output of koha-plack --restart
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23700
Jesse Maseto changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 09:34:50 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 07:34:50 +0000
Subject: [Koha-bugs] [Bug 23700] Fix output of koha-plack --restart
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23700
Jesse Maseto changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #93244|0 |1
is obsolete| |
--- Comment #3 from Jesse Maseto ---
Created attachment 93344
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93344&action=edit
Very nicely aligned now.
Bug 23700 - Fix output of koha-plack --restart
To test:
- Run "sudo koha-plack restart kohadev" and verify the output is
out of line.
- Apply the patch
- If you are on e.g. kohadevbox you need to copy koha-plack to
/usr/sbin/ thus:
sudo cp debian/scripts/koha-plack /usr/sbin/koha-plack
- Run "sudo koha-plack restart kohadev" again and check that you
get two lines of output, nicely aligned with the "OK" inside the
square brackets.
Signed-off-by: Jesse Maseto
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 09:48:34 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 07:48:34 +0000
Subject: [Koha-bugs] [Bug 14493] export_borrowers.pl - Export patron
attributes
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14493
Axelle Aix-Marseille Université changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |axelle.clarisse at univ-amu.fr
--- Comment #11 from Axelle Aix-Marseille Université ---
We try to test today : this patch doesn't apply on a sandbox (Biblibre n°1)
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 10:01:18 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 08:01:18 +0000
Subject: [Koha-bugs] [Bug 23702] New UNIMARC XSLT
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23702
Axelle Aix-Marseille Université changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |axelle.clarisse at univ-amu.fr
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 10:10:38 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 08:10:38 +0000
Subject: [Koha-bugs] [Bug 20888] Allow use of boolean operator 'not' in item
search
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20888
Axelle Aix-Marseille Université changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |axelle.clarisse at univ-amu.fr
--- Comment #12 from Axelle Aix-Marseille Université ---
We try to test today : this patch doesn't apply on a sandbox (Biblibre n°1)
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 10:37:26 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 08:37:26 +0000
Subject: [Koha-bugs] [Bug 23586] Issuing rules failing in 19.05
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23586
Andreas Jonsson changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--- Comment #6 from Andreas Jonsson ---
I think that any library that have branch specific issuing rules will be
affected by this, but the problem will be visible on any Koha-installation.
I propose two test plans:
1. By code inspection:
* Review commit 7d71d9507202ff667776bf9cb6de0bf2603ad0dd and note that it
changes the parameter "$branch" passed to CalcDateDue from the return value of
_GetCircControlBranch, which is a branchcode, to $circ_library, which is a
library object.
* Note that CalcDateDue will eventually call CalcHardDueDate with the library
object as parameter, and that CalcHardDueDate expects a branchcode which it
will pass as parameter to the database query.
2. By inspecting the query log in MySQL:
- Enable query-logging in MySQL by editing /etc/mysql/my.cnf and restarting the
mysql server:
general_log_file = /var/log/mysql/mysql.log
general_log = 1
- Perform an issue and grep for 'Koha::Library=HASH(' in
/var/log/mysql/mysql.log
- Apply patch
- sudo truncate --size=0 /var/log/mysql/mysql.log
- Perform an issue and grep for 'Koha::Library=HASH(' in
/var/log/mysql/mysql.log
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 10:38:12 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 08:38:12 +0000
Subject: [Koha-bugs] [Bug 21249] Syspref to choose whether to search
homebranch, holding branch or both for library groups in advanced search
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249
sandboxes at biblibre.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
CC| |sandboxes at biblibre.com
--- Comment #13 from sandboxes at biblibre.com ---
Patch tested with a sandbox, by Amandine Zocca
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 10:38:30 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 08:38:30 +0000
Subject: [Koha-bugs] [Bug 21249] Syspref to choose whether to search
homebranch, holding branch or both for library groups in advanced search
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249
sandboxes at biblibre.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #82138|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 10:38:36 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 08:38:36 +0000
Subject: [Koha-bugs] [Bug 21249] Syspref to choose whether to search
homebranch, holding branch or both for library groups in advanced search
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249
sandboxes at biblibre.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #83518|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 10:38:44 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 08:38:44 +0000
Subject: [Koha-bugs] [Bug 21249] Syspref to choose whether to search
homebranch, holding branch or both for library groups in advanced search
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249
--- Comment #14 from sandboxes at biblibre.com ---
Created attachment 93345
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93345&action=edit
Bug 21249: New syspref controlling branch fields queried against selected
library group value in advanced search
This commit allows librarians to choose whether they want to query the
homebranch, holdingbranch or homebranch AND holdingbranch when they set
a library group search condition in the staff client and OPAC advanced
searches.
Test plan:
1. Apply patch and run ./updatedatabase.pl in the koha shell
2. Restart memcached and plack
3. In the staff client go to Administration->Global system preferences
and search for the systempreference: AdvancedSearchBranchFieldToUse and
notice by default it is set to 'homebranch and holdingbranch'
4. Create a library group. Create a subgroup from the library group and add
several library branches to the sub group.
5. Note down the barcode of an item to use for testing searching. Make
sure the items homebranch and holdingbranch are different and the items
homebranch is a child of the sub group created in step 4
6. Perform an Advanced search in the staff client and write in the item
barcode as the keyword and select the sub group in the
'Location and availability' section.
7. Submit the search query and notice the item with a homebranch
existing in the selected sub group is returned. This proves that
when the AdvancedSearchBranchFieldToUse syspref is set to 'homebranch and
holdingbranch' the homebranch value is checked.
Also note at the top of the search result page the search query is listed:
Results of search
with limit(s): '(homebranch: or holdingbranch: or
homebranch:
or holdingbranch: )'
8. Now edit the item making sure the homebranch branch is not in the
sub group, and making sure the holdingbranch is in the sub group. This is to
test that holdingbranch is indeed being checked when
the AdvancedSearchBranchFieldToUse is set to
'homebranch and holdingbranch'
9. Repeat step 6 and notice the item with a holdingbranch existing
in the selected library group is returned.
10. Change the value of the AdvancedSearchBranchFieldToUse syspref to
'holdingbranch' and repeat step 6 and again notice the item with a
holdingbranch existing in the selected library group is returned.
Also note the search query at the top of the page is: "Results of search
with limit(s): '(holdingbranch: or holdingbranch: )'"
this shows holdingbranch not homebranch is a condition in the query
11. Change the value of the AdvancedSearchBranchFieldToUse syspref to
'homebranch'
12. Change the item homebranch back to a branch that is in the sub group
and change the holdingbranch value to a library branch that is not in
the sub group.
13. Repeat step 6 and notice the item with the homebranch in the
selected library group is returned, so we know the homebranch is being
checked.
Also note the search query at the top of the page is: " Results of
search with limit(s): '(homebranch: or homebranch: )'" this
shows homebranch not holdingbranch is a condition in the query.
Sponsored-By: Brimbank Library
Signed-off-by: Amandine Zocca
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 10:38:48 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 08:38:48 +0000
Subject: [Koha-bugs] [Bug 21249] Syspref to choose whether to search
homebranch, holding branch or both for library groups in advanced search
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249
--- Comment #15 from sandboxes at biblibre.com ---
Created attachment 93346
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93346&action=edit
Bug 21249: Made the SQL INSERT statement idempotent
Sponsored-BY: Brimbank Library, Australia
Signed-off-by: Amandine Zocca
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 10:41:20 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 08:41:20 +0000
Subject: [Koha-bugs] [Bug 12949] changing child to adult doesn't remove link
to guarantor
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12949
Arthur Suzuki changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |arthur.suzuki at biblibre.com
--- Comment #12 from Arthur Suzuki ---
merge conflict on master:
Fusion automatique de members/moremember.pl
CONFLIT (contenu) : Conflit de fusion dans members/moremember.pl
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 10:47:15 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 08:47:15 +0000
Subject: [Koha-bugs] [Bug 23586] Issuing rules failing in 19.05
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23586
--- Comment #7 from Andreas Jonsson ---
Since the problem is likely caused by the confusion caused by the fact that the
variable name $branch is sometimes used for branchnumbers and sometimes for
library objects I think that it is a good idea to change the variable names.
Also, I think it would be a good idea to add to the coding standards how to
name variables containing objects and object identities.
These types of errors should really be caught by a type system at compile time.
But in the absense of a type system, we can at least improve the situation by
having a consistent variable naming scheme.
The QA-team could also consider performing tests with the mysql query log
enabled and querying for patterns like '=HASH(' which could catch some
problems.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 10:59:40 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 08:59:40 +0000
Subject: [Koha-bugs] [Bug 21979] Add option to SIP2 config to send arbitrary
item field in CR instead of collection code
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21979
Jesse Maseto changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jesse at bywatersolutions.com
--- Comment #3 from Jesse Maseto ---
Hi Kyle, There are a few merge conflicts with this patch.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 11:02:50 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 09:02:50 +0000
Subject: [Koha-bugs] [Bug 18309] UNIMARC update from IFLA
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18309
Julian Maurice changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #93281|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 11:20:54 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 09:20:54 +0000
Subject: [Koha-bugs] [Bug 20888] Allow use of boolean operator 'not' in item
search
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20888
Matthias Meusburger changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #85281|0 |1
is obsolete| |
--- Comment #13 from Matthias Meusburger ---
Created attachment 93347
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93347&action=edit
Bug 20888: Allow use of boolean operator 'not' in item search
Test plan:
- Apply the patch
- Check that you have a 'is not' option in the third box in item search
- Check that you can exclude items from the search results with this 'is not'
option
- Check that you can still combine parameters with 'and' and 'or'
- Check that the exclusion works for custom fields (see Administration > Item
search fields)
- Check that the exclusion works for custom fields linked to authorised values
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 11:21:42 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 09:21:42 +0000
Subject: [Koha-bugs] [Bug 20888] Allow use of boolean operator 'not' in item
search
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20888
--- Comment #14 from Matthias Meusburger ---
The patch has been rebased, it should apply correctly on the sandboxes now.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 11:23:49 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 09:23:49 +0000
Subject: [Koha-bugs] [Bug 20589] Add field boosting and use elastic query
fields parameter instead of deprecated _all
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Failed QA |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 11:23:54 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 09:23:54 +0000
Subject: [Koha-bugs] [Bug 20589] Add field boosting and use elastic query
fields parameter instead of deprecated _all
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #93247|0 |1
is obsolete| |
Attachment #93248|0 |1
is obsolete| |
Attachment #93249|0 |1
is obsolete| |
Attachment #93250|0 |1
is obsolete| |
Attachment #93251|0 |1
is obsolete| |
--- Comment #53 from Nick Clemens ---
Created attachment 93348
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93348&action=edit
Bug 20589: Add field boosting and use query_string fields parameter
Generate a list of fields for the query_string query fields parameter,
with possible boosts, instead of using "_all"-field. Also add "search"
flag in search_marc_to_field table so that certain mappings can be
excluded from searches. Add option to include/exclude fields in
query_string "fields" parameter depending on searching in OPAC or staff
client. Refactor code to remove all other dependencies on "_all"-field.
How to test:
1) Reindex authorities and biblios.
2) Search biblios and try to verify that this works as expected.
3) Search authorities and try to verify that this works as expected.
4) Go to "Search engine configuration"
5) Change some "Boost", "Staff client", and "OPAC" settings and save.
6) Verify that those settings where saved accordingly.
7) Click the "Biblios" or "Authorities" tab and change one or more
"Searchable" settings
8) Verfiy that those settings where saved accordingly.
9) Try to verify that these settings has taken effect by peforming
some biblios and/or authorities searches.
Sponsorded-by: Gothenburg Univesity Library
Signed-off-by: Nick Clemens
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 11:24:07 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 09:24:07 +0000
Subject: [Koha-bugs] [Bug 20589] Add field boosting and use elastic query
fields parameter instead of deprecated _all
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589
--- Comment #54 from Nick Clemens ---
Created attachment 93349
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93349&action=edit
Bug 20589: fix QueryBuilder tests
Signed-off-by: Nick Clemens
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 11:24:20 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 09:24:20 +0000
Subject: [Koha-bugs] [Bug 20589] Add field boosting and use elastic query
fields parameter instead of deprecated _all
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589
--- Comment #55 from Nick Clemens ---
Created attachment 93350
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93350&action=edit
Bug 20589: Exclude boolean fields from search fields
Signed-off-by: Nick Clemens
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 11:24:34 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 09:24:34 +0000
Subject: [Koha-bugs] [Bug 20589] Add field boosting and use elastic query
fields parameter instead of deprecated _all
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589
--- Comment #56 from Nick Clemens ---
Created attachment 93351
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93351&action=edit
Bug 20589: Add option for searching entire record if record stored as array
Signed-off-by: Nick Clemens
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 11:24:41 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 09:24:41 +0000
Subject: [Koha-bugs] [Bug 20589] Add field boosting and use elastic query
fields parameter instead of deprecated _all
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589
--- Comment #57 from Nick Clemens ---
Created attachment 93352
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93352&action=edit
Bug 20589: DO NOT PUSH Schema changes
Signed-off-by: Nick Clemens
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 11:25:20 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 09:25:20 +0000
Subject: [Koha-bugs] [Bug 20589] Add field boosting and use elastic query
fields parameter instead of deprecated _all
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589
--- Comment #58 from Nick Clemens ---
Created attachment 93353
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93353&action=edit
Bug 20589: Remove expanded_facet variable and fix tests
Thi is a rebase from 14419 to remove an unused variable
Also update tests to expect the new expected result
Signed-off-by: Nick Clemens
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 11:27:37 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 09:27:37 +0000
Subject: [Koha-bugs] [Bug 20589] Add field boosting and use elastic query
fields parameter instead of deprecated _all
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589
--- Comment #59 from Nick Clemens ---
Added minor followup
Everything seems to work as expected. The authority searching changes seem to
be an improvement:
previously an 'exact' search matched any term, now it must match the entire
field. Punctuation could be excluded in the future, but exact match should eb
exact so I think good
starts with searches and sorting are improved
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 11:30:23 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 09:30:23 +0000
Subject: [Koha-bugs] [Bug 22280] The ILL module assumes every status needs a
next/previous status
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22280
Magnus Enger changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Failed QA |Passed QA
Patch complexity|--- |Small patch
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 11:30:26 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 09:30:26 +0000
Subject: [Koha-bugs] [Bug 22280] The ILL module assumes every status needs a
next/previous status
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22280
--- Comment #14 from Magnus Enger ---
Created attachment 93354
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93354&action=edit
Bug 22280: Add a unit test
This patch adds a unit test to t/db_dependent/Illrequests.t, where
a new node without any next_actions or prev_actions is added to the
core status graph.
Running the tests show a lot of warnings about "no query in
themelanguage", but that should not be related to the current bug.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 11:31:27 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 09:31:27 +0000
Subject: [Koha-bugs] [Bug 22280] The ILL module assumes every status needs a
next/previous status
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22280
--- Comment #15 from Magnus Enger ---
OK, I tried to add a unit test. Hopes it makes sense! Also reset status to PQA.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 11:32:07 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 09:32:07 +0000
Subject: [Koha-bugs] [Bug 22927] Item improperly marked returned when
changing damaged or withdrawn status
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22927
Claudie changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #90443|0 |1
is obsolete| |
--- Comment #3 from Claudie ---
Created attachment 93355
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93355&action=edit
Bug 22927: Do not check an already lost item when marked as withdrawn or
damaged
Due to how moredetail.pl was written it was hard to know which action
was triggered.
Test plan:
- Set MarkLostItemsAsReturned to "from the items tab of the catalog
module."
- Check an item out to a patron
- Use additem.pl to set that item to a lost status without returning it
- go to moredetail.pl for that item
- mark item as either damaged or withdrawn without interacting with the
lost dropdown
- note that item has not been returned
Note for QA: Maybe we could have just tested if exists
$item_changes->{'itemlost'}
to call LostItem
Signed-off-by: Claudie Trégouët
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 11:33:52 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 09:33:52 +0000
Subject: [Koha-bugs] [Bug 22927] Item improperly marked returned when
changing damaged or withdrawn status
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22927
Claudie changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
CC| |claudie.tregouet at biblibre.c
| |om
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 11:45:01 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 09:45:01 +0000
Subject: [Koha-bugs] [Bug 20334] Elasticsearch - Option for escaping slashes
in search queries
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334
Johanna Räisä changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |johanna.raisa at koha-suomi.fi
--- Comment #37 from Johanna Räisä ---
Is anything happening with this bug?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 11:45:19 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 09:45:19 +0000
Subject: [Koha-bugs] [Bug 14567] Browse interface for OPAC
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14567
Johanna Räisä changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |johanna.raisa at koha-suomi.fi
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 11:46:24 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 09:46:24 +0000
Subject: [Koha-bugs] [Bug 23351] Clean up localization template
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23351
Jesse Maseto changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 11:46:30 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 09:46:30 +0000
Subject: [Koha-bugs] [Bug 23351] Clean up localization template
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23351
Jesse Maseto changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #91853|0 |1
is obsolete| |
--- Comment #3 from Jesse Maseto ---
Created attachment 93356
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93356&action=edit
Looks good with in my tests.
Bug 23351: Clean up localization template
This patch modifies the template used for translation of item type
descriptions. It is updated with more consistent Bootstrap grid markup
and improved handling of adding and removing rows from the DataTable.
To test you should have more than one translation installed.
- Apply the patch and go to Administration -> Item types.
- Edit an item type.
- Click the translate link.
- Add a new translation. The table of translations should be updated
with your new translation.
- Test the "Delete" link corresponding to your new entry. It should
work correctly.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 11:46:49 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 09:46:49 +0000
Subject: [Koha-bugs] [Bug 14567] Browse interface for OPAC
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14567
Johanna Räisä changed:
What |Removed |Added
----------------------------------------------------------------------------
CC|johanna.raisa at koha-suomi.fi |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 11:49:44 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 09:49:44 +0000
Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681
--- Comment #1 from Andrew Isherwood ---
It has become increasingly apparent that using authorised values for this is
not the most appropriate way forward. The number of modifications and additions
to AV was increasing the scope of the work too much, it was clear that AV was
not the correct place for this.
Therefore, I am intending creating a table specifically for Patron Restrictions
and building the management UI for it, which will be placed probably under
"Koha administration" > "Patrons and circulation"
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 11:54:24 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 09:54:24 +0000
Subject: [Koha-bugs] [Bug 22773] Bulk Close invoices and Filter invoice view
(open/closed)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773
Devinim changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 11:54:28 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 09:54:28 +0000
Subject: [Koha-bugs] [Bug 22773] Bulk Close invoices and Filter invoice view
(open/closed)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773
--- Comment #1 from Devinim ---
Created attachment 93357
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93357&action=edit
Bug 22773: Bulk Close invoices and Filter invoice view (open/closed)
Test plan:
1)Verify that close tab occurse for closed invoices.
2)Try to select bulk invoices in open invoices tab and press button "Close
selected invoices". Verify that your selected invoices moved to close invoices
tab.
3)Try to select bulk invoices in close invoices tab and press button "Reopen
selected invoices". Verify that your selected invoices moved to open invoices
tab.
4)Check also when you check on "Show only subscriptions" checkbox you may see
subscribed invoices in all tabs.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 11:59:46 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 09:59:46 +0000
Subject: [Koha-bugs] [Bug 23710] New: Holds broken,
displays a JSON page with an error
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23710
Bug ID: 23710
Summary: Holds broken, displays a JSON page with an error
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: blocker
Priority: P5 - low
Component: Hold requests
Assignee: koha-bugs at lists.koha-community.org
Reporter: victor.grousset at biblibre.com
QA Contact: testopia at bugs.koha-community.org
CC: gmcharlt at gmail.com
== Test plan ==
1. Try to place a hold on a record
2. You get an error 😱
{"errors":[{"message":"Expected object - got
null.","path":"\/body"}],"status":400}
It happened
- on a DevBox of a colleague
- a my koha-testing-docker
- an instance of another colleague
The sandbox throws a 404 not found and the URL is the following:
http://pro.user01-koha.sandbox.biblibre.eu/api/v1/holds
So definitely related.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 12:06:49 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 10:06:49 +0000
Subject: [Koha-bugs] [Bug 23252] Pressing enter should not submit form in
item editor
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23252
Fridolin SOMERS changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|Missing input_marceditor |Pressing enter should not
|class in item editor |submit form in item editor
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 12:07:03 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 10:07:03 +0000
Subject: [Koha-bugs] [Bug 23252] Pressing enter should not submit form in
item editor
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23252
Fridolin SOMERS changed:
What |Removed |Added
----------------------------------------------------------------------------
Alias| |Missing, input_marceditor,
| |class, in, item, editor
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 12:07:33 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 10:07:33 +0000
Subject: [Koha-bugs] [Bug 23252] Pressing enter should not submit form in
item editor
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23252
Fridolin SOMERS changed:
What |Removed |Added
----------------------------------------------------------------------------
Alias|class, editor, in, |
|input_marceditor, item, |
|Missing |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 12:22:48 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 10:22:48 +0000
Subject: [Koha-bugs] [Bug 23252] Pressing enter should not submit form in
item editor
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23252
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |katrin.fischer at bsz-bw.de
--- Comment #12 from Katrin Fischer ---
It looks like this is actually a regressen - we fixed it before in bug 8557.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 12:52:23 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 10:52:23 +0000
Subject: [Koha-bugs] [Bug 7074] Show subtitle,
part and number of a record in list of checkins
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7074
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Version(s)| |19.11.00
released in| |
Status|Passed QA |Pushed to master
--
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 12:52:25 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 10:52:25 +0000
Subject: [Koha-bugs] [Bug 7074] Show subtitle,
part and number of a record in list of checkins
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7074
--- Comment #14 from Martin Renvoize ---
Nice work!
Pushed to master for 19.11.00
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 13:23:52 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 11:23:52 +0000
Subject: [Koha-bugs] [Bug 21979] Add option to SIP2 config to send arbitrary
item field in CR instead of collection code
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21979
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #83102|0 |1
is obsolete| |
--- Comment #4 from Kyle M Hall ---
Created attachment 93358
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93358&action=edit
Bug 21979: Add option to SIP2 config to send arbitrary item field in CR instead
of collection code
Some libraries need to send a different field as the collection code,
depending on how the library catalogs items. We should allow any arbitrary
item field to be used as the value for the CR field.
Test Plan:
1) Apply this patch
2) Set the new option cr_item_field to 'shelving_location'
3) Restart the SIP server
3) Perform a checkin via SIP
4) Note the CR field contains the shelving location code in the response
5) Perform an item information request
6) Note the CR field contains the shelving location code in the response
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 13:28:54 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 11:28:54 +0000
Subject: [Koha-bugs] [Bug 22874] Limit to available items doesn't work with
elasticsearch 6.x
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22874
Séverine Queune changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Failed QA
CC| |severine.queune at bulac.fr
--- Comment #2 from Séverine Queune ---
Here are the 2 sandboxes I used with :
- ES5 : http://pro.es5-koha.sandbox.biblibre.eu
- ES6 : http://pro.es6-koha.sandbox.biblibre.eu
Sorry Alex, they both failed...
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 14:02:33 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 12:02:33 +0000
Subject: [Koha-bugs] [Bug 22259] If two catalogers work on same record,
one overwrites the other
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22259
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |DUPLICATE
--- Comment #7 from Katrin Fischer ---
*** This bug has been marked as a duplicate of bug 23705 ***
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 14:02:33 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 12:02:33 +0000
Subject: [Koha-bugs] [Bug 23705] Add a syspref to enable record locking,
so that when one record is opened to be edited,
it's read only for other users
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23705
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |karin.hochschein at linklaters
| |.com
--- Comment #1 from Katrin Fischer ---
*** Bug 22259 has been marked as a duplicate of this bug. ***
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 14:14:13 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 12:14:13 +0000
Subject: [Koha-bugs] [Bug 22874] Limit to available items doesn't work with
elasticsearch 6.x
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22874
sandboxes at biblibre.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Failed QA |Signed Off
CC| |sandboxes at biblibre.com
--- Comment #3 from sandboxes at biblibre.com ---
Patch tested with a sandbox, by Séverine QUEUNE
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 14:14:28 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 12:14:28 +0000
Subject: [Koha-bugs] [Bug 22874] Limit to available items doesn't work with
elasticsearch 6.x
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22874
sandboxes at biblibre.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #89506|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 14:14:38 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 12:14:38 +0000
Subject: [Koha-bugs] [Bug 22874] Limit to available items doesn't work with
elasticsearch 6.x
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22874
--- Comment #4 from sandboxes at biblibre.com ---
Created attachment 93359
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93359&action=edit
Bug 22874 - use false instaed of 0 value for limiting on availability
Test plan
- Set up a elasticsearch 6 instance to work with Koha,
- you may need to make koha works with ES 6 (see bug 20589),
- make a search and limit it to available items only,
=> no result
- Apply this patch,
- make a search and limit it to available items only,
- you should get some results
- Do the same with ES 5.x
Signed-off-by: Séverine QUEUNE
Signed-off-by: Séverine QUEUNE
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 14:28:35 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 12:28:35 +0000
Subject: [Koha-bugs] [Bug 23710] Holds broken,
displays a JSON page with an error
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23710
--- Comment #1 from Martin Renvoize ---
Created attachment 93360
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93360&action=edit
Bug 23710: Revert to usng placerequest.pl
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 14:29:59 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 12:29:59 +0000
Subject: [Koha-bugs] [Bug 23670] Load Koha::Exceptions::ElasticSearch module
in Koha::SearchEngine::Elasticsearch
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23670
Séverine Queune changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 14:30:03 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 12:30:03 +0000
Subject: [Koha-bugs] [Bug 23670] Load Koha::Exceptions::ElasticSearch module
in Koha::SearchEngine::Elasticsearch
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23670
Séverine Queune changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #93132|0 |1
is obsolete| |
--- Comment #2 from Séverine Queune ---
Created attachment 93361
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93361&action=edit
Bug 23670 Load Koha::Exceptions::ElasticSearch module in
Koha::SearchEngine::Elasticsearch
Prevent Koha::SearchEngine::Elasticsearch from dying when trying to run
Koha::Exceptions::Elasticsearch::MARCFieldExprParseError->throw()
Plan test:
1. Go to Administration -> Searchengine configuration, and add a mapping
for 995Z, whatever the search field (I did it with local-classification),
save
2. run $KOHA_PATH/misc/search_tools/rebuild_elasticsearch.pl -v -d -b
3. see it die asking for Koha::Exceptions::Elasticsearch
4. apply patch
5. rerun $KOHA_PATH/misc/search_tools/rebuild_elasticsearch.pl -v -d -b
6. see it throw: Invalid MARC field expression: 995Z
Signed-off-by: Séverine QUEUNE
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 14:32:14 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 12:32:14 +0000
Subject: [Koha-bugs] [Bug 23710] Holds broken,
displays a JSON page with an error
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23710
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |martin.renvoize at ptfs-europe
| |.com
Status|NEW |Needs Signoff
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 14:33:10 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 12:33:10 +0000
Subject: [Koha-bugs] [Bug 23710] Holds broken,
displays a JSON page with an error
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23710
--- Comment #2 from Martin Renvoize ---
This is a quick fix.. but it's made me wonder about the club holds feature more
generally.
Do we still need placerequest.pl if we're aiming to move to the API entirely as
that patch attempted.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 14:38:03 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 12:38:03 +0000
Subject: [Koha-bugs] [Bug 23710] Holds broken,
displays a JSON page with an error
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23710
--- Comment #3 from Martin Renvoize ---
To add detail to the failure, I could replicate it on
Version 77.0.3865.90 (Official Build) Arch Linux (64-bit)
I used a patron which should have blocked my hold but chose to hold anyway as
you can.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 14:38:22 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 12:38:22 +0000
Subject: [Koha-bugs] [Bug 23710] Holds broken,
displays a JSON page with an error
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23710
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|koha-bugs at lists.koha-commun |agustinmoyano at theke.io
|ity.org |
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 14:43:04 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 12:43:04 +0000
Subject: [Koha-bugs] [Bug 23710] Holds broken,
displays a JSON page with an error
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23710
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Patch complexity|--- |Trivial patch
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 14:43:06 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 12:43:06 +0000
Subject: [Koha-bugs] [Bug 23710] Holds broken,
displays a JSON page with an error
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23710
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #93360|0 |1
is obsolete| |
--- Comment #4 from Owen Leonard ---
Created attachment 93362
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93362&action=edit
Bug 23710: Revert to usng placerequest.pl
Signed-off-by: Owen Leonard
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 14:47:40 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 12:47:40 +0000
Subject: [Koha-bugs] [Bug 23711] New: Icons on staff main page should be
font icons
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23711
Bug ID: 23711
Summary: Icons on staff main page should be font icons
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Staff Client
Assignee: koha-bugs at lists.koha-community.org
Reporter: lucas at bywatersolutions.com
QA Contact: testopia at bugs.koha-community.org
CC: gmcharlt at gmail.com
On the staff main page we should use font icons (Font Awesome) instead of
sprite.png. These are easier to adjust/customize with CSS than the sprites we
currently use.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 14:48:16 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 12:48:16 +0000
Subject: [Koha-bugs] [Bug 23671] Elasticsearch shouldn't throw exception on
an uppercase subfield identifier
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23671
Séverine Queune changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |severine.queune at bulac.fr
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 14:50:14 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 12:50:14 +0000
Subject: [Koha-bugs] [Bug 18757] Problem when importing only items in MARC
records
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18757
sandboxes at biblibre.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
CC| |sandboxes at biblibre.com
--- Comment #10 from sandboxes at biblibre.com ---
Patch tested with a sandbox, by Amandine Zocca
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 14:50:30 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 12:50:30 +0000
Subject: [Koha-bugs] [Bug 18757] Problem when importing only items in MARC
records
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18757
sandboxes at biblibre.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #64104|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 14:50:38 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 12:50:38 +0000
Subject: [Koha-bugs] [Bug 18757] Problem when importing only items in MARC
records
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18757
--- Comment #11 from sandboxes at biblibre.com ---
Created attachment 93363
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93363&action=edit
Bug 18757 - Problem when importing only items in MARC records
When importing records with Stage MARC records for import, one can use matching
rules to only import items into existing records.
Those imported items are stored as XML to be staged.
The bug is that when MARC Flavour is UNIMARC the XML serialization fails
because its is looking in field 100$a which does not exist.
You see in logs the error : Unsupported UNIMARC character encoding [] for XML
output for UNIMARC; 100$a
This patch adds the format "USMARC" to XML serialization, like in
C4::Items::_get_unlinked_subfields_xml
Test plan :
- On a UNIMARC database
- Define a maching rule on title 200$a
- Select a record with items
- Export it using : Save as > MARC (Unicode/UTF-8)
- Delete all items
- Go to Tools > Stage MARC records for import
- Upload exported file
- Select title matching rule
- Select "Ingore incoming record" in "Action if matching record found :"
- Select Yes and "Always add items" in "Check for embedded item record data?"
- Click Stage for import
=> Without patch you get the error
=> With patch the import is staged
- Import into the catalog and check item is well recreated
Signed-off-by: Amandine Zocca
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 15:01:31 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 13:01:31 +0000
Subject: [Koha-bugs] [Bug 23711] Icons on staff main page should be font
icons
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23711
Lucas Gass changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 15:01:35 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 13:01:35 +0000
Subject: [Koha-bugs] [Bug 23711] Icons on staff main page should be font
icons
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23711
--- Comment #1 from Lucas Gass ---
Created attachment 93364
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93364&action=edit
Bug 23711: Icons on staff main page should be font icons
TEST PLAN:
1. GO to '/cgi-bin/koha/mainpage.pl' and observe the icons.
2. Apply the patch and clear the browser cache.
3. Refresh '/cgi-bin/koha/mainpage.pl' and make sure all the icons are still
display. Note that some are not exactly the same as the old ones, but should be
similar. Make sure you enable Course reserves and ILL so you can observe those
icons as well.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 15:02:51 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 13:02:51 +0000
Subject: [Koha-bugs] [Bug 23586] Issuing rules failing in 19.05
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23586
--- Comment #8 from Katrin Fischer ---
Thx Andreas :)
Usually I'd expect something like:
- Do this in Koha
- Go there... click that
- Verify it is broken
- Apply patch
- Repeat steps above
- Verify it's working now!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 15:06:16 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 13:06:16 +0000
Subject: [Koha-bugs] [Bug 23586] Issuing rules failing in 19.05
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23586
--- Comment #9 from Katrin Fischer ---
(In reply to Andreas Jonsson from comment #7)
> Since the problem is likely caused by the confusion caused by the fact that
> the variable name $branch is sometimes used for branchnumbers and sometimes
> for library objects I think that it is a good idea to change the variable
> names.
>
> Also, I think it would be a good idea to add to the coding standards how to
> name variables containing objects and object identities.
>
> These types of errors should really be caught by a type system at compile
> time. But in the absense of a type system, we can at least improve the
> situation by having a consistent variable naming scheme.
>
> The QA-team could also consider performing tests with the mysql query log
> enabled and querying for patterns like '=HASH(' which could catch some
> problems.
The issue is not the idea, but that this patch is marked for 19.05 - so the
variable renaming would never make it into master. If we want to do that, we
need to make sure there is a patch for master and a backport - it should
probably be done on a separate bug report (but leaving to RM ;) )
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 15:08:37 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 13:08:37 +0000
Subject: [Koha-bugs] [Bug 21799] Change wording for quantity input field on
order receive page
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21799
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords|rel_18_05_candidate |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 15:09:56 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 13:09:56 +0000
Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on
source of import
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |rel_19_11_candidate
CC| |martin.renvoize at ptfs-europe
| |.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 15:10:01 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 13:10:01 +0000
Subject: [Koha-bugs] [Bug 20334] Elasticsearch - Option for escaping slashes
in search queries
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334
--- Comment #38 from Katrin Fischer ---
Is there something we can do to help get this moving again?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 15:12:51 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 13:12:51 +0000
Subject: [Koha-bugs] [Bug 23671] Elasticsearch shouldn't throw exception on
an uppercase subfield identifier
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23671
Séverine Queune changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #93133|0 |1
is obsolete| |
--- Comment #2 from Séverine Queune ---
Created attachment 93365
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93365&action=edit
Bug 23671: Elasticsearch shouldn't throw exception on an uppercase subfield
identifier
Prevent Elasticsearch from throwing an exception when the mappings
include uppercase subfield identifier.
Though forbidden in MARC21, It doesn't seem to be the case for Unimarc
or ISO 2709 as a whole. It is also possible to define such a subfield
identifier in the Koha MARC Framework and in the Elasticsearch
mappings.
Test plan:
1. add a 995Z subfield identifier in Elasticsearch mappings
(Administration -> Search engine configuration)
2. run $KOHA_PATH/misc/search_tools/rebuild_elasticsearch.pl -v -d -b
3. see it throw: “Invalid MARC field expression: 995Z”
4. apply patch
5. rerun $KOHA_PATH/misc/search_tools/rebuild_elasticsearch.pl -v -d -b
6. sababa
Signed-off-by: Séverine QUEUNE
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 15:13:57 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 13:13:57 +0000
Subject: [Koha-bugs] [Bug 19618] Add 'Club Holds' feature
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19618
Tomás Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com
|y.org |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 15:14:28 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 13:14:28 +0000
Subject: [Koha-bugs] [Bug 20389] Indexing fields concatenated
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20389
--- Comment #5 from Séverine Queune ---
Just tried in master : concatenation works fine using parenthesis : 700(ab)
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 15:17:19 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 13:17:19 +0000
Subject: [Koha-bugs] [Bug 23671] Elasticsearch shouldn't throw exception on
an uppercase subfield identifier
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23671
Nicolas Legrand changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |rel_19_11_candidate
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 15:18:17 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 13:18:17 +0000
Subject: [Koha-bugs] [Bug 23670] Load Koha::Exceptions::ElasticSearch module
in Koha::SearchEngine::Elasticsearch
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23670
Nicolas Legrand changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |rel_19_11_candidate
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 15:18:27 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 13:18:27 +0000
Subject: [Koha-bugs] [Bug 18084] Language selector hidden in user menu on
mobile interfaces
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18084
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Patch doesn't apply
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 15:23:38 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 13:23:38 +0000
Subject: [Koha-bugs] [Bug 23586] Issuing rules failing in 19.05
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23586
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Version|19.05 |master
--- Comment #10 from Martin Renvoize ---
This bug also applies at master to so I'm correcting the version to 'master'
and will bring it to the attention of RMaints that it's required for a quick
backport.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 15:26:31 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 13:26:31 +0000
Subject: [Koha-bugs] [Bug 14715] Results per page setting for catalog search
in staff client and OPAC
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|martin at bugs.koha-community. |aleisha at catalyst.net.nz
|org.xinxidi.net |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 15:28:18 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 13:28:18 +0000
Subject: [Koha-bugs] [Bug 19482] Elasticsearch - prevent removal / editing
of required indexes
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19482
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|In Discussion |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 15:28:32 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 13:28:32 +0000
Subject: [Koha-bugs] [Bug 19482] Elasticsearch - prevent removal / editing
of required indexes
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19482
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #80817|0 |1
is obsolete| |
Attachment #80818|0 |1
is obsolete| |
Attachment #80819|0 |1
is obsolete| |
Attachment #80820|0 |1
is obsolete| |
--- Comment #27 from Nick Clemens ---
Created attachment 93366
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93366&action=edit
Bug 19482 - DB changes
Signed-off-by: Nicolas Legrand
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 15:28:45 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 13:28:45 +0000
Subject: [Koha-bugs] [Bug 19482] Elasticsearch - prevent removal / editing
of required indexes
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19482
--- Comment #28 from Nick Clemens ---
Created attachment 93367
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93367&action=edit
Bug 19482 - Add support for defining 'mandatory' mappings
To test:
1 - Apply patch
2 - ./installer/data/mysql/updatedatabase.pl
3 - Reset ES mapping: Administration->Search engine configuration , button at
bottom of page
4 - 'issues' and 'title' mapping under 'search fields' should be mandatory and
not editable
5 - On 'Bibliographic records' tab you should not be able to delete the single
entry for issues
6 - You should be able to delete 'title' mappings, however, at the final one
you should be stopped by javascript
7 - Bonus: force remove the last mapping from the page using developer tools -
attempt to save and should be warned of missing mandatory mapping
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 15:28:49 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 13:28:49 +0000
Subject: [Koha-bugs] [Bug 19482] Elasticsearch - prevent removal / editing
of required indexes
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19482
--- Comment #29 from Nick Clemens ---
Created attachment 93368
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93368&action=edit
Bug 19482: SCHEMA CHANGES - DO NOT PUSH
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 15:29:53 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 13:29:53 +0000
Subject: [Koha-bugs] [Bug 18084] Language selector hidden in user menu on
mobile interfaces
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18084
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Patch doesn't apply |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 15:29:56 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 13:29:56 +0000
Subject: [Koha-bugs] [Bug 18084] Language selector hidden in user menu on
mobile interfaces
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18084
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #90578|0 |1
is obsolete| |
--- Comment #2 from Owen Leonard ---
Created attachment 93369
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93369&action=edit
Bug 18084: Language selector hidden in user menu on mobile interfaces
This patch updates templates and CSS so that the language-selection menu
in the header will not be hidden if the browser width is too narrow.
This patch also makes some more general improvements to the responsive
adaptability of the header elements.
To test, apply the patch and rebuild the OPAC CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).
Test the changes by viewing pages in the OPAC and adjusting your browser
width, paying attention to how elements in the top menu adapt to
different sizes. Test under varying conditions:
- Logged in/not loggeed user
- Search history enabled and disabled
- OpacLangSelectorMode showing menu in header or not
- opacuserlogin enabled or disabled
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 15:32:10 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 13:32:10 +0000
Subject: [Koha-bugs] [Bug 23293] OPACFineNoRenewals compares against
'balance' not 'outstanding'
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23293
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |rel_19_11_candidate
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 15:33:02 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 13:33:02 +0000
Subject: [Koha-bugs] [Bug 23293] OPACFineNoRenewals compares against
'balance' not 'outstanding'
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23293
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |katrin.fischer at bsz-bw.de
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 15:36:03 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 13:36:03 +0000
Subject: [Koha-bugs] [Bug 23586] Issuing rules failing in 19.05
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23586
--- Comment #11 from Katrin Fischer ---
(In reply to Martin Renvoize from comment #10)
> This bug also applies at master to so I'm correcting the version to 'master'
> and will bring it to the attention of RMaints that it's required for a quick
> backport.
Withdrawing my complaint about variable renaming in this case :)
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 15:42:52 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 13:42:52 +0000
Subject: [Koha-bugs] [Bug 23566] Continue on device - with QR codes
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23566
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Version(s)| |19.11.00
released in| |
Status|Passed QA |Pushed to master
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 15:42:54 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 13:42:54 +0000
Subject: [Koha-bugs] [Bug 23566] Continue on device - with QR codes
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23566
--- Comment #6 from Martin Renvoize ---
Nice work!
Pushed to master for 19.11.00
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 15:45:15 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 13:45:15 +0000
Subject: [Koha-bugs] [Bug 22280] The ILL module assumes every status needs a
next/previous status
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22280
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Version(s)| |19.11.00
released in| |
Status|Passed QA |Pushed to master
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 15:45:17 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 13:45:17 +0000
Subject: [Koha-bugs] [Bug 22280] The ILL module assumes every status needs a
next/previous status
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22280
--- Comment #16 from Martin Renvoize ---
Nice work!
Pushed to master for 19.11.00
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 15:46:46 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 13:46:46 +0000
Subject: [Koha-bugs] [Bug 23684] Import items only with merging rule
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23684
--- Comment #3 from Katrin Fischer ---
So your branchcode and collection code in Koha is 2250000 - correct?
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 15:54:12 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 13:54:12 +0000
Subject: [Koha-bugs] [Bug 20888] Allow use of boolean operator 'not' in item
search
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20888
sandboxes at biblibre.com changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |sandboxes at biblibre.com
Status|Needs Signoff |Signed Off
--- Comment #15 from sandboxes at biblibre.com ---
Patch tested with a sandbox, by Amandine Zocca
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 15:54:33 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 13:54:33 +0000
Subject: [Koha-bugs] [Bug 20888] Allow use of boolean operator 'not' in item
search
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20888
sandboxes at biblibre.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #93347|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 15:54:43 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 13:54:43 +0000
Subject: [Koha-bugs] [Bug 20888] Allow use of boolean operator 'not' in item
search
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20888
--- Comment #16 from sandboxes at biblibre.com ---
Created attachment 93370
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93370&action=edit
Bug 20888: Allow use of boolean operator 'not' in item search
Test plan:
- Apply the patch
- Check that you have a 'is not' option in the third box in item search
- Check that you can exclude items from the search results with this 'is not'
option
- Check that you can still combine parameters with 'and' and 'or'
- Check that the exclusion works for custom fields (see Administration > Item
search fields)
- Check that the exclusion works for custom fields linked to authorised values
Signed-off-by: Amandine Zocca
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 16:01:38 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 14:01:38 +0000
Subject: [Koha-bugs] [Bug 8778] Add Keyword phrase search to OPAC search
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8778
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #12291|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 16:02:48 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 14:02:48 +0000
Subject: [Koha-bugs] [Bug 8778] Add Keyword phrase search to OPAC search
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8778
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Patch doesn't apply |Signed Off
--- Comment #10 from Katrin Fischer ---
The first patch was old and not needed for the suggested change. Remaining
patch now applies cleanly.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 16:08:36 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 14:08:36 +0000
Subject: [Koha-bugs] [Bug 19482] Elasticsearch - prevent removal / editing
of required indexes
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19482
Nicolas Legrand changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 16:08:43 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 14:08:43 +0000
Subject: [Koha-bugs] [Bug 19482] Elasticsearch - prevent removal / editing
of required indexes
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19482
Nicolas Legrand changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #93366|0 |1
is obsolete| |
--- Comment #30 from Nicolas Legrand ---
Created attachment 93371
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93371&action=edit
Bug 19482 - DB changes
Signed-off-by: Nicolas Legrand
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 16:08:46 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 14:08:46 +0000
Subject: [Koha-bugs] [Bug 19482] Elasticsearch - prevent removal / editing
of required indexes
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19482
Nicolas Legrand changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #93367|0 |1
is obsolete| |
--- Comment #31 from Nicolas Legrand ---
Created attachment 93372
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93372&action=edit
Bug 19482 - Add support for defining 'mandatory' mappings
To test:
1 - Apply patch
2 - ./installer/data/mysql/updatedatabase.pl
3 - Reset ES mapping: Administration->Search engine configuration , button at
bottom of page
4 - 'issues' and 'title' mapping under 'search fields' should be mandatory and
not editable
5 - On 'Bibliographic records' tab you should not be able to delete the single
entry for issues
6 - You should be able to delete 'title' mappings, however, at the final one
you should be stopped by javascript
7 - Bonus: force remove the last mapping from the page using developer tools -
attempt to save and should be warned of missing mandatory mapping
Signed-off-by: Nicolas Legrand
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 16:08:50 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 14:08:50 +0000
Subject: [Koha-bugs] [Bug 19482] Elasticsearch - prevent removal / editing
of required indexes
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19482
Nicolas Legrand changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #93368|0 |1
is obsolete| |
--- Comment #32 from Nicolas Legrand ---
Created attachment 93373
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93373&action=edit
Bug 19482: SCHEMA CHANGES - DO NOT PUSH
Signed-off-by: Nicolas Legrand
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 16:12:44 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 14:12:44 +0000
Subject: [Koha-bugs] [Bug 13193] Make Memcached usage fork safe
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 16:13:02 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 14:13:02 +0000
Subject: [Koha-bugs] [Bug 18084] Language selector hidden in user menu on
mobile interfaces
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18084
Lucas Gass changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 16:13:11 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 14:13:11 +0000
Subject: [Koha-bugs] [Bug 18084] Language selector hidden in user menu on
mobile interfaces
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18084
Lucas Gass changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #93369|0 |1
is obsolete| |
--- Comment #3 from Lucas Gass ---
Created attachment 93374
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93374&action=edit
Bug 18084: Language selector hidden in user menu on mobile interfaces
Owen, the language dropdown now looks great so I am signing off. Should the
'Clear' button in red have the same font-weight/font-size as rest of the
navbar?
This patch updates templates and CSS so that the language-selection menu
in the header will not be hidden if the browser width is too narrow.
This patch also makes some more general improvements to the responsive
adaptability of the header elements.
To test, apply the patch and rebuild the OPAC CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).
Test the changes by viewing pages in the OPAC and adjusting your browser
width, paying attention to how elements in the top menu adapt to
different sizes. Test under varying conditions:
- Logged in/not loggeed user
- Search history enabled and disabled
- OpacLangSelectorMode showing menu in header or not
- opacuserlogin enabled or disabled
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 16:15:00 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 14:15:00 +0000
Subject: [Koha-bugs] [Bug 13193] Make Memcached usage fork safe
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Version(s)| |19.11.00
released in| |
Status|Passed QA |Pushed to master
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 16:15:05 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 14:15:05 +0000
Subject: [Koha-bugs] [Bug 13193] Make Memcached usage fork safe
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193
--- Comment #42 from Martin Renvoize ---
Nice work!
Pushed to master for 19.11.00
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 16:15:56 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 14:15:56 +0000
Subject: [Koha-bugs] [Bug 19482] Elasticsearch - prevent removal / editing
of required indexes
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19482
--- Comment #33 from Nicolas Legrand ---
Thank you Nick!
Tested with Unimarc, so there isn't any issues index defined for the
Bibliographic records section. Everything went as it should for the rest of it.
It could be puzzling for the Unimarc community, because our modifications will
be blocked and we will see the message :
“You attempted to delete all mappings for a required index, you must leave at
least one mapping”
until we add an issues index in Bibliographic records.
I'm not sure this should be fixed here or in a mapping.yaml patch. Listing the
name of the required field missing in the error message could be a nice
improvement.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 16:21:39 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 14:21:39 +0000
Subject: [Koha-bugs] [Bug 18309] UNIMARC update from IFLA
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18309
Sophie MEYNIEUX changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |sophie.meynieux at biblibre.co
| |m
--- Comment #82 from Sophie MEYNIEUX ---
Last update is adding field 214
https://www.ifla.org/files/assets/uca/unimarc_updates/BIBLIOGRAPHIC/u_b_214_update2019_online_final.pdf
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 16:22:46 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 14:22:46 +0000
Subject: [Koha-bugs] [Bug 13193] Make Memcached usage fork safe
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193
--- Comment #43 from Joonas Kylmälä ---
Martin, oh noes, the dependency was not added yet to the Koha repositories?
This needs to be reverted?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 16:23:59 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 14:23:59 +0000
Subject: [Koha-bugs] [Bug 22773] Bulk Close invoices and Filter invoice view
(open/closed)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773
ByWater Sandboxes changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #93357|0 |1
is obsolete| |
--- Comment #2 from ByWater Sandboxes ---
Created attachment 93375
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93375&action=edit
Bug 22773: Bulk Close invoices and Filter invoice view (open/closed)
Signed-off-by: Andrew Fuerste-Henry
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 16:24:37 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 14:24:37 +0000
Subject: [Koha-bugs] [Bug 22773] Bulk Close invoices and Filter invoice view
(open/closed)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773
Andrew Fuerste-Henry changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
CC| |andrew at bywatersolutions.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 16:27:00 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 14:27:00 +0000
Subject: [Koha-bugs] [Bug 23705] Add a syspref to enable record locking,
so that when one record is opened to be edited,
it's read only for other users
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23705
Josef Moravec changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |josef.moravec at gmail.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 16:37:03 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 14:37:03 +0000
Subject: [Koha-bugs] [Bug 13193] Make Memcached usage fork safe
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to master |ASSIGNED
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 16:37:20 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 14:37:20 +0000
Subject: [Koha-bugs] [Bug 13193] Make Memcached usage fork safe
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #92926|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 16:37:35 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 14:37:35 +0000
Subject: [Koha-bugs] [Bug 13193] Make Memcached usage fork safe
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #92931|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 16:39:10 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 14:39:10 +0000
Subject: [Koha-bugs] [Bug 23712] New: Silence warns from
Koha/Illrequest/Logger.pm
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23712
Bug ID: 23712
Summary: Silence warns from Koha/Illrequest/Logger.pm
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: trivial
Priority: P5 - low
Component: ILL
Assignee: magnus at libriotech.no
Reporter: magnus at libriotech.no
If you run this:
$ sudo koha-shell -c "prove t/db_dependent/Illrequests.t" kohadev
you get a lot of errors like this:
no query in themelanguage at /home/vagrant/kohaclone/C4/Templates.pm line 266.
This is because C4::Templates::_get_template_file() is called with just two
parameters, when it expects a CGI object as the third parameter:
C4::Templates::_get_template_file('ill/log/', 'intranet');
Patch coming.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 16:40:16 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 14:40:16 +0000
Subject: [Koha-bugs] [Bug 23712] Silence warns from Koha/Illrequest/Logger.pm
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23712
--- Comment #1 from Magnus Enger ---
There are probably many ways to solve this, but I will propose to add a new CGI
object and pass it along. Alternative solutions welcome!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 16:43:07 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 14:43:07 +0000
Subject: [Koha-bugs] [Bug 23713] New: Subscription add form broken for
translations
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23713
Bug ID: 23713
Summary: Subscription add form broken for translations
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: major
Priority: P5 - low
Component: Serials
Assignee: koha-bugs at lists.koha-community.org
Reporter: katrin.fischer at bsz-bw.de
QA Contact: testopia at bugs.koha-community.org
CC: colin.campbell at ptfs-europe.com
It's not possible to add a new subscription using translated templates.
What I see is:
English template:
var mana_enabled = [% IF (Koha.Preference('Mana') == 1 && mana_url) %]1[% ELSE
%]0[% END %];
de-DE template:
var mana_enabled = [% IF (Koha.Preference('Mana') == 1 && mana_url) %]1[% ELSE
%][% END %];
We are also missing a semicolon in one of the lines, but this doesn't seem to
effect the page functionality:
var MSG_PATTERN_IRREG = _("Warning! Present pattern has planned
irregularities. Click on 'Test prediction pattern' to check if it's still
valid")
Thx to Michael Hoffert and Alexander Arlt from koha-de for reporting it
initially and figuring out the root of the issue!
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 16:44:24 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 14:44:24 +0000
Subject: [Koha-bugs] [Bug 23712] Silence warns from Koha/Illrequest/Logger.pm
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23712
Magnus Enger changed:
What |Removed |Added
----------------------------------------------------------------------------
Patch complexity|--- |Trivial patch
Status|NEW |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 16:44:26 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 14:44:26 +0000
Subject: [Koha-bugs] [Bug 23712] Silence warns from Koha/Illrequest/Logger.pm
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23712
--- Comment #2 from Magnus Enger ---
Created attachment 93376
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93376&action=edit
Bug 23712 - Silence warns from Koha/Illrequest/Logger.pm
To test:
- Run: $ sudo koha-shell -c "prove t/db_dependent/Illrequests.t" kohadev
- Observe the warnings about "no query in themelanguage"
- Apply the patch
- Run prove again
- Observe the lack of warnings about "no query in themelanguage"
(There will be a couple of other warnings, but they are not
related to the present bug.)
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 16:48:12 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 14:48:12 +0000
Subject: [Koha-bugs] [Bug 23713] Subscription add form broken for
translations
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23713
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Component|Serials |I18N/L10N
CC| |frederic at tamil.fr
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 16:48:43 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 14:48:43 +0000
Subject: [Koha-bugs] [Bug 22997] Searching gives no results in auth_finder.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22997
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Failed QA |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 16:48:57 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 14:48:57 +0000
Subject: [Koha-bugs] [Bug 22997] Searching gives no results in auth_finder.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22997
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #91095|0 |1
is obsolete| |
Attachment #92119|0 |1
is obsolete| |
--- Comment #9 from Nick Clemens ---
Created attachment 93377
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93377&action=edit
Bug 22997: Searching gives no results in auth_finder.pl
During cataloguing of an existing biblio, on an heading field,
the use of tag editor fills authorities finder with existing value :
Search main heading ($a only)
Search main heading
Default operator beeing 'contains'.
Actually with Elasticsearch those search give no results.
Example with heading :
200
$a Casaubon
$b Isaac
$f 1559-1614
Call to Elasticsearch :
"query" : {
"bool" : {
"must" : [
{
"query_string" : {
"query" : "Casaubon*",
"default_field" : "heading-main",
}
},
{
"query_string" : {
"query" : "(Isaac*) AND (1559-1614*)",
"default_field" : "heading"
}
}
]
}
},
"sort" : [
{
"heading__sort.phrase" : "asc"
}
]
}
Patch adds to "query_string" :
analyze_wildcard : true.
Test plan :
1) Use Elasticsearch
2) Edit an existing biblio record
3) Use tag editor on a heading
4) Click search => You get correct results
5) Check also search in authorities-home.pl
Signed-off-by: Kyle M Hall
Signed-off-by: Nick Clemens
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 16:49:01 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 14:49:01 +0000
Subject: [Koha-bugs] [Bug 22997] Searching gives no results in auth_finder.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22997
--- Comment #10 from Nick Clemens ---
Created attachment 93378
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93378&action=edit
Bug 22997: Unit test
Run prove t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t
Signed-off-by: Nick Clemens
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 16:49:25 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 14:49:25 +0000
Subject: [Koha-bugs] [Bug 23713] Subscription add form broken for
translations
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23713
--- Comment #1 from Katrin Fischer ---
To give a bit more info, the Javascript we get from the wrong TT is:
var mana_enabled = ;
So this implodes. It should be:
var mana_enabled = 0;
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 16:50:44 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 14:50:44 +0000
Subject: [Koha-bugs] [Bug 22997] Searching gives no results in auth_finder.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22997
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |nick at bywatersolutions.com
--- Comment #11 from Nick Clemens ---
The issue is searches with a '-' in the middle, like a date range
1906-1995
Square brackets '[]' actually break searching for biblios and authorities in
general in ES and must be escaped, that hould be outside the scope here for the
moment
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 16:52:26 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 14:52:26 +0000
Subject: [Koha-bugs] [Bug 22412] Elasticsearch - Second term of a boolean
research is lost after applying a facet
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22412
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|BLOCKED |RESOLVED
Resolution|--- |DUPLICATE
CC| |nick at bywatersolutions.com
--- Comment #2 from Nick Clemens ---
*** This bug has been marked as a duplicate of bug 22413 ***
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 16:52:26 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 14:52:26 +0000
Subject: [Koha-bugs] [Bug 22413] Elasticsearch - Search settings are lost
after sorting, faceting or paging
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22413
--- Comment #16 from Nick Clemens ---
*** Bug 22412 has been marked as a duplicate of this bug. ***
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 16:56:42 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 14:56:42 +0000
Subject: [Koha-bugs] [Bug 23714] New: Problem with ILLModuleUnmediated
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23714
Bug ID: 23714
Summary: Problem with ILLModuleUnmediated
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: minor
Priority: P5 - low
Component: ILL
Assignee: koha-bugs at lists.koha-community.org
Reporter: magnus at libriotech.no
If you run this:
$ sudo koha-shell -c "prove t/db_dependent/Illrequests.t" kohadev
you get this:
Use of uninitialized value in concatenation (.) or string at
/home/vagrant/kohaclone/Koha/Illrequest.pm line 857.
Use of uninitialized value in concatenation (.) or string at
/home/vagrant/kohaclone/Koha/Illrequest.pm line 859
(Among some other warnings that are fixed on bug 23712.)
Lines 857 and 859 look like this:
my $intra_tmpl = join "/", $backend_tmpl, "intra-includes",
$params->{method} . ".inc";
my $opac_tmpl = join "/", $backend_tmpl, "opac-includes",
$params->{method} . ".inc";
$params->{method} is uninitialized because of these lines in
Koha::Illrequest::backend_create():
if ( C4::Context->preference("ILLModuleUnmediated") && $permitted ) {
my $unmediated_result = $self->_backend_capability(
'unmediated_ill',
$args
);
$result = $unmediated_result if $unmediated_result;
}
This replaces whatever was in $result. So before this code you can have a
$result that looks like this:
$VAR1 = {
'stage' => 'commit',
'method' => 'create',
'permitted' => 1
};
and after the code it looks like this:
$VAR1 = {
'unmediated_ill' => 1
};
Is this the intended behaviour? If no, we should fix it (add 'unmediated_ill'
=> 1 to the existing data instead of replacing it?). If yes, we should make
expandTemplate() handle a missing method more gracefully.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 17:03:34 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 15:03:34 +0000
Subject: [Koha-bugs] [Bug 20589] Add field boosting and use elastic query
fields parameter instead of deprecated _all
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589
Alex Arnaud changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #93348|0 |1
is obsolete| |
--- Comment #60 from Alex Arnaud ---
Created attachment 93379
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93379&action=edit
Bug 20589: Add field boosting and use query_string fields parameter
Generate a list of fields for the query_string query fields parameter,
with possible boosts, instead of using "_all"-field. Also add "search"
flag in search_marc_to_field table so that certain mappings can be
excluded from searches. Add option to include/exclude fields in
query_string "fields" parameter depending on searching in OPAC or staff
client. Refactor code to remove all other dependencies on "_all"-field.
How to test:
1) Reindex authorities and biblios.
2) Search biblios and try to verify that this works as expected.
3) Search authorities and try to verify that this works as expected.
4) Go to "Search engine configuration"
5) Change some "Boost", "Staff client", and "OPAC" settings and save.
6) Verify that those settings where saved accordingly.
7) Click the "Biblios" or "Authorities" tab and change one or more
"Searchable" settings
8) Verfiy that those settings where saved accordingly.
9) Try to verify that these settings has taken effect by peforming
some biblios and/or authorities searches.
Sponsorded-by: Gothenburg Univesity Library
Signed-off-by: Nick Clemens
Signed-off-by: Alex Arnaud
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 1 17:03:43 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2019 15:03:43 +0000
Subject: [Koha-bugs] [Bug 20589] Add field boosting and use elastic query
fields parameter instead of deprecated _all
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589
Alex Arnaud changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #93349|0 |1
is obsolete| |
--- Comment #61 from Alex Arnaud ---
Created attachment 93380
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93380&action=edit
Bug 20589: fix QueryBuilder tests
Signed-off-by: Nick Clemens