[Koha-bugs] [Bug 23723] New: using exit to stop sending output to browser doesn't work under plack

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23723

            Bug ID: 23723
           Summary: using exit to stop sending output to browser doesn't
                    work under plack
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: critical
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: dpavlin at rot13.org
        QA Contact: testopia at bugs.koha-community.org

When fixing Bug 23589 Theodoros Theodoropoulos noticed that we are sending
headers and html after pdf output to browser. It seems that using just exit
isn't enough to stop plack from generating headers and html page. This was
noticed back in 2011 with Bug 5630 which added safe_exit in C4::Auth. It seems
that we need to use something similar throughout all code which gets invoked
with plack to fix this.

I'm opening this bug as placeholder until I do more testing and figure out
which parts need change and we have a lot of exit; in code:

git grep 'exit;' | wc -l
352

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.