[Koha-bugs] [Bug 23011] AuthenticatePatron could alert if password is not safe

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23011

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA
                 CC|                            |julian.maurice at biblibre.com

--- Comment #3 from Julian Maurice <julian.maurice at biblibre.com> ---
Tests are failing, but it's just the number of tests that is wrong

>  Parse errors: Bad plan.  You planned 9 tests but ran 10.

QA tool reports some errors as well:

>  FAIL   C4/ILSDI/Services.pm
>  FAIL   forbidden patterns
>               forbidden pattern: tab char (line 382)
>               forbidden pattern: tab char (line 386)
>               forbidden pattern: tab char (line 384)
>               forbidden pattern: tab char (line 383)
>               forbidden pattern: tab char (line 385)
> 
> Commit title does not start with 'Bug XXXXX: ' - de967f9fc0
> Commit title does not start with 'Bug XXXXX: ' - 23cd5391bc

Otherwise it works well, but I'm a bit concerned by the fact that the patch
duplicates the password regexp. If someone modify it in is_password_valid,
there are high chances that they will forgot to modify it in ILSDI code. Also,
it's not the only thing checked in is_password_valid (there is also a check on
whitespaces). Is it really needed to return the regexp ?

-- 
You are receiving this mail because:
You are watching all bug changes.