[Koha-bugs] [Bug 23734] New: Defaults set during patron imports throws warnings

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23734

            Bug ID: 23734
           Summary: Defaults set during patron imports throws warnings
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

To recreate:
Create a small import file, with minimal columns, tail the logs, import and
note warnings


IN DBIX/Class/Row:

elsif ($self->_is_column_numeric($col)) {  # do a numeric comparison if
datatype allows it
    return $old == $new;

But in Koha/Patrons/Import.pm

We assume "" for all defaults

Even if we pass defaults of '0' for these columns
 elsif ( $defaults->{$key} ) {
won't be triggered by a 0 value, it should be 'exists'

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.