[Koha-bugs] [Bug 22773] Bulk Close invoices and Filter invoice view (open/closed)

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #6 from Owen Leonard <oleonard at myacpl.org> ---
(In reply to Katrin Fischer from comment #3)

> - The buttons don't align - we are missing: margin: .5em 0 0; on the second
> button.

Actually the right fix would be to remove the lin in staff-global.scss for
"#merge" (currently line 3488).

> They should also be using: btn btn-default classes instead of submit.

This still needs to be fixed.

> - The alignment on the 'closed inovices' table seems a bit off. It's much
> smaller than my other table in testing and aligns 'center'.

I suggest adding "autoWidth: false" to the DataTable configuration.

By the way, I mentioned in conversation with Katrin on IRC that the
dataTables.fnFilterAll.js should be unnecessary. The source of the plugin
itself says it is deprecated:

" * DataTables 1.10+ provides this ability through its new API, which is able
to
 * to control multiple tables at a time.
 * `$('.dataTable').DataTable().search( ... )` for example will apply the same
 * filter to all tables on the page. The new API should be used in preference
 * to this older method if at all possible."

However I wasn't able to get this method to work on both tables, so it appears
the plugin is required for now.

-- 
You are receiving this mail because:
You are watching all bug changes.