[Koha-bugs] [Bug 23051] Optionally renew fine accruing items when all fines on item are paid off

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23051

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |nick at bywatersolutions.com

--- Comment #20 from Nick Clemens <nick at bywatersolutions.com> ---
Hi Andrew,

Tests need a minor rebase to pass.

I have a few questions from reading the code:

1 - You duplicate the code in Account->pay and Line->apply, could that be a
subroutine that can be shared and tested? It's minor but would be nice to avoid
duplication

2 - I don't like the lack of feedback for the renewal/failure. At the very
least maybe some feedback on the interface that the items may be renewed

3 - In the case where a renewal doesn't make the book current (i.e. the book is
overdue longer than the renewal period) I think this would give strange
results. Possibly you could consider this a configuration issue, but it should
be warned somewhere at the least

-- 
You are receiving this mail because:
You are watching all bug changes.