[Koha-bugs] [Bug 23681] Patron restrictions should be user definable

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

--- Comment #22 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Hi Kyle

Thanks for taking a look at this.

>Can Koha::RestrictionType(s) be moved to Koha::Patron::RestrictionType(s)

That's actually how I had it originally. However I moved it since, as far as I
could see, everything in Koha::Patron::* was related to a singular patron and
represented properties of that patron, which was not the case of
RestrictionTypes, which represents the canonical list of restriction types, or
a restriction type, not at all related to a patron. I'm happy to move it back
if you feel it would be better there, but wanted to explain the rationale.

>Can the table debarment_types be renamed to patron_restriction_types so our internal and external terminology match?

Again, there is a rationale behind this. I named the table "debarment_types"
because it was related to a pre-existing table "borrower_debarments" and I felt
it would be confusing to name it "restriction_types". I realise that there is a
move towards "restriction" rather than "debarment", and I have used the new
term in the parts of this bug that are truly new, but where I'm interacting
with stuff that's referring to debarments, it felt less confusing to use the
same terminology for my bits. Hopefully, at some point, a full sweep of
"debarment" => "restriction" will be done, so I felt this was a reasonable
interim balance. Again, if you'd rather it be changed, I can do so.

Many thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.