[Koha-bugs] [Bug 22539] Fines charged on back-dated checkin when item has been renewed

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22539

Stefan Berndtsson <stefan.berndtsson at ub.gu.se> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |stefan.berndtsson at ub.gu.se

--- Comment #23 from Stefan Berndtsson <stefan.berndtsson at ub.gu.se> ---
This issue has hit us as well. We calculate fines during weekends regardless of
whether or not we're closed, but if the book was returned on saturday and
sunday or monday was the first fined day, making the user pay for the book
can't be correct, right?

In AddReturn, there are a few conditions for recalculating fines.

They used to be:
  "(syspref_is_set AND is_overdue) OR explicit_return_date".

This has now been changed to:
  "(syspref_is_set AND was_overdue_on_return_date AND is_not_lost)"

Why does it check if there should be a recalculation based on the backdated
date (was_overdue_on_return_date)? The fine will still be calculated based on
the backdated date, but the condition whether or not to recalculate shouldn't
depend on the overdue status at that date.

This line in AddReturn():

$is_overdue = $issue->is_overdue( $return_date );

...used to be:

$is_overdue = $issue->is_overdue;


To me, the logical condition should be:
1. Syspref CalculateFinesOnReturn is set
2. Book is overdue right now
3. Book is not lost

-- 
You are receiving this mail because:
You are watching all bug changes.