[Koha-bugs] [Bug 23051] Optionally renew fine accruing items when all fines on item are paid off

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23051

--- Comment #25 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Hi Nick

Thanks for taking a look at this.

>Tests need a minor rebase to pass.
Fixed

>You duplicate the code in Account->pay and Line->apply [..]
Indeed. I've now refactored the duplicated code into a couple of helper
functions in Koha::Account.

>I don't like the lack of feedback for the renewal/failure [..]
This is a very tricky issue, and one I side-stepped during dev. Firstly, any
feedback would only be available in the UI. Since there is more than one way of
paying off fines that don't involve the Koha UI (e.g. SIP), those methods would
not receive the feedback. Also, since the renewal is happening as a side effect
of paying off a fine, anything that was saying "pay off the fine on this item"
will have to be expecting something entirely unrelated, i.e. "this item
couldn't renew" back, which feels wrong. I do agree that no feedback at all is
bad though. I'll have a think and see if I can come up with.

>In the case where a renewal doesn't make the book current [..]
Same as the previous one really.

I'll do some pondering...

-- 
You are receiving this mail because:
You are watching all bug changes.