[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049

--- Comment #62 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
(In reply to Marcel de Rooy from comment #58)
> Moving authorized values to new table:
> SUBSTR(authorised_value, 1, 64)
> This may be a source of trouble, at least theoretically. Why not switch from
> the 64 to 80 chars?
> 
>   `accounttype` varchar(80) default NULL,
>   `debit_type_code` varchar(64) default NULL,
>   `payment_type` varchar(80) default NULL, -- optional authorised value
> PAYMENT_TYPE
> This looks a bit inconsistent too?
> 
> Why not give the table an autoincrement id as PK and do not duplicate the
> code everywhere? Accountlines could be large, less space?

I stuck to codes here to continue the pattern for simple reporting and also to
allow for simple translations of the core system defaults where a code is
significantly simpler to remember for translators. (Discussed with Katrin at
hackfest regarding the translation comment, she was very pleased that we could
keep the existing translations in the form of the include files).

-- 
You are receiving this mail because:
You are watching all bug changes.