[Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

--- Comment #209 from Ere Maijala <ere.maijala at helsinki.fi> ---
(In reply to David Cook from comment #207)
> Comment on attachment 94109 [details] [review]
> Bug 13937: (QA follow-up) Make tests work with YAZ 4 and 5.
> 
> Review of attachment 94109 [details] [review]:
> -----------------------------------------------------------------
> 
> ::: t/db_dependent/Koha/Z3950Responder/GenericSession.t
> @@ +82,5 @@
> >      $child = fork();
> >      if ($child == 0) {
> >          my $config_dir = dirname(__FILE__) . '/';
> > +        # Copy pqf.properties from etc/z3950
> > +        copy($config_dir . '../../../../etc/z3950/pqf.properties', $config_dir . 'pqf.properties') || die "Copying pqf.properties failed: $!";
> 
> This seems a little fragile to me. I don't know what we're doing in other
> scripts, but it might be worth using https://perldoc.perl.org/FindBin.html
> here?

I'll revise. Actually, would it better to just include a copy of pqf.properties
in the test dir? It would also make sure that any changes to the default
pqf.properties don't break tests.

-- 
You are receiving this mail because:
You are watching all bug changes.