[Koha-bugs] [Bug 23780] Batch check out fails to inform or trap

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23780

Christopher Brannon <cbrannon at cdalibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |In Discussion

--- Comment #2 from Christopher Brannon <cbrannon at cdalibrary.org> ---
(In reply to Jonathan Druart from comment #1)
> Created attachment 94216 [details] [review]
> Bug 23780: Add DEBT info to batch checkouts info
> 
> DEBT can be impossible or needs confirmation.
> 
> Test plan:
> Create an invoice of 50 (and make sure 50 is above the limit)
> Check an item out using the batch checkouts feature
> => You should see the warning in the "Information" column

Technically, it works for the fines, but if I have multiple reasons, it only
shows one reason and lets you blow past the other unknowingly.

For this to work as expected, it needs to show ALL reasons.

To test:
* Set checkout limit to 5 items.
* Set MaxFine to 3
* Set borrower with a manual invoice of $5.
* Batch checkout 6 items.  You will see information on every item that the
patron has a debt of 5.00, but on the 6th item, you should ALSO see "Too many
checked out".

The problem is other items are not already checked out to trap this.  SO, what
needs to happen is either 
A) the batch checkout needs to "Look ahead" at all issues and evaluate all
potential blocks, or
B) the batch checkout needs to run through the same process again on all the
checked items and catch the next block.

Process A would be preferable so you don't have to override over and over again
through each scenario.

I want to sign off, because this is a step in the right direction, but it does
not address the multiple blocks addressed in the description of the problem.

-- 
You are receiving this mail because:
You are watching all bug changes.