[Koha-bugs] [Bug 23051] Optionally renew fine accruing items when all fines on item are paid off

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23051

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #35 from Nick Clemens <nick at bywatersolutions.com> ---
t/db_dependent/Koha/Account.t
  - test count needs adjustment
t/db_dependent/Koha/Account/Lines.t
  - tests are failing

The feedback is improved, it would be nice to get feedback on what was
successfully renewed as well. Ideally SIP would get feedback in a screen
message, and patrons would get a notice of renewal on the opac. I am also not
sure about the code path if a patron paid fines on the opac (via paypal etc.)
but renewals are not allowed on the opac. 

In general I think I would prefer to see 'ok' and 'not_ok' returned as a single
'renewal_results' array, then it can be parsed once and success and failure
returned. Our trainers would very much like there to be feedback for any
renewal, otherwise it feels a bit magic and unpredictable

There is no listing of errors if I use the 'pay' button on an individual fine,
but there is when I use 'pay amount' or 'pay selected'

I don't really like that the functions are internal functions and then exported
- fine_paid_renewable could be an accountline method? I think maybe_renew could
also be an accountline method? it could act on the item attached to fine, and
maybe names like:
renewable
renew_items


For the last point, I think the pref description should highlight that if
'RenewalPeriodBase' is set to due date, there may be doubled charges

I do really like the idea here, but I think it is a big change and needs some
refining

-- 
You are receiving this mail because:
You are watching all bug changes.