[Koha-bugs] [Bug 18743] Filter suggestion lists correctly for IndependentBranches

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18743

Séverine Queune <severine.queune at bulac.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #21 from Séverine Queune <severine.queune at bulac.fr> ---
I had a doubt concerning the settings of IndependentBranches, so for each test
I precise which of the 'Yes/No' I used.

> A. You are superlibrarian and IndependentBranches is not set
> 1. Hit /suggestion/suggestion.pl
With IndependentBranches = 'Yes'

> => Default view shows the suggestions from your library
no : I can see all the pending suggestions whatever is the fitler I used for
Library

> 2. Filter by another library
> => You see the suggestions from this library
no : same as 1.

> 3. Filter by "Any" libraries
> => You see all the suggestions
no : same as 1.

> 4. "Organize by library"
> => You see all the suggestions, organized by library
no : all the suggestions are displayed in only one tab which name is the
library I'm logged in

> 5. Filter by a specific library
> => You see the suggestion from your library, all in one tab
None of the filter boxes open when I clic on them so I can't test.
Tested with 2 different superadmin accounts, located in 2 different sites, on 2
different computers.


> B. You are not superlibrarian and IndependentBranches
> Same as A.
With IndependentBranches = 'No'
1. ok
2. ok
3. ok
4. ok
5. ok

> C. You are superlibrarian and IndependentBranches is set
> Same as A.
With IndependentBranches = 'No'
1. ok
2. ok
3. ok
4. ok
5. ok

> D. You are not superlibrarian and IndependentBranches is not set
> You will never see suggestions coming from outside your library
With IndependentBranches = 'Yes'
1. ok
2. ok : option not available as expected
3. ok : only suggestions for my site are displayed
4+5. no : if I filter on my site and then "organize by library", the table is
not displayed. I can only see it filtering on "Any". 

I wonder what is the behaviour we want to have concerning the count of
"suggestions waiting" on /koha/mainpage.pl and /acqui/acqui-home.pl : for case
D, only the pending suggestions on the site of the logged user are counted.
For the 3 other cases, all the suggestions are counted. I understand this logic
as these users can modifiy all of them, but I think it might be a little
disturbing for a user to see "x pending suggestions" and, on the suggestion
page, having an empty page because all the suggestions are made for an other
site.
Could we imagine to have something like : "Pending suggestions : my site = x /
all = y" ?

-- 
You are receiving this mail because:
You are watching all bug changes.