[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|BLOCKED                     |Failed QA

--- Comment #207 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(Minor) If you archive a debit type, you should probably be no longer allowed
to create a manual invoice with that type.
(Minor) UPDATE accountlines SET accounttype = ? WHERE accounttype = ?
=> Hope you dont have too many clashes on the prefix here ;) The algorithm now
just assumes that it should be the first one found. But hard to solve..
(Minor) UPDATE accountlines SET accounttype = 'MANUAL' WHERE accounttype = 'M'
=> How do you know that you are not moving sundry to manual fee here? Or is
that okay (did we manage to get rid of it completely) ?
(Major) t/db_dependent/api/v1/patrons_accounts.t
    not ok 5 - 200 OK
    #   Failed test '200 OK'
    #   at t/db_dependent/api/v1/patrons_accounts.t line 95.
    #          got: '500'
    #     expected: '200'
    not ok 6 - exact match for JSON Pointer ""
    #   Failed test 'exact match for JSON Pointer ""'
    #   at t/db_dependent/api/v1/patrons_accounts.t line 95.
    #     Structures begin differing at:
    #          $got->{balance} = Does not exist
    #     $expected->{balance} = '100.01'
    not ok 11 - 200 OK
    #   Failed test '200 OK'
    #   at t/db_dependent/api/v1/patrons_accounts.t line 139.
    #          got: '500'
    #     expected: '200'
    not ok 12 - exact match for JSON Pointer ""
    #   Failed test 'exact match for JSON Pointer ""'
    #   at t/db_dependent/api/v1/patrons_accounts.t line 139.
    #     Structures begin differing at:
    #          $got->{outstanding_debits} = Does not exist
    #     $expected->{outstanding_debits} = HASH(0x55d12cacfd80)
=> Some other tests with API calls do pass.
(Major) Three other tests still fail. Related to new constraint on type check.

-- 
You are receiving this mail because:
You are watching all bug changes.