[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823

--- Comment #168 from Alex Arnaud <alex.arnaud at biblibre.com> ---
(In reply to Nick Clemens from comment #150)
> Minor conflict from new clipboard feature on rancor
Rebased
> 
> Preferences.Save( [% loggelogged_in_user.borrowernumber | $raw %] );
> Should be 'logged_in_user'?
Fixed
> 
> This is very awesome! It seems to work as expected for the most part, but I
> found some functional issues that I think must be addressed:
> 
> After saving duplicate we should use the new record number and duplicate
> should be unchecked - is essentially 'Save as new'?
> 
> Checking 'Catalog record ##' and 'New catalog record' would imply duplicate,
> but it doesn't do that - maybe we shouldn't have 'New catalog record' when
> editing an existing record?
> 
> Similarly, saving as 'Duplicate' and 'New catalog record' creates two new
> records if I uncheck the current record.
I'm quite confused with this "Duplicate" batch. It's apparently the same as
"New catalog record".
But "New record" almost works as we want: After saving, the new record id is
checked. Almost because we may
uncheck "New record" (?).

At the start, the "Duplicate" batch is not intented to appear in the batch list
(and so not intented to be checked).
The feature come from Bug 16232 and is used from the record detail page.
Bug 23436 make this batch appear properly in the lits.

I'm not the initiator of this feature. So i'm listening to the librarians for
how to use these "Duplicate", "New record".
Feedbacks are welcome.

> 
> Saving to "Batch: test" and "test: #5" is confusing, do I need to check
> both? the Batch seems superfluous, I am not sure that unchecking the
> specific record and selecting only the batch is clear that we are creating a
> new record, maybe if a specific record is not checked we can show "Batch:
> test (new record)"

"Batch: test" is the current batch you are working on. 
We keep it checked so that you can create new records and save them without to
re-check the batch.

"test: #5" tells you are working on the record #5 saved in the test batch.

If you save again a record keeping "Batch: test" and "test: #5" checked. The
record is updated in the batch.
If you uncheck "test: #5" and save, we try to save a new record with the same
id in the batch Test => Error, duplicate id
Keeping only "test: #5" checked seems also updating the record in the batch.

Once again i would appreciate some feedback from Rancor users.

-- 
You are receiving this mail because:
You are watching all bug changes.