[Koha-bugs] [Bug 23858] Vendors endpoint not setting the Location header

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Tue Oct 22 12:59:21 CEST 2019


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23858

--- Comment #7 from Joonas Kylmälä <joonas.kylmala at helsinki.fi> ---
(In reply to Tomás Cohen Arazi from comment #6)
> (In reply to Joonas Kylmälä from comment #5)
> > Instead of making a follow-up to your own commit please squash the 201
> > regression tests to the first patch "Bug 23858: Regression tests" and make
> > the fix separate
> 
> Well, it is not a 'fix'. I actually wanted to honor the rule that
> refactoring patches should be separate from those introducing the behavior
> change so we can keep track of things better. The refactoring could have
> happened on a separate bug I reckon.
> 
> Yesterday I've finished the patrons one as well. Submitting today

Oh, I misread the patch earlier, I thought it was adding that 201 check as new
test but I now see it tested it earlier already for 200 return code. Sorry for
this confusion, will sign-off this soon.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list