[Koha-bugs] [Bug 23233] AllowItemsOnHoldCheckout is misnamed and does not indicate it is for SIP-based checkouts only

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23233

Joonas Kylmälä <joonas.kylmala at helsinki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #91114|0                           |1
        is obsolete|                            |

--- Comment #11 from Joonas Kylmälä <joonas.kylmala at helsinki.fi> ---
Created attachment 94526
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94526&action=edit
Bug 23233: AllowItemsOnHoldCheckout is misnamed and does not indicate it is for
SIP-based checkouts only

The system preference AllowItemsOnHoldCheckout only affects SIP based
checkouts. I believe we should rename it AllowItemsOnHoldCheckoutSIP so it
matches AllowItemsOnHoldCheckoutSCO. We should also update the description as
well.

As far as I know AllowItemsOnHoldCheckout has never affected anything except
SIP traffic. That does not preclude the addition of another
AllowItemsOnHoldCheckout syspref that would affect the staff interface, but
that would be an enhancement and is outside the scope of this bug report.

Test Plan:
1) Test AllowItemsOnHoldCheckout via SIP
2) Apply this patch
3) Test AllowItemsOnHoldCheckoutSIP via SIP
4) Note there is no difference!
5) Note the syspref description has been update to mention SIP

Signed-off-by: Joonas Kylmälä <joonas.kylmala at helsinki.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.