[Koha-bugs] [Bug 23051] Optionally renew fine accruing items when all fines on item are paid off

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23051

--- Comment #40 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Hi Nick

>I am also not sure about the code path if a patron paid fines on the opac (via paypal etc.) but renewals are not allowed on the opac.

Looking at the code, the OPAC PayPal payment would cause items to be renewed as
part of the fine payment. The same applies if the site is using the WPM or
Capita payment plugins, I'm not sure of any others though I suspect the same
would also be true for any payment plugin, essentially anything that pays the
fines using the Koha::Account::pay function.

I'm unsure what to do here. There seems to be a convention of passing a "note"
parameter when calling the "pay" function. With the OPAC PayPal payment, the
note is passed as "PayPal", with Capita it's "Pay360 Payment" etc. So, we could
have a blacklist (not sure which would be best), which prevented the renewal
from happening if the payment was passed a note containing one of these values,
though that seems a bit fragile.

If we are going to prevent renewal for payments made via the OPAC, we should
probably highlight that in the syspref.

Any thoughts?

-- 
You are receiving this mail because:
You are watching all bug changes.