[Koha-bugs] [Bug 22706] Add plugin hooks to enable Norwegian national patron database

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22706

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
QA comments.. discussed in IRC but adding here for note.

1) The password check should be done before the call to `$self =
$self->SUPER::store;` to ensure we throw an error before the patron data is
stored.
2) The plugin should respect the 'skip_validation' parameter when passed to
set_password.

Otherwise, I'm generally happy with the approach here.

Side note.. I wasn't entirely sure how plugins should interact with the
existing system preferences available for password enforcement. (whether the
plugin should work along with the existing preferences or outright replace
them)  As it stands they will work in combination with system preferences..
this issue can be easily resolved by documenting how they interact... I'm happy
with either approach.

-- 
You are receiving this mail because:
You are watching all bug changes.