[Koha-bugs] [Bug 23068] Add ability for Koha to handle X-Forwarded-For headers so REMOTE_ADDR features work behind a proxy

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068

--- Comment #20 from Kyle M Hall <kyle at bywatersolutions.com> ---
(In reply to David Cook from comment #19)
> Comment on attachment 94807 [details] [review]
> Bug 23068: Add ability for Koha to handle X-Forwarded-For headers so
> REMOTE_ADDR features work behind a proxy
> 
> Review of attachment 94807 [details] [review]:
> -----------------------------------------------------------------
> 
> ::: C4/Context.pm
> @@ +1107,5 @@
> > +
> > +=cut
> > +
> > +sub set_remote_address {
> > +    if ( C4::Context->config('koha_trusted_proxies') ) {
> 
> Wouldn't this still be called under Plack?
> 
> Couldn't we just look to see if it's Plack via environmental variables and
> only do this for CGI?

That's a good thought. Is there an environment variable that is set for scripts
running under plack?

-- 
You are receiving this mail because:
You are watching all bug changes.