[Koha-bugs] [Bug 22581] Add support for Plaine & Easie musical incipits rendering in OPAC

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22581

--- Comment #12 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Minor QA comments.

* We appear to load the verovio css regardless of the syspref settings
* I think we seem to load the midi player JS even if we're only interested in
displaying the musical notation (this might be me just not understanding the
way the library code works)
* The clips seem to play very quickly to me.. I'm no musician though so perhaps
they're playing at the proper speed?
* I'm sure how the $u subfield is intended to work.. you suggest in the test
plan that it is required for this feature.. or is that simply to prove that $u
still displays correctly when the verovio incipit are in place?

Generally, I really like this feature and think we can probably do some
cleaning up in followups. 

I'm going to let this one slip past the Slush deadline a little so we should
still make it before the freeze.

-- 
You are receiving this mail because:
You are watching all bug changes.