From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 00:38:58 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 31 Aug 2019 22:38:58 +0000
Subject: [Koha-bugs] [Bug 23527] New: BakerTaylorBookstoreURL is converted
to escaped characters by template, rendering it invalid
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23527
Bug ID: 23527
Summary: BakerTaylorBookstoreURL is converted to escaped
characters by template, rendering it invalid
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: trivial
Priority: P5 - low
Component: OPAC
Assignee: oleonard at myacpl.org
Reporter: techservspec at gmail.com
QA Contact: testopia at bugs.koha-community.org
The url stored in the preference BakerTaylorBookstoreURL is rendered in
opac-detail.tt with escaped characters (including the "/", "?" and "="
characters which are designating subdirectories and parameters), thus making
the resulting link invalid.
For example:
The URL used for BakerTaylorBookstoreURL is
https://contentcafe2.btol.com/ContentCafeClient/ContentCafe.aspx?UserID=
However, what is rendered in the OPAC is
https://contentcafe2.btol.com%2FContentCafeClient%2FContentCafe.aspx%3FUserID%3D
To test this (requires a Baker & Taylor username and id):
1. Enter
contentcafe2.btol.com/ContentCafeClient/ContentCafe.aspx?UserID=(your
username)&Password=(your password)&ItemKey=
into the BakerTaylorBookstoreURL preference and enable Baker & Taylor images.
2. Display a record that has a cover image in the OPAC.
3. Click on the image. You are not redirected to the above url (in firefox
nothing happens, in chrome you are directed to "about:blank#blocked").
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 00:39:37 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 31 Aug 2019 22:39:37 +0000
Subject: [Koha-bugs] [Bug 23527] BakerTaylorBookstoreURL is converted to
escaped characters by template, rendering it invalid
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23527
David Kuhn changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |techservspec at gmail.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 01:08:52 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 31 Aug 2019 23:08:52 +0000
Subject: [Koha-bugs] [Bug 23527] BakerTaylorBookstoreURL is converted to
escaped characters by template, rendering it invalid
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23527
--- Comment #1 from David Kuhn ---
This also occurs in opac-search.tt.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 01:15:36 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 31 Aug 2019 23:15:36 +0000
Subject: [Koha-bugs] [Bug 23527] BakerTaylorBookstoreURL is converted to
escaped characters by template, rendering it invalid
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23527
--- Comment #2 from David Kuhn ---
Sorry, I mean opac-results.tt
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 01:38:05 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 31 Aug 2019 23:38:05 +0000
Subject: [Koha-bugs] [Bug 23527] BakerTaylorBookstoreURL is converted to
escaped characters by template, rendering it invalid
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23527
David Kuhn changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 01:38:08 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 31 Aug 2019 23:38:08 +0000
Subject: [Koha-bugs] [Bug 23527] BakerTaylorBookstoreURL is converted to
escaped characters by template, rendering it invalid
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23527
--- Comment #3 from David Kuhn ---
Created attachment 92516
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92516&action=edit
Bug 23527 - BakerTaylorBookstoreURL is converted to escaped characters by
template, rendering it invalid
Changing the template toolkit filter for rendering the value of
BakerTaylorBookstoreURL in opac-detail.tt and opac-results.tt from uri to url
fixes the problem.
To test (requires a Baker & Taylor username and password):
1. Enter the B&T url into BakerTaylorBookstoreURL.
2. Set BakerTaylorEnabled to "add" and enter your username and password.
3. Look up a title in the OPAC.
4. Locate a title with a cover image.
5. Click on the cover image. You are not redirected to the url stored in
BakerTaylorBookstoreURL.
6. Display the full record for the title
7. Click on the cover image. You are not redirected to the url stored in
BakerTaylorBookstoreURL.
8. Apply the patch.
9. Refresh the OPAC display.
10. Click on the cover image. You are now redirected to the specified url.
11. Return to the results list.
12. Click on a cover image. You are now redirected to the specified url.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 16:46:28 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Sep 2019 14:46:28 +0000
Subject: [Koha-bugs] [Bug 23273] Downloading from overdues.pl doesn't use
set filters
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23273
--- Comment #10 from Jonathan Druart ---
(In reply to Katrin Fischer from comment #8)
> We are missing a filter here, should be an easy fix, but was not sure which
> one to use here:
>
> FAIL koha-tmpl/intranet-tmpl/prog/en/modules/circ/overdue.tt
> FAIL filters
> missing_filter at line 39 ( [% url_params = BLOCK %][%
> url_params %]&[% var | uri %]=[% filters.$var | uri %][% END %])
>
> Leaving PQA for now.
Martin, you added:
- [% url_params = BLOCK %][% url_params %]&[% var | uri %]=[%
filters.$var | uri %][% END %]
+ [% url_params = BLOCK %][% url_params | uri %]&[% var | uri
%]=[% filters.$var | uri %][% END %]
It feel wrong, it should be $raw, otherwise it will be double encoded.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 16:57:21 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Sep 2019 14:57:21 +0000
Subject: [Koha-bugs] [Bug 20307] Language overlay for authorized values
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20307
--- Comment #46 from Jonathan Druart ---
(In reply to Katrin Fischer from comment #45)
> I started with testing the DEPARTMENT again.
>
> I added a de-DE translation for the DEPARTMENT. None for en.
>
> 1) The language de-DE is not activated, but it starts to show the
> translation I added for German in the English interface. dep-dei - internal
> staff description in the table below, shows in the English OPAC GUI.
> Staff/OPAC might be a template issue, but still wondering why it shows up in
> the English GUI?
Where? When editing/adding a course reserve I see the default (untranslated)
value.
> 2) In staff admin:
> My translation for OPAC description shows as description in the OPAC summary
> (the OPAC description column being empty). When I edit the OPAC description,
> the translation shows there. So maybe just something wrong on the list of
> values?
I do not get that one, sorry. Could you provide a screenshot?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 17:35:07 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Sep 2019 15:35:07 +0000
Subject: [Koha-bugs] [Bug 23273] Downloading from overdues.pl doesn't use
set filters
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23273
--- Comment #11 from Jonathan Druart ---
Also, there was a debug statement:
+use Data::Printer colored => 1; warn p $filters;
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 17:35:53 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Sep 2019 15:35:53 +0000
Subject: [Koha-bugs] [Bug 23273] Downloading from overdues.pl doesn't use
set filters
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23273
--- Comment #12 from Jonathan Druart ---
Created attachment 92517
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92517&action=edit
Bug 23273: Remove debug statement
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 19:47:18 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Sep 2019 17:47:18 +0000
Subject: [Koha-bugs] [Bug 23038] Expected warnings displayed by tests should
be hidden
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23038
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Failed QA |Signed Off
--- Comment #6 from Jonathan Druart ---
All ok for me, could you please retest?
kohadev-koha at kohadevbox:/home/vagrant/kohaclone$ prove
t/db_dependent/Circulation/MarkIssueReturned.t
t/db_dependent/Circulation/MarkIssueReturned.t .. ok
All tests successful.
Files=1, Tests=3, 4 wallclock secs ( 0.01 usr 0.01 sys + 3.13 cusr 0.50
csys = 3.65 CPU)
Result: PASS
kohadev-koha at kohadevbox:/home/vagrant/kohaclone$ prove
t/db_dependent/Suggestions.t
t/db_dependent/Suggestions.t .. ok
All tests successful.
Files=1, Tests=110, 7 wallclock secs ( 0.05 usr 0.01 sys + 5.26 cusr 1.26
csys = 6.58 CPU)
Result: PASS
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 20:25:29 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Sep 2019 18:25:29 +0000
Subject: [Koha-bugs] [Bug 14293] Error in the calculation of the suspension
of users per day
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14293
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|jonathan.druart at bugs.koha-c |koha-bugs at lists.koha-commun
|ommunity.org |ity.org
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 20:34:23 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Sep 2019 18:34:23 +0000
Subject: [Koha-bugs] [Bug 23210] login4tags should be a link
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23210
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 20:34:28 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Sep 2019 18:34:28 +0000
Subject: [Koha-bugs] [Bug 23210] login4tags should be a link
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23210
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #92512|0 |1
is obsolete| |
Attachment #92513|0 |1
is obsolete| |
--- Comment #9 from Jonathan Druart ---
Created attachment 92518
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92518&action=edit
Bug 23210: login4tags should be a link
TEST PLAN:
1. Make sure TagsEnabled and TagsInputOnList are set to allow.
2. Don't be logged into the OPAC.
3. Make a search and notice the 'Log in to add tags' text is not a link
on the results page.
4. Apply patch
5. Refresh OPAC results page
6. 'Log in to add tags' takes you to the login page.
Signed-off-by: Owen Leonard
Signed-off-by: Michal Denar
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 20:34:32 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Sep 2019 18:34:32 +0000
Subject: [Koha-bugs] [Bug 23210] login4tags should be a link
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23210
--- Comment #10 from Jonathan Druart ---
Created attachment 92519
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92519&action=edit
Bug 23210: (follow-up) Log in for tags link should trigger modal
This patch modifies the "Log in to add tags" link on the OPAC search
results page, adding the class which is used elsewhere in the OPAC
templates for triggering the login modal.
Also: Removed an unnecessary period.
To test, apply the patch and follow the original test plan. Clicking the
"Log in to add tags" link should trigger the login modal. After logging
in you should be returned to the page you were on.
Signed-off-by: Michal Denar
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 20:49:06 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Sep 2019 18:49:06 +0000
Subject: [Koha-bugs] [Bug 23397] Order lines can be duplicated in acqui
scripts spent.pl and ordered.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23397
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jonathan.druart at bugs.koha-c
| |ommunity.org
--- Comment #13 from Jonathan Druart ---
I was completely stuck with circ/pendingreserves.pl because of the use of
GROUP_CONCAT. It makes things super hard to rewrite. Do not we have another
option?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 20:56:30 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Sep 2019 18:56:30 +0000
Subject: [Koha-bugs] [Bug 23397] Order lines can be duplicated in acqui
scripts spent.pl and ordered.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23397
--- Comment #14 from Jonathan Druart ---
I do not have much to suggest apart from rewriting the scripts from scratch,
which seems quite out of the scope ;)
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 21:25:50 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Sep 2019 19:25:50 +0000
Subject: [Koha-bugs] [Bug 23289] Label Template - Creation not working
(MariaDB >= 10.2.4)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23289
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks|17258 |
Summary|Label Template - Creation |Label Template - Creation
|not working with SQL strict |not working (MariaDB >=
|mode enabled |10.2.4)
Assignee|cnighswonger at foundations.ed |jonathan.druart at bugs.koha-c
|u |ommunity.org
Version|19.05 |master
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258
[Bug 17258] [OMNIBUS] MySQL 5.7
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 21:25:50 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Sep 2019 19:25:50 +0000
Subject: [Koha-bugs] [Bug 17258] [OMNIBUS] MySQL 5.7
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on|23289 |
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23289
[Bug 23289] Label Template - Creation not working (MariaDB >= 10.2.4)
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 21:29:20 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Sep 2019 19:29:20 +0000
Subject: [Koha-bugs] [Bug 23289] Label Template - Creation not working
(MariaDB >= 10.2.4)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23289
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 21:29:25 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Sep 2019 19:29:25 +0000
Subject: [Koha-bugs] [Bug 23289] Label Template - Creation not working
(MariaDB >= 10.2.4)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23289
--- Comment #7 from Jonathan Druart ---
Created attachment 92520
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92520&action=edit
Bug 23289: Quote new 'rows' MariaDB reserved word
Since MariaDB 10.2.4 rows is a reserved word:
https://mariadb.com/kb/en/library/mariadb-1024-release-notes/
"""
New reserved word: ROWS. This can no longer be used as an identifier
without being quoted.
"""
Test plan:
With MariaDB >= 10.2.4, create a new label template.
Also, prove t/db_dependent/Labels/t_Template.t
Without this patch you will get the following SQL error: DBD::mysql::st execute
failed: You have an error in your SQL syntax; check the manual that corresponds
to your MariaDB server version for the right syntax to use near 'rows, creator,
template_code, page_height,
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 21:39:22 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Sep 2019 19:39:22 +0000
Subject: [Koha-bugs] [Bug 23484] Holds to pull (pendingreserves.pl) uses
removed default_branch_item_rules table
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23484
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jonathan.druart at bugs.koha-c
| |ommunity.org
Severity|enhancement |major
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 21:39:37 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Sep 2019 19:39:37 +0000
Subject: [Koha-bugs] [Bug 23484] Holds to pull (pendingreserves.pl) uses
removed default_branch_item_rules table
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23484
--- Comment #3 from Jonathan Druart ---
The error is:
DBD::mysql::st execute failed: Table 'koha_kohadev.default_branch_item_rules'
doesn't exist [for Statement "SELECT min(reservedate) as l_reservedate,
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 21:44:59 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Sep 2019 19:44:59 +0000
Subject: [Koha-bugs] [Bug 23484] Holds to pull (pendingreserves.pl) uses
removed default_branch_item_rules table
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23484
--- Comment #4 from Jonathan Druart ---
I am wondering if we should not retrieve the list of itemtypes for which the
holds are allowed, then use them in the WHERE clause.
It will make the query more readable and we will remove a LEFT JOIN. What do
you think?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 21:48:53 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Sep 2019 19:48:53 +0000
Subject: [Koha-bugs] [Bug 19249] Date picker broken in "Quick add new
patron" form
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19249
--- Comment #4 from Jonathan Druart ---
Yes, as well as all other date fields.
As Fridolin said we should rework the way the fields are displayed/hidden. It's
not an easy fix.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 21:57:54 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Sep 2019 19:57:54 +0000
Subject: [Koha-bugs] [Bug 23247] Simplify visibility logic in
opac-MARCdetail.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23247
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jonathan.druart at bugs.koha-c
| |ommunity.org
--- Comment #8 from Jonathan Druart ---
(In reply to M. Tompsett from comment #6)
> I believe I have rebased it correctly to be off bug 22721 as mentioned by
> Katrin in comment #4. As such, I'm happy to leave it back at Needs Signoff.
Why did not you sign it off?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 22:02:55 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Sep 2019 20:02:55 +0000
Subject: [Koha-bugs] [Bug 23079] Checkouts page broken because of problems
with date calculation (TZAmerica/Sao_Paulo)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23079
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Failed QA |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 22:03:00 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Sep 2019 20:03:00 +0000
Subject: [Koha-bugs] [Bug 23079] Checkouts page broken because of problems
with date calculation (TZAmerica/Sao_Paulo)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23079
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #90939|0 |1
is obsolete| |
--- Comment #15 from Jonathan Druart ---
Created attachment 92521
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92521&action=edit
Bug 23079: Add tests
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 22:14:25 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Sep 2019 20:14:25 +0000
Subject: [Koha-bugs] [Bug 23210] login4tags should be a link
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23210
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #92518|0 |1
is obsolete| |
Attachment #92519|0 |1
is obsolete| |
--- Comment #11 from Katrin Fischer ---
Created attachment 92522
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92522&action=edit
Bug 23210: login4tags should be a link and included in every search result
TEST PLAN:
1. Make sure TagsEnabled and TagsInputOnList are set to allow.
2. Don't be logged into the OPAC.
3. Make a search and notice the 'Log in to add tags' text is not a link
on the results page.
4. Apply patch
5. Refresh OPAC results page
6. 'Log in to add tags' takes you to the login page.
Signed-off-by: Owen Leonard
Signed-off-by: Michal Denar
Signed-off-by: Michal Denar
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 22:14:32 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Sep 2019 20:14:32 +0000
Subject: [Koha-bugs] [Bug 23210] login4tags should be a link
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23210
--- Comment #12 from Katrin Fischer ---
Created attachment 92523
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92523&action=edit
Bug 23210: (follow-up) Log in for tags link should trigger modal
This patch modifies the "Log in to add tags" link on the OPAC search
results page, adding the class which is used elsewhere in the OPAC
templates for triggering the login modal.
Also: Removed an unnecessary period.
To test, apply the patch and follow the original test plan. Clicking the
"Log in to add tags" link should trigger the login modal. After logging
in you should be returned to the page you were on.
Signed-off-by: Michal Denar
Signed-off-by: Michal Denar
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 22:18:27 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Sep 2019 20:18:27 +0000
Subject: [Koha-bugs] [Bug 23528] New: Show 'log in to add tags' link on all
search result entries
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23528
Bug ID: 23528
Summary: Show 'log in to add tags' link on all search result
entries
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: minor
Priority: P5 - low
Component: OPAC
Assignee: oleonard at myacpl.org
Reporter: katrin.fischer at bsz-bw.de
QA Contact: testopia at bugs.koha-community.org
Splitting this out as a separate bug report from bug 23210:
(In reply to Lucas Gass from comment #0)
> If a non-authenticated user goes to the search results page they will only
> see the login4tags (Log in to add tags ) text included with the first
> result. This should be included with every result.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 22:19:34 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Sep 2019 20:19:34 +0000
Subject: [Koha-bugs] [Bug 23210] login4tags should be a link
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23210
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |katrin.fischer at bsz-bw.de
--- Comment #13 from Katrin Fischer ---
(In reply to Lucas Gass from comment #0)
> If a non-authenticated user goes to the search results page they will only
> see the login4tags (Log in to add tags ) text included with the first
> result. This should be included with every result.
This part is still not fixed - I've filed a new bug.
Bug 23528 - Show 'log in to add tags' link on all search result entries
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 22:19:40 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Sep 2019 20:19:40 +0000
Subject: [Koha-bugs] [Bug 23528] Show 'log in to add tags' link on all
search result entries
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23528
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on| |23210
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23210
[Bug 23210] login4tags should be a link
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 22:19:40 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Sep 2019 20:19:40 +0000
Subject: [Koha-bugs] [Bug 23210] login4tags should be a link
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23210
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |23528
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23528
[Bug 23528] Show 'log in to add tags' link on all search result entries
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 22:22:01 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Sep 2019 20:22:01 +0000
Subject: [Koha-bugs] [Bug 23518] Problem with borrower search autocomplete
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23518
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |katrin.fischer at bsz-bw.de
--- Comment #4 from Katrin Fischer ---
Seeing a sign off from Nick and Michal - should this not be PQA? Taking a quick
look.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 22:35:03 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Sep 2019 20:35:03 +0000
Subject: [Koha-bugs] [Bug 23518] Problem with borrower search autocomplete
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23518
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 22:35:07 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Sep 2019 20:35:07 +0000
Subject: [Koha-bugs] [Bug 23518] Problem with borrower search autocomplete
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23518
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #92511|0 |1
is obsolete| |
--- Comment #5 from Katrin Fischer ---
Created attachment 92524
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92524&action=edit
Bug 23518: Problem with borrower search autocomplete
This patch fixes a bug introduced by my patch for Bug 23405: Keyboard
navigation of patron autocomplete results was broken because I
incorrectly assumed that the autocomplete "select" action was redundant
because keyboard navigation would trigger the selected link. It doesn't!
This patch adds the "select" action back to the autocomplete
configuration, explicitly defining a redirect to match the URL which is
followed if the user uses the mouse to click a result.
To test you should have a patron in your database which has no card
number. Make sure CircAutocompl is enabled.
- From the circulation home page, type a patron name in the "Check out"
form and wait for autocomplete search results to display.
- Making a selection from the autocomplete results should work by
clicking with a mouse OR using the arrow keys and TAB or ENTER.
- Test with patrons with and without card numbers.
Signed-off-by: Nick Clemens
Signed-off-by: Michal Denar
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 22:36:27 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Sep 2019 20:36:27 +0000
Subject: [Koha-bugs] [Bug 23411] SMS messages should not fall back to 'email'
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23411
Michal Denar changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |black23 at gmail.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 22:59:49 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Sep 2019 20:59:49 +0000
Subject: [Koha-bugs] [Bug 23079] Checkouts page broken because of problems
with date calculation (TZAmerica/Sao_Paulo)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23079
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Patch complexity|--- |Small patch
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 23:00:09 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Sep 2019 21:00:09 +0000
Subject: [Koha-bugs] [Bug 23079] Checkouts page broken because of problems
with date calculation (TZAmerica/Sao_Paulo)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23079
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #90940|0 |1
is obsolete| |
--- Comment #16 from Katrin Fischer ---
Created attachment 92525
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92525&action=edit
Bug 23079: Handle invalid timezones when adding/subtracting durations
On Nov 3rd 2019, Brazil will skip from 00:00 to 1:00
(http://www.currenttimeonline.com/dst/dst.do?tz=America/Sao_Paulo), DateTime
consider it as an invalid date.
It is a problem when we are playing with dates without the time part (always
00:00).
When we instantiate a DateTime (from dt_from_string) we are already handling
this issue, and use the floating timezone (since bug 12669).
The problem remains when we generate a DateTime then add or subtract a
duration, which will result in an invalid date:
DateTime->new(year => 2019, month => 12, day => 3, time_zone =>
'America/Sao_Paulo')->subtract(days => 30);
=> Nov 3rd 2019, kaboom.
We should replace all the problematic occurrences of dt_from_string->subtract
(or ->add)
with dt_from_string(undef, undef, 'floating'), to use the floating timezone and
avoid the error.
Actually there are not many of them, I have found only 3 that could
produce real problems.
The other occurrences are:
- in tests => Not a big deal (for now)
- called on a datetime, so it will explode if called at midnight
00:00:00 (and nobody should work at that time).
Test plan:
0/ Define the timezone to 'America/Sao_Paulo' (in your koha-conf.xml file),
restart_all
1/ Set a patron's expiry date to Dec 3rd 2019, and
NotifyBorrowerDeparture to 30 (default value)
2/ See the checkouts page for this user
=> Without this patch you get "Invalid local time for date in time zone:
America/Sao_Paulo"
=> With this patch apply the page displays correctly
QA will review the 2 other occurrences.
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 23:00:27 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Sep 2019 21:00:27 +0000
Subject: [Koha-bugs] [Bug 23079] Checkouts page broken because of problems
with date calculation (TZAmerica/Sao_Paulo)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23079
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #92521|0 |1
is obsolete| |
--- Comment #17 from Katrin Fischer ---
Created attachment 92526
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92526&action=edit
Bug 23079: Add tests
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 23:04:22 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Sep 2019 21:04:22 +0000
Subject: [Koha-bugs] [Bug 23273] Downloading from overdues.pl doesn't use
set filters
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23273
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #92517|0 |1
is obsolete| |
--- Comment #13 from Katrin Fischer ---
Created attachment 92527
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92527&action=edit
Bug 23273: Remove debug statement
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 23:04:43 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Sep 2019 21:04:43 +0000
Subject: [Koha-bugs] [Bug 23273] Downloading from overdues.pl doesn't use
set filters
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23273
--- Comment #14 from Katrin Fischer ---
Moving into PQA queue for better visibility.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 23:04:52 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Sep 2019 21:04:52 +0000
Subject: [Koha-bugs] [Bug 23273] Downloading from overdues.pl doesn't use
set filters
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23273
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to master |ASSIGNED
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 23:04:59 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Sep 2019 21:04:59 +0000
Subject: [Koha-bugs] [Bug 23273] Downloading from overdues.pl doesn't use
set filters
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23273
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 23:05:05 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Sep 2019 21:05:05 +0000
Subject: [Koha-bugs] [Bug 23273] Downloading from overdues.pl doesn't use
set filters
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23273
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 23:05:13 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Sep 2019 21:05:13 +0000
Subject: [Koha-bugs] [Bug 23273] Downloading from overdues.pl doesn't use
set filters
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23273
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 23:08:09 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Sep 2019 21:08:09 +0000
Subject: [Koha-bugs] [Bug 23038] Expected warnings displayed by tests should
be hidden
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23038
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |katrin.fischer at bsz-bw.de
--- Comment #7 from Katrin Fischer ---
Hm, I see 2 QA script violations with this patch:
FAIL t/db_dependent/Circulation/MarkIssueReturned.t
FAIL critic
# Variables::ProhibitUnusedVariables: Got 1 violation(s).
FAIL t/db_dependent/Suggestions.t
FAIL critic
# Variables::ProhibitUnusedVariables: Got 1 violation(s).
But all tests pass.
Joubu, could you please take a look at those?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 23:08:15 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Sep 2019 21:08:15 +0000
Subject: [Koha-bugs] [Bug 23038] Expected warnings displayed by tests should
be hidden
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23038
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Failed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 23:30:50 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Sep 2019 21:30:50 +0000
Subject: [Koha-bugs] [Bug 23289] Label Template - Creation not working
(MariaDB >= 10.2.4)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23289
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Patch complexity|--- |Small patch
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 23:31:08 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Sep 2019 21:31:08 +0000
Subject: [Koha-bugs] [Bug 23289] Label Template - Creation not working
(MariaDB >= 10.2.4)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23289
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #92520|0 |1
is obsolete| |
--- Comment #8 from Katrin Fischer ---
Created attachment 92528
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92528&action=edit
Bug 23289: Quote new 'rows' MariaDB reserved word
Since MariaDB 10.2.4 rows is a reserved word:
https://mariadb.com/kb/en/library/mariadb-1024-release-notes/
"""
New reserved word: ROWS. This can no longer be used as an identifier
without being quoted.
"""
Test plan:
With MariaDB >= 10.2.4, create a new label template.
Also, prove t/db_dependent/Labels/t_Template.t
Without this patch you will get the following SQL error: DBD::mysql::st execute
failed: You have an error in your SQL syntax; check the manual that corresponds
to your MariaDB server version for the right syntax to use near 'rows, creator,
template_code, page_height,
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 23:38:53 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Sep 2019 21:38:53 +0000
Subject: [Koha-bugs] [Bug 23512] Reindent notices and slips page (letter.tt)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23512
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 23:38:58 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Sep 2019 21:38:58 +0000
Subject: [Koha-bugs] [Bug 23512] Reindent notices and slips page (letter.tt)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23512
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #92509|0 |1
is obsolete| |
--- Comment #3 from Katrin Fischer ---
Created attachment 92529
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92529&action=edit
Bug 23512: Reindent notices and slips page (letter.tt)
This patch re-indents the template for notices and slips. It
makes only whitespace changes. It should have no effect on the behavior
of the page.
To test, go to Tools -> Notices & slips.
Test every aspect of the notice creation and edit process. At each step
the page should work correctly.
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 23:39:03 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Sep 2019 21:39:03 +0000
Subject: [Koha-bugs] [Bug 23512] Reindent notices and slips page (letter.tt)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23512
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #92510|0 |1
is obsolete| |
--- Comment #4 from Katrin Fischer ---
Created attachment 92530
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92530&action=edit
Bug 23512: (follow-up) Markup comments and corrections
This patch adds comments to the template to highlight the markup
structure. It also corrects some minor markup errors.
This patch should have no effect on the interface or functionality.
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 23:41:25 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Sep 2019 21:41:25 +0000
Subject: [Koha-bugs] [Bug 23525] ISBD view uses view policy of ACQ framework
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23525
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |katrin.fischer at bsz-bw.de
--- Comment #1 from Katrin Fischer ---
Yes, I think this should have no effect on the ISBD views in ACQ and/or catalog
pages, it seems counter-intuitive.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 23:41:37 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Sep 2019 21:41:37 +0000
Subject: [Koha-bugs] [Bug 23525] ISBD view uses view policy of ACQ framework
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23525
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on| |19289
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289
[Bug 19289] Allow configuration of the fields on the 'Catalog details' form in
the acquisition baskets
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 23:41:37 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Sep 2019 21:41:37 +0000
Subject: [Koha-bugs] [Bug 19289] Allow configuration of the fields on the
'Catalog details' form in the acquisition baskets
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |23525
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23525
[Bug 23525] ISBD view uses view policy of ACQ framework
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 23:45:51 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Sep 2019 21:45:51 +0000
Subject: [Koha-bugs] [Bug 22602] OverDrive circulation integration is broken
when user is referred to Koha from another site
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22602
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |katrin.fischer at bsz-bw.de
--- Comment #5 from Katrin Fischer ---
Is there any way to test this without an Overdrive account? Or way to get one
for testing purposes?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 23:54:57 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Sep 2019 21:54:57 +0000
Subject: [Koha-bugs] [Bug 14851] Change terminology for budget being
"locked" to "disabled"
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14851
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |WONTFIX
--- Comment #2 from Katrin Fischer ---
Closing, please reopen, if you disagree. See also: bug 23524 and bug 22786 for
some newer developments.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 23:56:57 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Sep 2019 21:56:57 +0000
Subject: [Koha-bugs] [Bug 14857] shouldn't be allowed to receive from locked
fund
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14857
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |INVALID
Status|NEW |RESOLVED
CC| |katrin.fischer at bsz-bw.de
--- Comment #1 from Katrin Fischer ---
According to documentation, locked should not allow to modify:
https://koha-community.org/manual/19.05/en/html/administration.html?highlight=locked#budgets
Locking a budget means that funds will not be able to be modified by librarians
I read this like it should not affect the ordering/receiving process, but the
moving from amounts between funds or similar.
Closing, please reopen if you disagree.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 23:59:18 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Sep 2019 21:59:18 +0000
Subject: [Koha-bugs] [Bug 23524] Can modify/delete funds for locked budgets
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23524
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.koha-community
| |.org/bugzilla3/show_bug.cgi
| |?id=14851,
| |https://bugs.koha-community
| |.org/bugzilla3/show_bug.cgi
| |?id=14857
CC| |katrin.fischer at bsz-bw.de
--- Comment #1 from Katrin Fischer ---
I would think that changing the funds in the budget should be not allowed,
while we should still allow ordering and receiving (active/inactive works for
that).
The manual states:
https://koha-community.org/manual/19.05/en/html/administration.html?highlight=locked#budgets
Locking a budget means that funds will not be able to be modified by librarians
It doesn't work this way yet, but we could fix it.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 23:59:18 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Sep 2019 21:59:18 +0000
Subject: [Koha-bugs] [Bug 14851] Change terminology for budget being
"locked" to "disabled"
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14851
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.koha-community
| |.org/bugzilla3/show_bug.cgi
| |?id=23524
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 23:59:18 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Sep 2019 21:59:18 +0000
Subject: [Koha-bugs] [Bug 14857] shouldn't be allowed to receive from locked
fund
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14857
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.koha-community
| |.org/bugzilla3/show_bug.cgi
| |?id=23524
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 23:59:33 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Sep 2019 21:59:33 +0000
Subject: [Koha-bugs] [Bug 23524] Can modify/delete funds for locked budgets
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23524
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on| |22786
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22786
[Bug 22786] Can create new funds for locked budgets
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 23:59:33 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Sep 2019 21:59:33 +0000
Subject: [Koha-bugs] [Bug 22786] Can create new funds for locked budgets
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22786
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |23524
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23524
[Bug 23524] Can modify/delete funds for locked budgets
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 00:06:06 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Sep 2019 22:06:06 +0000
Subject: [Koha-bugs] [Bug 22854] Add separate column for administrative
locked patron
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22854
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |katrin.fischer at bsz-bw.de
--- Comment #3 from Katrin Fischer ---
I think that changing the pref resulting in unlocking users makes sense to me.
You might figure out you don't want to use the feature after all, so setting a
high value will help.
Having 2 columns will allow to have an administrative lock and a
too_many_attempts lock at the same time... but it makes me wonder if we could
just have 1 new column for the administrative lock as boolean? And keep the
failed_attempts behaviour.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 00:09:49 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Sep 2019 22:09:49 +0000
Subject: [Koha-bugs] [Bug 22552] Adding users to serials routing search
requires edit_borrowers permission
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22552
--- Comment #2 from Katrin Fischer ---
I think routing_list permission should be enough here. If you are supposed to
work with routing lists, you will need to see the patrons added to the list,
print it, and I think also modify and create routing lists (you need the search
for that).
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 00:10:35 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Sep 2019 22:10:35 +0000
Subject: [Koha-bugs] [Bug 23517] Incorrect permission requirements for holds
operations via the API
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23517
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |katrin.fischer at bsz-bw.de
--- Comment #3 from Katrin Fischer ---
(In reply to Owen Leonard from comment #2)
> I think we can work within the permissions definitions the staff client
> enforces right now, and I think you've got it right:
>
> - 'place_holds' allows changes to any hold detail except priority
> - 'modify_holds_priority' allows changes to priority independently of any
> other detail
+1
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 00:35:33 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Sep 2019 22:35:33 +0000
Subject: [Koha-bugs] [Bug 23501] Drag-and-drop hold reordering in the staff
client
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23501
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |katrin.fischer at bsz-bw.de
--- Comment #7 from Katrin Fischer ---
Could we add one of these warnings when you try to leave the page without
saving?
I like that you kept the arrows for now. I wonder if we need the arrows for
accessibility of if the priority pull down would be enough.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 03:11:12 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Sep 2019 01:11:12 +0000
Subject: [Koha-bugs] [Bug 16357] Plack error logs are not time stamped
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357
--- Comment #46 from David Cook ---
I have some thoughts on this one.
Firstly, why are we using Log::Log4perl::Appender::File at all? It doesn't make
sense, unless you're going to be logging to custom files independent of your
webserver. Since we're already leveraging the log file directives of Apache or
Starman and expecting to use their log files, let's just use
Log::Log4perl::Appender::Screen and set log4perl.appender.Screen.stderr = 1 to
log to STDERR. Easy as. Then the log files would be handled automagically by
the web servers.
If we, for some reason, must use Log::Log4perl::Appender::File, then let's use
application-specific webserver-independent log files.
So that's probably what we *should* do. Let's look at what we're currently
doing...
--
Looking at /etc/logrotate.d/koha-common, it looks like "sharedscripts" will
imply "create" which in the absence of configuration will use the existing file
attributes. That explains why the rotated log files are the same as the ones
that came before them. (The only issue there would be if you switched from
Apache to Plack and didn't chmod the files in the process I suppose.)
I took a look at ./etc/log4perl.conf and
./debian/templates/log4perl-site.conf.in, and it looks like the defaults are
the Apache logs.
I suppose that is technically OK if Apache is running Koha as a set of CGI
scripts, but really doesn't make sense if you're running Koha as a PSGI app.
--
In summary, I think the issue is with our Log4Perl default configuration, and
not a permissions issue per se.
I'm looking at a Koha running Plack at the moment, and it looks like the
Log4Perl appenders aren't even used. I'm guessing that they silently fail since
the Starman user can't write to the root owned Apache files.
--
Alas, I don't have time to work on this, but that's my 2 cents. I'd say the
easiest solution is to change to Log::Log4perl::Appender::Screen and set
log4perl.appender.Screen.stderr = 1, and then not worry about managing the log
files outside the web servers.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 07:15:38 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Sep 2019 05:15:38 +0000
Subject: [Koha-bugs] [Bug 19457] If CheckPrevCheckout is set to "Do",
then checkouts are blocked at the SIPServer
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19457
David Cook changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |dcook at prosentient.com.au
--- Comment #27 from David Cook ---
How is this system preference being checked? I don't see any code that directly
references "CheckPrevCheckout"? I just see templates.
I must be missing something painfully obvious, but I don't see it.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 07:45:11 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Sep 2019 05:45:11 +0000
Subject: [Koha-bugs] [Bug 23039] Hold found modal on checkin screen (
circulation.pl ) obscures Check in message info
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23039
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |katrin.fischer at bsz-bw.de
Status|Signed Off |Failed QA
--- Comment #14 from Katrin Fischer ---
(In reply to Nick Clemens from comment #13)
> I like this one Owen, I didn't like the way the dialogs disappeared when the
> modal appeared though. I am wondering if we can simply leave them in place?
> While we can bring the modal back up, it might be nice to keep the messages
> in place. I tried making them show on modal hide, but that added more page
> flicker
>
> Feel free to SO or obsolete my follow-up, I won't argue strongly
Owen, could you take a look please? (Back to signed off after, please :) )
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 07:53:33 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Sep 2019 05:53:33 +0000
Subject: [Koha-bugs] [Bug 23464] Update the process of quick spine label
printing
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23464
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |katrin.fischer at bsz-bw.de
--- Comment #6 from Katrin Fischer ---
I am testing this with the sample data and the callnumber is not showing up for
me in the print preview:
3999900000018
005.13/3
Can someone confirm?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 07:56:53 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Sep 2019 05:56:53 +0000
Subject: [Koha-bugs] [Bug 23464] Update the process of quick spine label
printing
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23464
--- Comment #7 from Katrin Fischer ---
(In reply to Katrin Fischer from comment #6)
> I am testing this with the sample data and the callnumber is not showing up
> for me in the print preview:
>
> 3999900000018
> 005.13/3
>
> Can someone confirm?
Fixed... the item didn't have a callnumber saved. What I saw was the unsafed
suggestion from the itemcallnumber syspref in the edit form...
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 07:58:26 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Sep 2019 05:58:26 +0000
Subject: [Koha-bugs] [Bug 23464] Update the process of quick spine label
printing
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23464
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 07:58:29 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Sep 2019 05:58:29 +0000
Subject: [Koha-bugs] [Bug 23464] Update the process of quick spine label
printing
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23464
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #92459|0 |1
is obsolete| |
--- Comment #8 from Katrin Fischer ---
Created attachment 92531
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92531&action=edit
Bug 23464: Update the process of quick spine label printing
This patch makes changes to the way quick spine label printing works,
either from the bibliographic details page or the Quick spine label
creator page.
To test, apply the patch and go to Tools -> Quick spine label creator.
- Type or scan a barcode. Submitting the form should trigger a popup
window with the spine label print page. The "print" button should
be centered at the bottom of the window in a footer-like container.
- If you have SpineLabelAutoPrint enabled, the print dialog should
appear automatically.
- After printing, the pop-up window should close and and focus should
be returned to the barcode field.
Enable the SpineLabelShowPrintOnBibDetails system preference. View the
bibliographic details page for a record in the catalog.
- In the holdings table, a "Spine label" column should appear as the
second-to-last column. The column should contain "Print label"
Bootstrap-style buttons.
- Clicking a "Print label" button should trigger a pop-up window with
the spine label print page. The behavior of the window should be the
same as above.
Signed-off-by: Maryse Simard
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 07:58:33 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Sep 2019 05:58:33 +0000
Subject: [Koha-bugs] [Bug 23464] Update the process of quick spine label
printing
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23464
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #92460|0 |1
is obsolete| |
--- Comment #9 from Katrin Fischer ---
Created attachment 92532
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92532&action=edit
Bug 23464: (follow-up) QA fixes
This patch corrects two issues raised during testing:
- Move JavaScript out of template check for IntranetUserJS so that
SpineLabelAutoPrint behavior works correctly.
- Add "close" button to pop-up window for cases when the barcode was
not found.
Also changed:
- Added "required" attribute to barcode input on quick spine
label printing page so that submitting an empty form will not work.
- Tweaked CSS slightly to fix alignment of spine label form and submit
button. (You must rebuild the staff client CSS:
https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client)
Signed-off-by: Maryse Simard
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 08:08:07 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Sep 2019 06:08:07 +0000
Subject: [Koha-bugs] [Bug 21852] Add more columns and column configuration
to overdues report
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21852
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Failed QA
--- Comment #31 from Katrin Fischer ---
I wanted to go ahead and squash, but there is a slight conflict with the
datatables update I think. I tried to fix it, but failed - can you have a look
please?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 08:12:10 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Sep 2019 06:12:10 +0000
Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Patch doesn't apply
--- Comment #90 from Katrin Fischer ---
I am sorry, but there are a lot of conflicts now with this patch.
With bug 14570 pushed, this might need to be reworked.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 08:19:02 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Sep 2019 06:19:02 +0000
Subject: [Koha-bugs] [Bug 22445] Ability to define a URL for custom cover
images
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445
--- Comment #71 from Katrin Fischer ---
(In reply to Kyle M Hall from comment #69)
> This looks pretty good, but I have one request; can you use Template Toolkit
> syntax instead of yet another bespoke syntax? If we standardize on TT for
> all templating we'll make everyone's lives much simpler.
I am not sure about that tbh, because the TT syntax is hard for users. With the
notices we still have trouble because of lack of documentation, lack of
'knowing the right variable names'. There is also a security risk we discussed
in other spots, as it allows you to use regex and similar and possibly do harm
with it.
That said, I think this is stuck on Jonathan's question about the MARC syntax.
Would it be possible to move this forward as is and treat the TT as possible
enhancement later on? Or allow TT syntax additionally?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 08:19:48 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Sep 2019 06:19:48 +0000
Subject: [Koha-bugs] [Bug 23377] bulkmarcimport.pl disables syspref caching
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23377
David Cook changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |dcook at prosentient.com.au
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 08:21:23 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Sep 2019 06:21:23 +0000
Subject: [Koha-bugs] [Bug 22217] error "Connection to the memcached servers
'__MEMCACHED_SERVERS__' failed" during install
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22217
David Cook changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |dcook at prosentient.com.au
--- Comment #1 from David Cook ---
These are more so warnings than errors. I think you can safely ignore them,
although Koha really should be updated to prevent the warnings from showing in
the first place.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 08:30:51 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Sep 2019 06:30:51 +0000
Subject: [Koha-bugs] [Bug 14293] Error in the calculation of the suspension
of users per day
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14293
--- Comment #38 from Katrin Fischer ---
(In reply to Koha Team Lyon 3 from comment #37)
> But for the moment, I'm not sure a lot of libraries are using it....
> Sonia
We have 2 or 3 libraries using it currently (one is in Spain, it appears common
there too).
I haven't read through all the bug to see what it changes, just wanted to leave
a note that this is probably a wider used feature.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 08:31:40 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Sep 2019 06:31:40 +0000
Subject: [Koha-bugs] [Bug 19457] If CheckPrevCheckout is set to "Do",
then checkouts are blocked at the SIPServer
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19457
Mason James changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |mtj at kohaaloha.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 08:47:47 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Sep 2019 06:47:47 +0000
Subject: [Koha-bugs] [Bug 19819] C4::Context->dbh is unreasonably slow
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19819
David Cook changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |dcook at prosentient.com.au
--- Comment #14 from David Cook ---
(In reply to Jonathan Druart from comment #9)
> Did you try this patch in production? I am expecting regressions on the
> issues with had on bug 14778 (like "server has gone away").
This was exactly what I was going to say. Database connection caching is a nice
idea but not something you want to implement naively.
I'd suggest not trying to re-invent the wheel on this one, and look somewhere
else for database connection pooling.
And actually looking at C4::Context::dbh... I see that
Koha::Database->schema->storage->dbh... which does cache the $schema object in
a package level variable.
This bug report was opened nearly 2 years ago, so maybe it is no longer
relevant.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 09:04:05 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Sep 2019 07:04:05 +0000
Subject: [Koha-bugs] [Bug 15341] Performance - Retrieve all sysprefs at once
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15341
David Cook changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |dcook at prosentient.com.au
--- Comment #23 from David Cook ---
Looks like an old one, but I've often wondered why we haven't fetched all the
system preferences at once to avoid subsequent calls to the database.
I suppose it does introduce overhead though as you are getting everything when
in practice you might only use a few preferences. And the more preferences you
have, the slower that fetch will become. It wouldn't scale.
I suppose the L1/L2 caching we have now should take care of this, although I'm
trying to see where the L2 cache gets intialized...
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 09:05:22 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Sep 2019 07:05:22 +0000
Subject: [Koha-bugs] [Bug 13193] Discussion: strategy for diagnosing
memcache issues.
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193
David Cook changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |dcook at prosentient.com.au
--- Comment #3 from David Cook ---
I might also be having some caching issues where the wrong system preference
value seems to be coming back from the caches, but still digging into that
one...
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 09:55:28 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Sep 2019 07:55:28 +0000
Subject: [Koha-bugs] [Bug 19457] If CheckPrevCheckout is set to "Do",
then checkouts are blocked at the SIPServer
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19457
--- Comment #28 from Matthias Meusburger ---
See comment #16, CheckPrevCheckout is checked by
wants_check_for_previous_checkout in Koha/Patron.pm
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 10:23:53 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Sep 2019 08:23:53 +0000
Subject: [Koha-bugs] [Bug 23529] New: Interlibrary loan javascript is broken
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23529
Bug ID: 23529
Summary: Interlibrary loan javascript is broken
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: major
Priority: P5 - low
Component: ILL
Assignee: koha-bugs at lists.koha-community.org
Reporter: andrew.isherwood at ptfs-europe.com
This was caused by an overzealous fix in Bug 23229. A fix was appended as a
follow-up patch on 23229 but Katrin advised that it should be a new bug, hence
this one.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 10:31:07 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Sep 2019 08:31:07 +0000
Subject: [Koha-bugs] [Bug 23529] Interlibrary loan javascript is broken
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23529
--- Comment #1 from Andrew Isherwood ---
Created attachment 92533
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92533&action=edit
Bug 23529: Narrow scope of changed
Whilst working on something else, it came to light that the previous fix
in bug 23229 was waaaaay too heavy handed and basically kills all ILL
related JS :( This is obviously a big problem, this patch fixes that.
The main problem is that all the ILL related JS is in a single file,
which isn't ideal as bits of it are used on different pages. Ideally,
we'd refactor it out into more manageable chunks which can be included
as required. Until such a time, this patch will do, it just prevents the
"get all requests" AJAX request unless you're on the ILL list page.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 10:32:19 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Sep 2019 08:32:19 +0000
Subject: [Koha-bugs] [Bug 23529] Interlibrary loan javascript is broken
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23529
Andrew Isherwood changed:
What |Removed |Added
----------------------------------------------------------------------------
Priority|P5 - low |P1 - high
Depends on| |23229
Status|NEW |Needs Signoff
CC| |katrin.fischer at bsz-bw.de
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23229
[Bug 23229] "Get all requests" API call fired when loading any ILL page
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 10:32:19 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Sep 2019 08:32:19 +0000
Subject: [Koha-bugs] [Bug 23229] "Get all requests" API call fired when
loading any ILL page
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23229
Andrew Isherwood changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |23529
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23529
[Bug 23529] Interlibrary loan javascript is broken
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 10:33:07 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Sep 2019 08:33:07 +0000
Subject: [Koha-bugs] [Bug 23229] "Get all requests" API call fired when
loading any ILL page
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23229
--- Comment #17 from Andrew Isherwood ---
Thanks Katrin, Bug 23529 now addresses this.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 10:33:52 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Sep 2019 08:33:52 +0000
Subject: [Koha-bugs] [Bug 23390] Add placeholder syntax for column names
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23390
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on| |23206
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23206
[Bug 23206] Batch patron modification from reports which return cardnumber
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 10:33:52 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Sep 2019 08:33:52 +0000
Subject: [Koha-bugs] [Bug 23206] Batch patron modification from reports
which return cardnumber
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23206
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |23390
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23390
[Bug 23390] Add placeholder syntax for column names
--
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.
From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 11:36:29 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Sep 2019 09:36:29 +0000
Subject: [Koha-bugs] [Bug 23529] Interlibrary loan javascript is broken
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23529
--- Comment #2 from Andrew Isherwood ---
Test plan:
- Go to "ILL requests" page
- TEST: Observe that the table loads all ILL requests
- Go to the "New ILL request" page for any installed backend
- TEST: Check the browser dev tools "Network" panel, observe that the
/api/v1/illrequests?embed=metadata,patron,capabilities,library,status_alias,comments,requested_partners
request is not made.
- Go to "Manage request" page for a request
- TEST: Check that the "ILL request log" and "Display supplier metadata"
buttons work
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 13:07:59 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Sep 2019 11:07:59 +0000
Subject: [Koha-bugs] [Bug 23428] Self registration with a verification by
email is broken
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23428
Fridolin SOMERS changed:
What |Removed |Added
----------------------------------------------------------------------------
Version(s)|19.11.00,19.05.03 |19.11.00,19.05.03,18.11.09
released in| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 14:16:06 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Sep 2019 12:16:06 +0000
Subject: [Koha-bugs] [Bug 23436] Save to 'undefined' showing in Advanced
cataloging editor
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23436
Fridolin SOMERS changed:
What |Removed |Added
----------------------------------------------------------------------------
Version(s)|19.11.00 |19.11.00,19.05.04
released in| |
CC| |fridolin.somers at biblibre.co
| |m
Status|Pushed to master |Pushed to stable
--- Comment #8 from Fridolin SOMERS ---
Pushed to 19.05.x for 19.05.04
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 14:17:01 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Sep 2019 12:17:01 +0000
Subject: [Koha-bugs] [Bug 23441] Export should not include the 'actions'
column in Z3950 results
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23441
Fridolin SOMERS changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
CC| |fridolin.somers at biblibre.co
| |m
Status|Pushed to master |RESOLVED
--- Comment #5 from Fridolin SOMERS ---
Depends on Bug 23307 not in 19.05.x
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 14:19:28 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Sep 2019 12:19:28 +0000
Subject: [Koha-bugs] [Bug 23319] Reloading page when adding to basket from
existing order can cause internal server error
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23319
Fridolin SOMERS changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to master |Pushed to stable
Version(s)|19.11.00 |19.11.00,19.05.04
released in| |
CC| |fridolin.somers at biblibre.co
| |m
--- Comment #6 from Fridolin SOMERS ---
Pushed to 19.05.x for 19.05.04
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 14:27:50 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Sep 2019 12:27:50 +0000
Subject: [Koha-bugs] [Bug 23408] Relatives' checkout table columns are not
configured properly
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23408
Fridolin SOMERS changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on| |19719
CC| |fridolin.somers at biblibre.co
| |m
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19719
[Bug 19719] Add a new column for collection in the patron checkouts data table
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 14:27:50 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Sep 2019 12:27:50 +0000
Subject: [Koha-bugs] [Bug 19719] Add a new column for collection in the
patron checkouts data table
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19719
Fridolin SOMERS changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |23408
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23408
[Bug 23408] Relatives' checkout table columns are not configured properly
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 14:28:24 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Sep 2019 12:28:24 +0000
Subject: [Koha-bugs] [Bug 23408] Relatives' checkout table columns are not
configured properly
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23408
--- Comment #7 from Fridolin SOMERS ---
Caused by Bug 19719 which added collection column only in circulation.tt
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 14:35:34 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Sep 2019 12:35:34 +0000
Subject: [Koha-bugs] [Bug 23408] Relatives' checkout table columns are not
configured properly
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23408
Fridolin SOMERS changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to master |Pushed to stable
Version(s)|19.11.00 |19.11.00,19.05.04
released in| |
--- Comment #8 from Fridolin SOMERS ---
Pushed to 19.05.x for 19.05.04
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 14:39:41 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Sep 2019 12:39:41 +0000
Subject: [Koha-bugs] [Bug 23413] Add a holds routine to Koha::Items to fetch
related holds
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23413
Fridolin SOMERS changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |fridolin.somers at biblibre.co
| |m
--- Comment #6 from Fridolin SOMERS ---
Fix terminology corrects POD, but vars are still incorrect :
my $transfer_rs = $self->_result->reserves->search($params);
Should be my $holds_rs ?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 14:49:44 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Sep 2019 12:49:44 +0000
Subject: [Koha-bugs] [Bug 23438] Use Font Awesome icons in intranet search
results browser
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23438
Fridolin SOMERS changed:
What |Removed |Added
----------------------------------------------------------------------------
Version(s)|19.11.00 |19.11.00,19.05.04
released in| |
Status|Pushed to master |Pushed to stable
--- Comment #7 from Fridolin SOMERS ---
Small enhancement, I choose to backport.
Pushed to 19.05.x for 19.05.04
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 15:02:28 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Sep 2019 13:02:28 +0000
Subject: [Koha-bugs] [Bug 23385] Hide default value fields by default on
patron import
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23385
Fridolin SOMERS changed:
What |Removed |Added
----------------------------------------------------------------------------
Version(s)|19.11.00 |19.11.00,19.05.04
released in| |
CC| |fridolin.somers at biblibre.co
| |m
Status|Pushed to master |Pushed to stable
--- Comment #8 from Fridolin SOMERS ---
Small enhancement, I choose to backport.
Pushed to 19.05.x for 19.05.04
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 15:03:59 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Sep 2019 13:03:59 +0000
Subject: [Koha-bugs] [Bug 23390] Add placeholder syntax for column names
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23390
Fridolin SOMERS changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to master |RESOLVED
CC| |fridolin.somers at biblibre.co
| |m
Resolution|--- |FIXED
--- Comment #18 from Fridolin SOMERS ---
Depends on Bug 23206 not in 19.05.x
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 15:12:50 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Sep 2019 13:12:50 +0000
Subject: [Koha-bugs] [Bug 20954] Add ability to set syspref overrides in SIP
as we can in Apache
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20954
Fridolin SOMERS changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|Pushed to master |RESOLVED
CC| |fridolin.somers at biblibre.co
| |m
--- Comment #8 from Fridolin SOMERS ---
Enhancement not pushed to 19.05.x
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 15:20:36 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Sep 2019 13:20:36 +0000
Subject: [Koha-bugs] [Bug 23291] Allow selecting patrons by smsalertnumber
in batch patron modification
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23291
Fridolin SOMERS changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |fridolin.somers at biblibre.co
| |m
--- Comment #6 from Fridolin SOMERS ---
Since Bug 23206 you can run batch patron modification from reports.
Could you use it to select patrons by SMS alert number ?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 15:49:26 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Sep 2019 13:49:26 +0000
Subject: [Koha-bugs] [Bug 13552] Add debar option to batch patron
modification
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13552
Fridolin SOMERS changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |fridolin.somers at biblibre.co
| |m
--- Comment #15 from Fridolin SOMERS ---
I think there is a problem.
$infos->{debarred} is used by AddDebarment() but also in Koha::Patrons->find(
$borrowernumber )->set($infos)->store.
In this case borrowers.debarred in DB with get the entered date, even if there
is an existing debarment with a greater date. This column must be set only by
Patron::Debarments.
I think $infos->{debarred} must be deleted after beeing used by AddDebarment().
Same for debarredcomment.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 15:56:08 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Sep 2019 13:56:08 +0000
Subject: [Koha-bugs] [Bug 22272] Calendar: When entering date ranges grey
out dates in the past from the start date
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22272
Fridolin SOMERS changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |fridolin.somers at biblibre.co
| |m
--- Comment #11 from Fridolin SOMERS ---
Patch only adds the line :
$("#dateofrange").datepicker( "option", "minDate",
$(this).datepicker("getDate")); //ensure end date can't be before start date
Other changes are just spaces changes.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 15:56:47 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Sep 2019 13:56:47 +0000
Subject: [Koha-bugs] [Bug 22272] Calendar: When entering date ranges grey
out dates in the past from the start date
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22272
Fridolin SOMERS changed:
What |Removed |Added
----------------------------------------------------------------------------
Version(s)|19.11.00 |19.11.00,19.05.04
released in| |
Status|Pushed to master |Pushed to stable
--- Comment #12 from Fridolin SOMERS ---
Pushed to 19.05.x for 19.05.04
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 16:22:06 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Sep 2019 14:22:06 +0000
Subject: [Koha-bugs] [Bug 16219] Runreport.pl should allow SQL parameters to
be passed on the command line
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16219
Fridolin SOMERS changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to master |Pushed to stable
Version(s)|19.11.00 |19.11.00,19.05.04
released in| |
CC| |fridolin.somers at biblibre.co
| |m
--- Comment #12 from Fridolin SOMERS ---
Small but powerfull enhancement, I choose to backport.
Pushed to 19.05.x for 19.05.04
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 16:36:12 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Sep 2019 14:36:12 +0000
Subject: [Koha-bugs] [Bug 23309] Can't add new subfields to bibliographic
frameworks in strict mode
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23309
Fridolin SOMERS changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |fridolin.somers at biblibre.co
| |m
Version(s)|19.11.00 |19.11.00,19.05.04
released in| |
Status|Pushed to master |Pushed to stable
--- Comment #15 from Fridolin SOMERS ---
Pushed to 19.05.x for 19.05.04
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 16:40:57 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Sep 2019 14:40:57 +0000
Subject: [Koha-bugs] [Bug 23242] Error when adding new Z39.50/SRU server in
DB strict mode
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23242
Fridolin SOMERS changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to master |Pushed to stable
Version(s)|19.11.00 |19.11.00,19.05.04
released in| |
CC| |fridolin.somers at biblibre.co
| |m
--- Comment #5 from Fridolin SOMERS ---
Pushed to 19.05.x for 19.05.04
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 16:47:36 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Sep 2019 14:47:36 +0000
Subject: [Koha-bugs] [Bug 23446] Fix display issue with serials navigation
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23446
Fridolin SOMERS changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |fridolin.somers at biblibre.co
| |m
Version(s)|19.11.00 |19.11.00,19.05.04
released in| |
Status|Pushed to master |Pushed to stable
--- Comment #5 from Fridolin SOMERS ---
Pushed to 19.05.x for 19.05.04
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 16:49:47 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Sep 2019 14:49:47 +0000
Subject: [Koha-bugs] [Bug 22830] correct for loop in
value_builder/unimarc_field_4XX.pl value_builder
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22830
Fridolin SOMERS changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to master |Pushed to stable
Version(s)|19.11.00 |19.11.00,19.05.04
released in| |
--- Comment #6 from Fridolin SOMERS ---
Pushed to 19.05.x for 19.05.04
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 17:11:36 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Sep 2019 15:11:36 +0000
Subject: [Koha-bugs] [Bug 23291] Allow selecting patrons by smsalertnumber
in batch patron modification
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23291
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |katrin.fischer at bsz-bw.de
--- Comment #7 from Katrin Fischer ---
(In reply to Fridolin SOMERS from comment #6)
> Since Bug 23206 you can run batch patron modification from reports.
> Could you use it to select patrons by SMS alert number ?
I think not easily, if you have a list of numbers, there is no easy (or
possible?) way to enter them into a runtim parameter. So it's a lot of more
steps to get the link.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 17:22:09 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Sep 2019 15:22:09 +0000
Subject: [Koha-bugs] [Bug 21027] Totals in statistics tab change when
StatisticsFields is changed
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21027
Fridolin SOMERS changed:
What |Removed |Added
----------------------------------------------------------------------------
Version(s)|19.11.00,19.05.03 |19.11.00,19.05.03,18.11.09
released in| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 02:34:03 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Sep 2019 00:34:03 +0000
Subject: [Koha-bugs] [Bug 19457] If CheckPrevCheckout is set to "Do",
then checkouts are blocked at the SIPServer
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19457
--- Comment #29 from David Cook ---
(In reply to Matthias Meusburger from comment #28)
> See comment #16, CheckPrevCheckout is checked by
> wants_check_for_previous_checkout in Koha/Patron.pm
Thanks, Matt. The reason I didn't see it before was that it checks
"checkPrevCheckout" rather than "CheckPrevCheckout". My grep search was case
sensitive and I totally missed it heh.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 04:20:40 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Sep 2019 02:20:40 +0000
Subject: [Koha-bugs] [Bug 22623] Item location and status details missing
from Your Cart display on OPAC if any attached item has a status of
Withdrawn.
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22623
Mason James changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |mtj at kohaaloha.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 06:01:03 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Sep 2019 04:01:03 +0000
Subject: [Koha-bugs] [Bug 23530] New: Opac-basket.pl script accidentally
displays 'hidden' items
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23530
Bug ID: 23530
Summary: Opac-basket.pl script accidentally displays 'hidden'
items
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P5 - low
Component: OPAC
Assignee: oleonard at myacpl.org
Reporter: mtj at kohaaloha.com
QA Contact: testopia at bugs.koha-community.org
The opac-basket.pl script (opac cart feature) seems to accidentally display
'hidden' items.
It seems the script intends to skip 'hidden' items, but actually skips *non*
'hidden' items instead
it seems to be a trivial fix, confirmed on master and 18.11.08 branches
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 06:09:15 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Sep 2019 04:09:15 +0000
Subject: [Koha-bugs] [Bug 23530] Opac-basket.pl script accidentally displays
'hidden' items
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23530
Mason James changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 06:09:18 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Sep 2019 04:09:18 +0000
Subject: [Koha-bugs] [Bug 23530] Opac-basket.pl script accidentally displays
'hidden' items
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23530
--- Comment #1 from Mason James ---
Created attachment 92534
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92534&action=edit
Bug 23530 - Opac-basket.pl script accidentally displays 'hidden' items
to test patch..
- prep a test bib with hidden and other items
- add bib to cart
observe that hidden items are displayed - non-hidden items are hidden
- apply patch, reload page
observe that hidden items are hidden, non-hidden items are displayed
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 06:11:42 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Sep 2019 04:11:42 +0000
Subject: [Koha-bugs] [Bug 23530] Opac-basket.pl script accidentally displays
'hidden' items
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23530
--- Comment #2 from Mason James ---
Created attachment 92535
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92535&action=edit
before patch, WITHDRAWN item displayed
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 06:12:59 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Sep 2019 04:12:59 +0000
Subject: [Koha-bugs] [Bug 23530] Opac-basket.pl script accidentally displays
'hidden' items
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23530
--- Comment #3 from Mason James ---
Created attachment 92536
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92536&action=edit
after patch, WITHDRAWN item hidden
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 06:17:49 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Sep 2019 04:17:49 +0000
Subject: [Koha-bugs] [Bug 23530] Opac-basket.pl script accidentally displays
'hidden' items
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23530
Mason James changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |m.de.rooy at rijksmuseum.nl
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 06:19:49 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Sep 2019 04:19:49 +0000
Subject: [Koha-bugs] [Bug 23530] Opac-basket.pl script accidentally displays
'hidden' items
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23530
--- Comment #4 from Mason James ---
hi Marcel
i think the error was introduced from a 'squashing' patch for BZ 14385
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80466
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 07:08:29 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Sep 2019 05:08:29 +0000
Subject: [Koha-bugs] [Bug 15513] Hide OpacHiddenItems items from cart
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15513
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |DUPLICATE
Status|NEW |RESOLVED
--- Comment #1 from Katrin Fischer ---
*** This bug has been marked as a duplicate of bug 23530 ***
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 07:08:29 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Sep 2019 05:08:29 +0000
Subject: [Koha-bugs] [Bug 23530] Opac-basket.pl script accidentally displays
'hidden' items
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23530
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |katrin.fischer at bsz-bw.de
--- Comment #5 from Katrin Fischer ---
*** Bug 15513 has been marked as a duplicate of this bug. ***
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 07:12:56 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Sep 2019 05:12:56 +0000
Subject: [Koha-bugs] [Bug 23530] Opac-basket.pl script accidentally displays
'hidden' items
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23530
Irma Birchall changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |irma at calyx.net.au
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 07:23:32 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Sep 2019 05:23:32 +0000
Subject: [Koha-bugs] [Bug 23530] Opac-basket.pl script accidentally displays
'hidden' items
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23530
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Severity|normal |major
--- Comment #6 from Katrin Fischer ---
Updating severity - affects the OPAC (library patrons) and is even worse than
showing the hidden items as it hides the all the items that you should see.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 07:25:45 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Sep 2019 05:25:45 +0000
Subject: [Koha-bugs] [Bug 23530] Opac-basket.pl script accidentally displays
'hidden' items
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23530
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 07:25:51 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Sep 2019 05:25:51 +0000
Subject: [Koha-bugs] [Bug 23530] Opac-basket.pl script accidentally displays
'hidden' items
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23530
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #92534|0 |1
is obsolete| |
--- Comment #7 from Katrin Fischer ---
Created attachment 92537
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92537&action=edit
Bug 23530: Fix cart showing only hidden items
Items hidden with the OpacHiddenItems system preference
were still displayed in the OPAC cart and the normal items
were hidden instead. This patch corrects the display.
To test:
- prep a test bib with hidden and other items using
the OpacHiddenItems system preference
- add bib to cart
- observe that hidden items are displayed - non-hidden items are hidden
- apply patch, reload page
- observe that hidden items are hidden, non-hidden items are displayed
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 07:26:22 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Sep 2019 05:26:22 +0000
Subject: [Koha-bugs] [Bug 23530] Opac-basket.pl script accidentally displays
'hidden' items
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23530
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|oleonard at myacpl.org |mtj at kohaaloha.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 10:35:19 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Sep 2019 08:35:19 +0000
Subject: [Koha-bugs] [Bug 23531] New: ILS-DI doesn't implement
needed_before_date and pickup_expiry_date parameters.
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531
Bug ID: 23531
Summary: ILS-DI doesn't implement needed_before_date and
pickup_expiry_date parameters.
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P5 - low
Component: Web services
Assignee: koha-bugs at lists.koha-community.org
Reporter: arthur.suzuki at biblibre.com
QA Contact: testopia at bugs.koha-community.org
tried to send the following request :
GET
/cgi-bin/koha/ilsdi.pl?service=HoldItem&patron_id=196&bib_id=96629&item_id=112194&needed_before_date=2020-08-18&pickup_expiry_date=2020-10-18&pickup_location=BDY
the reservation which is placed doesn't take the "needed_before_date" and
pickup_expiry_date" parameter, although those are documented.
Arthur
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 11:14:37 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Sep 2019 09:14:37 +0000
Subject: [Koha-bugs] [Bug 23531] ILS-DI doesn't implement needed_before_date
and pickup_expiry_date parameters.
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531
--- Comment #1 from Arthur Suzuki ---
Created attachment 92538
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92538&action=edit
bug23531 : fix ILSDI non-implemented but documented parameters
test plan :
1/ Submit a hold through ILSDI with needed_before_date and
pickup_expiry_date parameters
2/ Verify in Koha those parameters are not applied to the newly created
reserve. Delete reserve.
3/ Apply patch and repeat 1.
4/ Verify the reserve created by same request as 1 now has both dates
applied and visible in Koha.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 11:40:56 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Sep 2019 09:40:56 +0000
Subject: [Koha-bugs] [Bug 23173] ILL should be able to search third party
sources prior to request creation
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23173
Andrew Isherwood changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #92107|0 |1
is obsolete| |
--- Comment #8 from Andrew Isherwood ---
Created attachment 92539
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92539&action=edit
Bug 23173: Add ILLCheckAvailability syspref
This patch adds the new syspref "ILLCheckAvailability"
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 11:40:59 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Sep 2019 09:40:59 +0000
Subject: [Koha-bugs] [Bug 23173] ILL should be able to search third party
sources prior to request creation
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23173
Andrew Isherwood changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #92108|0 |1
is obsolete| |
--- Comment #9 from Andrew Isherwood ---
Created attachment 92540
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92540&action=edit
Bug 23173: Provide core infrastructure
This patch adds the required infrastructure to enable ILL availability
plugins to intercept the request creation process and, using the
supplied metadata, search for and display possible relevant items from
whichever availability plugins are installed.
Currently two availability plugins exist:
z39.50 - Searches any number of the Koha instance's configured Z targets
https://github.com/PTFS-Europe/koha-plugin-ill-avail-z3950
Unpaywall - Searches the Unpaywall API for possible open access versions
of the requested item
https://github.com/PTFS-Europe/koha-plugin-ill-avail-unpaywall
The Unpaywall plugin is intended to serve as a "reference" plugin as the
API it deals with is extremely simple
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 12:25:14 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Sep 2019 10:25:14 +0000
Subject: [Koha-bugs] [Bug 23415] Notify patron fines when renewing
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415
Emmi Takkinen changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #92039|0 |1
is obsolete| |
--- Comment #2 from Emmi Takkinen ---
Created attachment 92541
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92541&action=edit
Bug 23415: Notify patron fines when renewing
In previous patch error message wasn't translatable. Fixed that and made sure
loading gif on checkout list works correctly after this patch is applied.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 12:56:19 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Sep 2019 10:56:19 +0000
Subject: [Koha-bugs] [Bug 23532] New: AutoCreateAuthorities create authority
only headings
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23532
Bug ID: 23532
Summary: AutoCreateAuthorities create authority only headings
Change sponsored?: ---
Product: Koha
Version: 19.05
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Cataloging
Assignee: koha-bugs at lists.koha-community.org
Reporter: gveranis at gmail.com
QA Contact: testopia at bugs.koha-community.org
CC: m.de.rooy at rijksmuseum.nl
The problem:
We have enable AutoCreateAuthorities and also enable BiblioAddsAuthorities
and when we insert values for tag 650 , we get authorities only with 150$a
filled and not other subfields.
I found that on C4/Biblio.pm lines 549 - 555
map {
$authfield->add_subfields( $_->[0] => $_->[1] )
if ( $_->[0] =~ /[A-z]/ && $_->[0] ne "a"
&& C4::Heading::valid_bib_heading_subfield(
$authority_type->auth_tag_to_report, $_->[0] )
);
} $field->subfields();
Koha try to copy subfields to the new authority record.
BUT the condition
C4::Heading::valid_bib_heading_subfield(
$authority_type->auth_tag_to_report, $_->[0])
return false. Because the $authority_type->auth_tag_to_report has value of 150
and not 650 as file C4/Heading/MARC21.pm declared.
if we set on file C4/Heading/MARC21.pm also the value
'150' => { auth_type => 'TOPIC_TERM', subfields => 'abvxyz', subject => 1 },
(valid based on
https://github.com/Koha-Community/Koha/blob/master/installer/data/mysql/en/marcflavour/marc21/mandatory/authorities_normal_marc21.sql)
then it works , but I am not sure if it is valid to set there new fields.
or better solution could be $authority_type->auth_tag_to_report take right
value in condition.
Could anyone propose the best solution ?
Thanks,
George Veranis
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 12:56:50 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Sep 2019 10:56:50 +0000
Subject: [Koha-bugs] [Bug 23532] AutoCreateAuthorities create authority only
headings
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23532
George Veranis changed:
What |Removed |Added
----------------------------------------------------------------------------
Severity|enhancement |trivial
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 13:21:19 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Sep 2019 11:21:19 +0000
Subject: [Koha-bugs] [Bug 23413] Add a holds routine to Koha::Items to fetch
related holds
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23413
--- Comment #7 from Nick Clemens ---
Created attachment 92542
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92542&action=edit
Bug 23413: (follow-up) Rename variables
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 13:21:23 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Sep 2019 11:21:23 +0000
Subject: [Koha-bugs] [Bug 23413] Add a holds routine to Koha::Items to fetch
related holds
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23413
--- Comment #8 from Nick Clemens ---
Created attachment 92543
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92543&action=edit
Bug 23413: Update tests to use build_sample_biblio
Before these changes the tests fail if run under Elasticsearch
This makes sure they pass either way
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 13:27:00 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Sep 2019 11:27:00 +0000
Subject: [Koha-bugs] [Bug 23413] Add a holds routine to Koha::Items to fetch
related holds
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23413
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #92543|0 |1
is obsolete| |
--- Comment #9 from Nick Clemens ---
Created attachment 92544
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92544&action=edit
Bug 23413: Update tests to use build_sample_biblio
Before these changes the tests fail if run under Elasticsearch
This makes sure they pass either way
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 14:28:12 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Sep 2019 12:28:12 +0000
Subject: [Koha-bugs] [Bug 23529] Interlibrary loan javascript is broken
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23529
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Failed QA
--- Comment #3 from Owen Leonard ---
I get an error when testing this:
SyntaxError: missing ) after argument list ill-list-table_19.0600022.js:502:8
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 14:41:52 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Sep 2019 12:41:52 +0000
Subject: [Koha-bugs] [Bug 23531] ILS-DI doesn't implement needed_before_date
and pickup_expiry_date parameters.
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531
Arthur Suzuki changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |Needs Signoff
Assignee|koha-bugs at lists.koha-commun |arthur.suzuki at biblibre.com
|ity.org |
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 14:44:08 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Sep 2019 12:44:08 +0000
Subject: [Koha-bugs] [Bug 23156] Add pagination to checkouts in ILS-DI
GetPatronInfo service
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23156
--- Comment #18 from Arthur Suzuki ---
Awesome!
Nice work everyone :)
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 14:46:15 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Sep 2019 12:46:15 +0000
Subject: [Koha-bugs] [Bug 23529] Interlibrary loan javascript is broken
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23529
--- Comment #4 from Andrew Isherwood ---
Created attachment 92545
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92545&action=edit
Bug 23529: (follow-up) Fix syntax error
As mentioned in comment #3
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 14:48:19 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Sep 2019 12:48:19 +0000
Subject: [Koha-bugs] [Bug 23529] Interlibrary loan javascript is broken
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23529
Andrew Isherwood changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Failed QA |Needs Signoff
--- Comment #5 from Andrew Isherwood ---
Sorry Owen, bad commit!
What's super weird is that, although I could see the syntax error in my editor,
my browser wasn't complaining about it! Hence me not catching if before I
attached the patch.
Anyway, it should be fixed now. Apologies for that!
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 15:16:08 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Sep 2019 13:16:08 +0000
Subject: [Koha-bugs] [Bug 23530] Opac-basket.pl script accidentally displays
'hidden' items
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23530
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 15:16:13 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Sep 2019 13:16:13 +0000
Subject: [Koha-bugs] [Bug 23530] Opac-basket.pl script accidentally displays
'hidden' items
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23530
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #92537|0 |1
is obsolete| |
--- Comment #8 from Nick Clemens ---
Created attachment 92546
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92546&action=edit
Bug 23530: Fix cart showing only hidden items
Items hidden with the OpacHiddenItems system preference
were still displayed in the OPAC cart and the normal items
were hidden instead. This patch corrects the display.
To test:
- prep a test bib with hidden and other items using
the OpacHiddenItems system preference
- add bib to cart
- observe that hidden items are displayed - non-hidden items are hidden
- apply patch, reload page
- observe that hidden items are hidden, non-hidden items are displayed
Signed-off-by: Katrin Fischer
Signed-off-by: Nick Clemens
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 15:23:57 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Sep 2019 13:23:57 +0000
Subject: [Koha-bugs] [Bug 23039] Hold found modal on checkin screen (
circulation.pl ) obscures Check in message info
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23039
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Failed QA |Signed Off
--- Comment #15 from Owen Leonard ---
(In reply to Nick Clemens from comment #13)
> I am wondering if we can simply leave them in place?
I don't have a problem with doing it this way.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 15:28:51 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Sep 2019 13:28:51 +0000
Subject: [Koha-bugs] [Bug 23512] Reindent notices and slips page (letter.tt)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23512
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 15:28:55 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Sep 2019 13:28:55 +0000
Subject: [Koha-bugs] [Bug 23512] Reindent notices and slips page (letter.tt)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23512
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #92529|0 |1
is obsolete| |
Attachment #92530|0 |1
is obsolete| |
--- Comment #5 from Nick Clemens ---
Created attachment 92547
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92547&action=edit
Bug 23512: (follow-up) Markup comments and corrections
This patch adds comments to the template to highlight the markup
structure. It also corrects some minor markup errors.
This patch should have no effect on the interface or functionality.
Signed-off-by: Katrin Fischer
Signed-off-by: Nick Clemens
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 15:29:24 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Sep 2019 13:29:24 +0000
Subject: [Koha-bugs] [Bug 23512] Reindent notices and slips page (letter.tt)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23512
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #92547|0 |1
is obsolete| |
--- Comment #6 from Nick Clemens ---
Created attachment 92548
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92548&action=edit
Bug 23512: Reindent notices and slips page (letter.tt)
This patch re-indents the template for notices and slips. It
makes only whitespace changes. It should have no effect on the behavior
of the page.
To test, go to Tools -> Notices & slips.
Test every aspect of the notice creation and edit process. At each step
the page should work correctly.
Signed-off-by: Katrin Fischer
Signed-off-by: Nick Clemens
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 15:29:28 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Sep 2019 13:29:28 +0000
Subject: [Koha-bugs] [Bug 23512] Reindent notices and slips page (letter.tt)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23512
--- Comment #7 from Nick Clemens ---
Created attachment 92549
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92549&action=edit
Bug 23512: (follow-up) Markup comments and corrections
This patch adds comments to the template to highlight the markup
structure. It also corrects some minor markup errors.
This patch should have no effect on the interface or functionality.
Signed-off-by: Katrin Fischer
Signed-off-by: Nick Clemens
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 15:55:29 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Sep 2019 13:55:29 +0000
Subject: [Koha-bugs] [Bug 23173] ILL should be able to search third party
sources prior to request creation
In-Reply-To: