From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 00:38:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 31 Aug 2019 22:38:58 +0000 Subject: [Koha-bugs] [Bug 23527] New: BakerTaylorBookstoreURL is converted to escaped characters by template, rendering it invalid Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23527 Bug ID: 23527 Summary: BakerTaylorBookstoreURL is converted to escaped characters by template, rendering it invalid Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: techservspec at gmail.com QA Contact: testopia at bugs.koha-community.org The url stored in the preference BakerTaylorBookstoreURL is rendered in opac-detail.tt with escaped characters (including the "/", "?" and "=" characters which are designating subdirectories and parameters), thus making the resulting link invalid. For example: The URL used for BakerTaylorBookstoreURL is https://contentcafe2.btol.com/ContentCafeClient/ContentCafe.aspx?UserID= However, what is rendered in the OPAC is https://contentcafe2.btol.com%2FContentCafeClient%2FContentCafe.aspx%3FUserID%3D To test this (requires a Baker & Taylor username and id): 1. Enter contentcafe2.btol.com/ContentCafeClient/ContentCafe.aspx?UserID=(your username)&Password=(your password)&ItemKey= into the BakerTaylorBookstoreURL preference and enable Baker & Taylor images. 2. Display a record that has a cover image in the OPAC. 3. Click on the image. You are not redirected to the above url (in firefox nothing happens, in chrome you are directed to "about:blank#blocked"). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 00:39:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 31 Aug 2019 22:39:37 +0000 Subject: [Koha-bugs] [Bug 23527] BakerTaylorBookstoreURL is converted to escaped characters by template, rendering it invalid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23527 David Kuhn changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |techservspec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 01:08:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 31 Aug 2019 23:08:52 +0000 Subject: [Koha-bugs] [Bug 23527] BakerTaylorBookstoreURL is converted to escaped characters by template, rendering it invalid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23527 --- Comment #1 from David Kuhn --- This also occurs in opac-search.tt. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 01:15:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 31 Aug 2019 23:15:36 +0000 Subject: [Koha-bugs] [Bug 23527] BakerTaylorBookstoreURL is converted to escaped characters by template, rendering it invalid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23527 --- Comment #2 from David Kuhn --- Sorry, I mean opac-results.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 01:38:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 31 Aug 2019 23:38:05 +0000 Subject: [Koha-bugs] [Bug 23527] BakerTaylorBookstoreURL is converted to escaped characters by template, rendering it invalid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23527 David Kuhn changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 01:38:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 31 Aug 2019 23:38:08 +0000 Subject: [Koha-bugs] [Bug 23527] BakerTaylorBookstoreURL is converted to escaped characters by template, rendering it invalid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23527 --- Comment #3 from David Kuhn --- Created attachment 92516 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92516&action=edit Bug 23527 - BakerTaylorBookstoreURL is converted to escaped characters by template, rendering it invalid Changing the template toolkit filter for rendering the value of BakerTaylorBookstoreURL in opac-detail.tt and opac-results.tt from uri to url fixes the problem. To test (requires a Baker & Taylor username and password): 1. Enter the B&T url into BakerTaylorBookstoreURL. 2. Set BakerTaylorEnabled to "add" and enter your username and password. 3. Look up a title in the OPAC. 4. Locate a title with a cover image. 5. Click on the cover image. You are not redirected to the url stored in BakerTaylorBookstoreURL. 6. Display the full record for the title 7. Click on the cover image. You are not redirected to the url stored in BakerTaylorBookstoreURL. 8. Apply the patch. 9. Refresh the OPAC display. 10. Click on the cover image. You are now redirected to the specified url. 11. Return to the results list. 12. Click on a cover image. You are now redirected to the specified url. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 16:46:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Sep 2019 14:46:28 +0000 Subject: [Koha-bugs] [Bug 23273] Downloading from overdues.pl doesn't use set filters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23273 --- Comment #10 from Jonathan Druart --- (In reply to Katrin Fischer from comment #8) > We are missing a filter here, should be an easy fix, but was not sure which > one to use here: > > FAIL koha-tmpl/intranet-tmpl/prog/en/modules/circ/overdue.tt > FAIL filters > missing_filter at line 39 ( [% url_params = BLOCK %][% > url_params %]&[% var | uri %]=[% filters.$var | uri %][% END %]) > > Leaving PQA for now. Martin, you added: - [% url_params = BLOCK %][% url_params %]&[% var | uri %]=[% filters.$var | uri %][% END %] + [% url_params = BLOCK %][% url_params | uri %]&[% var | uri %]=[% filters.$var | uri %][% END %] It feel wrong, it should be $raw, otherwise it will be double encoded. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 16:57:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Sep 2019 14:57:21 +0000 Subject: [Koha-bugs] [Bug 20307] Language overlay for authorized values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20307 --- Comment #46 from Jonathan Druart --- (In reply to Katrin Fischer from comment #45) > I started with testing the DEPARTMENT again. > > I added a de-DE translation for the DEPARTMENT. None for en. > > 1) The language de-DE is not activated, but it starts to show the > translation I added for German in the English interface. dep-dei - internal > staff description in the table below, shows in the English OPAC GUI. > Staff/OPAC might be a template issue, but still wondering why it shows up in > the English GUI? Where? When editing/adding a course reserve I see the default (untranslated) value. > 2) In staff admin: > My translation for OPAC description shows as description in the OPAC summary > (the OPAC description column being empty). When I edit the OPAC description, > the translation shows there. So maybe just something wrong on the list of > values? I do not get that one, sorry. Could you provide a screenshot? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 17:35:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Sep 2019 15:35:07 +0000 Subject: [Koha-bugs] [Bug 23273] Downloading from overdues.pl doesn't use set filters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23273 --- Comment #11 from Jonathan Druart --- Also, there was a debug statement: +use Data::Printer colored => 1; warn p $filters; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 17:35:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Sep 2019 15:35:53 +0000 Subject: [Koha-bugs] [Bug 23273] Downloading from overdues.pl doesn't use set filters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23273 --- Comment #12 from Jonathan Druart --- Created attachment 92517 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92517&action=edit Bug 23273: Remove debug statement -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 19:47:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Sep 2019 17:47:18 +0000 Subject: [Koha-bugs] [Bug 23038] Expected warnings displayed by tests should be hidden In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23038 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #6 from Jonathan Druart --- All ok for me, could you please retest? kohadev-koha at kohadevbox:/home/vagrant/kohaclone$ prove t/db_dependent/Circulation/MarkIssueReturned.t t/db_dependent/Circulation/MarkIssueReturned.t .. ok All tests successful. Files=1, Tests=3, 4 wallclock secs ( 0.01 usr 0.01 sys + 3.13 cusr 0.50 csys = 3.65 CPU) Result: PASS kohadev-koha at kohadevbox:/home/vagrant/kohaclone$ prove t/db_dependent/Suggestions.t t/db_dependent/Suggestions.t .. ok All tests successful. Files=1, Tests=110, 7 wallclock secs ( 0.05 usr 0.01 sys + 5.26 cusr 1.26 csys = 6.58 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 20:25:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Sep 2019 18:25:29 +0000 Subject: [Koha-bugs] [Bug 14293] Error in the calculation of the suspension of users per day In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14293 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jonathan.druart at bugs.koha-c |koha-bugs at lists.koha-commun |ommunity.org |ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 20:34:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Sep 2019 18:34:23 +0000 Subject: [Koha-bugs] [Bug 23210] login4tags should be a link In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23210 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 20:34:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Sep 2019 18:34:28 +0000 Subject: [Koha-bugs] [Bug 23210] login4tags should be a link In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23210 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92512|0 |1 is obsolete| | Attachment #92513|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart --- Created attachment 92518 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92518&action=edit Bug 23210: login4tags should be a link TEST PLAN: 1. Make sure TagsEnabled and TagsInputOnList are set to allow. 2. Don't be logged into the OPAC. 3. Make a search and notice the 'Log in to add tags' text is not a link on the results page. 4. Apply patch 5. Refresh OPAC results page 6. 'Log in to add tags' takes you to the login page. Signed-off-by: Owen Leonard Signed-off-by: Michal Denar Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 20:34:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Sep 2019 18:34:32 +0000 Subject: [Koha-bugs] [Bug 23210] login4tags should be a link In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23210 --- Comment #10 from Jonathan Druart --- Created attachment 92519 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92519&action=edit Bug 23210: (follow-up) Log in for tags link should trigger modal This patch modifies the "Log in to add tags" link on the OPAC search results page, adding the class which is used elsewhere in the OPAC templates for triggering the login modal. Also: Removed an unnecessary period. To test, apply the patch and follow the original test plan. Clicking the "Log in to add tags" link should trigger the login modal. After logging in you should be returned to the page you were on. Signed-off-by: Michal Denar Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 20:49:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Sep 2019 18:49:06 +0000 Subject: [Koha-bugs] [Bug 23397] Order lines can be duplicated in acqui scripts spent.pl and ordered.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23397 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #13 from Jonathan Druart --- I was completely stuck with circ/pendingreserves.pl because of the use of GROUP_CONCAT. It makes things super hard to rewrite. Do not we have another option? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 20:56:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Sep 2019 18:56:30 +0000 Subject: [Koha-bugs] [Bug 23397] Order lines can be duplicated in acqui scripts spent.pl and ordered.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23397 --- Comment #14 from Jonathan Druart --- I do not have much to suggest apart from rewriting the scripts from scratch, which seems quite out of the scope ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 21:25:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Sep 2019 19:25:50 +0000 Subject: [Koha-bugs] [Bug 23289] Label Template - Creation not working (MariaDB >= 10.2.4) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23289 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|17258 | Summary|Label Template - Creation |Label Template - Creation |not working with SQL strict |not working (MariaDB >= |mode enabled |10.2.4) Assignee|cnighswonger at foundations.ed |jonathan.druart at bugs.koha-c |u |ommunity.org Version|19.05 |master Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258 [Bug 17258] [OMNIBUS] MySQL 5.7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 21:25:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Sep 2019 19:25:50 +0000 Subject: [Koha-bugs] [Bug 17258] [OMNIBUS] MySQL 5.7 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|23289 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23289 [Bug 23289] Label Template - Creation not working (MariaDB >= 10.2.4) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 21:29:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Sep 2019 19:29:20 +0000 Subject: [Koha-bugs] [Bug 23289] Label Template - Creation not working (MariaDB >= 10.2.4) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23289 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 21:29:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Sep 2019 19:29:25 +0000 Subject: [Koha-bugs] [Bug 23289] Label Template - Creation not working (MariaDB >= 10.2.4) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23289 --- Comment #7 from Jonathan Druart --- Created attachment 92520 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92520&action=edit Bug 23289: Quote new 'rows' MariaDB reserved word Since MariaDB 10.2.4 rows is a reserved word: https://mariadb.com/kb/en/library/mariadb-1024-release-notes/ """ New reserved word: ROWS. This can no longer be used as an identifier without being quoted. """ Test plan: With MariaDB >= 10.2.4, create a new label template. Also, prove t/db_dependent/Labels/t_Template.t Without this patch you will get the following SQL error: DBD::mysql::st execute failed: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'rows, creator, template_code, page_height, -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 21:39:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Sep 2019 19:39:22 +0000 Subject: [Koha-bugs] [Bug 23484] Holds to pull (pendingreserves.pl) uses removed default_branch_item_rules table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23484 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Severity|enhancement |major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 21:39:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Sep 2019 19:39:37 +0000 Subject: [Koha-bugs] [Bug 23484] Holds to pull (pendingreserves.pl) uses removed default_branch_item_rules table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23484 --- Comment #3 from Jonathan Druart --- The error is: DBD::mysql::st execute failed: Table 'koha_kohadev.default_branch_item_rules' doesn't exist [for Statement "SELECT min(reservedate) as l_reservedate, -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 21:44:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Sep 2019 19:44:59 +0000 Subject: [Koha-bugs] [Bug 23484] Holds to pull (pendingreserves.pl) uses removed default_branch_item_rules table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23484 --- Comment #4 from Jonathan Druart --- I am wondering if we should not retrieve the list of itemtypes for which the holds are allowed, then use them in the WHERE clause. It will make the query more readable and we will remove a LEFT JOIN. What do you think? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 21:48:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Sep 2019 19:48:53 +0000 Subject: [Koha-bugs] [Bug 19249] Date picker broken in "Quick add new patron" form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19249 --- Comment #4 from Jonathan Druart --- Yes, as well as all other date fields. As Fridolin said we should rework the way the fields are displayed/hidden. It's not an easy fix. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 21:57:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Sep 2019 19:57:54 +0000 Subject: [Koha-bugs] [Bug 23247] Simplify visibility logic in opac-MARCdetail.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23247 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #8 from Jonathan Druart --- (In reply to M. Tompsett from comment #6) > I believe I have rebased it correctly to be off bug 22721 as mentioned by > Katrin in comment #4. As such, I'm happy to leave it back at Needs Signoff. Why did not you sign it off? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 22:02:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Sep 2019 20:02:55 +0000 Subject: [Koha-bugs] [Bug 23079] Checkouts page broken because of problems with date calculation (TZAmerica/Sao_Paulo) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23079 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 22:03:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Sep 2019 20:03:00 +0000 Subject: [Koha-bugs] [Bug 23079] Checkouts page broken because of problems with date calculation (TZAmerica/Sao_Paulo) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23079 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90939|0 |1 is obsolete| | --- Comment #15 from Jonathan Druart --- Created attachment 92521 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92521&action=edit Bug 23079: Add tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 22:14:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Sep 2019 20:14:25 +0000 Subject: [Koha-bugs] [Bug 23210] login4tags should be a link In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23210 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92518|0 |1 is obsolete| | Attachment #92519|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer --- Created attachment 92522 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92522&action=edit Bug 23210: login4tags should be a link and included in every search result TEST PLAN: 1. Make sure TagsEnabled and TagsInputOnList are set to allow. 2. Don't be logged into the OPAC. 3. Make a search and notice the 'Log in to add tags' text is not a link on the results page. 4. Apply patch 5. Refresh OPAC results page 6. 'Log in to add tags' takes you to the login page. Signed-off-by: Owen Leonard Signed-off-by: Michal Denar Signed-off-by: Michal Denar Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 22:14:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Sep 2019 20:14:32 +0000 Subject: [Koha-bugs] [Bug 23210] login4tags should be a link In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23210 --- Comment #12 from Katrin Fischer --- Created attachment 92523 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92523&action=edit Bug 23210: (follow-up) Log in for tags link should trigger modal This patch modifies the "Log in to add tags" link on the OPAC search results page, adding the class which is used elsewhere in the OPAC templates for triggering the login modal. Also: Removed an unnecessary period. To test, apply the patch and follow the original test plan. Clicking the "Log in to add tags" link should trigger the login modal. After logging in you should be returned to the page you were on. Signed-off-by: Michal Denar Signed-off-by: Michal Denar Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 22:18:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Sep 2019 20:18:27 +0000 Subject: [Koha-bugs] [Bug 23528] New: Show 'log in to add tags' link on all search result entries Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23528 Bug ID: 23528 Summary: Show 'log in to add tags' link on all search result entries Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org Splitting this out as a separate bug report from bug 23210: (In reply to Lucas Gass from comment #0) > If a non-authenticated user goes to the search results page they will only > see the login4tags (Log in to add tags ) text included with the first > result. This should be included with every result. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 22:19:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Sep 2019 20:19:34 +0000 Subject: [Koha-bugs] [Bug 23210] login4tags should be a link In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23210 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #13 from Katrin Fischer --- (In reply to Lucas Gass from comment #0) > If a non-authenticated user goes to the search results page they will only > see the login4tags (Log in to add tags ) text included with the first > result. This should be included with every result. This part is still not fixed - I've filed a new bug. Bug 23528 - Show 'log in to add tags' link on all search result entries -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 22:19:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Sep 2019 20:19:40 +0000 Subject: [Koha-bugs] [Bug 23528] Show 'log in to add tags' link on all search result entries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23528 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23210 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23210 [Bug 23210] login4tags should be a link -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 22:19:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Sep 2019 20:19:40 +0000 Subject: [Koha-bugs] [Bug 23210] login4tags should be a link In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23210 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23528 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23528 [Bug 23528] Show 'log in to add tags' link on all search result entries -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 22:22:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Sep 2019 20:22:01 +0000 Subject: [Koha-bugs] [Bug 23518] Problem with borrower search autocomplete In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23518 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #4 from Katrin Fischer --- Seeing a sign off from Nick and Michal - should this not be PQA? Taking a quick look. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 22:35:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Sep 2019 20:35:03 +0000 Subject: [Koha-bugs] [Bug 23518] Problem with borrower search autocomplete In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23518 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 22:35:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Sep 2019 20:35:07 +0000 Subject: [Koha-bugs] [Bug 23518] Problem with borrower search autocomplete In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23518 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92511|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 92524 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92524&action=edit Bug 23518: Problem with borrower search autocomplete This patch fixes a bug introduced by my patch for Bug 23405: Keyboard navigation of patron autocomplete results was broken because I incorrectly assumed that the autocomplete "select" action was redundant because keyboard navigation would trigger the selected link. It doesn't! This patch adds the "select" action back to the autocomplete configuration, explicitly defining a redirect to match the URL which is followed if the user uses the mouse to click a result. To test you should have a patron in your database which has no card number. Make sure CircAutocompl is enabled. - From the circulation home page, type a patron name in the "Check out" form and wait for autocomplete search results to display. - Making a selection from the autocomplete results should work by clicking with a mouse OR using the arrow keys and TAB or ENTER. - Test with patrons with and without card numbers. Signed-off-by: Nick Clemens Signed-off-by: Michal Denar Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 22:36:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Sep 2019 20:36:27 +0000 Subject: [Koha-bugs] [Bug 23411] SMS messages should not fall back to 'email' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23411 Michal Denar changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 22:59:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Sep 2019 20:59:49 +0000 Subject: [Koha-bugs] [Bug 23079] Checkouts page broken because of problems with date calculation (TZAmerica/Sao_Paulo) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23079 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 23:00:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Sep 2019 21:00:09 +0000 Subject: [Koha-bugs] [Bug 23079] Checkouts page broken because of problems with date calculation (TZAmerica/Sao_Paulo) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23079 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90940|0 |1 is obsolete| | --- Comment #16 from Katrin Fischer --- Created attachment 92525 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92525&action=edit Bug 23079: Handle invalid timezones when adding/subtracting durations On Nov 3rd 2019, Brazil will skip from 00:00 to 1:00 (http://www.currenttimeonline.com/dst/dst.do?tz=America/Sao_Paulo), DateTime consider it as an invalid date. It is a problem when we are playing with dates without the time part (always 00:00). When we instantiate a DateTime (from dt_from_string) we are already handling this issue, and use the floating timezone (since bug 12669). The problem remains when we generate a DateTime then add or subtract a duration, which will result in an invalid date: DateTime->new(year => 2019, month => 12, day => 3, time_zone => 'America/Sao_Paulo')->subtract(days => 30); => Nov 3rd 2019, kaboom. We should replace all the problematic occurrences of dt_from_string->subtract (or ->add) with dt_from_string(undef, undef, 'floating'), to use the floating timezone and avoid the error. Actually there are not many of them, I have found only 3 that could produce real problems. The other occurrences are: - in tests => Not a big deal (for now) - called on a datetime, so it will explode if called at midnight 00:00:00 (and nobody should work at that time). Test plan: 0/ Define the timezone to 'America/Sao_Paulo' (in your koha-conf.xml file), restart_all 1/ Set a patron's expiry date to Dec 3rd 2019, and NotifyBorrowerDeparture to 30 (default value) 2/ See the checkouts page for this user => Without this patch you get "Invalid local time for date in time zone: America/Sao_Paulo" => With this patch apply the page displays correctly QA will review the 2 other occurrences. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 23:00:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Sep 2019 21:00:27 +0000 Subject: [Koha-bugs] [Bug 23079] Checkouts page broken because of problems with date calculation (TZAmerica/Sao_Paulo) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23079 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92521|0 |1 is obsolete| | --- Comment #17 from Katrin Fischer --- Created attachment 92526 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92526&action=edit Bug 23079: Add tests Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 23:04:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Sep 2019 21:04:22 +0000 Subject: [Koha-bugs] [Bug 23273] Downloading from overdues.pl doesn't use set filters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23273 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92517|0 |1 is obsolete| | --- Comment #13 from Katrin Fischer --- Created attachment 92527 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92527&action=edit Bug 23273: Remove debug statement Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 23:04:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Sep 2019 21:04:43 +0000 Subject: [Koha-bugs] [Bug 23273] Downloading from overdues.pl doesn't use set filters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23273 --- Comment #14 from Katrin Fischer --- Moving into PQA queue for better visibility. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 23:04:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Sep 2019 21:04:52 +0000 Subject: [Koha-bugs] [Bug 23273] Downloading from overdues.pl doesn't use set filters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23273 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 23:04:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Sep 2019 21:04:59 +0000 Subject: [Koha-bugs] [Bug 23273] Downloading from overdues.pl doesn't use set filters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23273 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 23:05:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Sep 2019 21:05:05 +0000 Subject: [Koha-bugs] [Bug 23273] Downloading from overdues.pl doesn't use set filters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23273 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 23:05:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Sep 2019 21:05:13 +0000 Subject: [Koha-bugs] [Bug 23273] Downloading from overdues.pl doesn't use set filters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23273 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 23:08:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Sep 2019 21:08:09 +0000 Subject: [Koha-bugs] [Bug 23038] Expected warnings displayed by tests should be hidden In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23038 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #7 from Katrin Fischer --- Hm, I see 2 QA script violations with this patch: FAIL t/db_dependent/Circulation/MarkIssueReturned.t FAIL critic # Variables::ProhibitUnusedVariables: Got 1 violation(s). FAIL t/db_dependent/Suggestions.t FAIL critic # Variables::ProhibitUnusedVariables: Got 1 violation(s). But all tests pass. Joubu, could you please take a look at those? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 23:08:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Sep 2019 21:08:15 +0000 Subject: [Koha-bugs] [Bug 23038] Expected warnings displayed by tests should be hidden In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23038 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 23:30:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Sep 2019 21:30:50 +0000 Subject: [Koha-bugs] [Bug 23289] Label Template - Creation not working (MariaDB >= 10.2.4) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23289 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 23:31:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Sep 2019 21:31:08 +0000 Subject: [Koha-bugs] [Bug 23289] Label Template - Creation not working (MariaDB >= 10.2.4) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23289 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92520|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer --- Created attachment 92528 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92528&action=edit Bug 23289: Quote new 'rows' MariaDB reserved word Since MariaDB 10.2.4 rows is a reserved word: https://mariadb.com/kb/en/library/mariadb-1024-release-notes/ """ New reserved word: ROWS. This can no longer be used as an identifier without being quoted. """ Test plan: With MariaDB >= 10.2.4, create a new label template. Also, prove t/db_dependent/Labels/t_Template.t Without this patch you will get the following SQL error: DBD::mysql::st execute failed: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'rows, creator, template_code, page_height, Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 23:38:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Sep 2019 21:38:53 +0000 Subject: [Koha-bugs] [Bug 23512] Reindent notices and slips page (letter.tt) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23512 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 23:38:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Sep 2019 21:38:58 +0000 Subject: [Koha-bugs] [Bug 23512] Reindent notices and slips page (letter.tt) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23512 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92509|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 92529 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92529&action=edit Bug 23512: Reindent notices and slips page (letter.tt) This patch re-indents the template for notices and slips. It makes only whitespace changes. It should have no effect on the behavior of the page. To test, go to Tools -> Notices & slips. Test every aspect of the notice creation and edit process. At each step the page should work correctly. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 23:39:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Sep 2019 21:39:03 +0000 Subject: [Koha-bugs] [Bug 23512] Reindent notices and slips page (letter.tt) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23512 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92510|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 92530 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92530&action=edit Bug 23512: (follow-up) Markup comments and corrections This patch adds comments to the template to highlight the markup structure. It also corrects some minor markup errors. This patch should have no effect on the interface or functionality. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 23:41:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Sep 2019 21:41:25 +0000 Subject: [Koha-bugs] [Bug 23525] ISBD view uses view policy of ACQ framework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23525 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Yes, I think this should have no effect on the ISBD views in ACQ and/or catalog pages, it seems counter-intuitive. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 23:41:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Sep 2019 21:41:37 +0000 Subject: [Koha-bugs] [Bug 23525] ISBD view uses view policy of ACQ framework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23525 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |19289 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289 [Bug 19289] Allow configuration of the fields on the 'Catalog details' form in the acquisition baskets -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 23:41:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Sep 2019 21:41:37 +0000 Subject: [Koha-bugs] [Bug 19289] Allow configuration of the fields on the 'Catalog details' form in the acquisition baskets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23525 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23525 [Bug 23525] ISBD view uses view policy of ACQ framework -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 23:45:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Sep 2019 21:45:51 +0000 Subject: [Koha-bugs] [Bug 22602] OverDrive circulation integration is broken when user is referred to Koha from another site In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22602 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #5 from Katrin Fischer --- Is there any way to test this without an Overdrive account? Or way to get one for testing purposes? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 23:54:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Sep 2019 21:54:57 +0000 Subject: [Koha-bugs] [Bug 14851] Change terminology for budget being "locked" to "disabled" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14851 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WONTFIX --- Comment #2 from Katrin Fischer --- Closing, please reopen, if you disagree. See also: bug 23524 and bug 22786 for some newer developments. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 23:56:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Sep 2019 21:56:57 +0000 Subject: [Koha-bugs] [Bug 14857] shouldn't be allowed to receive from locked fund In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14857 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- According to documentation, locked should not allow to modify: https://koha-community.org/manual/19.05/en/html/administration.html?highlight=locked#budgets Locking a budget means that funds will not be able to be modified by librarians I read this like it should not affect the ordering/receiving process, but the moving from amounts between funds or similar. Closing, please reopen if you disagree. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 23:59:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Sep 2019 21:59:18 +0000 Subject: [Koha-bugs] [Bug 23524] Can modify/delete funds for locked budgets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23524 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14851, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14857 CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- I would think that changing the funds in the budget should be not allowed, while we should still allow ordering and receiving (active/inactive works for that). The manual states: https://koha-community.org/manual/19.05/en/html/administration.html?highlight=locked#budgets Locking a budget means that funds will not be able to be modified by librarians It doesn't work this way yet, but we could fix it. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 23:59:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Sep 2019 21:59:18 +0000 Subject: [Koha-bugs] [Bug 14851] Change terminology for budget being "locked" to "disabled" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14851 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23524 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 23:59:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Sep 2019 21:59:18 +0000 Subject: [Koha-bugs] [Bug 14857] shouldn't be allowed to receive from locked fund In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14857 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23524 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 23:59:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Sep 2019 21:59:33 +0000 Subject: [Koha-bugs] [Bug 23524] Can modify/delete funds for locked budgets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23524 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22786 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22786 [Bug 22786] Can create new funds for locked budgets -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Sep 1 23:59:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Sep 2019 21:59:33 +0000 Subject: [Koha-bugs] [Bug 22786] Can create new funds for locked budgets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22786 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23524 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23524 [Bug 23524] Can modify/delete funds for locked budgets -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 00:06:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Sep 2019 22:06:06 +0000 Subject: [Koha-bugs] [Bug 22854] Add separate column for administrative locked patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22854 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer --- I think that changing the pref resulting in unlocking users makes sense to me. You might figure out you don't want to use the feature after all, so setting a high value will help. Having 2 columns will allow to have an administrative lock and a too_many_attempts lock at the same time... but it makes me wonder if we could just have 1 new column for the administrative lock as boolean? And keep the failed_attempts behaviour. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 00:09:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Sep 2019 22:09:49 +0000 Subject: [Koha-bugs] [Bug 22552] Adding users to serials routing search requires edit_borrowers permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22552 --- Comment #2 from Katrin Fischer --- I think routing_list permission should be enough here. If you are supposed to work with routing lists, you will need to see the patrons added to the list, print it, and I think also modify and create routing lists (you need the search for that). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 00:10:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Sep 2019 22:10:35 +0000 Subject: [Koha-bugs] [Bug 23517] Incorrect permission requirements for holds operations via the API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23517 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer --- (In reply to Owen Leonard from comment #2) > I think we can work within the permissions definitions the staff client > enforces right now, and I think you've got it right: > > - 'place_holds' allows changes to any hold detail except priority > - 'modify_holds_priority' allows changes to priority independently of any > other detail +1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 00:35:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Sep 2019 22:35:33 +0000 Subject: [Koha-bugs] [Bug 23501] Drag-and-drop hold reordering in the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23501 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #7 from Katrin Fischer --- Could we add one of these warnings when you try to leave the page without saving? I like that you kept the arrows for now. I wonder if we need the arrows for accessibility of if the priority pull down would be enough. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 03:11:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Sep 2019 01:11:12 +0000 Subject: [Koha-bugs] [Bug 16357] Plack error logs are not time stamped In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 --- Comment #46 from David Cook --- I have some thoughts on this one. Firstly, why are we using Log::Log4perl::Appender::File at all? It doesn't make sense, unless you're going to be logging to custom files independent of your webserver. Since we're already leveraging the log file directives of Apache or Starman and expecting to use their log files, let's just use Log::Log4perl::Appender::Screen and set log4perl.appender.Screen.stderr = 1 to log to STDERR. Easy as. Then the log files would be handled automagically by the web servers. If we, for some reason, must use Log::Log4perl::Appender::File, then let's use application-specific webserver-independent log files. So that's probably what we *should* do. Let's look at what we're currently doing... -- Looking at /etc/logrotate.d/koha-common, it looks like "sharedscripts" will imply "create" which in the absence of configuration will use the existing file attributes. That explains why the rotated log files are the same as the ones that came before them. (The only issue there would be if you switched from Apache to Plack and didn't chmod the files in the process I suppose.) I took a look at ./etc/log4perl.conf and ./debian/templates/log4perl-site.conf.in, and it looks like the defaults are the Apache logs. I suppose that is technically OK if Apache is running Koha as a set of CGI scripts, but really doesn't make sense if you're running Koha as a PSGI app. -- In summary, I think the issue is with our Log4Perl default configuration, and not a permissions issue per se. I'm looking at a Koha running Plack at the moment, and it looks like the Log4Perl appenders aren't even used. I'm guessing that they silently fail since the Starman user can't write to the root owned Apache files. -- Alas, I don't have time to work on this, but that's my 2 cents. I'd say the easiest solution is to change to Log::Log4perl::Appender::Screen and set log4perl.appender.Screen.stderr = 1, and then not worry about managing the log files outside the web servers. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 07:15:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Sep 2019 05:15:38 +0000 Subject: [Koha-bugs] [Bug 19457] If CheckPrevCheckout is set to "Do", then checkouts are blocked at the SIPServer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19457 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #27 from David Cook --- How is this system preference being checked? I don't see any code that directly references "CheckPrevCheckout"? I just see templates. I must be missing something painfully obvious, but I don't see it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 07:45:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Sep 2019 05:45:11 +0000 Subject: [Koha-bugs] [Bug 23039] Hold found modal on checkin screen ( circulation.pl ) obscures Check in message info In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23039 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Signed Off |Failed QA --- Comment #14 from Katrin Fischer --- (In reply to Nick Clemens from comment #13) > I like this one Owen, I didn't like the way the dialogs disappeared when the > modal appeared though. I am wondering if we can simply leave them in place? > While we can bring the modal back up, it might be nice to keep the messages > in place. I tried making them show on modal hide, but that added more page > flicker > > Feel free to SO or obsolete my follow-up, I won't argue strongly Owen, could you take a look please? (Back to signed off after, please :) ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 07:53:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Sep 2019 05:53:33 +0000 Subject: [Koha-bugs] [Bug 23464] Update the process of quick spine label printing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23464 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #6 from Katrin Fischer --- I am testing this with the sample data and the callnumber is not showing up for me in the print preview: 3999900000018 005.13/3 Can someone confirm? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 07:56:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Sep 2019 05:56:53 +0000 Subject: [Koha-bugs] [Bug 23464] Update the process of quick spine label printing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23464 --- Comment #7 from Katrin Fischer --- (In reply to Katrin Fischer from comment #6) > I am testing this with the sample data and the callnumber is not showing up > for me in the print preview: > > 3999900000018 > 005.13/3 > > Can someone confirm? Fixed... the item didn't have a callnumber saved. What I saw was the unsafed suggestion from the itemcallnumber syspref in the edit form... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 07:58:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Sep 2019 05:58:26 +0000 Subject: [Koha-bugs] [Bug 23464] Update the process of quick spine label printing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23464 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 07:58:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Sep 2019 05:58:29 +0000 Subject: [Koha-bugs] [Bug 23464] Update the process of quick spine label printing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23464 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92459|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer --- Created attachment 92531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92531&action=edit Bug 23464: Update the process of quick spine label printing This patch makes changes to the way quick spine label printing works, either from the bibliographic details page or the Quick spine label creator page. To test, apply the patch and go to Tools -> Quick spine label creator. - Type or scan a barcode. Submitting the form should trigger a popup window with the spine label print page. The "print" button should be centered at the bottom of the window in a footer-like container. - If you have SpineLabelAutoPrint enabled, the print dialog should appear automatically. - After printing, the pop-up window should close and and focus should be returned to the barcode field. Enable the SpineLabelShowPrintOnBibDetails system preference. View the bibliographic details page for a record in the catalog. - In the holdings table, a "Spine label" column should appear as the second-to-last column. The column should contain "Print label" Bootstrap-style buttons. - Clicking a "Print label" button should trigger a pop-up window with the spine label print page. The behavior of the window should be the same as above. Signed-off-by: Maryse Simard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 07:58:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Sep 2019 05:58:33 +0000 Subject: [Koha-bugs] [Bug 23464] Update the process of quick spine label printing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23464 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92460|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer --- Created attachment 92532 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92532&action=edit Bug 23464: (follow-up) QA fixes This patch corrects two issues raised during testing: - Move JavaScript out of template check for IntranetUserJS so that SpineLabelAutoPrint behavior works correctly. - Add "close" button to pop-up window for cases when the barcode was not found. Also changed: - Added "required" attribute to barcode input on quick spine label printing page so that submitting an empty form will not work. - Tweaked CSS slightly to fix alignment of spine label form and submit button. (You must rebuild the staff client CSS: https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client) Signed-off-by: Maryse Simard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 08:08:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Sep 2019 06:08:07 +0000 Subject: [Koha-bugs] [Bug 21852] Add more columns and column configuration to overdues report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21852 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #31 from Katrin Fischer --- I wanted to go ahead and squash, but there is a slight conflict with the datatables update I think. I tried to fix it, but failed - can you have a look please? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 08:12:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Sep 2019 06:12:10 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #90 from Katrin Fischer --- I am sorry, but there are a lot of conflicts now with this patch. With bug 14570 pushed, this might need to be reworked. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 08:19:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Sep 2019 06:19:02 +0000 Subject: [Koha-bugs] [Bug 22445] Ability to define a URL for custom cover images In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 --- Comment #71 from Katrin Fischer --- (In reply to Kyle M Hall from comment #69) > This looks pretty good, but I have one request; can you use Template Toolkit > syntax instead of yet another bespoke syntax? If we standardize on TT for > all templating we'll make everyone's lives much simpler. I am not sure about that tbh, because the TT syntax is hard for users. With the notices we still have trouble because of lack of documentation, lack of 'knowing the right variable names'. There is also a security risk we discussed in other spots, as it allows you to use regex and similar and possibly do harm with it. That said, I think this is stuck on Jonathan's question about the MARC syntax. Would it be possible to move this forward as is and treat the TT as possible enhancement later on? Or allow TT syntax additionally? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 08:19:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Sep 2019 06:19:48 +0000 Subject: [Koha-bugs] [Bug 23377] bulkmarcimport.pl disables syspref caching In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23377 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 08:21:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Sep 2019 06:21:23 +0000 Subject: [Koha-bugs] [Bug 22217] error "Connection to the memcached servers '__MEMCACHED_SERVERS__' failed" during install In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22217 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #1 from David Cook --- These are more so warnings than errors. I think you can safely ignore them, although Koha really should be updated to prevent the warnings from showing in the first place. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 08:30:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Sep 2019 06:30:51 +0000 Subject: [Koha-bugs] [Bug 14293] Error in the calculation of the suspension of users per day In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14293 --- Comment #38 from Katrin Fischer --- (In reply to Koha Team Lyon 3 from comment #37) > But for the moment, I'm not sure a lot of libraries are using it.... > Sonia We have 2 or 3 libraries using it currently (one is in Spain, it appears common there too). I haven't read through all the bug to see what it changes, just wanted to leave a note that this is probably a wider used feature. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 08:31:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Sep 2019 06:31:40 +0000 Subject: [Koha-bugs] [Bug 19457] If CheckPrevCheckout is set to "Do", then checkouts are blocked at the SIPServer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19457 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 08:47:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Sep 2019 06:47:47 +0000 Subject: [Koha-bugs] [Bug 19819] C4::Context->dbh is unreasonably slow In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19819 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #14 from David Cook --- (In reply to Jonathan Druart from comment #9) > Did you try this patch in production? I am expecting regressions on the > issues with had on bug 14778 (like "server has gone away"). This was exactly what I was going to say. Database connection caching is a nice idea but not something you want to implement naively. I'd suggest not trying to re-invent the wheel on this one, and look somewhere else for database connection pooling. And actually looking at C4::Context::dbh... I see that Koha::Database->schema->storage->dbh... which does cache the $schema object in a package level variable. This bug report was opened nearly 2 years ago, so maybe it is no longer relevant. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 09:04:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Sep 2019 07:04:05 +0000 Subject: [Koha-bugs] [Bug 15341] Performance - Retrieve all sysprefs at once In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15341 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #23 from David Cook --- Looks like an old one, but I've often wondered why we haven't fetched all the system preferences at once to avoid subsequent calls to the database. I suppose it does introduce overhead though as you are getting everything when in practice you might only use a few preferences. And the more preferences you have, the slower that fetch will become. It wouldn't scale. I suppose the L1/L2 caching we have now should take care of this, although I'm trying to see where the L2 cache gets intialized... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 09:05:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Sep 2019 07:05:22 +0000 Subject: [Koha-bugs] [Bug 13193] Discussion: strategy for diagnosing memcache issues. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #3 from David Cook --- I might also be having some caching issues where the wrong system preference value seems to be coming back from the caches, but still digging into that one... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 09:55:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Sep 2019 07:55:28 +0000 Subject: [Koha-bugs] [Bug 19457] If CheckPrevCheckout is set to "Do", then checkouts are blocked at the SIPServer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19457 --- Comment #28 from Matthias Meusburger --- See comment #16, CheckPrevCheckout is checked by wants_check_for_previous_checkout in Koha/Patron.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 10:23:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Sep 2019 08:23:53 +0000 Subject: [Koha-bugs] [Bug 23529] New: Interlibrary loan javascript is broken Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23529 Bug ID: 23529 Summary: Interlibrary loan javascript is broken Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: ILL Assignee: koha-bugs at lists.koha-community.org Reporter: andrew.isherwood at ptfs-europe.com This was caused by an overzealous fix in Bug 23229. A fix was appended as a follow-up patch on 23229 but Katrin advised that it should be a new bug, hence this one. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 10:31:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Sep 2019 08:31:07 +0000 Subject: [Koha-bugs] [Bug 23529] Interlibrary loan javascript is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23529 --- Comment #1 from Andrew Isherwood --- Created attachment 92533 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92533&action=edit Bug 23529: Narrow scope of changed Whilst working on something else, it came to light that the previous fix in bug 23229 was waaaaay too heavy handed and basically kills all ILL related JS :( This is obviously a big problem, this patch fixes that. The main problem is that all the ILL related JS is in a single file, which isn't ideal as bits of it are used on different pages. Ideally, we'd refactor it out into more manageable chunks which can be included as required. Until such a time, this patch will do, it just prevents the "get all requests" AJAX request unless you're on the ILL list page. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 10:32:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Sep 2019 08:32:19 +0000 Subject: [Koha-bugs] [Bug 23529] Interlibrary loan javascript is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23529 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P1 - high Depends on| |23229 Status|NEW |Needs Signoff CC| |katrin.fischer at bsz-bw.de Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23229 [Bug 23229] "Get all requests" API call fired when loading any ILL page -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 10:32:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Sep 2019 08:32:19 +0000 Subject: [Koha-bugs] [Bug 23229] "Get all requests" API call fired when loading any ILL page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23229 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23529 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23529 [Bug 23529] Interlibrary loan javascript is broken -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 10:33:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Sep 2019 08:33:07 +0000 Subject: [Koha-bugs] [Bug 23229] "Get all requests" API call fired when loading any ILL page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23229 --- Comment #17 from Andrew Isherwood --- Thanks Katrin, Bug 23529 now addresses this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 10:33:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Sep 2019 08:33:52 +0000 Subject: [Koha-bugs] [Bug 23390] Add placeholder syntax for column names In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23390 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23206 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23206 [Bug 23206] Batch patron modification from reports which return cardnumber -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 10:33:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Sep 2019 08:33:52 +0000 Subject: [Koha-bugs] [Bug 23206] Batch patron modification from reports which return cardnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23206 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23390 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23390 [Bug 23390] Add placeholder syntax for column names -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 11:36:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Sep 2019 09:36:29 +0000 Subject: [Koha-bugs] [Bug 23529] Interlibrary loan javascript is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23529 --- Comment #2 from Andrew Isherwood --- Test plan: - Go to "ILL requests" page - TEST: Observe that the table loads all ILL requests - Go to the "New ILL request" page for any installed backend - TEST: Check the browser dev tools "Network" panel, observe that the /api/v1/illrequests?embed=metadata,patron,capabilities,library,status_alias,comments,requested_partners request is not made. - Go to "Manage request" page for a request - TEST: Check that the "ILL request log" and "Display supplier metadata" buttons work -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 13:07:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Sep 2019 11:07:59 +0000 Subject: [Koha-bugs] [Bug 23428] Self registration with a verification by email is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23428 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|19.11.00,19.05.03 |19.11.00,19.05.03,18.11.09 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 14:16:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Sep 2019 12:16:06 +0000 Subject: [Koha-bugs] [Bug 23436] Save to 'undefined' showing in Advanced cataloging editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23436 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|19.11.00 |19.11.00,19.05.04 released in| | CC| |fridolin.somers at biblibre.co | |m Status|Pushed to master |Pushed to stable --- Comment #8 from Fridolin SOMERS --- Pushed to 19.05.x for 19.05.04 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 14:17:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Sep 2019 12:17:01 +0000 Subject: [Koha-bugs] [Bug 23441] Export should not include the 'actions' column in Z3950 results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23441 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |fridolin.somers at biblibre.co | |m Status|Pushed to master |RESOLVED --- Comment #5 from Fridolin SOMERS --- Depends on Bug 23307 not in 19.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 14:19:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Sep 2019 12:19:28 +0000 Subject: [Koha-bugs] [Bug 23319] Reloading page when adding to basket from existing order can cause internal server error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23319 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|19.11.00 |19.11.00,19.05.04 released in| | CC| |fridolin.somers at biblibre.co | |m --- Comment #6 from Fridolin SOMERS --- Pushed to 19.05.x for 19.05.04 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 14:27:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Sep 2019 12:27:50 +0000 Subject: [Koha-bugs] [Bug 23408] Relatives' checkout table columns are not configured properly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23408 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |19719 CC| |fridolin.somers at biblibre.co | |m Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19719 [Bug 19719] Add a new column for collection in the patron checkouts data table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 14:27:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Sep 2019 12:27:50 +0000 Subject: [Koha-bugs] [Bug 19719] Add a new column for collection in the patron checkouts data table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19719 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23408 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23408 [Bug 23408] Relatives' checkout table columns are not configured properly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 14:28:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Sep 2019 12:28:24 +0000 Subject: [Koha-bugs] [Bug 23408] Relatives' checkout table columns are not configured properly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23408 --- Comment #7 from Fridolin SOMERS --- Caused by Bug 19719 which added collection column only in circulation.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 14:35:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Sep 2019 12:35:34 +0000 Subject: [Koha-bugs] [Bug 23408] Relatives' checkout table columns are not configured properly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23408 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|19.11.00 |19.11.00,19.05.04 released in| | --- Comment #8 from Fridolin SOMERS --- Pushed to 19.05.x for 19.05.04 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 14:39:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Sep 2019 12:39:41 +0000 Subject: [Koha-bugs] [Bug 23413] Add a holds routine to Koha::Items to fetch related holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23413 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #6 from Fridolin SOMERS --- Fix terminology corrects POD, but vars are still incorrect : my $transfer_rs = $self->_result->reserves->search($params); Should be my $holds_rs ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 14:49:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Sep 2019 12:49:44 +0000 Subject: [Koha-bugs] [Bug 23438] Use Font Awesome icons in intranet search results browser In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23438 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|19.11.00 |19.11.00,19.05.04 released in| | Status|Pushed to master |Pushed to stable --- Comment #7 from Fridolin SOMERS --- Small enhancement, I choose to backport. Pushed to 19.05.x for 19.05.04 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 15:02:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Sep 2019 13:02:28 +0000 Subject: [Koha-bugs] [Bug 23385] Hide default value fields by default on patron import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23385 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|19.11.00 |19.11.00,19.05.04 released in| | CC| |fridolin.somers at biblibre.co | |m Status|Pushed to master |Pushed to stable --- Comment #8 from Fridolin SOMERS --- Small enhancement, I choose to backport. Pushed to 19.05.x for 19.05.04 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 15:03:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Sep 2019 13:03:59 +0000 Subject: [Koha-bugs] [Bug 23390] Add placeholder syntax for column names In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23390 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED CC| |fridolin.somers at biblibre.co | |m Resolution|--- |FIXED --- Comment #18 from Fridolin SOMERS --- Depends on Bug 23206 not in 19.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 15:12:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Sep 2019 13:12:50 +0000 Subject: [Koha-bugs] [Bug 20954] Add ability to set syspref overrides in SIP as we can in Apache In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20954 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED CC| |fridolin.somers at biblibre.co | |m --- Comment #8 from Fridolin SOMERS --- Enhancement not pushed to 19.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 15:20:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Sep 2019 13:20:36 +0000 Subject: [Koha-bugs] [Bug 23291] Allow selecting patrons by smsalertnumber in batch patron modification In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23291 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #6 from Fridolin SOMERS --- Since Bug 23206 you can run batch patron modification from reports. Could you use it to select patrons by SMS alert number ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 15:49:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Sep 2019 13:49:26 +0000 Subject: [Koha-bugs] [Bug 13552] Add debar option to batch patron modification In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13552 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #15 from Fridolin SOMERS --- I think there is a problem. $infos->{debarred} is used by AddDebarment() but also in Koha::Patrons->find( $borrowernumber )->set($infos)->store. In this case borrowers.debarred in DB with get the entered date, even if there is an existing debarment with a greater date. This column must be set only by Patron::Debarments. I think $infos->{debarred} must be deleted after beeing used by AddDebarment(). Same for debarredcomment. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 15:56:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Sep 2019 13:56:08 +0000 Subject: [Koha-bugs] [Bug 22272] Calendar: When entering date ranges grey out dates in the past from the start date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22272 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #11 from Fridolin SOMERS --- Patch only adds the line : $("#dateofrange").datepicker( "option", "minDate", $(this).datepicker("getDate")); //ensure end date can't be before start date Other changes are just spaces changes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 15:56:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Sep 2019 13:56:47 +0000 Subject: [Koha-bugs] [Bug 22272] Calendar: When entering date ranges grey out dates in the past from the start date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22272 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|19.11.00 |19.11.00,19.05.04 released in| | Status|Pushed to master |Pushed to stable --- Comment #12 from Fridolin SOMERS --- Pushed to 19.05.x for 19.05.04 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 16:22:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Sep 2019 14:22:06 +0000 Subject: [Koha-bugs] [Bug 16219] Runreport.pl should allow SQL parameters to be passed on the command line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16219 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|19.11.00 |19.11.00,19.05.04 released in| | CC| |fridolin.somers at biblibre.co | |m --- Comment #12 from Fridolin SOMERS --- Small but powerfull enhancement, I choose to backport. Pushed to 19.05.x for 19.05.04 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 16:36:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Sep 2019 14:36:12 +0000 Subject: [Koha-bugs] [Bug 23309] Can't add new subfields to bibliographic frameworks in strict mode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23309 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Version(s)|19.11.00 |19.11.00,19.05.04 released in| | Status|Pushed to master |Pushed to stable --- Comment #15 from Fridolin SOMERS --- Pushed to 19.05.x for 19.05.04 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 16:40:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Sep 2019 14:40:57 +0000 Subject: [Koha-bugs] [Bug 23242] Error when adding new Z39.50/SRU server in DB strict mode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23242 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|19.11.00 |19.11.00,19.05.04 released in| | CC| |fridolin.somers at biblibre.co | |m --- Comment #5 from Fridolin SOMERS --- Pushed to 19.05.x for 19.05.04 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 16:47:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Sep 2019 14:47:36 +0000 Subject: [Koha-bugs] [Bug 23446] Fix display issue with serials navigation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23446 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Version(s)|19.11.00 |19.11.00,19.05.04 released in| | Status|Pushed to master |Pushed to stable --- Comment #5 from Fridolin SOMERS --- Pushed to 19.05.x for 19.05.04 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 16:49:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Sep 2019 14:49:47 +0000 Subject: [Koha-bugs] [Bug 22830] correct for loop in value_builder/unimarc_field_4XX.pl value_builder In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22830 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|19.11.00 |19.11.00,19.05.04 released in| | --- Comment #6 from Fridolin SOMERS --- Pushed to 19.05.x for 19.05.04 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 17:11:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Sep 2019 15:11:36 +0000 Subject: [Koha-bugs] [Bug 23291] Allow selecting patrons by smsalertnumber in batch patron modification In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23291 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #7 from Katrin Fischer --- (In reply to Fridolin SOMERS from comment #6) > Since Bug 23206 you can run batch patron modification from reports. > Could you use it to select patrons by SMS alert number ? I think not easily, if you have a list of numbers, there is no easy (or possible?) way to enter them into a runtim parameter. So it's a lot of more steps to get the link. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 2 17:22:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Sep 2019 15:22:09 +0000 Subject: [Koha-bugs] [Bug 21027] Totals in statistics tab change when StatisticsFields is changed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21027 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|19.11.00,19.05.03 |19.11.00,19.05.03,18.11.09 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 02:34:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Sep 2019 00:34:03 +0000 Subject: [Koha-bugs] [Bug 19457] If CheckPrevCheckout is set to "Do", then checkouts are blocked at the SIPServer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19457 --- Comment #29 from David Cook --- (In reply to Matthias Meusburger from comment #28) > See comment #16, CheckPrevCheckout is checked by > wants_check_for_previous_checkout in Koha/Patron.pm Thanks, Matt. The reason I didn't see it before was that it checks "checkPrevCheckout" rather than "CheckPrevCheckout". My grep search was case sensitive and I totally missed it heh. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 04:20:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Sep 2019 02:20:40 +0000 Subject: [Koha-bugs] [Bug 22623] Item location and status details missing from Your Cart display on OPAC if any attached item has a status of Withdrawn. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22623 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 06:01:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Sep 2019 04:01:03 +0000 Subject: [Koha-bugs] [Bug 23530] New: Opac-basket.pl script accidentally displays 'hidden' items Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23530 Bug ID: 23530 Summary: Opac-basket.pl script accidentally displays 'hidden' items Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: mtj at kohaaloha.com QA Contact: testopia at bugs.koha-community.org The opac-basket.pl script (opac cart feature) seems to accidentally display 'hidden' items. It seems the script intends to skip 'hidden' items, but actually skips *non* 'hidden' items instead it seems to be a trivial fix, confirmed on master and 18.11.08 branches -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 06:09:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Sep 2019 04:09:15 +0000 Subject: [Koha-bugs] [Bug 23530] Opac-basket.pl script accidentally displays 'hidden' items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23530 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 06:09:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Sep 2019 04:09:18 +0000 Subject: [Koha-bugs] [Bug 23530] Opac-basket.pl script accidentally displays 'hidden' items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23530 --- Comment #1 from Mason James --- Created attachment 92534 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92534&action=edit Bug 23530 - Opac-basket.pl script accidentally displays 'hidden' items to test patch.. - prep a test bib with hidden and other items - add bib to cart observe that hidden items are displayed - non-hidden items are hidden - apply patch, reload page observe that hidden items are hidden, non-hidden items are displayed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 06:11:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Sep 2019 04:11:42 +0000 Subject: [Koha-bugs] [Bug 23530] Opac-basket.pl script accidentally displays 'hidden' items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23530 --- Comment #2 from Mason James --- Created attachment 92535 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92535&action=edit before patch, WITHDRAWN item displayed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 06:12:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Sep 2019 04:12:59 +0000 Subject: [Koha-bugs] [Bug 23530] Opac-basket.pl script accidentally displays 'hidden' items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23530 --- Comment #3 from Mason James --- Created attachment 92536 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92536&action=edit after patch, WITHDRAWN item hidden -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 06:17:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Sep 2019 04:17:49 +0000 Subject: [Koha-bugs] [Bug 23530] Opac-basket.pl script accidentally displays 'hidden' items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23530 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 06:19:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Sep 2019 04:19:49 +0000 Subject: [Koha-bugs] [Bug 23530] Opac-basket.pl script accidentally displays 'hidden' items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23530 --- Comment #4 from Mason James --- hi Marcel i think the error was introduced from a 'squashing' patch for BZ 14385 https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80466 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 07:08:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Sep 2019 05:08:29 +0000 Subject: [Koha-bugs] [Bug 15513] Hide OpacHiddenItems items from cart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15513 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #1 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 23530 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 07:08:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Sep 2019 05:08:29 +0000 Subject: [Koha-bugs] [Bug 23530] Opac-basket.pl script accidentally displays 'hidden' items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23530 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #5 from Katrin Fischer --- *** Bug 15513 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 07:12:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Sep 2019 05:12:56 +0000 Subject: [Koha-bugs] [Bug 23530] Opac-basket.pl script accidentally displays 'hidden' items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23530 Irma Birchall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |irma at calyx.net.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 07:23:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Sep 2019 05:23:32 +0000 Subject: [Koha-bugs] [Bug 23530] Opac-basket.pl script accidentally displays 'hidden' items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23530 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major --- Comment #6 from Katrin Fischer --- Updating severity - affects the OPAC (library patrons) and is even worse than showing the hidden items as it hides the all the items that you should see. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 07:25:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Sep 2019 05:25:45 +0000 Subject: [Koha-bugs] [Bug 23530] Opac-basket.pl script accidentally displays 'hidden' items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23530 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 07:25:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Sep 2019 05:25:51 +0000 Subject: [Koha-bugs] [Bug 23530] Opac-basket.pl script accidentally displays 'hidden' items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23530 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92534|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer --- Created attachment 92537 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92537&action=edit Bug 23530: Fix cart showing only hidden items Items hidden with the OpacHiddenItems system preference were still displayed in the OPAC cart and the normal items were hidden instead. This patch corrects the display. To test: - prep a test bib with hidden and other items using the OpacHiddenItems system preference - add bib to cart - observe that hidden items are displayed - non-hidden items are hidden - apply patch, reload page - observe that hidden items are hidden, non-hidden items are displayed Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 07:26:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Sep 2019 05:26:22 +0000 Subject: [Koha-bugs] [Bug 23530] Opac-basket.pl script accidentally displays 'hidden' items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23530 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 10:35:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Sep 2019 08:35:19 +0000 Subject: [Koha-bugs] [Bug 23531] New: ILS-DI doesn't implement needed_before_date and pickup_expiry_date parameters. Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531 Bug ID: 23531 Summary: ILS-DI doesn't implement needed_before_date and pickup_expiry_date parameters. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Web services Assignee: koha-bugs at lists.koha-community.org Reporter: arthur.suzuki at biblibre.com QA Contact: testopia at bugs.koha-community.org tried to send the following request : GET /cgi-bin/koha/ilsdi.pl?service=HoldItem&patron_id=196&bib_id=96629&item_id=112194&needed_before_date=2020-08-18&pickup_expiry_date=2020-10-18&pickup_location=BDY the reservation which is placed doesn't take the "needed_before_date" and pickup_expiry_date" parameter, although those are documented. Arthur -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 11:14:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Sep 2019 09:14:37 +0000 Subject: [Koha-bugs] [Bug 23531] ILS-DI doesn't implement needed_before_date and pickup_expiry_date parameters. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531 --- Comment #1 from Arthur Suzuki --- Created attachment 92538 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92538&action=edit bug23531 : fix ILSDI non-implemented but documented parameters test plan : 1/ Submit a hold through ILSDI with needed_before_date and pickup_expiry_date parameters 2/ Verify in Koha those parameters are not applied to the newly created reserve. Delete reserve. 3/ Apply patch and repeat 1. 4/ Verify the reserve created by same request as 1 now has both dates applied and visible in Koha. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 11:40:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Sep 2019 09:40:56 +0000 Subject: [Koha-bugs] [Bug 23173] ILL should be able to search third party sources prior to request creation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23173 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92107|0 |1 is obsolete| | --- Comment #8 from Andrew Isherwood --- Created attachment 92539 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92539&action=edit Bug 23173: Add ILLCheckAvailability syspref This patch adds the new syspref "ILLCheckAvailability" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 11:40:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Sep 2019 09:40:59 +0000 Subject: [Koha-bugs] [Bug 23173] ILL should be able to search third party sources prior to request creation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23173 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92108|0 |1 is obsolete| | --- Comment #9 from Andrew Isherwood --- Created attachment 92540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92540&action=edit Bug 23173: Provide core infrastructure This patch adds the required infrastructure to enable ILL availability plugins to intercept the request creation process and, using the supplied metadata, search for and display possible relevant items from whichever availability plugins are installed. Currently two availability plugins exist: z39.50 - Searches any number of the Koha instance's configured Z targets https://github.com/PTFS-Europe/koha-plugin-ill-avail-z3950 Unpaywall - Searches the Unpaywall API for possible open access versions of the requested item https://github.com/PTFS-Europe/koha-plugin-ill-avail-unpaywall The Unpaywall plugin is intended to serve as a "reference" plugin as the API it deals with is extremely simple -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 12:25:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Sep 2019 10:25:14 +0000 Subject: [Koha-bugs] [Bug 23415] Notify patron fines when renewing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Emmi Takkinen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92039|0 |1 is obsolete| | --- Comment #2 from Emmi Takkinen --- Created attachment 92541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92541&action=edit Bug 23415: Notify patron fines when renewing In previous patch error message wasn't translatable. Fixed that and made sure loading gif on checkout list works correctly after this patch is applied. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 12:56:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Sep 2019 10:56:19 +0000 Subject: [Koha-bugs] [Bug 23532] New: AutoCreateAuthorities create authority only headings Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23532 Bug ID: 23532 Summary: AutoCreateAuthorities create authority only headings Change sponsored?: --- Product: Koha Version: 19.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: gveranis at gmail.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl The problem: We have enable AutoCreateAuthorities and also enable BiblioAddsAuthorities and when we insert values for tag 650 , we get authorities only with 150$a filled and not other subfields. I found that on C4/Biblio.pm lines 549 - 555 map { $authfield->add_subfields( $_->[0] => $_->[1] ) if ( $_->[0] =~ /[A-z]/ && $_->[0] ne "a" && C4::Heading::valid_bib_heading_subfield( $authority_type->auth_tag_to_report, $_->[0] ) ); } $field->subfields(); Koha try to copy subfields to the new authority record. BUT the condition C4::Heading::valid_bib_heading_subfield( $authority_type->auth_tag_to_report, $_->[0]) return false. Because the $authority_type->auth_tag_to_report has value of 150 and not 650 as file C4/Heading/MARC21.pm declared. if we set on file C4/Heading/MARC21.pm also the value '150' => { auth_type => 'TOPIC_TERM', subfields => 'abvxyz', subject => 1 }, (valid based on https://github.com/Koha-Community/Koha/blob/master/installer/data/mysql/en/marcflavour/marc21/mandatory/authorities_normal_marc21.sql) then it works , but I am not sure if it is valid to set there new fields. or better solution could be $authority_type->auth_tag_to_report take right value in condition. Could anyone propose the best solution ? Thanks, George Veranis -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 12:56:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Sep 2019 10:56:50 +0000 Subject: [Koha-bugs] [Bug 23532] AutoCreateAuthorities create authority only headings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23532 George Veranis changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 13:21:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Sep 2019 11:21:19 +0000 Subject: [Koha-bugs] [Bug 23413] Add a holds routine to Koha::Items to fetch related holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23413 --- Comment #7 from Nick Clemens --- Created attachment 92542 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92542&action=edit Bug 23413: (follow-up) Rename variables -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 13:21:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Sep 2019 11:21:23 +0000 Subject: [Koha-bugs] [Bug 23413] Add a holds routine to Koha::Items to fetch related holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23413 --- Comment #8 from Nick Clemens --- Created attachment 92543 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92543&action=edit Bug 23413: Update tests to use build_sample_biblio Before these changes the tests fail if run under Elasticsearch This makes sure they pass either way -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 13:27:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Sep 2019 11:27:00 +0000 Subject: [Koha-bugs] [Bug 23413] Add a holds routine to Koha::Items to fetch related holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23413 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92543|0 |1 is obsolete| | --- Comment #9 from Nick Clemens --- Created attachment 92544 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92544&action=edit Bug 23413: Update tests to use build_sample_biblio Before these changes the tests fail if run under Elasticsearch This makes sure they pass either way -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 14:28:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Sep 2019 12:28:12 +0000 Subject: [Koha-bugs] [Bug 23529] Interlibrary loan javascript is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23529 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from Owen Leonard --- I get an error when testing this: SyntaxError: missing ) after argument list ill-list-table_19.0600022.js:502:8 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 14:41:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Sep 2019 12:41:52 +0000 Subject: [Koha-bugs] [Bug 23531] ILS-DI doesn't implement needed_before_date and pickup_expiry_date parameters. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |arthur.suzuki at biblibre.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 14:44:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Sep 2019 12:44:08 +0000 Subject: [Koha-bugs] [Bug 23156] Add pagination to checkouts in ILS-DI GetPatronInfo service In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23156 --- Comment #18 from Arthur Suzuki --- Awesome! Nice work everyone :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 14:46:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Sep 2019 12:46:15 +0000 Subject: [Koha-bugs] [Bug 23529] Interlibrary loan javascript is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23529 --- Comment #4 from Andrew Isherwood --- Created attachment 92545 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92545&action=edit Bug 23529: (follow-up) Fix syntax error As mentioned in comment #3 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 14:48:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Sep 2019 12:48:19 +0000 Subject: [Koha-bugs] [Bug 23529] Interlibrary loan javascript is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23529 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #5 from Andrew Isherwood --- Sorry Owen, bad commit! What's super weird is that, although I could see the syntax error in my editor, my browser wasn't complaining about it! Hence me not catching if before I attached the patch. Anyway, it should be fixed now. Apologies for that! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 15:16:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Sep 2019 13:16:08 +0000 Subject: [Koha-bugs] [Bug 23530] Opac-basket.pl script accidentally displays 'hidden' items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23530 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 15:16:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Sep 2019 13:16:13 +0000 Subject: [Koha-bugs] [Bug 23530] Opac-basket.pl script accidentally displays 'hidden' items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23530 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92537|0 |1 is obsolete| | --- Comment #8 from Nick Clemens --- Created attachment 92546 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92546&action=edit Bug 23530: Fix cart showing only hidden items Items hidden with the OpacHiddenItems system preference were still displayed in the OPAC cart and the normal items were hidden instead. This patch corrects the display. To test: - prep a test bib with hidden and other items using the OpacHiddenItems system preference - add bib to cart - observe that hidden items are displayed - non-hidden items are hidden - apply patch, reload page - observe that hidden items are hidden, non-hidden items are displayed Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 15:23:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Sep 2019 13:23:57 +0000 Subject: [Koha-bugs] [Bug 23039] Hold found modal on checkin screen ( circulation.pl ) obscures Check in message info In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23039 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #15 from Owen Leonard --- (In reply to Nick Clemens from comment #13) > I am wondering if we can simply leave them in place? I don't have a problem with doing it this way. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 15:28:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Sep 2019 13:28:51 +0000 Subject: [Koha-bugs] [Bug 23512] Reindent notices and slips page (letter.tt) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23512 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 15:28:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Sep 2019 13:28:55 +0000 Subject: [Koha-bugs] [Bug 23512] Reindent notices and slips page (letter.tt) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23512 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92529|0 |1 is obsolete| | Attachment #92530|0 |1 is obsolete| | --- Comment #5 from Nick Clemens --- Created attachment 92547 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92547&action=edit Bug 23512: (follow-up) Markup comments and corrections This patch adds comments to the template to highlight the markup structure. It also corrects some minor markup errors. This patch should have no effect on the interface or functionality. Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 15:29:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Sep 2019 13:29:24 +0000 Subject: [Koha-bugs] [Bug 23512] Reindent notices and slips page (letter.tt) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23512 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92547|0 |1 is obsolete| | --- Comment #6 from Nick Clemens --- Created attachment 92548 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92548&action=edit Bug 23512: Reindent notices and slips page (letter.tt) This patch re-indents the template for notices and slips. It makes only whitespace changes. It should have no effect on the behavior of the page. To test, go to Tools -> Notices & slips. Test every aspect of the notice creation and edit process. At each step the page should work correctly. Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 15:29:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Sep 2019 13:29:28 +0000 Subject: [Koha-bugs] [Bug 23512] Reindent notices and slips page (letter.tt) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23512 --- Comment #7 from Nick Clemens --- Created attachment 92549 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92549&action=edit Bug 23512: (follow-up) Markup comments and corrections This patch adds comments to the template to highlight the markup structure. It also corrects some minor markup errors. This patch should have no effect on the interface or functionality. Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 15:55:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Sep 2019 13:55:29 +0000 Subject: [Koha-bugs] [Bug 23173] ILL should be able to search third party sources prior to request creation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23173 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92539|0 |1 is obsolete| | --- Comment #10 from Andrew Isherwood --- Created attachment 92550 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92550&action=edit Bug 23173: Add ILLCheckAvailability syspref This patch adds the new syspref "ILLCheckAvailability" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 15:55:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Sep 2019 13:55:33 +0000 Subject: [Koha-bugs] [Bug 23173] ILL should be able to search third party sources prior to request creation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23173 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92540|0 |1 is obsolete| | --- Comment #11 from Andrew Isherwood --- Created attachment 92551 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92551&action=edit Bug 23173: Provide core infrastructure This patch adds the required infrastructure to enable ILL availability plugins to intercept the request creation process and, using the supplied metadata, search for and display possible relevant items from whichever availability plugins are installed. Currently two availability plugins exist: z39.50 - Searches any number of the Koha instance's configured Z targets https://github.com/PTFS-Europe/koha-plugin-ill-avail-z3950 Unpaywall - Searches the Unpaywall API for possible open access versions of the requested item https://github.com/PTFS-Europe/koha-plugin-ill-avail-unpaywall The Unpaywall plugin is intended to serve as a "reference" plugin as the API it deals with is extremely simple -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 16:35:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Sep 2019 14:35:10 +0000 Subject: [Koha-bugs] [Bug 23079] Checkouts page broken because of problems with date calculation (TZAmerica/Sao_Paulo) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23079 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 16:35:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Sep 2019 14:35:14 +0000 Subject: [Koha-bugs] [Bug 23079] Checkouts page broken because of problems with date calculation (TZAmerica/Sao_Paulo) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23079 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92525|0 |1 is obsolete| | --- Comment #18 from Nick Clemens --- Created attachment 92552 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92552&action=edit Bug 23079: Handle invalid timezones when adding/subtracting durations On Nov 3rd 2019, Brazil will skip from 00:00 to 1:00 (http://www.currenttimeonline.com/dst/dst.do?tz=America/Sao_Paulo), DateTime consider it as an invalid date. It is a problem when we are playing with dates without the time part (always 00:00). When we instantiate a DateTime (from dt_from_string) we are already handling this issue, and use the floating timezone (since bug 12669). The problem remains when we generate a DateTime then add or subtract a duration, which will result in an invalid date: DateTime->new(year => 2019, month => 12, day => 3, time_zone => 'America/Sao_Paulo')->subtract(days => 30); => Nov 3rd 2019, kaboom. We should replace all the problematic occurrences of dt_from_string->subtract (or ->add) with dt_from_string(undef, undef, 'floating'), to use the floating timezone and avoid the error. Actually there are not many of them, I have found only 3 that could produce real problems. The other occurrences are: - in tests => Not a big deal (for now) - called on a datetime, so it will explode if called at midnight 00:00:00 (and nobody should work at that time). Test plan: 0/ Define the timezone to 'America/Sao_Paulo' (in your koha-conf.xml file), restart_all 1/ Set a patron's expiry date to Dec 3rd 2019, and NotifyBorrowerDeparture to 30 (default value) 2/ See the checkouts page for this user => Without this patch you get "Invalid local time for date in time zone: America/Sao_Paulo" => With this patch apply the page displays correctly QA will review the 2 other occurrences. Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 16:35:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Sep 2019 14:35:17 +0000 Subject: [Koha-bugs] [Bug 23079] Checkouts page broken because of problems with date calculation (TZAmerica/Sao_Paulo) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23079 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92526|0 |1 is obsolete| | --- Comment #19 from Nick Clemens --- Created attachment 92553 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92553&action=edit Bug 23079: Add tests Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 16:42:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Sep 2019 14:42:23 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agustín Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 16:42:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Sep 2019 14:42:43 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agustín Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91701|0 |1 is obsolete| | Attachment #91702|0 |1 is obsolete| | Attachment #91703|0 |1 is obsolete| | Attachment #91704|0 |1 is obsolete| | Attachment #91705|0 |1 is obsolete| | Attachment #91706|0 |1 is obsolete| | Attachment #91707|0 |1 is obsolete| | Attachment #91708|0 |1 is obsolete| | Attachment #91709|0 |1 is obsolete| | Attachment #91710|0 |1 is obsolete| | Attachment #91711|0 |1 is obsolete| | Attachment #91712|0 |1 is obsolete| | Attachment #91750|0 |1 is obsolete| | Attachment #91751|0 |1 is obsolete| | Attachment #91752|0 |1 is obsolete| | Attachment #91753|0 |1 is obsolete| | Attachment #91754|0 |1 is obsolete| | Attachment #91755|0 |1 is obsolete| | Attachment #91756|0 |1 is obsolete| | Attachment #91757|0 |1 is obsolete| | Attachment #91758|0 |1 is obsolete| | --- Comment #194 from Agustín Moyano --- Created attachment 92554 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92554&action=edit Bug 22284: New ft_local_hold_group column, and 'holgroup' enum option In order to add groups for holds, this patch provides a new column in library_groups to identify them. Also provides new enum option for hold_fulfillment_policy column of default_branch_circ_rules, default_circ_rules, default_branch_item_rules and branch_item_rules. To test: 1) check that there is no ft_local_hold_group column in library_groups and that there are no 'holdgroup' enum option in hold_fulfillment_policy in default_branch_circ_rules, default_circ_rules, default_branch_item_rules and branch_item_rules 2) apply this patch 3) perl installer/data/mysql/updatedatabase.pl && dbic SUCCESS => !(step 1) ;-D 4) Sign off Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 16:42:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Sep 2019 14:42:59 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #195 from Agustín Moyano --- Created attachment 92555 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92555&action=edit Bug 22284: Add new checkbox in Library Groups This patch adds a new checkbox option 'Is local hold group' when you create a new root group. To test: 1) In intranet go to Library Groups in admin module 2) Add new root group 3) Check that there is no 'Is local hold group' checkbox 4) Apply this patch 5) Add new root group SUCCESS => a new 'Is local hold group' checkbox appears 6) Select 'Is local hold group' and save 7) Click edit button for root group SUCCESS => 'Is local hold group' is checked 8) Sign off Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 16:43:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Sep 2019 14:43:12 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #196 from Agustín Moyano --- Created attachment 92556 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92556&action=edit Bug 22284: New hold group options in smart-rules This patch adds new options for 'Default checkout, hold and return policy' and 'Default holds policy by item type', both in 'Hold policy' and 'Hold pickup library match' columns To test: 1) Go to 'Circulation and fines rules' in admin 2) Check that there are no options for hold group in 'Hold policy' and 'Hold pickup library match' columns 3) Apply this patch SUCCESS => in 'Hold policy' you should see 'From local hold group' option, and in 'Hold pickup library match' you should see "Item's hold group" 4) Select any of those options and save SUCCESS => options should be selected when page reloads 5) Sign off Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 16:43:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Sep 2019 14:43:27 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #197 from Agustín Moyano --- Created attachment 92557 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92557&action=edit Bug 22284: Control hold groups in C4::Reserves This patch modifies C4::Reserves to control when hold group options where selected in smart rules. In CanItemBeReserved adds 2 new error status messages 1) branchNotInHoldGroup: when a patron's homebranch is not in item's hold group 2) pickupNotInHoldGroup: when a selected pickup location is not in item's hold group Also CheckReserves is modified when item's priority is defined, to control by hold group when required. Finally, IsAvailableForItemLevelRequest was also modified to control by hold group when required. To test: 1) Apply this patch 2) prove t/db_dependent/Holds.t SUCCESS => Result: PASS 3) Sign off Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 16:43:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Sep 2019 14:43:45 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #198 from Agustín Moyano --- Created attachment 92558 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92558&action=edit Bug 22284: New methods in Koha::Library::Groups and Koha::Library This patch adds new methods in Koha::Library::Groups and Koha::Library. 1) For Koha::Library::Groups adds get_root_ancestor that returns all root groups for a given search parameters, for example Koha::Library::Groups->get_root_ancestor( { id => $group_id } ) 2) For Koha::Library adds 2.1) get_hold_libraries: returns all libraries (including self) that belongs to the same holdgroups. If $self belongs to several holdgroups it will return a distinct list of all libraries belonging to them. 2.2) validate_hold_sibling: Returns 1 if the given parameters matches any of the libraries that belong to any of the holdgroups this library belongs. For example $library->validate_hold_sibling( { branchcode => $branchcode } ) To test: 1) apply this patch 2) prove t/db_dependent/Koha/Libraries.t t/db_dependent/LibraryGroups.t SUCCESS => green letters :-D 3) Sign off Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 16:43:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Sep 2019 14:43:59 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #199 from Agustín Moyano --- Created attachment 92559 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92559&action=edit Bug 22284: Opac pickup_locations This patch modifies Koha::Libraries->pickup_location and moves most of the logic to Koha::Item and Koha::Biblio in preparation for api endpoints in the future. There where 2 methods added 1) Koha::Item->pickup_locations that given a patron, returns all pickup locations of this item, considering hold fulfillment rules, and hold allowed rules. 2) Koha::Biblio->pickup_locations that given a patron, returns a distinct list of libraries returned by each of this biblio items pickup location. Koha::Libraries->pickup_location analyzes input param and calls Koha::Item->pickup_locations or Koha::Biblio->pickup_locations as needed. Also in opac-reserve.tt the way options where obtained to fill the pickup location select was modified to pass the patron as a parameter. To test: 1) opac: try to place hold on a item and check that all libraries are shown in the pickup location select. 2) intranet: in Library groups, add 2 root groups marked as local hold group and add different libraries to each. 3) opac: login as a user of a library belonging to one hold group, and search try to place a hold on an item belongin to the other hold group. 4) intranet: in Circulation and fines rules, play with 'Hold policy' and 'Hold pickup library match' rules. 5) opac: On each modification of the rules reload the page. SUCCESS => Every time you reload the page, the number of pickup locations showed in select varies. 6) prove t/db_dependent/Koha/Biblios.t t/db_dependent/Koha/Items.t SUCCESS => Result: PASS 7) Sign off Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 16:44:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Sep 2019 14:44:12 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #200 from Agustín Moyano --- Created attachment 92560 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92560&action=edit Bug 22284: (follow-up) Default to circulation control branch when no hold libraries are found Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 16:44:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Sep 2019 14:44:27 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #201 from Agustín Moyano --- Created attachment 92561 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92561&action=edit Bug 22284: New message, new column and filter pickup locations in reserve/request.tt This patch adds a new message to 'Hold' column in 'Place a hold on a specific item' table. The message is "Cannot place hold from patrons's library". It appears when patron's homebranch is not in item's hold group, and hold_fulfillment_policy is set to 'holdgroup'. This patch also adds a new column "Allowed pickup locations" that lists allowed pickup locations per item. Finally, the select that displays pickup locations is filtered by allowed pickup locations, when multi_hold is not enabled To test: 1) Apply this patch 2) In library groups add a root group and check it as hold group. 3) Add two libraries to the group 4) In circulation and fines rules, in 'Default checkout, hold and return policy', in Hold policy change the value to 'From local hold group' 5) Search a patron from a different library than step 3, select one and click 'search to hold' 6) Search by location for items in any library of step 3 7) On any item, clic on 'Place hold for ...' SUCCESS => when the page is loaded, in the 'Place a hold on a specific item', you should see the message "Cannot place hold from patrons's library" in 'Hold' column => You should see a new column called "Allowed pickup locations" and the message is "Any library" 8) In circulation and fines rules, in 'Default checkout, hold and return policy', in 'Hold policy' change the value again to 'From any library' and change 'Hold pickup library match' to "Item's hold group" 8) Repeat steps 5 to 7 SUCCESS => when the page is loaded, you should see the "Pickup at" select filtered by libraries in hold group => You should see in "Allowed pickup locations" a coma separated list of the libraries in item's hold group => If biblio has an item whose control branch is not in a hold group, you should see the control branch name in "Allowed pickup locations" 9) Sign off Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 16:44:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Sep 2019 14:44:44 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #202 from Agustín Moyano --- Created attachment 92562 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92562&action=edit Bug 22284: Filter item's pickup locations in holds_table.inc This patch filters pickup locations per item in holds_table.inc To test: 1) Go to Circulation and fines rules and change max holds allowed to > 0, and change 'Hold pickup library match' to homebranch 2) Search for a patron 3) Click on "Search to hold" 4) Search for any bilio 5) Place hold on a specific item CHECK => Item's pickup location is a select with all libraries 6) Apply this patch 7) Repeat steps 2 to 5 SUCCESS => Item's pickup location is filtered by allowed pickup locations 8) Sign off Sponsored-by: VOKAL Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 16:44:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Sep 2019 14:44:51 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #203 from Agustín Moyano --- Created attachment 92563 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92563&action=edit Bug 22284: (follow-up) Remove commented warn and address test failures Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 16:45:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Sep 2019 14:45:04 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #204 from Agustín Moyano --- Created attachment 92564 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92564&action=edit Bug 22284: (follow-up) fix test count after merge Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 16:45:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Sep 2019 14:45:21 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #205 from Agustín Moyano --- Created attachment 92565 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92565&action=edit Bug 22284: (follow-up) fixes after 15496 Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 16:45:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Sep 2019 14:45:31 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #206 from Agustín Moyano --- Created attachment 92566 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92566&action=edit Bug 22284: (follow-up) fixes after 18936 Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 16:45:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Sep 2019 14:45:44 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #207 from Agustín Moyano --- Created attachment 92567 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92567&action=edit Bug 22284: (follow-up) Remove HomeOrHolding from reserves Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 16:45:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Sep 2019 14:45:57 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #208 from Agustín Moyano --- Created attachment 92568 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92568&action=edit Bug 22284: Add "patron's hold group" as new hold_fulfillment_policy option This patch adds "patron's hold group" as a new option to Hold pickup library match To test: 1. Set ReservesControlBranch preference to item. 2. Create a hold group 3. Go to circulation and fines rules SUCCESS => in 'Hold pickup library match' there is a new option called "patron's hold group" 4. In a library not in hold group set 'Hold policy' to "any" and 'Hold pickup library match' to "patron's hold group" 5. Search for a user in the hold group 6. 'Search to hold' for items of the library of step 4 7. Select an item and 'Place hold for [user]' SUCCESS => in 'Pickup at' you should see patron's hold group as options 8. In OPAC sign in as the same user of step 5 9. Search for the item in step 7 SUCCESS => in 'Pick up locations' you should see patron's hold group as options 10. Sign off Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 16:46:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Sep 2019 14:46:09 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #209 from Agustín Moyano --- Created attachment 92569 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92569&action=edit Bug 22284: (follow-up) Use GetReserveControlBranch in Koha::Item->pickup_locations Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 16:46:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Sep 2019 14:46:20 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #210 from Agustín Moyano --- Created attachment 92570 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92570&action=edit Bug 22284: (follow-up) Fix tests Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 16:46:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Sep 2019 14:46:31 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #211 from Agustín Moyano --- Created attachment 92571 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92571&action=edit Bug 22284: (follow-up) Fix typo in request.tt Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 16:46:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Sep 2019 14:46:42 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #212 from Agustín Moyano --- Created attachment 92572 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92572&action=edit Bug 22284: (follow-up) Filter pickup on specific item click Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 16:46:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Sep 2019 14:46:57 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #213 from Agustín Moyano --- Created attachment 92573 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92573&action=edit Bug 22284: (Do not push) Schema update Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 16:47:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Sep 2019 14:47:07 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #214 from Agustín Moyano --- Created attachment 92574 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92574&action=edit Bug 22284: (follow-up) Fix typos transfered -> transferred Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 16:55:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Sep 2019 14:55:30 +0000 Subject: [Koha-bugs] [Bug 21852] Add more columns and column configuration to overdues report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21852 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 16:55:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Sep 2019 14:55:33 +0000 Subject: [Koha-bugs] [Bug 21852] Add more columns and column configuration to overdues report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21852 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92373|0 |1 is obsolete| | Attachment #92374|0 |1 is obsolete| | Attachment #92375|0 |1 is obsolete| | --- Comment #32 from Owen Leonard --- Created attachment 92575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92575&action=edit Bug 21852: Add more columns and column configuration to overdues report This patch adds some new columns to the overdue report: Patron category, item home library, item holding library, item type. Adding these columns makes available columns better match the available filter fields in the sidebar form. Column configuration is added to this DataTable, with the new columns defined as hidden by default in order to preserve current functionality. This patch also fixes a bug where the home and holding branch template variable names didn't match what was being used in the template for pre-selecting the searched-for value in the sidebar filter menu. To test, apply the patch and go to Circulation -> Overdues. - The list of overdues should look correct, with no new columns shown. - Test the column visibility button, showing the columns which are hidden by default. Confirm that the data in these columns displays correctly. - Update the default configuration for this table in Administration -> Configure columns. Confirm that your changes are applied to the overdues report. Signed-off-by: Maryse Simard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 17:31:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Sep 2019 15:31:36 +0000 Subject: [Koha-bugs] [Bug 23265] Update to DB revision 16.12.00.032 fails: Unknown column 'me.item_level_hold' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23265 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92029|0 |1 is obsolete| | --- Comment #7 from Victor Grousset/tuxayo --- Created attachment 92576 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92576&action=edit Bug 23265: (bug 12063 follow-up) Remove Koha::Holds from updatedatabase Test plan: Have a DB that fail the 16.12.00.032 update, then apply this patch and verify the expiration dates RM: Please inforce this rule, no use of Koha:: in updatedatabase! Signed-off-by: Victor Grousset -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 17:32:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Sep 2019 15:32:15 +0000 Subject: [Koha-bugs] [Bug 23265] Update to DB revision 16.12.00.032 fails: Unknown column 'me.item_level_hold' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23265 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor.grousset at biblibre.co | |m Status|Needs Signoff |Signed Off --- Comment #8 from Victor Grousset/tuxayo --- Thanks, I just stumbled on this issue :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 18:34:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Sep 2019 16:34:33 +0000 Subject: [Koha-bugs] [Bug 23172] Issuingrules not checked when returning item and allocating to bib-level holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23172 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |nick at bywatersolutions.com --- Comment #11 from Nick Clemens --- I didn't fully test, but a few notes: 1 - Reserves.t fails after applying the patches 2 - The tests should use specific branches rather than deleting all rules/reserves - not a blocker 3 - check_if_existing_hold_matches_issuingrules should use the item and borrower methods rather than find - this will let us use table relationships and prefetch in the future and save db calls/hits 4 - Why do you unbless the item? 5 - the ReservesControlBranch code could be its own function - Koha::Hold::get_control_branch - not a blocker, but the tests should mock the pref and ensure behaviour works as expected with both settings -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 18:54:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Sep 2019 16:54:27 +0000 Subject: [Koha-bugs] [Bug 22627] Rephrase 'your fines' tab in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22627 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 18:54:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Sep 2019 16:54:35 +0000 Subject: [Koha-bugs] [Bug 22627] Rephrase 'your fines' tab in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22627 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92141|0 |1 is obsolete| | --- Comment #10 from Nick Clemens --- Created attachment 92577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92577&action=edit Bug 22627: Renames OPAC fines tab to 'your charges' to be more inclusive Brought up on Bug 21578, the 'your fines' tab in the OPAC would be better named as 'your charges' as not all charges are fines, some are credits etc. To test: 1) In the OPAC, click on the user's name and note that the tab that was called your fines is now called your charges. 2) When you click on the tab, the title says Your charges, the breadcrumb says Your charges, and the table title is Your charges. Sponsored-by: Catalyst IT. Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 18:54:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Sep 2019 16:54:40 +0000 Subject: [Koha-bugs] [Bug 22627] Rephrase 'your fines' tab in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22627 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92142|0 |1 is obsolete| | --- Comment #11 from Nick Clemens --- Created attachment 92578 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92578&action=edit Bug 22627: Rename tab on my summary page This completes the first patch by also changing the tab on the OPAC summary page from "Fines" to "Charges". Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 20:36:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Sep 2019 18:36:04 +0000 Subject: [Koha-bugs] [Bug 23533] New: Reindent patron entry form (memberentrygen.tt) Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23533 Bug ID: 23533 Summary: Reindent patron entry form (memberentrygen.tt) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: testopia at bugs.koha-community.org I would like to reindent members/memberentrygen.tt. Correct indentation, replace tabs with spaces, and add some comments to clarify the structure. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 20:49:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Sep 2019 18:49:47 +0000 Subject: [Koha-bugs] [Bug 23534] New: Use patron-title.inc on patron entry page Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23534 Bug ID: 23534 Summary: Use patron-title.inc on patron entry page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: testopia at bugs.koha-community.org Depends on: 23533 There are several places on the patron entry form where we could use patron-title.inc instead of outputting the patron name information directly in the template. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23533 [Bug 23533] Reindent patron entry form (memberentrygen.tt) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 20:49:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Sep 2019 18:49:47 +0000 Subject: [Koha-bugs] [Bug 23533] Reindent patron entry form (memberentrygen.tt) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23533 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23534 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23534 [Bug 23534] Use patron-title.inc on patron entry page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 21:57:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Sep 2019 19:57:47 +0000 Subject: [Koha-bugs] [Bug 22524] Elasticsearch - Date range in advanced search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22524 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #32 from Lucas Gass --- backported to 18.11.x for 18.11.10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 22:43:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Sep 2019 20:43:19 +0000 Subject: [Koha-bugs] [Bug 22524] Elasticsearch - Date range in advanced search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22524 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 22:44:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Sep 2019 20:44:43 +0000 Subject: [Koha-bugs] [Bug 23316] GetFine needs updating for bug 22521 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23316 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #6 from Lucas Gass --- missing dependencies for 18.11.x, no backport -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 22:44:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Sep 2019 20:44:55 +0000 Subject: [Koha-bugs] [Bug 23316] GetFine needs updating for bug 22521 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23316 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 22:46:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Sep 2019 20:46:24 +0000 Subject: [Koha-bugs] [Bug 22249] Error when submitting Mana comment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22249 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #13 from Lucas Gass --- missing dependency for 18.11.x, no backport -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 22:46:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Sep 2019 20:46:41 +0000 Subject: [Koha-bugs] [Bug 22249] Error when submitting Mana comment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22249 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 22:48:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Sep 2019 20:48:26 +0000 Subject: [Koha-bugs] [Bug 21716] Item Search hangs when \ exists in MARC fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21716 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 23:02:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Sep 2019 21:02:01 +0000 Subject: [Koha-bugs] [Bug 21716] Item Search hangs when \ exists in MARC fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21716 --- Comment #18 from Lucas Gass --- backported to 19.05.x for 19.05.03 backported to 18.11.x for 18.11.10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 23:02:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Sep 2019 21:02:14 +0000 Subject: [Koha-bugs] [Bug 21716] Item Search hangs when \ exists in MARC fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21716 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 23:19:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Sep 2019 21:19:30 +0000 Subject: [Koha-bugs] [Bug 23226] Remove type attribute from script tags: Cataloging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23226 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #6 from Lucas Gass --- backported to 18.11.x for 18.11.10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 23:22:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Sep 2019 21:22:01 +0000 Subject: [Koha-bugs] [Bug 23345] Wrong parameter name in koha-dump usage statement In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23345 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |lucas at bywatersolutions.com --- Comment #6 from Lucas Gass --- backported to 18.11.x for 18.11.10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 23:29:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Sep 2019 21:29:45 +0000 Subject: [Koha-bugs] [Bug 23251] EDI Order line incorrectly terminated when it ends with a quoted apostrophe In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23251 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #8 from Lucas Gass --- backported to 18.11.x for 18.11.10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 3 23:30:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Sep 2019 21:30:04 +0000 Subject: [Koha-bugs] [Bug 23251] EDI Order line incorrectly terminated when it ends with a quoted apostrophe In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23251 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 00:23:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Sep 2019 22:23:13 +0000 Subject: [Koha-bugs] [Bug 21518] Material type "three-dimensional artifact" displays as "visual material" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21518 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #8 from Lucas Gass --- backported to 18.11.x for 18.11.10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 00:23:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Sep 2019 22:23:32 +0000 Subject: [Koha-bugs] [Bug 21518] Material type "three-dimensional artifact" displays as "visual material" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21518 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 00:35:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Sep 2019 22:35:55 +0000 Subject: [Koha-bugs] [Bug 23099] OPAC Search result sorting "go" button flashes on page load In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23099 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |lucas at bywatersolutions.com --- Comment #6 from Lucas Gass --- backported to 18.11.x for 18.11.10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 01:55:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Sep 2019 23:55:40 +0000 Subject: [Koha-bugs] [Bug 21701] Have PayPal optionally return to originating OPAC url rather than OPACBaseURL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21701 --- Comment #3 from David Kuhn --- The following prerequisites are needed to test this patch: 1. Enable PayPal on your system (either Sandbox mode or Live) 2. Set the PayPal credentials PayPalPwd, PayPalSignature, and PayPalUser for the mode selected above Of course, you also need to be using an alias URL for your OPAC. If needed, you can set up a PayPal sandbox account at https://developer.paypal.com To test: 1. Apply the patch. 2. With the option "PayPalReturnURL" set to "OPACBaseURL", log into a card via the OPAC and start the process to pay in PayPal (you can either complete the payment or cancel from the PayPal page). When you are returned to the OPAC, the domain will be the value of OPACBaseURL. 3. With the option "PayPalReturnURL" set to "OPAC's alias", repeat the above sequence to make a payment in PayPal. When you are returned to the OPAC, the domain will be your current alias. If you get the message: "Error: there was a problem processing your payment Unable to verify payment. Please contact the library to verify your payment." there may be a problem with the Paypal credentials entered. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 03:26:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Sep 2019 01:26:28 +0000 Subject: [Koha-bugs] [Bug 22581] Include the Verovio library to show musical incipits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22581 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 03:47:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Sep 2019 01:47:02 +0000 Subject: [Koha-bugs] [Bug 22581] Include the Verovio library to show musical incipits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22581 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 14:00:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Sep 2019 12:00:38 +0000 Subject: [Koha-bugs] [Bug 23484] Holds to pull (pendingreserves.pl) uses removed default_branch_item_rules table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23484 --- Comment #5 from Nick Clemens --- (In reply to Jonathan Druart from comment #4) > I am wondering if we should not retrieve the list of itemtypes for which the > holds are allowed, then use them in the WHERE clause. > It will make the query more readable and we will remove a LEFT JOIN. What do > you think? That makes some sense, but will be two queries instead of one? In either case I think we should fix this now and re-engineer this report on another bug -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 14:07:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Sep 2019 12:07:50 +0000 Subject: [Koha-bugs] [Bug 23484] Holds to pull (pendingreserves.pl) uses removed default_branch_item_rules table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23484 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #6 from Katrin Fischer --- (In reply to Nick Clemens from comment #5) > (In reply to Jonathan Druart from comment #4) > > I am wondering if we should not retrieve the list of itemtypes for which the > > holds are allowed, then use them in the WHERE clause. > > It will make the query more readable and we will remove a LEFT JOIN. What do > > you think? > > That makes some sense, but will be two queries instead of one? In either > case I think we should fix this now and re-engineer this report on another > bug +1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 14:22:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Sep 2019 12:22:30 +0000 Subject: [Koha-bugs] [Bug 22630] Allow to change homebranch in course reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91575|0 |1 is obsolete| | Attachment #91576|0 |1 is obsolete| | Attachment #91577|0 |1 is obsolete| | Attachment #91578|0 |1 is obsolete| | --- Comment #37 from Julian Maurice --- Created attachment 92579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92579&action=edit Bug 22630: Allow to change homebranch in course reserves Test plan: 1. Create a course (disabled) 2. Add a reserve to this course for an item and set a homebranch different from the item's homebranch 3. Enable the course 4. Verify that the item's homebranch has changed 5. Disable the course 6. Verify that the item's homebranch was reset to its initial value 7. prove t/db_dependent/CourseReserves/CourseItems.t Sponsored-by: Université de Lyon 3 Signed-off-by: Liz Rea Signed-off-by: SONIA BOUIS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 14:22:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Sep 2019 12:22:41 +0000 Subject: [Koha-bugs] [Bug 22630] Allow to change homebranch in course reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 --- Comment #38 from Julian Maurice --- Created attachment 92580 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92580&action=edit Bug 22630: Fix homebranch select's value in course item edit page Sponsored-by: Université de Lyon 3 Signed-off-by: SONIA BOUIS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 14:24:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Sep 2019 12:24:10 +0000 Subject: [Koha-bugs] [Bug 22630] Allow to change homebranch in course reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #39 from Julian Maurice --- Patches rebased on master. Removed two patches because a similar fix was pushed in bug 22142 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 15:21:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Sep 2019 13:21:59 +0000 Subject: [Koha-bugs] [Bug 23073] wiki.koha-community.org needs updating to a later version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23073 --- Comment #7 from Thomas Dukleth --- I successfully changed variables and added some additional conditions to avoid NULL values as necessary from the original form of the Postgres to MySQL conversion script, http://www.winterrodeln.org/trac/browser/servermediawiki/trunk/pgsqltomysql/pgsqltomysql.py . I also added the Postgres schema for the wiki which is "mediawiki", the same as the database name in the case of the Koha Wiki, and not the "public" schema. I should now be reporting that it takes X minutes to run a script to convert the wiki database on my test system, however, there is an error similar to what was found to be SQL statement quotation or comma separation problem addressed at https://stackoverflow.com/questions/41475309/psycopg-error-column-does-not-exist and https://stackoverflow.com/questions/41804213/psycopg2-programmingerror-column-your-name-does-not-exist . I am printing the generated SQL statements to try to trace the problem. I may try using the generated SQL statements directly with suggested quotation to avoid problems where the SQL statements as stored in a variable elude what may be needed quotation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 17:14:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Sep 2019 15:14:34 +0000 Subject: [Koha-bugs] [Bug 23533] Reindent patron entry form (memberentrygen.tt) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23533 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 17:14:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Sep 2019 15:14:39 +0000 Subject: [Koha-bugs] [Bug 23533] Reindent patron entry form (memberentrygen.tt) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23533 --- Comment #1 from Owen Leonard --- Created attachment 92581 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92581&action=edit Bug 23533: Reindent patron entry form (memberentrygen.tt) This patch re-indents the template for patron entry/editing. It makes only whitespace changes. It should have no effect on the behavior of the page. To test, create or edit a patron. Test every aspect of the process. At each step the page should work correctly. Including: - Adult patron - Child patron - Organizational patron - Quick patron add - Duplicate patron - With mandatory fields - With 'BorrowerUnwantedField's defined - With ExtendedPatronAttributes enabled -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 17:14:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Sep 2019 15:14:42 +0000 Subject: [Koha-bugs] [Bug 23533] Reindent patron entry form (memberentrygen.tt) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23533 --- Comment #2 from Owen Leonard --- Created attachment 92582 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92582&action=edit Bug 23512: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the interface or functionality. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 17:42:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Sep 2019 15:42:59 +0000 Subject: [Koha-bugs] [Bug 23534] Use patron-title.inc on patron entry page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23534 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 17:43:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Sep 2019 15:43:03 +0000 Subject: [Koha-bugs] [Bug 23534] Use patron-title.inc on patron entry page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23534 --- Comment #1 from Owen Leonard --- Created attachment 92583 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92583&action=edit Bug 23534: Use patron-title.inc on patron entry page There are a few instances where we can simplify the patron entry template by using the patron-title include file instead of outputting patron name variables one by one. This patch does so in the page title, page breadcrumbs, and page heading. To test, apply the patch and edit a patron record. The page title, breadcrumbs, and main heading should all look correct. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 17:51:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Sep 2019 15:51:19 +0000 Subject: [Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92376|0 |1 is obsolete| | --- Comment #72 from Julian Maurice --- Created attachment 92584 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92584&action=edit Bug 15261: Verify if checkouts/reserves requests periods overlap... ... with existing reserves When checking out or placing hold, we should check if an existing reserve whose period overlap exists. A user place an hold from opac whose requested period overlap an existing reserve period => prevent reserve, A librarian place an hold from staff whose requested period overlap an existing reserve period => Warn librarian (Ask for confirmation), A librarian make a checkout from staff whose requested period overlap an existing reserve period => Warn librarian (Ask for confirmation). Test plan: Enable syspref: AllowHoldDateInFuture OPACAllowHoldDateInFuture PreventChechoutOnSameReservePeriod and PreventReservesOnSamePeriod 1 (staff side): Place a hold on title (which has only one items) level with start date and expiration date. Place another hold (also title level) with period overlaping this reserve. Check you are warned about an existing reserve 2 (staff side): Place a hold on title (which has more than one items) level with start date and expiration date. Place another hold (also title level) with period overlaping this reserve. Check you are NOT warned about an existing reserve. Because it remains at least one item not reserved. 3 (staff side): Place a hold on item level with start date and expiration date. Place another hold on item level with period overlaping this reserve. Check you are warned about an existing reserve. 4 (opac side): Do the same than for staff side. Instead of a warn, reserve is prevented. 5: Place a hold on title (which has only one items) level with start date and expiration date. Try to checkout the unique item from this title with period overlaping the reserve period. Check you are warned about an existing reserve 6: Place a hold on title (which has more than one items) level with start date and expiration date. Checkout an item from this title with period overlaping the reserve period. Check you are NOT warned about an existing reserve. 7: Place a hold on item level with start date and expiration date. Checkout this item period overlaping the reserve period. Check you are warned about an existing reserve Rebased on master (2016-03-11) Rebased on master (2016-06-23) Rebased on master (2017-03-23) Rebased on master (2018-03-15) Rebased on master (2019-04-18) Signed-off-by: Séverine QUEUNE Rebased-by: Alex Arnaud -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 17:51:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Sep 2019 15:51:25 +0000 Subject: [Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92377|0 |1 is obsolete| | --- Comment #73 from Julian Maurice --- Created attachment 92585 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92585&action=edit Bug 15261: Check reserves while renewing an issue Test plan: - Create an issue (i.e from 15/09/2017 to 04/10/2017), - place a reserve on the same item from 05/10/2017 to 30/10/2017), - enable PreventCheckoutOnSameReservePeriod, - Check that you are not able to renew the issue. Rebased (2018-03-15) Rebased (2019-04-18) Rebased-by: Alex Arnaud -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 17:53:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Sep 2019 15:53:05 +0000 Subject: [Koha-bugs] [Bug 23536] New: Use use a template block to output patron categories Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23536 Bug ID: 23536 Summary: Use use a template block to output patron categories Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: testopia at bugs.koha-community.org Depends on: 23533, 23534 There are three places in the patron entry template which use the same logic for displaying the patron category. These can be converted into a single re-usable block. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23533 [Bug 23533] Reindent patron entry form (memberentrygen.tt) https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23534 [Bug 23534] Use patron-title.inc on patron entry page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 17:53:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Sep 2019 15:53:05 +0000 Subject: [Koha-bugs] [Bug 23533] Reindent patron entry form (memberentrygen.tt) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23533 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23536 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23536 [Bug 23536] Use use a template block to output patron categories -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 17:53:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Sep 2019 15:53:05 +0000 Subject: [Koha-bugs] [Bug 23534] Use patron-title.inc on patron entry page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23534 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23536 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23536 [Bug 23536] Use use a template block to output patron categories -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 18:06:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Sep 2019 16:06:37 +0000 Subject: [Koha-bugs] [Bug 23537] New: Overdrive won't show complete results if the Overdrive object doesn't have a primaryCreator Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23537 Bug ID: 23537 Summary: Overdrive won't show complete results if the Overdrive object doesn't have a primaryCreator Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: wizzyrea at gmail.com QA Contact: testopia at bugs.koha-community.org Overdrive won't show complete results if the Overdrive object doesn't have a primaryCreator Some items from overdrive, such as magazines, don't have a primaryCreator in their object. When Koha gets a result like this, the overdrive search won't show any results after the first to have this condition, because it's trying to push an undefined property. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 18:22:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Sep 2019 16:22:48 +0000 Subject: [Koha-bugs] [Bug 23537] Overdrive won't show complete results if the Overdrive object doesn't have a primaryCreator In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23537 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 18:22:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Sep 2019 16:22:51 +0000 Subject: [Koha-bugs] [Bug 23537] Overdrive won't show complete results if the Overdrive object doesn't have a primaryCreator In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23537 --- Comment #1 from Liz Rea --- Created attachment 92586 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92586&action=edit Bug 23537: Overdrive won't show complete results at all times To test: On an overdrive enabled OPAC (tough sell, I know) Do a search for something you know has magazines, the collection I was looking at had "knit" as one Without this patch, the results will show "(many) items found in overdrive collection" but only show a small number of them. With the patch, the number of results should match the number shown/paginated. A site that has this fix applied, is https://tracy.bywatersolutions.com/cgi-bin/koha/opac-overdrive-search.pl?q=knit Before this patch, the number of results was 44, but there were only 8 shown. Now we see all 44 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 18:53:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Sep 2019 16:53:28 +0000 Subject: [Koha-bugs] [Bug 23538] New: Email Library when New Patrons Self Register Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538 Bug ID: 23538 Summary: Email Library when New Patrons Self Register Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: kelly at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Self Registration is a great feature in the OPAC. However, some libraries find it hard to manage these new registrations and would like to be alerted via email when a new patron self-registers. In the newest version of Koha, 19.05, this feature has been added for Purchase Suggestions, email library when new purchase suggestion is created. It would be great to have this same thing for Self Registration. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 18:58:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Sep 2019 16:58:16 +0000 Subject: [Koha-bugs] [Bug 23536] Remove obsolete category markup from patron entry In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23536 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Use use a template block to |Remove obsolete category |output patron categories |markup from patron entry Severity|enhancement |minor --- Comment #1 from Owen Leonard --- I'm repurposing this bug because further investigation shows that the repeated section of markup is in fact obsolete. I will submit a patch to remove the obsolete markup. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 19:09:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Sep 2019 17:09:49 +0000 Subject: [Koha-bugs] [Bug 23536] Remove obsolete category markup from patron entry In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23536 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 19:09:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Sep 2019 17:09:52 +0000 Subject: [Koha-bugs] [Bug 23536] Remove obsolete category markup from patron entry In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23536 --- Comment #2 from Owen Leonard --- Created attachment 92587 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92587&action=edit Bug 23536: Remove obsolete category markup from patron entry This patch removes some obsolete markup from the patron entry template (memberentrygen.tt). The old markup was necessary in a long-gone version of Koha where it was possible to add patrons using built-in categories instead of defining your own. To test, apply the patch and test the process of adding or editing patrons. You should see the patron category displayed correctly in the page title, breadcrumbs, and main heading. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 19:10:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Sep 2019 17:10:06 +0000 Subject: [Koha-bugs] [Bug 23517] Incorrect permission requirements for holds operations via the API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23517 --- Comment #4 from Tomás Cohen Arazi --- Created attachment 92588 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92588&action=edit Bug 23517: Add a spec for PUT /holds/{hold_id}/priority This patch adds the OpenAPI spec for the endpoint, and tests for the desired behaviour. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 19:10:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Sep 2019 17:10:09 +0000 Subject: [Koha-bugs] [Bug 23517] Incorrect permission requirements for holds operations via the API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23517 --- Comment #5 from Tomás Cohen Arazi --- Created attachment 92589 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92589&action=edit Bug 23517: Add the controller method for holds priorities handling This patch implements the PUT /holds/:hold_id/priority endpoint To test: - Apply this patches - Run: $ kshell k$ prove t/db_dependent/api/v1/holds.t => SUCCESS: Tests pass! - Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 19:10:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Sep 2019 17:10:13 +0000 Subject: [Koha-bugs] [Bug 23517] Incorrect permission requirements for holds operations via the API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23517 --- Comment #6 from Tomás Cohen Arazi --- Created attachment 92590 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92590&action=edit Bug 23517: (follow-up) Tidy tests Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 19:12:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Sep 2019 17:12:11 +0000 Subject: [Koha-bugs] [Bug 23517] Incorrect permission requirements for holds operations via the API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23517 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #7 from Tomás Cohen Arazi --- My implementation adds the: PUT /holds/{hold_id}/priority endpoint for setting the priority of a hold. It uses the same approach rotas endpoint does. And it checks for the very specific permissions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 19:13:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Sep 2019 17:13:20 +0000 Subject: [Koha-bugs] [Bug 23517] Add /holds/{hold_id}/priority route (PUT) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23517 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Incorrect permission |Add |requirements for holds |/holds/{hold_id}/priority |operations via the API |route (PUT) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 19:18:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Sep 2019 17:18:28 +0000 Subject: [Koha-bugs] [Bug 23517] Add /holds/{hold_id}/priority route (PUT) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23517 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |https://wiki.koha-community | |.org/wiki/Holds_priority_en | |dpoint_RFC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 19:43:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Sep 2019 17:43:59 +0000 Subject: [Koha-bugs] [Bug 23539] New: .accounttype should match authorised_values.authorised_value in size Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23539 Bug ID: 23539 Summary: .accounttype should match authorised_values.authorised_value in size Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Account type is a varchar(16), but the authorised value filling it ( MANUAL_INVOICE type ) is a varchar(80). Account type should be increased to this size to avoid truncation of authorised values. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 19:48:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Sep 2019 17:48:04 +0000 Subject: [Koha-bugs] [Bug 23539] accountlines.accounttype should match authorised_values.authorised_value in size In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23539 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|.accounttype should match |accountlines.accounttype |authorised_values.authorise |should match |d_value in size |authorised_values.authorise | |d_value in size -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 19:49:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Sep 2019 17:49:28 +0000 Subject: [Koha-bugs] [Bug 23539] accountlines.accounttype should match authorised_values.authorised_value in size In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23539 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 19:49:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Sep 2019 17:49:31 +0000 Subject: [Koha-bugs] [Bug 23539] accountlines.accounttype should match authorised_values.authorised_value in size In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23539 --- Comment #1 from Kyle M Hall --- Created attachment 92591 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92591&action=edit Bug 23539: accountlines.accounttype should match authorised_values.authorised_value in size -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 19:50:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Sep 2019 17:50:53 +0000 Subject: [Koha-bugs] [Bug 22880] Convert opacheader system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 19:50:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Sep 2019 17:50:56 +0000 Subject: [Koha-bugs] [Bug 22880] Convert opacheader system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92207|0 |1 is obsolete| | Attachment #92208|0 |1 is obsolete| | --- Comment #13 from Owen Leonard --- Created attachment 92592 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92592&action=edit Bug 22880: Convert opacheader system preference to news block This patch builds on Bug 22318 to move the opacheader system preference into the Koha news system, making it possible to have language- and library-specific content. It extends the original patch by adding an option to the template plugin specifying whether the content title should be shown (probably should be a flag in opac_news). It also adds a wrapper div with the content location as the ID (e.g. 'opacheader'). This will make it slightly more backwards-compatible with CSS customizations. To test you should have some content in the opacheader system preference. Apply the patch and run the database update process. - Go to the OPAC and confirm that the content which was previously in the opacheader system preference now displays correctly where it was before. - In the staff client, go to Tools -> News and verify that the content from opacheader is now stored in a news item with the location 'opacheader_en.' - Go to Administration -> System preferences and confirm that the opacheader preference has been removed. Signed-off-by: Hayley Mapley -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 19:50:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Sep 2019 17:50:59 +0000 Subject: [Koha-bugs] [Bug 22880] Convert opacheader system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 --- Comment #14 from Owen Leonard --- Created attachment 92593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92593&action=edit Bug 22880: Use placeholders Always. Signed-off-by: Hayley Mapley -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 19:51:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Sep 2019 17:51:03 +0000 Subject: [Koha-bugs] [Bug 22880] Convert opacheader system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 --- Comment #15 from Owen Leonard --- Created attachment 92594 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92594&action=edit Bug 22880: (follow-up) Define OpacHeader variable for conditional This follow-up uses the updates introduced by Bug 23253 as a model for improving the display of opacheader. Adding the OpacHeader variable allows the template to check for its existence and display some container markup around opacheader if it exists. This will help ease the transition for libraries who depend on the #opacheader id for styling. To test, apply the patch and test the OPAC with an 'opacheader' item defined. The content should be displayed on the page inside '
.' Delete the 'opacheader' news item and reload the OPAC page. There should no longer be an #opacheader div. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 19:51:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Sep 2019 17:51:57 +0000 Subject: [Koha-bugs] [Bug 22880] Convert opacheader system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 --- Comment #16 from Owen Leonard --- Rebased! (In reply to Hayley Mapley from comment #12) > After applying the patch, the header had slightly less left margin/left > padding. My follow-up addresses this. Thanks for testing! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 21:01:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Sep 2019 19:01:05 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Charles Farmer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85677|0 |1 is obsolete| | Attachment #85678|0 |1 is obsolete| | Attachment #85679|0 |1 is obsolete| | Attachment #85680|0 |1 is obsolete| | Attachment #85681|0 |1 is obsolete| | Attachment #85682|0 |1 is obsolete| | Attachment #85683|0 |1 is obsolete| | Attachment #85684|0 |1 is obsolete| | Attachment #85685|0 |1 is obsolete| | Attachment #85686|0 |1 is obsolete| | Attachment #85687|0 |1 is obsolete| | Attachment #85688|0 |1 is obsolete| | Attachment #85689|0 |1 is obsolete| | Attachment #85690|0 |1 is obsolete| | Attachment #85691|0 |1 is obsolete| | --- Comment #215 from Charles Farmer --- Created attachment 92595 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92595&action=edit Bug 17015: Performance comparison (images) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 21:01:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Sep 2019 19:01:39 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 --- Comment #216 from Charles Farmer --- Created attachment 92596 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92596&action=edit Bug 17015: DiscreteCalendar UI, Back-End and necessary scripts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 21:01:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Sep 2019 19:01:47 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 --- Comment #217 from Charles Farmer --- Created attachment 92597 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92597&action=edit Bug 17015: Install scripts for DiscreteCalendar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 21:01:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Sep 2019 19:01:55 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 --- Comment #218 from Charles Farmer --- Created attachment 92598 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92598&action=edit Bug 17015: Tests for DiscreteCalendar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 23:29:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Sep 2019 21:29:12 +0000 Subject: [Koha-bugs] [Bug 23537] Overdrive won't show complete results if the Overdrive object doesn't have a primaryCreator In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23537 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |wizzyrea at gmail.com CC| |wizzyrea at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 23:48:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Sep 2019 21:48:10 +0000 Subject: [Koha-bugs] [Bug 21390] Send self registration verification emails immediately In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21390 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Sep 4 23:48:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Sep 2019 21:48:14 +0000 Subject: [Koha-bugs] [Bug 21390] Send self registration verification emails immediately In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21390 --- Comment #1 from Chris Cormack --- Created attachment 92599 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92599&action=edit Bug 21390 Send registration verification emails immediately To test 1/ Enable self registration 2/ Register, notice message is queued in the table but not sent 3/ Apply patch 4/ Register again, notice message is queued, but immediately sent -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 00:16:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Sep 2019 22:16:42 +0000 Subject: [Koha-bugs] [Bug 23538] Email Library when New Patrons Self Register In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|18.11 |master Assignee|oleonard at myacpl.org |koha-bugs at lists.koha-commun | |ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 00:23:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Sep 2019 22:23:23 +0000 Subject: [Koha-bugs] [Bug 22880] Convert opacheader system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 Hayley Mapley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92592|0 |1 is obsolete| | --- Comment #17 from Hayley Mapley --- Created attachment 92600 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92600&action=edit Bug 22880: Convert opacheader system preference to news block This patch builds on Bug 22318 to move the opacheader system preference into the Koha news system, making it possible to have language- and library-specific content. It extends the original patch by adding an option to the template plugin specifying whether the content title should be shown (probably should be a flag in opac_news). It also adds a wrapper div with the content location as the ID (e.g. 'opacheader'). This will make it slightly more backwards-compatible with CSS customizations. To test you should have some content in the opacheader system preference. Apply the patch and run the database update process. - Go to the OPAC and confirm that the content which was previously in the opacheader system preference now displays correctly where it was before. - In the staff client, go to Tools -> News and verify that the content from opacheader is now stored in a news item with the location 'opacheader_en.' - Go to Administration -> System preferences and confirm that the opacheader preference has been removed. Signed-off-by: Hayley Mapley Signed-off-by: Hayley Mapley -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 00:23:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Sep 2019 22:23:48 +0000 Subject: [Koha-bugs] [Bug 22880] Convert opacheader system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 Hayley Mapley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92593|0 |1 is obsolete| | --- Comment #18 from Hayley Mapley --- Created attachment 92601 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92601&action=edit Bug 22880: Use placeholders Always. Signed-off-by: Hayley Mapley Signed-off-by: Hayley Mapley -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 00:24:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Sep 2019 22:24:16 +0000 Subject: [Koha-bugs] [Bug 22880] Convert opacheader system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 Hayley Mapley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 00:24:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Sep 2019 22:24:19 +0000 Subject: [Koha-bugs] [Bug 22880] Convert opacheader system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 Hayley Mapley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92594|0 |1 is obsolete| | --- Comment #19 from Hayley Mapley --- Created attachment 92602 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92602&action=edit Bug 22880: (follow-up) Define OpacHeader variable for conditional This follow-up uses the updates introduced by Bug 23253 as a model for improving the display of opacheader. Adding the OpacHeader variable allows the template to check for its existence and display some container markup around opacheader if it exists. This will help ease the transition for libraries who depend on the #opacheader id for styling. To test, apply the patch and test the OPAC with an 'opacheader' item defined. The content should be displayed on the page inside '
.' Delete the 'opacheader' news item and reload the OPAC page. There should no longer be an #opacheader div. Signed-off-by: Hayley Mapley -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 00:45:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Sep 2019 22:45:04 +0000 Subject: [Koha-bugs] [Bug 23467] BlockExpiredPatronOpacActions is causing screen to duplicate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23467 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |koha-bugs at lists.koha-commun | |ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 02:27:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2019 00:27:09 +0000 Subject: [Koha-bugs] [Bug 21406] Not adding author to request can cause JS errors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21406 Myka Kennedy Stephens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mkstephens at lancasterseminar | |y.edu --- Comment #1 from Myka Kennedy Stephens --- +1 Agreed. I have noticed that the table that generates in the OPAC view adds 'N/A' to the author field. Perhaps the JS for the staff client table could be amended to insert "N/A" when the author field is absent. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 06:15:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2019 04:15:47 +0000 Subject: [Koha-bugs] [Bug 16251] Material type is not correctly set for Rancor 008 widget In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16251 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 06:53:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2019 04:53:56 +0000 Subject: [Koha-bugs] [Bug 23530] Opac-basket.pl script accidentally displays 'hidden' items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23530 Bob Birchall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bob at calyx.net.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 07:59:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2019 05:59:20 +0000 Subject: [Koha-bugs] [Bug 23111] Setting a custom framework as the default for cataloguing is not possible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 09:38:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2019 07:38:07 +0000 Subject: [Koha-bugs] [Bug 23540] New: Gender 'N' is not translatable Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23540 Bug ID: 23540 Summary: Gender 'N' is not translatable Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: pasi.kallinen at koha-suomi.fi QA Contact: testopia at bugs.koha-community.org Patrons of type 'I' (institution) automatically get their sex/gender set to 'N' (which is short for "None"), but the 'N' is not translatable and actually shows up in the patron details page. Relevant code in memberentrygen.tt: [% IF ( I ) %][% END %] The template code for showing the gender text should be unified into single included file, instead of spread over multiple places like: koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt: [% IF ( patron.sex == 'F' ) %]Female[% ELSIF ( patron.sex == 'M' ) %]Male[% ELSE %][% patron.sex | html %][% END %] koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember-brief.tt: [% IF ( patron.sex ) %]
  • Gender:[% IF ( patron.sex == 'F' ) %]Female[% ELSIF ( patron.sex == 'M' ) %]Male[% ELSE %][% patron.sex | html %][% END %]
  • [% END %] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 11:11:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2019 09:11:32 +0000 Subject: [Koha-bugs] [Bug 20390] Elasticsearch - Mappings for UNIMARC (updates existing) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20390 e.betemps changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |e.betemps at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 11:12:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2019 09:12:30 +0000 Subject: [Koha-bugs] [Bug 22636] Elasticsearch admin page design enhancement In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22636 e.betemps changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |e.betemps at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 11:14:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2019 09:14:06 +0000 Subject: [Koha-bugs] [Bug 22903] Elasticsearch, dynamic display when you refine your search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22903 e.betemps changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |e.betemps at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 11:17:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2019 09:17:14 +0000 Subject: [Koha-bugs] [Bug 22524] Elasticsearch - Date range in advanced search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22524 e.betemps changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |e.betemps at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 11:18:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2019 09:18:07 +0000 Subject: [Koha-bugs] [Bug 23521] ES 6 - limit terms with many words can make the search inaccurate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23521 e.betemps changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |e.betemps at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 11:45:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2019 09:45:44 +0000 Subject: [Koha-bugs] [Bug 22630] Allow to change homebranch in course reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #40 from Koha Team Lyon 3 --- I tested it according to the plan test and everything was fine. I also tried to modify the value changed by the reserve course, to delete one item in the course and to delete a course. Everything works fine, the value of the item return to their original values. It's OK for me. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 11:47:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2019 09:47:12 +0000 Subject: [Koha-bugs] [Bug 22630] Allow to change homebranch in course reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 --- Comment #41 from sandboxes at biblibre.com --- Patch tested with a sandbox, by sonia bouis -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 11:47:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2019 09:47:38 +0000 Subject: [Koha-bugs] [Bug 22630] Allow to change homebranch in course reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92579|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 11:47:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2019 09:47:46 +0000 Subject: [Koha-bugs] [Bug 22630] Allow to change homebranch in course reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92580|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 11:48:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2019 09:48:03 +0000 Subject: [Koha-bugs] [Bug 22630] Allow to change homebranch in course reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 --- Comment #42 from sandboxes at biblibre.com --- Created attachment 92603 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92603&action=edit Bug 22630: Allow to change homebranch in course reserves Test plan: 1. Create a course (disabled) 2. Add a reserve to this course for an item and set a homebranch different from the item's homebranch 3. Enable the course 4. Verify that the item's homebranch has changed 5. Disable the course 6. Verify that the item's homebranch was reset to its initial value 7. prove t/db_dependent/CourseReserves/CourseItems.t Sponsored-by: Université de Lyon 3 Signed-off-by: Liz Rea Signed-off-by: SONIA BOUIS Signed-off-by: sonia bouis -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 11:48:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2019 09:48:06 +0000 Subject: [Koha-bugs] [Bug 22630] Allow to change homebranch in course reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 --- Comment #43 from sandboxes at biblibre.com --- Created attachment 92604 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92604&action=edit Bug 22630: Fix homebranch select's value in course item edit page Sponsored-by: Université de Lyon 3 Signed-off-by: SONIA BOUIS Signed-off-by: sonia bouis -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 12:26:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2019 10:26:10 +0000 Subject: [Koha-bugs] [Bug 23540] Gender 'N' is not translatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23540 paxed changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |pasi.kallinen at koha-suomi.fi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 14:15:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2019 12:15:50 +0000 Subject: [Koha-bugs] [Bug 23541] New: Duplicate Hold Notifications Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23541 Bug ID: 23541 Summary: Duplicate Hold Notifications Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: kelly at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org In 18.11, it was reported that library patrons from several libraries were receiving duplicate hold notifications. This is not performing consistently, and hard to reproduce. Both Firefox and Chrome browsers have performed the same way. It would appear that the hold request has been sent twice and unfortunately, it can't be determined what is causing this. The patrons that have received duplicate hold notifications don't consistently get the duplicate hold notification, it is quite random. This duplicate hold notifications are occurring in Email form and a variety of email providers are doing this. These duplicate hold notifications are happening on holds on the shelf and checked in holds, this is happening sporadically during the day. The libraries that have reported this are not using SIP devices and only one is using a RFID scanner. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 14:20:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2019 12:20:38 +0000 Subject: [Koha-bugs] [Bug 23539] accountlines.accounttype should match authorised_values.authorised_value in size In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23539 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 14:24:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2019 12:24:15 +0000 Subject: [Koha-bugs] [Bug 23539] accountlines.accounttype should match authorised_values.authorised_value in size In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23539 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 14:24:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2019 12:24:17 +0000 Subject: [Koha-bugs] [Bug 23539] accountlines.accounttype should match authorised_values.authorised_value in size In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23539 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92591|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 92605 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92605&action=edit Bug 23539: accountlines.accounttype should match authorised_values.authorised_value in size Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 14:32:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2019 12:32:14 +0000 Subject: [Koha-bugs] [Bug 23542] New: SRU import ending issue Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23542 Bug ID: 23542 Summary: SRU import ending issue Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Z39.50 / SRU / OpenSearch Servers Assignee: koha-bugs at lists.koha-community.org Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl When importing records from a SRU server, the diacritics have bad encoding. I reproduce with BNF server so it may be a UNIMARC issue. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 14:32:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2019 12:32:19 +0000 Subject: [Koha-bugs] [Bug 23542] SRU import ending issue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23542 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |fridolin.somers at biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 14:32:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2019 12:32:30 +0000 Subject: [Koha-bugs] [Bug 23542] SRU import ending issue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23542 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 14:37:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2019 12:37:57 +0000 Subject: [Koha-bugs] [Bug 23073] wiki.koha-community.org needs updating to a later version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23073 --- Comment #8 from Thomas Dukleth --- >From printing variables, I seem to have confirmed that the problem with the Postgres to MySQL conversion script is failure to use proper quotation of the data and/or SQL statement as a whole, http://www.winterrodeln.org/trac/browser/servermediawiki/trunk/pgsqltomysql/pgsqltomysql.py . It had been evident at glance that quoting had been originally considered for column names. Nothing seems to be magically quoting the data so the originator of the script presumably had some well trusted content. Consequently, I seem to need to escape any quotes within the column data; quote the data from each column; possibly avoid quoting numeric values to avoid a data type problem; and possibly quote the entire SQL statement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 14:45:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2019 12:45:35 +0000 Subject: [Koha-bugs] [Bug 21406] Not adding author to request can cause JS errors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21406 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #2 from Andrew Isherwood --- I'm not actually seeing this any more on master. There have been a lot of changes to both the ILL template and the associated JS since this bug was created, so it's highly likely it was fixed. I've looked through the commits to try and identify where it was fixed, but there are so many and some are so far reaching that I gave up. Suffice it to say, this is now fixed! I'll mark this bug "Resolved" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 14:56:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2019 12:56:33 +0000 Subject: [Koha-bugs] [Bug 23542] SRU import ending issue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23542 --- Comment #1 from Fridolin SOMERS --- Created attachment 92606 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92606&action=edit Bug 23542: fix SRU import ending issue When importing records from a SRU server, the diacritics have bad encoding. I reproduce with BNF server so it may be a UNIMARC issue. Looks like this does not affect autorities import for SRU server. In C4::Breeding::_handle_one_result(), in case of a Z39.50 server, when creating MARC::Record MarcToUTF8Record() is called which calls SetMarcUnicodeFlag(). This ensures that leader indicates UTF-8 encoding. Looking at MARC::Record->encoding() shows that encoding depends on leader even for UNIMARC. So this patch adds a call to SetMarcUnicodeFlag() in cas of a SRU server in C4::Breeding::_handle_one_result(). Test plan : 1) Use a UNIMARC database 2) Configure a connexion to a UNIMARC SRU, for example BNF, see https://doc.biblibre.com/koha/autour_de_koha/serveurs_z3950_sru#serveur_de_la_bnf 3) Go to cataloguing module 4) Click on 'New from Z39.50/SRU' 5) Choose only the SRU target 6) Search for ISBN 2266072889 7) Confirm you see good encoding : diacritic on 'a' of title 'Strate-a-gemmes' 8) Click on 'Marc preview' 9) Confirm you see good encoding 10) Click import 11) Confirm you see good encoding 12) Check SRU connexion on a MARC21 database is still OK -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 14:56:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2019 12:56:53 +0000 Subject: [Koha-bugs] [Bug 23542] SRU import ending issue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23542 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 15:03:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2019 13:03:52 +0000 Subject: [Koha-bugs] [Bug 21406] Not adding author to request can cause JS errors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21406 Myka Kennedy Stephens changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |--- Status|RESOLVED |REOPENED --- Comment #3 from Myka Kennedy Stephens --- We are on 18.11.08 with the Free Form backend and are experiencing this error. Would it be possible to still get a patch backported to 18.11.x? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 15:10:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2019 13:10:21 +0000 Subject: [Koha-bugs] [Bug 21944] Fix waiting holds at wrong location bug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at libriotech.no --- Comment #11 from Magnus Enger --- Any chance we could get this moving again? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 15:11:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2019 13:11:21 +0000 Subject: [Koha-bugs] [Bug 22478] Cross-site scripting vulnerability in paginations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22478 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 15:11:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2019 13:11:23 +0000 Subject: [Koha-bugs] [Bug 22836] Tests catching XSS vulnerabilities in pagination are not correct In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22836 Bug 22836 depends on bug 22478, which changed state. Bug 22478 Summary: Cross-site scripting vulnerability in paginations https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22478 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 15:12:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2019 13:12:12 +0000 Subject: [Koha-bugs] [Bug 23291] Allow selecting patrons by smsalertnumber in batch patron modification In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23291 --- Comment #8 from Owen Leonard --- I wonder how difficult it would be to allow the user to choose any phone number for matching? sms, primary, secondary, or other? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 15:19:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2019 13:19:44 +0000 Subject: [Koha-bugs] [Bug 19197] Lower case "or" results in broken ElasticSearch queries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19197 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80688|0 |1 is obsolete| | --- Comment #7 from Nick Clemens --- Created attachment 92607 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92607&action=edit Bug 19197: Fix multibranch limits in ElasticSearch Two issues here: 1 - OR must be capitalized 2 - The 'branch' is not analyzed and turned into 'homebranch' correctly. If we specify 'homebranch' we can later build in a 'holdingbranch' search too To test: 1 - Go to Administration -> Library Groups 2 - Create a search group for staff and opac 3 - Add two libraries 4 - Perform an advanced search, limit to the group you just created 5 - Note the number of results 6 - Switch SearchEngine syspref to 'Elasticsearch' 7 - Repeat search, note it fails 8 - Apply patch 9 - Restart all the things 10 - Repeat the search 11 - Success! Number of results should match previous search 12 - Switch SearchEngine to 'Zebra' 13 - Repeat search 14 - Success! Search works and number of results matches -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 15:30:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2019 13:30:30 +0000 Subject: [Koha-bugs] [Bug 23541] Duplicate Hold Notifications In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23541 Benjamin Daeuber changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bdaeuber at cityoffargo.com --- Comment #1 from Benjamin Daeuber --- This is creating two entries in the notification table, so this isn't an issue on the email server end, it's definitely in Koha. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 15:42:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2019 13:42:58 +0000 Subject: [Koha-bugs] [Bug 23542] SRU import ending issue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23542 --- Comment #2 from Marcel de Rooy --- Not sure if this is the right solution. Did you check if you pass new_from_xml the correct parameters in case of UNIMARC ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 15:53:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2019 13:53:08 +0000 Subject: [Koha-bugs] [Bug 21406] Not adding author to request can cause JS errors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21406 Myka Kennedy Stephens changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|REOPENED |RESOLVED --- Comment #4 from Myka Kennedy Stephens --- Nick Clemens tracked it down to bug 18589, which made it to 19.05 and won't be backported to 18.11.x. Our library is scheduled to be upgraded to 19.05 in about 2 months, so we will just wait. Thanks! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 15:56:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2019 13:56:18 +0000 Subject: [Koha-bugs] [Bug 21406] Not adding author to request can cause JS errors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21406 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |--- CC| |nick at bywatersolutions.com Status|RESOLVED |REOPENED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 15:56:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2019 13:56:38 +0000 Subject: [Koha-bugs] [Bug 21406] Not adding author to request can cause JS errors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21406 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |18.11 Severity|enhancement |normal Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 15:56:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2019 13:56:50 +0000 Subject: [Koha-bugs] [Bug 21406] Not adding author to request can cause JS errors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21406 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 15:56:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2019 13:56:55 +0000 Subject: [Koha-bugs] [Bug 21406] Not adding author to request can cause JS errors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21406 --- Comment #5 from Nick Clemens --- Created attachment 92608 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92608&action=edit Bug 21406: [18.11.x only] Prevent errors from undefined fields in requests To test: 1 - In 18.11 enable ILL and install the freeform backend 2 - Create a request for 'Journal article' 3 - Note there is no 'Author' field 4 - Try to view ILL requests 5 - You get a datatables error about missing metadata_author column 6 - Apply patch 7 - No more error -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 15:57:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2019 13:57:04 +0000 Subject: [Koha-bugs] [Bug 11677] Limit to Only items currently available for loan or reference not working In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11677 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|19.11.00 |19.11.00,19.05.04 released in| | CC| |fridolin.somers at biblibre.co | |m --- Comment #39 from Fridolin SOMERS --- Pushed to 19.05.x for 19.05.04 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 15:57:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2019 13:57:11 +0000 Subject: [Koha-bugs] [Bug 21406] Not adding author to request can cause JS errors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21406 --- Comment #6 from Andrew Isherwood --- Clearly Nick's sleuthing skills are far superior to mine, either that or he just doesn't give up so easily. Anyway, glad he was able to track it down! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 16:38:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2019 14:38:21 +0000 Subject: [Koha-bugs] [Bug 23501] Drag-and-drop hold reordering in the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23501 --- Comment #8 from Christopher Brannon --- (In reply to Katrin Fischer from comment #7) > Could we add one of these warnings when you try to leave the page without > saving? > > I like that you kept the arrows for now. I wonder if we need the arrows for > accessibility of if the priority pull down would be enough. I'm thinking that with the pull down we could eliminate either the dropdowns or the arrows, but not both. If you have a long list, drag and drop might be cumbersome. At least with the arrows, we could do away with the two arrows that bump the item up or down one position, but we should keep the arrows that bump to the top or bottom of the list. Thoughts? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 16:43:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2019 14:43:44 +0000 Subject: [Koha-bugs] [Bug 21944] Fix waiting holds at wrong location bug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944 --- Comment #12 from Christopher Brannon --- (In reply to Magnus Enger from comment #11) > Any chance we could get this moving again? I tried. My patch worked, but I couldn't figure out how to write the test. It's been a while, so correct me if I am wrong, but Nick's test may work, but his patch doesn't, when I look at the actual results. I gave up because the testing was too complicated, and I couldn't wrap my head around it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 16:44:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2019 14:44:08 +0000 Subject: [Koha-bugs] [Bug 21944] Fix waiting holds at wrong location bug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|cbrannon at cdalibrary.org |koha-bugs at lists.koha-commun | |ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 16:45:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2019 14:45:27 +0000 Subject: [Koha-bugs] [Bug 22799] Batch item modification is case sensitive In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22799 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|19.11.00 |19.11.00,19.05.04 released in| | Status|Pushed to master |Pushed to stable CC| |fridolin.somers at biblibre.co | |m --- Comment #21 from Fridolin SOMERS --- Pushed to 19.05.x for 19.05.04 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 16:52:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2019 14:52:52 +0000 Subject: [Koha-bugs] [Bug 23445] Loan period unit in circulation rules is untranslatable causing problems when editing rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23445 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Status|Pushed to master |Pushed to stable Version(s)|19.11.00 |19.11.00,19.05.04 released in| | --- Comment #11 from Fridolin SOMERS --- Pushed to 19.05.x for 19.05.04 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 16:56:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2019 14:56:59 +0000 Subject: [Koha-bugs] [Bug 23324] Need an ISBN normalization routine In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23324 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Status|Pushed to master |Pushed to stable Version(s)|19.11.00 |19.11.00,19.05.04 released in| | --- Comment #11 from Fridolin SOMERS --- Pushed to 19.05.x for 19.05.04 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 16:59:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2019 14:59:10 +0000 Subject: [Koha-bugs] [Bug 23437] When UseAuthoritiesForTracing is 'Use' we should use series authorities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23437 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |fridolin.somers at biblibre.co | |m Version(s)|19.11.00 |19.11.00,19.05.04 released in| | --- Comment #7 from Fridolin SOMERS --- Pushed to 19.05.x for 19.05.04 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 17:01:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2019 15:01:07 +0000 Subject: [Koha-bugs] [Bug 17057] Remove event attributes from holds template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17057 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED CC| |fridolin.somers at biblibre.co | |m Resolution|--- |FIXED --- Comment #11 from Fridolin SOMERS --- Enhancement not pushed to 19.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 17:01:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2019 15:01:07 +0000 Subject: [Koha-bugs] [Bug 23458] Clean up holds template in the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23458 Bug 23458 depends on bug 17057, which changed state. Bug 17057 Summary: Remove event attributes from holds template https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17057 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 17:02:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2019 15:02:04 +0000 Subject: [Koha-bugs] [Bug 23458] Clean up holds template in the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23458 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED CC| |fridolin.somers at biblibre.co | |m --- Comment #8 from Fridolin SOMERS --- Enhancement not pushed to 19.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 17:02:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2019 15:02:42 +0000 Subject: [Koha-bugs] [Bug 23448] Clean up subscription detail template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23448 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED CC| |fridolin.somers at biblibre.co | |m --- Comment #8 from Fridolin SOMERS --- Enhancement not pushed to 19.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 17:07:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2019 15:07:58 +0000 Subject: [Koha-bugs] [Bug 23281] Add Koha::Objects::Limit::Library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23281 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |fridolin.somers at biblibre.co | |m Status|Pushed to master |RESOLVED --- Comment #12 from Fridolin SOMERS --- Enhancement not pushed to 19.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 17:07:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2019 15:07:58 +0000 Subject: [Koha-bugs] [Bug 23271] Koha::Patron::Category should use Koha::Object::Limit::Library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23271 Bug 23271 depends on bug 23281, which changed state. Bug 23281 Summary: Add Koha::Objects::Limit::Library https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23281 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 17:07:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2019 15:07:58 +0000 Subject: [Koha-bugs] [Bug 23272] Koha::AuthorisedValue should use Koha::Object::Limit::Library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23272 Bug 23272 depends on bug 23281, which changed state. Bug 23281 Summary: Add Koha::Objects::Limit::Library https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23281 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 17:09:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2019 15:09:43 +0000 Subject: [Koha-bugs] [Bug 23543] New: Adding Withdrawn to the Item Search Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23543 Bug ID: 23543 Summary: Adding Withdrawn to the Item Search Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: koha-bugs at lists.koha-community.org Reporter: kelly at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Lots of libraries love the item search for its easy flexibility to retrieve results without having to write a report. In the item search, you can choose Damaged / Lost, but it would be great to see Withdrawn included to this list! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 17:13:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2019 15:13:19 +0000 Subject: [Koha-bugs] [Bug 23273] Downloading from overdues.pl doesn't use set filters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23273 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master CC| |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 17:13:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2019 15:13:54 +0000 Subject: [Koha-bugs] [Bug 23273] Downloading from overdues.pl doesn't use set filters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23273 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|19.11.00 |19.11.00,19.05.04 released in| | --- Comment #15 from Fridolin SOMERS --- Pushed to 19.05.x for 19.05.04 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 17:23:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2019 15:23:20 +0000 Subject: [Koha-bugs] [Bug 21944] Fix waiting holds at wrong location bug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 17:23:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2019 15:23:22 +0000 Subject: [Koha-bugs] [Bug 21944] Fix waiting holds at wrong location bug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84753|0 |1 is obsolete| | Attachment #84754|0 |1 is obsolete| | --- Comment #13 from Nick Clemens --- Created attachment 92609 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92609&action=edit Bug 21944: Test for Circulation.pm -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 17:23:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2019 15:23:27 +0000 Subject: [Koha-bugs] [Bug 21944] Fix waiting holds at wrong location bug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944 --- Comment #14 from Nick Clemens --- Created attachment 92610 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92610&action=edit Bug 21944: Reroute waiting hold from wrong branch To Test: 1) Place a hold on an item. 2) Check in the item to trigger the hold. Item is now listed as waiting. 3) Set branch to a different library. 4) Check in the item to trigger the hold. Notice that nothing but a local use is recorded. 5) Apply the patch. 6) Repeat steps 1-4. Notice that the hold is triggered around routed to its original pickup location. A transfer is set and the hold status is changed from waiting to correctly showing the item as in transit. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 17:23:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2019 15:23:40 +0000 Subject: [Koha-bugs] [Bug 21944] Fix waiting holds at wrong location bug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 17:24:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2019 15:24:15 +0000 Subject: [Koha-bugs] [Bug 21944] Fix waiting holds at wrong location bug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944 --- Comment #15 from Nick Clemens --- Patches rebased and retested, they work for me, can you test and explain the problem Christopher? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 17:32:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2019 15:32:41 +0000 Subject: [Koha-bugs] [Bug 23544] New: Advanced search: Allow to select more than one language for searching Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23544 Bug ID: 23544 Summary: Advanced search: Allow to select more than one language for searching Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org You can currently search by language by using the pull down in the advanced search in staff and OPAC. This only works for one language at a time. It would be nice, if more than one language could be selected and searched for. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 17:32:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2019 15:32:50 +0000 Subject: [Koha-bugs] [Bug 23544] Advanced search: Allow to select more than one language for searching In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23544 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 17:44:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2019 15:44:05 +0000 Subject: [Koha-bugs] [Bug 23546] New: Allow library to choose which language subscription pattern to search Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23546 Bug ID: 23546 Summary: Allow library to choose which language subscription pattern to search Change sponsored?: --- Product: Koha Version: 19.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Mana-kb Assignee: koha-bugs at lists.koha-community.org Reporter: kelly at bywatersolutions.com Currently, when a library is searching for a subscription pattern within Mana, it would be nice for the library to be able to limit the search for a specific language such as English so those would be the ones to display. To eliminate the languages that would not be helpful to the library importing. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 17:42:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2019 15:42:09 +0000 Subject: [Koha-bugs] [Bug 23545] New: Create Record in Serials should auto-populate record number to subscription Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23545 Bug ID: 23545 Summary: Create Record in Serials should auto-populate record number to subscription Change sponsored?: --- Product: Koha Version: 19.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com On subscription-add.pl, if one clicks "Create Record" and makes a new bib, that bib should auto-populate back to subscription-add.pl. As is, one creates the record, then has to find that record and manually add it to the subscription. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 17:49:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2019 15:49:03 +0000 Subject: [Koha-bugs] [Bug 23543] Adding Withdrawn to the Item Search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23543 kraborn at nrhtx.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kraborn at nrhtx.com --- Comment #1 from kraborn at nrhtx.com --- I agree; the item search would be even more powerful if you could also choose to ignore withdrawn items. Without this option, identifying withdrawn items can be time consuming and/or cumbersome. Thank you! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 17:56:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2019 15:56:28 +0000 Subject: [Koha-bugs] [Bug 20502] Record URL broken, when there is more than one 856 on the record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20502 --- Comment #2 from Katrin Fischer --- Still valid in 18.11 at least, possibly master as well. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 18:00:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2019 16:00:44 +0000 Subject: [Koha-bugs] [Bug 23547] New: Add column configuration to course reserves table in the OPAC Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23547 Bug ID: 23547 Summary: Add column configuration to course reserves table in the OPAC Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org It would be nice if it was easy to hide columns from the course reserves table in the OPAC (example: hide the Link column because it doesn't contain full text links reliably). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 18:05:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2019 16:05:59 +0000 Subject: [Koha-bugs] [Bug 21406] Not adding author to request can cause JS errors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21406 Myka Kennedy Stephens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #7 from Myka Kennedy Stephens --- Tested patch. Works as expected. Results of test: 1. Applied patch. 2. Created journal article request, filling in values for fields provided (no author field) 3. Viewed list of ILL Requests. No error or warning message. 4. Author field for new journal article request says "N/A" Thank you!! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 18:27:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2019 16:27:43 +0000 Subject: [Koha-bugs] [Bug 23541] Duplicate Hold Notifications In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23541 Cheryl changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |clackman at fargolibrary.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 19:44:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2019 17:44:35 +0000 Subject: [Koha-bugs] [Bug 23548] New: AQ field required in checkin response Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23548 Bug ID: 23548 Summary: AQ field required in checkin response Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: SIP2 Assignee: koha-bugs at lists.koha-community.org Reporter: stefan.berndtsson at ub.gu.se QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com When doing checkin through SIP, the AQ field is a required field in the response (code 10), however it is only provided when the item checked in is found. There should be an empty "AQ|" in the return message when the item is not found to not violate the required field status. For context, this is an actual issue with the checkin stations from PV-SUPA when you want them to accept any book, even if they're not found by Koha. It gives an error, and refuses to handle the checkin further. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 20:34:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2019 18:34:19 +0000 Subject: [Koha-bugs] [Bug 9513] Did you mean? Option to search only 4XX in authority records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9513 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 21:36:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2019 19:36:37 +0000 Subject: [Koha-bugs] [Bug 21958] _check_valid_auth_link checks too many subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21958 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 21:36:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2019 19:36:42 +0000 Subject: [Koha-bugs] [Bug 21958] _check_valid_auth_link checks too many subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21958 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91150|0 |1 is obsolete| | --- Comment #7 from Nick Clemens --- Created attachment 92611 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92611&action=edit Bug 21958: Fix bibliographic record field comparison with authority This makes the comparison between bibliographic field and authority field more robust and per subfield. This makes the comparison not consider the same e.g. the following fields: $a Test User $a Test $b User The actual issue cannot be as easily reproduced with the patches for bug 21826 applied, but here's a test plan anyway: 1. Make sure tests pass (especially t/db_dependent/AuthoritiesMarc*) 2. Make sure authority linking still works properly 3. Make sure authority and biblio frameworks allow subfield i 4. Make sure that even if you add subfield i to 700 in biblio, authority link is kept the same 5. Make sure that even if you add subfield i to the authority record, the authority link is kept the same -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 23:28:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2019 21:28:12 +0000 Subject: [Koha-bugs] [Bug 23549] New: i am unable to open home page Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23549 Bug ID: 23549 Summary: i am unable to open home page Change sponsored?: Seeking developer Product: Koha Version: 17.05 Hardware: PC OS: Windows Status: NEW Severity: critical Priority: P1 - high Component: bugs.koha-community.org Assignee: koha-bugs at lists.koha-community.org Reporter: konenianitha at gmail.com QA Contact: testopia at bugs.koha-community.org CC: konenianitha at gmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Sep 5 23:55:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2019 21:55:53 +0000 Subject: [Koha-bugs] [Bug 11677] Limit to Only items currently available for loan or reference not working In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11677 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Status|Pushed to stable |Pushed to oldstable --- Comment #40 from Lucas Gass --- backported to 18.11.x for 18.11.10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 00:07:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2019 22:07:42 +0000 Subject: [Koha-bugs] [Bug 23550] New: Not possible to add multiple patron restrictions in memberentry.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23550 Bug ID: 23550 Summary: Not possible to add multiple patron restrictions in memberentry.pl Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com When editing a patron record in memberentry.pl, you have a link to "Add manual restriction", but after you click and add, there is no link to add another. You have to save and edit again, or you can add multiple restrictions straight from circulation.pl or moremember.pl. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 00:20:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2019 22:20:45 +0000 Subject: [Koha-bugs] [Bug 11677] Limit to Only items currently available for loan or reference not working In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11677 --- Comment #41 from Christopher Brannon --- (In reply to Lucas Gass from comment #40) > backported to 18.11.x for 18.11.10 +1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 00:34:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Sep 2019 22:34:59 +0000 Subject: [Koha-bugs] [Bug 23537] Overdrive won't show complete results if the Overdrive object doesn't have a primaryCreator In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23537 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 03:05:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Sep 2019 01:05:27 +0000 Subject: [Koha-bugs] [Bug 4274] Optionally allow sending cart without requiring login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4274 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea at gmail.com --- Comment #14 from Liz Rea --- David, any chance you could push the branch you've got this code in somewhere public, so we could do the work of pulling this feature out for you? Seems a pity to have to re-engineer it. Cheers, Liz -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 04:23:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Sep 2019 02:23:51 +0000 Subject: [Koha-bugs] [Bug 23549] i am unable to open home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23549 konenianitha at gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|critical |trivial Priority|P1 - high |P5 - low -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 04:25:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Sep 2019 02:25:07 +0000 Subject: [Koha-bugs] [Bug 23549] i am unable to open home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23549 konenianitha at gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 07:42:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Sep 2019 05:42:52 +0000 Subject: [Koha-bugs] [Bug 23265] Update to DB revision 16.12.00.032 fails: Unknown column 'me.item_level_hold' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23265 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 07:42:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Sep 2019 05:42:55 +0000 Subject: [Koha-bugs] [Bug 23265] Update to DB revision 16.12.00.032 fails: Unknown column 'me.item_level_hold' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23265 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92576|0 |1 is obsolete| | --- Comment #9 from Marcel de Rooy --- Created attachment 92612 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92612&action=edit Bug 23265: (bug 12063 follow-up) Remove Koha::Holds from updatedatabase Test plan: Have a DB that fail the 16.12.00.032 update, then apply this patch and verify the expiration dates RM: Please inforce this rule, no use of Koha:: in updatedatabase! Signed-off-by: Victor Grousset Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 07:44:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Sep 2019 05:44:23 +0000 Subject: [Koha-bugs] [Bug 23265] Update to DB revision 16.12.00.032 fails: Unknown column 'me.item_level_hold' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23265 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | Patch complexity|--- |Small patch CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 07:49:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Sep 2019 05:49:41 +0000 Subject: [Koha-bugs] [Bug 23289] Label Template - Creation not working (MariaDB >= 10.2.4) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23289 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 07:49:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Sep 2019 05:49:44 +0000 Subject: [Koha-bugs] [Bug 23289] Label Template - Creation not working (MariaDB >= 10.2.4) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23289 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92528|0 |1 is obsolete| | --- Comment #9 from Marcel de Rooy --- Created attachment 92613 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92613&action=edit Bug 23289: Quote new 'rows' MariaDB reserved word Since MariaDB 10.2.4 rows is a reserved word: https://mariadb.com/kb/en/library/mariadb-1024-release-notes/ """ New reserved word: ROWS. This can no longer be used as an identifier without being quoted. """ Test plan: With MariaDB >= 10.2.4, create a new label template. Also, prove t/db_dependent/Labels/t_Template.t Without this patch you will get the following SQL error: DBD::mysql::st execute failed: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'rows, creator, template_code, page_height, Signed-off-by: Katrin Fischer Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 07:50:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Sep 2019 05:50:17 +0000 Subject: [Koha-bugs] [Bug 23289] Label Template - Creation not working (MariaDB >= 10.2.4) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23289 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 07:57:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Sep 2019 05:57:55 +0000 Subject: [Koha-bugs] [Bug 23539] accountlines.accounttype should match authorised_values.authorised_value in size In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23539 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 07:57:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Sep 2019 05:57:58 +0000 Subject: [Koha-bugs] [Bug 23539] accountlines.accounttype should match authorised_values.authorised_value in size In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23539 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92605|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy --- Created attachment 92614 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92614&action=edit Bug 23539: accountlines.accounttype should match authorised_values.authorised_value in size Signed-off-by: Owen Leonard Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 07:58:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Sep 2019 05:58:26 +0000 Subject: [Koha-bugs] [Bug 23539] accountlines.accounttype should match authorised_values.authorised_value in size In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23539 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 08:00:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Sep 2019 06:00:14 +0000 Subject: [Koha-bugs] [Bug 22602] OverDrive circulation integration is broken when user is referred to Koha from another site In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22602 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |m.de.rooy at rijksmuseum.nl --- Comment #6 from Marcel de Rooy --- From: root You might wanna fix that too ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 08:47:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Sep 2019 06:47:29 +0000 Subject: [Koha-bugs] [Bug 16111] RSS feed for OPAC search results has wrong content type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #62 from Marcel de Rooy --- QA: Looking here now -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 08:53:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Sep 2019 06:53:33 +0000 Subject: [Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 Laurence Rault changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #74 from Laurence Rault --- 1) Place a hold on title (which has only one items) level with start date and expiration date : impossible to validate the hold : Global symbol "@realbi" requires explicit package name (did you forget to declare "my @realbi"?) at /home/koha/src/reserve/placerequest.pl line 107. Execution of /home/koha/src/reserve/placerequest.pl aborted due to compilation errors. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 09:03:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Sep 2019 07:03:35 +0000 Subject: [Koha-bugs] [Bug 23551] New: problem while renew the checkout books in koha 19.05.03 Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23551 Bug ID: 23551 Summary: problem while renew the checkout books in koha 19.05.03 Change sponsored?: --- Product: Koha Version: 19.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: librarian at sageuniversity.in QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Hi All, Recently I am facing a problem while renew the checkout book in koha 19.05 . I allocated 14 days for loan period, But when i renew the book the system is not adding the loan period (current date + 14 days). system is showing current date. Is there any option to be change current system preference ?. Now the system preference is showing "RenewalPeriodBase: the current date" -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 09:11:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Sep 2019 07:11:32 +0000 Subject: [Koha-bugs] [Bug 23551] problem while renew the checkout books in koha 19.05.03 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23551 Govind Basedia changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |librarian at sageuniversity.in -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 09:43:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Sep 2019 07:43:37 +0000 Subject: [Koha-bugs] [Bug 23551] problem while renew the checkout books in koha 19.05.03 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23551 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Hi Govind, trying to help narrow this down a bit more: - Does it happen from OPAC and staff interface? - What is your renewal period set to? (loan period is only the initial) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 09:49:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Sep 2019 07:49:44 +0000 Subject: [Koha-bugs] [Bug 23551] problem while renew the checkout books in koha 19.05.03 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23551 --- Comment #2 from Govind Basedia --- (In reply to Katrin Fischer from comment #1) > Hi Govind, trying to help narrow this down a bit more: > - Does it happen from OPAC and staff interface? > - What is your renewal period set to? (loan period is only the initial) Yes 15 days -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 09:59:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Sep 2019 07:59:46 +0000 Subject: [Koha-bugs] [Bug 16111] RSS feed for OPAC search results has wrong content type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111 --- Comment #63 from Victor Grousset/tuxayo --- > refresh the page, it should do RSS things (i.e. firefox should render it as a nice looking thing, rather than raw XML.) Is that actually the case? Since version 64, there is no more a feed reader to have a nice looking thing, an extension is required. https://support.mozilla.org/en-US/kb/feed-reader-replacements-firefox Thank Owen for linking with bug 23378, Will test this one as soon as possible. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 10:05:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Sep 2019 08:05:58 +0000 Subject: [Koha-bugs] [Bug 23273] Downloading from overdues.pl doesn't use set filters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23273 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |ASSIGNED Version(s)|19.11.00,19.05.04 |19.11.00 released in| | --- Comment #16 from Fridolin SOMERS --- Sorry I went to fast on backporting this. A patch is missing in master and i found an issue. I revert for now from 19.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 10:06:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Sep 2019 08:06:16 +0000 Subject: [Koha-bugs] [Bug 23273] Downloading from overdues.pl doesn't use set filters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23273 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 10:06:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Sep 2019 08:06:34 +0000 Subject: [Koha-bugs] [Bug 23273] Downloading from overdues.pl doesn't use set filters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23273 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 10:06:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Sep 2019 08:06:46 +0000 Subject: [Koha-bugs] [Bug 23273] Downloading from overdues.pl doesn't use set filters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23273 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 10:06:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Sep 2019 08:06:49 +0000 Subject: [Koha-bugs] [Bug 23551] problem while renew the checkout books in koha 19.05.03 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23551 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 10:41:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Sep 2019 08:41:27 +0000 Subject: [Koha-bugs] [Bug 23552] New: Include ISSN in list and cart emails Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23552 Bug ID: 23552 Summary: Include ISSN in list and cart emails Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Lists Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl The cart and list emails include the ISBN, but not the ISSN. Also: the ISBN label shows, when there is no ISBN. The check in the template appears not to be working correctly. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 11:01:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Sep 2019 09:01:36 +0000 Subject: [Koha-bugs] [Bug 22970] Allow to change homebranch in batch add course reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22970 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off --- Comment #4 from Koha Team Lyon 3 --- I applied it on top of BZ 22630 on a sandbox. I tested it according to the plan test and everything was fine. I also tried to modify the value changed by the reserve course, to delete one item in the course and to delete a course. Everything works fine, the value of the item return to their original values. I'm changing the status to "signed off" but I can't modify the patch with the sandbox as there was several bugs applied. Sonia -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 11:07:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Sep 2019 09:07:54 +0000 Subject: [Koha-bugs] [Bug 23553] New: Internal server error while placing a reserve through pro interface Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23553 Bug ID: 23553 Summary: Internal server error while placing a reserve through pro interface Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: arthur.suzuki at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com When selecting a specific item in the pro interface, got "internal server error" Plack complains : Can't call method "itemnumber" on unblessed reference at /home/koha/src/reserve/placerequest.pl line 94. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 11:08:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Sep 2019 09:08:29 +0000 Subject: [Koha-bugs] [Bug 23553] Internal server error while placing a reserve through pro interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23553 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |major Assignee|koha-bugs at lists.koha-commun |arthur.suzuki at biblibre.com |ity.org | Priority|P5 - low |P2 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 11:13:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Sep 2019 09:13:20 +0000 Subject: [Koha-bugs] [Bug 23554] New: Display info from MARC21 110 and 111 in cart/list emails Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23554 Bug ID: 23554 Summary: Display info from MARC21 110 and 111 in cart/list emails Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Lists Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl The cart and list emails use GetBiblioData (gets biblio.author) and GetMarcAuthors (gets info from 700-720). This leaves out the 110 and 111 as author is usually only mapped to 100... :( -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 11:18:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Sep 2019 09:18:25 +0000 Subject: [Koha-bugs] [Bug 23553] Internal server error while placing a reserve through pro interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23553 --- Comment #1 from Arthur Suzuki --- Created attachment 92616 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92616&action=edit Bug 23553 : fix internal server error while placing reserve on item from pro interface test plan : 1 / try to place a reserve on a specific item from the pro interface 2 / get failure 3 / apply patch 4 / repeat 1 and verify you don't get failure + there is a new reserve on the selected item. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 11:19:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Sep 2019 09:19:23 +0000 Subject: [Koha-bugs] [Bug 23273] Downloading from overdues.pl doesn't use set filters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23273 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 11:19:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Sep 2019 09:19:25 +0000 Subject: [Koha-bugs] [Bug 23273] Downloading from overdues.pl doesn't use set filters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23273 --- Comment #17 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 11:20:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Sep 2019 09:20:42 +0000 Subject: [Koha-bugs] [Bug 23273] Downloading from overdues.pl doesn't use set filters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23273 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #18 from Martin Renvoize --- Followup pushed and filters corrected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 11:25:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Sep 2019 09:25:21 +0000 Subject: [Koha-bugs] [Bug 23555] New: checkouts are not getting updated when using SIP Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23555 Bug ID: 23555 Summary: checkouts are not getting updated when using SIP Change sponsored?: --- Product: Koha Version: 19.05 Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: ithelpdesk at edutech.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Created attachment 92617 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92617&action=edit issue in checkout update hi, when checkout items using SIP2, the same is not getting updated in to patron's account. it is just showing loading and not load at all. please find the attached screenshot and help me resolving this issue i have tried updating system status to 'YES" in SIP config file and also tried the below steps also but negative result. Access your Koha server with shell. - Locate the file 'checkouts' in your local Koha installation. It is in 'svc' subdirectory of the Koha home directory. - Change your working directory to the directory containing 'checkouts'. - Run this command: wget -O checkouts http://tinyurl.com/zg6ukte It retrieves a valid 'checkouts' program. Nidheesh Madhavan -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 11:30:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Sep 2019 09:30:01 +0000 Subject: [Koha-bugs] [Bug 23553] Internal server error while placing a reserve through pro interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23553 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 11:32:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Sep 2019 09:32:26 +0000 Subject: [Koha-bugs] [Bug 20254] Forbid the download of duplicate EDI messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20254 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED CC| |fridolin.somers at biblibre.co | |m --- Comment #15 from Fridolin SOMERS --- Enhancement not pushed to 19.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 11:40:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Sep 2019 09:40:14 +0000 Subject: [Koha-bugs] [Bug 23273] Downloading from overdues.pl doesn't use set filters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23273 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|19.11.00 |19.11.00,19.05.04 released in| | Status|Pushed to master |Pushed to stable --- Comment #19 from Fridolin SOMERS --- Pushed to 19.05.x for 19.05.04 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 11:41:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Sep 2019 09:41:44 +0000 Subject: [Koha-bugs] [Bug 16111] RSS feed for OPAC search results has wrong content type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111 --- Comment #64 from Marcel de Rooy --- I am seeing URLs like /cgi-bin/koha/opac-search.pl?&sort_by=relevance_dsc&format=atom OR /cgi-bin/koha/opac-search.pl?amp;idx=kw&q=perl&format=rss The extra ampersand was removed (before) by: $query_cgi =~ s/^&//; # remove unnecessary & from beginning of the query cgi But this is a side effect of the third patch. Note that I am afraid that this patch making changes to C4/Search.pm might break more things than we see now. And imo these changes are not needed for this purpose. I propose to partially revert that patch in QA. Soon submitting it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 11:44:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Sep 2019 09:44:08 +0000 Subject: [Koha-bugs] [Bug 16111] RSS feed for OPAC search results has wrong content type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111 --- Comment #65 from Marcel de Rooy --- The rss template contains things like: SEARCH_RESULT.query_cgi and SEARCH_RESULT.limit_cgi These are empty! SEARCH_RESULTS comes from: @newresults = searchResults( $search_context, $query_desc, $hits, $results_per_page, $offset, $scan, $results_hashref->{$server}->{"RECORDS"}); This sub does not return keys for query_cgi and limit_cgi. It does contain a result number: $oldbiblio->{result_number} = $i + 1; Will correct one obvious error. Remainder should be corrected elsewhere. It results in quite a few useless links. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 11:44:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Sep 2019 09:44:39 +0000 Subject: [Koha-bugs] [Bug 16111] RSS feed for OPAC search results has wrong content type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111 --- Comment #66 from Marcel de Rooy --- opac-search.pl +$format = 'rss' if $format =~ /rss/; Hmm. Maybe we should only allow rss2 now too ? Adding a follow-up. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 11:50:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Sep 2019 09:50:33 +0000 Subject: [Koha-bugs] [Bug 16111] RSS feed for OPAC search results has wrong content type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111 --- Comment #67 from Marcel de Rooy --- Should we use dc:creator or author? Koha just puts author in item:title element Specs: An item's title element holds character data that provides the item's headline. See also: For all elements defined in the RSS specification that enclose character data, the text SHOULD be interpreted as plain text with the exception of an item's description element, which MUST be suitable for presentation as HTML. All of these elements MUST NOT contain child elements. => Koha puts html inside in the title element Will not touch it here -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 11:51:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Sep 2019 09:51:28 +0000 Subject: [Koha-bugs] [Bug 23553] Internal server error while placing a reserve through staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23553 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Internal server error while |Internal server error while |placing a reserve through |placing a reserve through |pro interface |staff interface -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 6 11:52:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Sep 2019 09:52:08 +0000 Subject: [Koha-bugs] [Bug 16111] RSS feed for OPAC search results has wrong content type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111 --- Comment #68 from Marcel de Rooy --- Before each item we have: