[Koha-bugs] [Bug 21944] Fix waiting holds at wrong location bug

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Fri Sep 6 13:35:22 CEST 2019


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944

--- Comment #16 from Magnus Enger <magnus at libriotech.no> ---
The patch works as advertised for me, but I get a bunch of errors when I try to
run the tests: 

$ sudo koha-shell -c "prove t/db_dependent/Circulation.t" kohadev
t/db_dependent/Circulation.t .. 1/45 
        #   Failed test 'GetLatestAutoRenewDate should return -5 days if
no_auto_renewal_after = 5 and date_due is 10 days before'
        #   at t/db_dependent/Circulation.t line 862.
        #          got: '2019-09-01T11:32:00'
        #     expected: '2019-09-01T11:32:00'

        #   Failed test 'GetLatestAutoRenewDate should return +5 days if
no_auto_renewal_after = 15 and date_due is 10 days before'
        #   at t/db_dependent/Circulation.t line 869.
        #          got: '2019-09-11T11:32:00'
        #     expected: '2019-09-11T11:32:00'

        #   Failed test 'GetLatestAutoRenewDate should return +2 days if
no_auto_renewal_after_hard_limit is defined and not no_auto_renewal_after'
        #   at t/db_dependent/Circulation.t line 876.
        #          got: '2019-09-08T00:00:00'
        #     expected: '2019-09-08T00:00:00'

        #   Failed test 'GetLatestAutoRenewDate should return +2 days if
no_auto_renewal_after_hard_limit is < no_auto_renewal_after'
        #   at t/db_dependent/Circulation.t line 882.
        #          got: '2019-09-08T00:00:00'
        #     expected: '2019-09-08T00:00:00'
        # Looks like you failed 4 tests of 5.

    #   Failed test 'GetLatestAutoRenewDate'
    #   at t/db_dependent/Circulation.t line 887.
    # Looks like you failed 1 test of 71.
t/db_dependent/Circulation.t .. 15/45 
#   Failed test 'CanBookBeRenewed tests'
#   at t/db_dependent/Circulation.t line 998.
t/db_dependent/Circulation.t .. 18/45 
    #   Failed test 'There should not be any errors or alerts (impossible)
(error: EXPIRED) (question: ISSUED_TO_ANOTHER issued_firstname
issued_borrowernumber issued_surname issued_cardnumber)'
    #   at t/db_dependent/Circulation.t line 1326.
    #          got: '1'
    #     expected: '0'

    #   Failed test 'There should not be any errors or alerts (impossible)
(error: EXPIRED) (question: issued_surname issued_borrowernumber
issued_cardnumber issued_firstname ISSUED_TO_ANOTHER)'
    #   at t/db_dependent/Circulation.t line 1331.
    #          got: '1'
    #     expected: '0'

    #   Failed test 'There should not be any errors or alerts (impossible)
(error: EXPIRED) (question: issued_firstname ISSUED_TO_ANOTHER
issued_cardnumber issued_borrowernumber issued_surname)'
    #   at t/db_dependent/Circulation.t line 1335.
    #          got: '1'
    #     expected: '0'

    #   Failed test 'There should not be any errors or alerts (impossible)
(error: EXPIRED) (question: ISSUED_TO_ANOTHER issued_firstname
issued_borrowernumber issued_surname issued_cardnumber)'
    #   at t/db_dependent/Circulation.t line 1349.
    #          got: '1'
    #     expected: '0'

    #   Failed test 'There should not be any errors or alerts (impossible)
(error: EXPIRED) (question: issued_firstname ISSUED_TO_ANOTHER
issued_cardnumber issued_surname issued_borrowernumber)'
    #   at t/db_dependent/Circulation.t line 1363.
    #          got: '1'
    #     expected: '0'
    # Looks like you failed 5 tests of 24.
t/db_dependent/Circulation.t .. 22/45 
#   Failed test 'CanBookBeIssued & AllowReturnToBranch'
#   at t/db_dependent/Circulation.t line 1379.
t/db_dependent/Circulation.t .. 23/45 
    #   Failed test 'No key for error and alert (error: EXPIRED) (question:
USERBLOCKEDOVERDUE)'
    #   at t/db_dependent/Circulation.t line 1489.
    #          got: '1'
    #     expected: '0'
    # Looks like you failed 1 test of 8.
t/db_dependent/Circulation.t .. 24/45 
#   Failed test 'CanBookBeIssued + Koha::Patron->is_debarred|has_overdues'
#   at t/db_dependent/Circulation.t line 1508.
t/db_dependent/Circulation.t .. 25/45 
    #   Failed test 'No error or alert should be raised (error: EXPIRED)
(question: BIBLIO_ALREADY_ISSUED)'
    #   at t/db_dependent/Circulation.t line 1674.
    #          got: '1'
    #     expected: '0'

    #   Failed test 'No BIBLIO_ALREADY_ISSUED flag should be set if
AllowMultipleIssuesOnABiblio=1 (error: EXPIRED)'
    #   at t/db_dependent/Circulation.t line 1679.
    #          got: '1'
    #     expected: '0'

    #   Failed test 'No BIBLIO_ALREADY_ISSUED flag should be set if it is a
subscription (error: EXPIRED)'
    #   at t/db_dependent/Circulation.t line 1686.
    #          got: '1'
    #     expected: '0'

    #   Failed test 'No BIBLIO_ALREADY_ISSUED flag should be set if it is a
subscription (error: EXPIRED)'
    #   at t/db_dependent/Circulation.t line 1690.
    #          got: '1'
    #     expected: '0'
    # Looks like you failed 4 tests of 5.
t/db_dependent/Circulation.t .. 27/45 
#   Failed test 'CanBookBeIssued + AllowMultipleIssuesOnABiblio'
#   at t/db_dependent/Circulation.t line 1691.
t/db_dependent/Circulation.t .. 38/45 
    #   Failed test 'Item can be issued to this patron'
    #   at t/db_dependent/Circulation.t line 2980.
    #     Structures begin differing at:
    #          $got->{EXPIRED} = '1'
    #     $expected->{EXPIRED} = Does not exist
    # Looks like you failed 1 test of 2.

#   Failed test 'CanBookBeIssued | item-level_itypes=biblio'
#   at t/db_dependent/Circulation.t line 2981.

        #   Failed test 'Item can be issued to this patron'
        #   at t/db_dependent/Circulation.t line 3025.
        #     Structures begin differing at:
        #          $got->{EXPIRED} = '1'
        #     $expected->{EXPIRED} = Does not exist

        #   Failed test 'Item can not be issued, not for loan at item type
level'
        #   at t/db_dependent/Circulation.t line 3034.
        #     Structures begin differing at:
        #          $got->{EXPIRED} = '1'
        #     $expected->{EXPIRED} = Does not exist

        #   Failed test 'Item can not be issued, not for loan at item type
level'
        #   at t/db_dependent/Circulation.t line 3042.
        #     Structures begin differing at:
        #          $got->{EXPIRED} = '1'
        #     $expected->{EXPIRED} = Does not exist
        # Looks like you failed 3 tests of 6.

    #   Failed test 'item-level_itypes = 1'
    #   at t/db_dependent/Circulation.t line 3047.

        #   Failed test 'Item can be issued to this patron'
        #   at t/db_dependent/Circulation.t line 3067.
        #     Structures begin differing at:
        #          $got->{EXPIRED} = '1'
        #     $expected->{EXPIRED} = Does not exist

        #   Failed test 'Item can not be issued, not for loan at item type
level'
        #   at t/db_dependent/Circulation.t line 3076.
        #     Structures begin differing at:
        #          $got->{EXPIRED} = '1'
        #     $expected->{EXPIRED} = Does not exist

        #   Failed test 'Item can not be issued, not for loan at item type
level'
        #   at t/db_dependent/Circulation.t line 3084.
        #     Structures begin differing at:
        #          $got->{EXPIRED} = '1'
        #     $expected->{EXPIRED} = Does not exist
        # Looks like you failed 3 tests of 6.

    #   Failed test 'item-level_itypes = 0'
    #   at t/db_dependent/Circulation.t line 3089.
    # Looks like you failed 2 tests of 2.
t/db_dependent/Circulation.t .. 40/45 
#   Failed test 'CanBookBeIssued | notforloan'
#   at t/db_dependent/Circulation.t line 3092.
t/db_dependent/Circulation.t .. 45/45 # Looks like you failed 6 tests of 45.
t/db_dependent/Circulation.t .. Dubious, test returned 6 (wstat 1536, 0x600)
Failed 6/45 subtests 

Test Summary Report
-------------------
t/db_dependent/Circulation.t (Wstat: 1536 Tests: 45 Failed: 6)
  Failed tests:  15, 22, 24, 27, 39-40
  Non-zero exit status: 6
Files=1, Tests=45, 37 wallclock secs ( 0.07 usr  0.04 sys + 26.04 cusr  4.54
csys = 30.69 CPU)
Result: FAIL

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list