[Koha-bugs] [Bug 23580] Add C4::Context->yaml_preference

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23580

--- Comment #9 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Marcel de Rooy from comment #8)
> One point of attention:
> C4/Circulation.pm:    my $update_loc_rules =
> get_yaml_pref_hash('UpdateItemLocationOnCheckin');
> C4/Circulation.pm:    my $denyingrules =
> Koha::Config::SysPrefs->find('ItemsDeniedRenewal')->get_yaml_pref_hash();
> 
> This routine comes from Koha/Util/SystemPreferences.pm.
> It is parsing (probably) a small subset of YAML constructions, and is meant
> to always return a hashref. Surely, we could better use YAML to parse and
> expect both arrayrefs and hashrefs.
> 
> So, I would recommend to remove get_yaml_pref_hash now too.

Excellent point. I personally mistrust *Utils libraries in general :-D I
understand the use of course.

I agree the implementation on this bugis far more flexible, and should be
preferred.

One thing I fancied about this was: shouldn't we add a new type of syspref or
column so we can make ->preference actually return the decoded syspref if
required?

-- 
You are receiving this mail because:
You are watching all bug changes.