[Koha-bugs] [Bug 23272] Koha::AuthorisedValue should use Koha::Object::Limit::Library

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23272

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #12 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Just added a followup here to fix the failing tests.. as the commit says
however I took the quick option of adding a ternary.. perhaps a longer
discussion is in order to settle on a returns guideline for koha object
methods.  To me, if an object is expected as the return we should always return
an object (even if it's an empty/full object) rather than ever returning an
implicit 'undef'. That would prevent the need for ternaries throughout the
codebase checking the return value before chaining methods.

Thoughts.

-- 
You are receiving this mail because:
You are watching all bug changes.