[Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous payments in a POS fashion

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com,
                   |                            |tomascohen at gmail.com

--- Comment #28 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
The feature works, and the code is pretty clean. I have a few remarks to be
considered:

- We should really have a separate table and stop using MANUAL_INV. It feels
really dirty to have a note field contain a decimal value to be used as a
number. To start with. I think we agree on this, and there's even work from
Josef that would do it.
- Things look misaligned to me (hidpi laptop).
- 'Collected from patron' should reuse some patron searching things already
exist in the codebase. Thinking of the dialog to pick a guarantor.
- Currency symbol is the pound one, no matter what the system is configured to
use.
- 'Click on the item cost' maybe instead of 'Click on the item'.
- Are you planning on having an inventory of things to sell? I think the use of
authorised values is very limited, besides my criticism. I expect librarians
wanting to just scan the barcode and get the price on the screen.

-- 
You are receiving this mail because:
You are watching all bug changes.