[Koha-bugs] [Bug 22602] OverDrive circulation integration is broken when user is referred to Koha from another site

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Fri Sep 27 08:32:44 CEST 2019


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22602

--- Comment #9 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Bouzid Fergani from comment #8)
> Created attachment 92821 [details] [review]
> Bug 23272: (RM followup) Fix failing tests
> 
> This bug introduced a regression whereby if any authorized value has no
> branch limitations then the authorized value administration page would
> fail to display at all.
> 
> A simple ternary corrects the issue, but I'm now wondering about the
> logic of returning 'undef' from 'get_branch_limits'.. perhaps an empty
> (or full) resultset might be a better option to prevent us from
> requireing ternaries before calling chained methods on such objects.
> 
> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
> Signed-off-by: Bouzid Fergani <bouzid.fergani at inlibro.com>

Bouzid: buy a new keyboard ;)

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list