[Koha-bugs] [Bug 7376] Transfer limits should be checked at check-in

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376

--- Comment #71 from Lari Taskula <lari.taskula at hypernova.fi> ---
(In reply to Lari Taskula from comment #63)
> We are also trying to solve this issue. About a month ago I created some
> patches for the National Library of Finland to test within the Finnish Koha
> fork. I did not yet rebase those patches for master, but they can be found
> in this PR
> 
> https://github.com/KohaSuomi/Koha/pull/104
> 
> Sorry for causing duplicate work. I should had mentioned this as I started
> the task.

Here are my patches from GitHub, rebased on current master branch.

I didn't test team Lyon's patch, but it seems the main difference is that this
version displays a more specific error message
"Transfer is forbidden between [% Branches.GetName( holdingbranch ) %] (item's
current library) and [% LoginBranchname | html %]."

The location for logic is also different. Mine checks transfer limits in
CanBookBeReturned() while the original patch does it in AddReturn(). Not sure
if it currently makes a difference, but it could help covering some edge cases.
AddReturn of course internally uses CanBookBeReturned so I suppose this is more
appropriate place to add the logic into.

But as the original patch, this is also missing unit tests.

-- 
You are receiving this mail because:
You are watching all bug changes.