From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 00:01:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 22:01:18 +0000
Subject: [Koha-bugs] [Bug 24693] GD is declared as an optional dependency
but Koha dies without it
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24693
Joy Nelson changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |joy at bywatersolutions.com
--- Comment #10 from Joy Nelson ---
Does not apply to 19.11.x branch. Not backported
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 00:07:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 22:07:09 +0000
Subject: [Koha-bugs] [Bug 23174] Default (OPAC)ISBD contains
tags that
print in ISBD download
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23174
--- Comment #3 from Katrin Fischer ---
The
come from the default data - a lot of people don't even know they can
change that :)
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 00:11:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 22:11:23 +0000
Subject: [Koha-bugs] [Bug 25031] Improve handling of multiple covers on the
biblio detail page in the staff client
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25031
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |Needs Signoff
Patch complexity|--- |Small patch
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 00:11:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 22:11:26 +0000
Subject: [Koha-bugs] [Bug 25031] Improve handling of multiple covers on the
biblio detail page in the staff client
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25031
--- Comment #1 from Owen Leonard ---
Created attachment 102162
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102162&action=edit
Bug 25031: Improve handling of multiple covers on the biblio detail page in the
staff client
This patch modifies the template, JS, and CSS for the bibliographic
detail page in order to gracefully handle multiple cover images.
The changed version loops through any cover images which might be
embedded and checks that they are successfully loaded. Only
successfully-loaded images are shown. Only the first image is shown, and
the others can be "paged through" using generated navigation controls.
To test, apply the page and rebuild the staff client CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).
Enable multiple cover image services. The patch was developed with these
services available:
- Amazon
- Local cover images (including multiple local cover images)
- Coce (serving up Amazon, Google, and OpenLibrary images)
- Images from the CustomCoverImages preference
View a variety of titles and confirm that the cover images are
displaying correctly, whether there be 0, 1, 2, or more covers
available.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 00:11:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 22:11:27 +0000
Subject: [Koha-bugs] [Bug 24211] Compress/uncompress translation files
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24211
Joy Nelson changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |joy at bywatersolutions.com
--- Comment #13 from Joy Nelson ---
enhancement not backported to 19.11.x branch
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 00:11:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 22:11:57 +0000
Subject: [Koha-bugs] [Bug 24356] objects.search prefetch
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24356
Joy Nelson changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |joy at bywatersolutions.com
--- Comment #30 from Joy Nelson ---
Enhancement not backported to 19.11.x
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 00:12:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 22:12:35 +0000
Subject: [Koha-bugs] [Bug 24291] Explanation next to limit item types by
library is confusing
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24291
Joy Nelson changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |joy at bywatersolutions.com
--- Comment #5 from Joy Nelson ---
Enhancement not backported to 19.11.x
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 00:13:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 22:13:12 +0000
Subject: [Koha-bugs] [Bug 22880] Convert opacheader system preference to
news block
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880
Joy Nelson changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |joy at bywatersolutions.com
--- Comment #64 from Joy Nelson ---
Enhancement not backported to 19.11.x
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 00:13:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 22:13:52 +0000
Subject: [Koha-bugs] [Bug 24545] Replace Franklin Street by gnu.org/licenses
in copyright
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24545
Joy Nelson changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |joy at bywatersolutions.com
--- Comment #30 from Joy Nelson ---
Enhancement not backported to 19.11.x
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 00:16:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 22:16:43 +0000
Subject: [Koha-bugs] [Bug 23148] Replace Bridge icons with transparent PNG
files
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23148
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |Academy
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 00:18:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 22:18:41 +0000
Subject: [Koha-bugs] [Bug 23138] Elasticsearch - koha-elasticsearch rebuild
should support -d and other parameters
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23138
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|Elasticsearch - |Elasticsearch -
|koha-elasticsearch rebuidl |koha-elasticsearch rebuild
|should support -d and other |should support -d and other
|parameters |parameters
CC| |katrin.fischer at bsz-bw.de
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 00:20:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 22:20:25 +0000
Subject: [Koha-bugs] [Bug 24809] OAI PMH can fail on fetching deleted records
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24809
Joy Nelson changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to master |Pushed to stable
Version(s)|20.05.00 |20.05.00, 19.11.05
released in| |
CC| |joy at bywatersolutions.com
--- Comment #15 from Joy Nelson ---
Backported to 19.11.x branch for 19.11.05
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 00:20:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 22:20:53 +0000
Subject: [Koha-bugs] [Bug 22522] API authentication breaks with updated
Mojolicious version
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22522
Joy Nelson changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |joy at bywatersolutions.com
--- Comment #53 from Joy Nelson ---
does not apply to 19.11.x branch. please rebase if needed.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 00:24:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 22:24:48 +0000
Subject: [Koha-bugs] [Bug 24909] Add unprivileged route to get a
bibliographic record
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24909
David Nind changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 00:24:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 22:24:51 +0000
Subject: [Koha-bugs] [Bug 24909] Add unprivileged route to get a
bibliographic record
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24909
David Nind changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #101057|0 |1
is obsolete| |
--- Comment #7 from David Nind ---
Created attachment 102163
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102163&action=edit
Bug 24909: Unit tests
Signed-off-by: Tomas Cohen Arazi
Signed-off-by: David Nind
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 00:24:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 22:24:54 +0000
Subject: [Koha-bugs] [Bug 24909] Add unprivileged route to get a
bibliographic record
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24909
David Nind changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #101058|0 |1
is obsolete| |
--- Comment #8 from David Nind ---
Created attachment 102164
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102164&action=edit
Bug 24909: Route spec
Signed-off-by: Tomas Cohen Arazi
Signed-off-by: David Nind
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 00:24:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 22:24:58 +0000
Subject: [Koha-bugs] [Bug 24909] Add unprivileged route to get a
bibliographic record
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24909
David Nind changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #101059|0 |1
is obsolete| |
--- Comment #9 from David Nind ---
Created attachment 102165
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102165&action=edit
Bug 24909: Add unprivileged route to get a bibliographic record
This patch adds a route to get bibliographic records without privileged
access. This needs to match the OPAC expected behaviour.
Some things were considered on the implementation:
- The ViewPolicy filter that hides/shows things based on the frameworks
needded to be used, as in the OPAC.
- OpacHiddenItems and OpacHiddenItemsExceptions need to be considered
for hiding records the same way the OPAC is expected to.
- Avoid using OpacHiddenItemsExceptions, but rely on the patron category
instead (use Koha::Patron::Category->override_hidden_items abstraction
is used instead so it should keep working once 22547 is moved
forward).
- Tests should cover all the use cases:
* logged in user
* anonymous user
* logged in with category that overrides
* logged in with category that doesn't override
This is all implemented on the tests.
To test:
1. Apply the tests patch
2. Run:
$ kshell
k$ prove t/db_dependent/api/v1/biblios.t
=> FAIL: Route not implemented
3. Apply the rest of the patches
4. Repeat 2
=> SUCCESS: Tests pass!
5. Try it with your favourite API tool (Postman?)
6. Sign off :-D
Note: please notice there isn't a default fallback behaviour for when
you don't specify the Accept header, so testing this on a regular
browser will just print the accepted mime types instead of the record
itself.
To test this with a tool (like Postman) you should enable
RESTBasicAuthe and make the tool use Basic authentication with valid
credentials. And you need to specify any of the following strings on the
Accept header:
- application/marcxml+xml
- application/marc-in-json
- application/marc
- text/plain
Signed-off-by: David Nind
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 00:25:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 22:25:08 +0000
Subject: [Koha-bugs] [Bug 24605] Series link from 830 is not uri encoded
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24605
Joy Nelson changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to master |Pushed to stable
CC| |joy at bywatersolutions.com
Version(s)|20.05.00 |20.05.00, 19.11.05
released in| |
--- Comment #10 from Joy Nelson ---
backported to 19.11.x branch for 19.11.05
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 00:27:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 22:27:38 +0000
Subject: [Koha-bugs] [Bug 24909] Add unprivileged route to get a
bibliographic record
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24909
David Nind changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |david at davidnind.com
--- Comment #10 from David Nind ---
Note: text/plain is not an available option for Accept header.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 00:27:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 22:27:54 +0000
Subject: [Koha-bugs] [Bug 24294] Creating an order with ACQ framework using
00x fields doesn't work with default value
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24294
Joy Nelson changed:
What |Removed |Added
----------------------------------------------------------------------------
Version(s)|20.05.00 |20.05.00, 19.11.05
released in| |
Status|Pushed to master |Pushed to stable
CC| |joy at bywatersolutions.com
--- Comment #14 from Joy Nelson ---
backported to 19.11.x branch for 19.11.05
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 00:42:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 22:42:45 +0000
Subject: [Koha-bugs] [Bug 13327] OPACPopupAuthorsSearch doesn't work with
XSLT views
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327
Joy Nelson changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |joy at bywatersolutions.com
--- Comment #33 from Joy Nelson ---
enhancement not backported to 19.11.x
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 00:43:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 22:43:50 +0000
Subject: [Koha-bugs] [Bug 24746] Duplicate id in opacheader markup
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24746
Joy Nelson changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |joy at bywatersolutions.com
--- Comment #9 from Joy Nelson ---
not backported 19.11.x due to dependencies
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 00:45:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 22:45:09 +0000
Subject: [Koha-bugs] [Bug 17016] Button to clear all fields in budget
planning
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17016
Joy Nelson changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |joy at bywatersolutions.com
--- Comment #19 from Joy Nelson ---
enhancement not backported to 19.11.x
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 00:45:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 22:45:34 +0000
Subject: [Koha-bugs] [Bug 24193] Add CodeMirror linting of JavaScript, CSS,
HTML, and YAML system preferences
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24193
Joy Nelson changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |joy at bywatersolutions.com
--- Comment #11 from Joy Nelson ---
enhancement not backported to 19.11.x
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 00:46:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 22:46:13 +0000
Subject: [Koha-bugs] [Bug 15377] Allow removal of 'checked out' items from
course reserves
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15377
Joy Nelson changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |joy at bywatersolutions.com
--- Comment #14 from Joy Nelson ---
enhancement not backported to 19.11.x
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 00:46:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 22:46:48 +0000
Subject: [Koha-bugs] [Bug 21746] Remove NO_LIBRARY_SET
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21746
Joy Nelson changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |joy at bywatersolutions.com
--- Comment #15 from Joy Nelson ---
enhancement not backported to 19.11.x
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 00:47:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 22:47:17 +0000
Subject: [Koha-bugs] [Bug 24390] Add item total to rotating collections
(addItems.tt)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24390
Joy Nelson changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |joy at bywatersolutions.com
--- Comment #8 from Joy Nelson ---
enhancement not backported to 19.11.x
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 00:47:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 22:47:46 +0000
Subject: [Koha-bugs] [Bug 23547] Add column configuration to course reserves
table in the OPAC
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23547
Joy Nelson changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |joy at bywatersolutions.com
--- Comment #9 from Joy Nelson ---
enhancement not backported to 19.11.x
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 00:47:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 22:47:49 +0000
Subject: [Koha-bugs] [Bug 24909] Add unprivileged route to get a
bibliographic record
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24909
--- Comment #11 from Tomás Cohen Arazi ---
(In reply to David Nind from comment #10)
> Note: text/plain is not an available option for Accept header.
Right, I can write a follow-up for that. I wrote that for the privileged access
API before writing this one!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 00:48:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 22:48:16 +0000
Subject: [Koha-bugs] [Bug 24617] Add title notes count in staff detail
(following 24530)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24617
Joy Nelson changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |joy at bywatersolutions.com
--- Comment #9 from Joy Nelson ---
enhancement not backported to 19.11.x
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 00:48:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 22:48:41 +0000
Subject: [Koha-bugs] [Bug 24732] Make DumpTemplateVars more readable
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24732
Joy Nelson changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |joy at bywatersolutions.com
--- Comment #5 from Joy Nelson ---
enhancement no backported to 19.11.x
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 00:49:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 22:49:21 +0000
Subject: [Koha-bugs] [Bug 24757] t/db_dependent/Koha/Patrons.t get_age fails
on February 28 in a Leap Year
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24757
Joy Nelson changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |joy at bywatersolutions.com
--- Comment #13 from Joy Nelson ---
enhancement not backported to 19.11.x
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 00:55:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 22:55:37 +0000
Subject: [Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936
Agustín Moyano changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Failed QA |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 00:55:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2020 22:55:42 +0000
Subject: [Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936
--- Comment #52 from Agustín Moyano ---
Created attachment 102166
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102166&action=edit
Bug 20936: (follow-up) change opac-holdsrecord to opac-holdshistory, set
translatable strings and set rows per page to 20
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 04:51:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Apr 2020 02:51:16 +0000
Subject: [Koha-bugs] [Bug 25031] Improve handling of multiple covers on the
biblio detail page in the staff client
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25031
David Nind changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |david at davidnind.com
--- Comment #2 from David Nind ---
I have tested with Amazon and local cover images, and it seems to work okay.
I don't have access to a Coce server, so I wasn't able to test that.
I did note that if there is no image available, then there is a visible border
but with nothing inside of it.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 04:56:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Apr 2020 02:56:07 +0000
Subject: [Koha-bugs] [Bug 25032] Generic unhandled exception handling
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25032
Tomás Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |In Discussion
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 04:57:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Apr 2020 02:57:13 +0000
Subject: [Koha-bugs] [Bug 25032] Generic unhandled exception handling
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25032
Tomás Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.koha-community
| |.org/bugzilla3/show_bug.cgi
| |?id=18205
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 04:57:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Apr 2020 02:57:13 +0000
Subject: [Koha-bugs] [Bug 18205] API interface to Koha::Logger
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18205
Tomás Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.koha-community
| |.org/bugzilla3/show_bug.cgi
| |?id=25032
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 05:17:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Apr 2020 03:17:42 +0000
Subject: [Koha-bugs] [Bug 18227] Koha::Logger utf8 handling defeating "wide
characters in print"
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18227
Tomás Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on|15253 |
CC| |tomascohen at gmail.com
Blocks| |15253
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253
[Bug 15253] Add Koha::Logger based logging for SIP2
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 05:17:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Apr 2020 03:17:42 +0000
Subject: [Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253
Tomás Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks|18227 |
Depends on| |18227
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18227
[Bug 18227] Koha::Logger utf8 handling defeating "wide characters in print"
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 05:18:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Apr 2020 03:18:20 +0000
Subject: [Koha-bugs] [Bug 18227] Koha::Logger utf8 handling defeating "wide
characters in print"
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18227
Tomás Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Patch doesn't apply |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 05:18:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Apr 2020 03:18:25 +0000
Subject: [Koha-bugs] [Bug 18227] Koha::Logger utf8 handling defeating "wide
characters in print"
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18227
Tomás Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #60912|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 05:19:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Apr 2020 03:19:59 +0000
Subject: [Koha-bugs] [Bug 18227] Koha::Logger utf8 handling defeating "wide
characters in print"
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18227
--- Comment #4 from Tomás Cohen Arazi ---
Created attachment 102167
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102167&action=edit
Bug 18227: Handle utf8 in Koha::Logger
No more wide characters in print when logging to a file with Koha::Logger.
Test with this string
"♯Turpo :"
Signed-off-by: Tomas Cohen Arazi
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 05:20:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Apr 2020 03:20:05 +0000
Subject: [Koha-bugs] [Bug 18227] Koha::Logger utf8 handling defeating "wide
characters in print"
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18227
--- Comment #5 from Tomás Cohen Arazi ---
Created attachment 102168
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102168&action=edit
Bug 18227: (QA follow-up) Add fix to koha-common.postinst
Now koha-common.postinst has a way to patch log4perl configs on
instances, we should patch the Z3950 responder config accordingly,
before it is backported to 19.11 or the 20.05 release :-D
Signed-off-by: Tomas Cohen Arazi
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 05:23:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Apr 2020 03:23:09 +0000
Subject: [Koha-bugs] [Bug 18227] Koha::Logger utf8 handling defeating "wide
characters in print"
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18227
Tomás Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jonathan.druart at bugs.koha-c
| |ommunity.org,
| |martin.renvoize at ptfs-europe
| |.com
--- Comment #6 from Tomás Cohen Arazi ---
I changed the dependency the other way so this has the chance to get pushed
faster. This is important as my follow-up is patching something that hasn't hit
stable yet (koha-common.postinst) and if the 19.11 rmaint is willing to
backport bug 24905, this needs to be fixed for backporting, otherwise patching
production Koha will be really tricky.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 05:23:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Apr 2020 03:23:18 +0000
Subject: [Koha-bugs] [Bug 18227] Koha::Logger utf8 handling defeating "wide
characters in print"
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18227
Tomás Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on| |24905
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24905
[Bug 24905] log4perl-site.conf.in missing entries for the z39.50 server
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 05:23:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Apr 2020 03:23:18 +0000
Subject: [Koha-bugs] [Bug 24905] log4perl-site.conf.in missing entries for
the z39.50 server
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24905
Tomás Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |18227
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18227
[Bug 18227] Koha::Logger utf8 handling defeating "wide characters in print"
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 05:24:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Apr 2020 03:24:21 +0000
Subject: [Koha-bugs] [Bug 24905] log4perl-site.conf.in missing entries for
the z39.50 server
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24905
Tomás Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |joy at bywatersolutions.com
--- Comment #8 from Tomás Cohen Arazi ---
Joy, if you would pick this one for 19.11.x, please wait until bug 24905 can be
pushed along with this one. Together, not separate :-D
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 05:25:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Apr 2020 03:25:12 +0000
Subject: [Koha-bugs] [Bug 24905] log4perl-site.conf.in missing entries for
the z39.50 server
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24905
--- Comment #9 from Tomás Cohen Arazi ---
Joy, if you would pick this one for 19.11.x, please wait until bug 18227 can be
pushed along with this one. Together, not separate :-D
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 05:47:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Apr 2020 03:47:24 +0000
Subject: [Koha-bugs] [Bug 23172] Issuingrules not checked when returning
item and allocating to bib-level holds
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23172
Aleisha Amohia changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Failed QA |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 05:47:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Apr 2020 03:47:29 +0000
Subject: [Koha-bugs] [Bug 23172] Issuingrules not checked when returning
item and allocating to bib-level holds
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23172
--- Comment #15 from Aleisha Amohia ---
Created attachment 102169
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102169&action=edit
Bug 23172: (follow-up) Fixing test
Ensure that the following tests pass:
t/db_dependent/Hold.t
t/db_dependent/Reserves.t
And that the original test plan works as expected
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 05:53:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Apr 2020 03:53:19 +0000
Subject: [Koha-bugs] [Bug 23111] Setting a custom framework as the default
for cataloguing is not possible
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111
Aleisha Amohia changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |In Discussion
CC| |aleisha at catalyst.net.nz
--- Comment #14 from Aleisha Amohia ---
These patches still apply cleanly. Setting to In Discussion as I think that's
more appropriate. Tomás can you please answer Comment #13 when you get a
chance?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 06:04:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Apr 2020 04:04:16 +0000
Subject: [Koha-bugs] [Bug 20844] Reset a hold when it is missing after
allocation
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20844
Aleisha Amohia changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|In Discussion |ASSIGNED
--- Comment #34 from Aleisha Amohia ---
The code has moved on a bit since these patches were originally written. Will
see if I can revive.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 06:23:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Apr 2020 04:23:33 +0000
Subject: [Koha-bugs] [Bug 15400] Display patron age in useful places
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15400
--- Comment #61 from Aleisha Amohia ---
I'm getting a different error that I'm not sure how to fix
Source map error: Error: request failed with status 404
Resource URL:
http://localhost:8081/intranet-tmpl/lib/datatables/datatables.min_19.1200060.js
Source Map URL: pdfmake.min.js.map
Anyone?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 06:40:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Apr 2020 04:40:51 +0000
Subject: [Koha-bugs] [Bug 14367] History for MARC records. Roll back changes
on a timeline or per field.
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14367
--- Comment #31 from Aleisha Amohia ---
I think what we have is good for a first iteration. I'm happy to work on the
extra stuff once this is through as it is working.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 06:50:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Apr 2020 04:50:07 +0000
Subject: [Koha-bugs] [Bug 20453] Send notification when hold is cancelled by
librarian
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20453
Aleisha Amohia changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #99546|0 |1
is obsolete| |
--- Comment #4 from Aleisha Amohia ---
Created attachment 102170
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102170&action=edit
Bug 20453: Adding notice to be sent when cancelling holds
Sponsored-by: Waikato Institute of Technology
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 06:50:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Apr 2020 04:50:12 +0000
Subject: [Koha-bugs] [Bug 20453] Send notification when hold is cancelled by
librarian
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20453
Aleisha Amohia changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #99547|0 |1
is obsolete| |
--- Comment #5 from Aleisha Amohia ---
Created attachment 102171
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102171&action=edit
Bug 20453: Send notice when cancelling a hold from intranet
To test:
1) Apply patch
2) Place a reserve for Borrower A
3) Cancel the reserve from reserve/request.pl
4) Go to Borrower A's account page and look at Notices tab
5) Confirm the HOLD_MANUAL_CANCEL notice is pending
6) Place a reserve for Borrower A again
7) Go to Circulation -> Holds to pull
8) Cancel the hold
9) Repeat steps 4 and 5
10) Place a reserve for Borrower A again
11) Go to Borrower A's account page and look at the Holds table (under
Check out tab or Details tab)
12) Cancel hold using 'Cancel marked holds' button
13) Repeat steps 4 and 5
Sponsored-by: Waikato Institute of Technology
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 06:50:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Apr 2020 04:50:21 +0000
Subject: [Koha-bugs] [Bug 20453] Send notification when hold is cancelled by
librarian
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20453
Aleisha Amohia changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Patch doesn't apply |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 07:26:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Apr 2020 05:26:47 +0000
Subject: [Koha-bugs] [Bug 16892] Add automatic patron registration via
OAuth2 login
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892
--- Comment #57 from David Cook ---
(In reply to Martin Renvoize from comment #56)
> David earns the necromancer badge...
Guilty O_O.
The worst part is that I have no idea why I was digging yesterday.
Oh wait I was going through release notes for the past few major releases, and
this one totally confused me until I realised it was referring to the Google
OpenIDConnect functionality. (OAuth2 has to be one of the most misused words in
AuthZ/AuthN discussions...but that just earns me the pedant badge >_>.)
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 07:32:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Apr 2020 05:32:45 +0000
Subject: [Koha-bugs] [Bug 5158] Koha needs its own cookie, ice cream,
and fudge flavors
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5158
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |martin.renvoize at ptfs-europe
| |.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 07:34:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Apr 2020 05:34:50 +0000
Subject: [Koha-bugs] [Bug 23111] Setting a custom framework as the default
for cataloguing is not possible
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111
David Cook changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |dcook at prosentient.com.au
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 07:35:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Apr 2020 05:35:06 +0000
Subject: [Koha-bugs] [Bug 24193] Add CodeMirror linting of JavaScript, CSS,
HTML, and YAML system preferences
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24193
David Cook changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |dcook at prosentient.com.au
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 07:35:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Apr 2020 05:35:40 +0000
Subject: [Koha-bugs] [Bug 24909] Add unprivileged route to get a
bibliographic record
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24909
David Cook changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |dcook at prosentient.com.au
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 07:35:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Apr 2020 05:35:55 +0000
Subject: [Koha-bugs] [Bug 24809] OAI PMH can fail on fetching deleted records
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24809
David Cook changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |dcook at prosentient.com.au
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 07:38:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Apr 2020 05:38:58 +0000
Subject: [Koha-bugs] [Bug 5158] Koha needs its own cookie, ice cream,
and fudge flavors
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5158
--- Comment #9 from Martin Renvoize ---
My submission is the wonderfully weird and tasty Peanut butter, Chocolate chip
and Bacon cookie
https://www.google.com/amp/s/www.foodnetwork.com/recipes/food-network-kitchen/peanut-butter-chocolate-chip-bacon-cookies-recipe-1973911.amp
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 08:14:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Apr 2020 06:14:40 +0000
Subject: [Koha-bugs] [Bug 24537] Allow IP ranges in ILS-DI:AuthorizedIPs
using Net::Netmask
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24537
David Nind changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 08:14:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Apr 2020 06:14:43 +0000
Subject: [Koha-bugs] [Bug 24537] Allow IP ranges in ILS-DI:AuthorizedIPs
using Net::Netmask
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24537
David Nind changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #98105|0 |1
is obsolete| |
--- Comment #4 from David Nind ---
Created attachment 102172
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102172&action=edit
Bug 24537: Allow IP ranges in ILS-DI:AuthorizedIPs using Net::Netmask
This patch uses Net::Netmask to match IPs from ILS-DI:AuthorizedIPs
against $ENV{REMOTE_USER}. By using Net::Netmask, we can use addresses
in a variety of formats. This includes 127.0.0.1, 192.168.1.0/24,
10.0.0, and so on.
To Test:
1. Apply the patch
2. Empty the 'ILS-DI:AuthorizedIPs' system preference
3. Send a request to
'/cgi-bin/koha/ilsdi.pl?service=LookupPatron&id=1&id_type=cardnumber'
3b. Note that the request is successful
4. Set the 'ILS-DI:AuthorizedIPs' system preference to a subnet including
your IP address (e.g. 192.168.1.0/24)
5. Send a request to
'/cgi-bin/koha/ilsdi.pl?service=LookupPatron&id=1&id_type=cardnumber'
5b. Note that the request is successful
6. Set the 'ILS-DI:AuthorizedIPs' system preference to a subnet that doesn't
include
your IP address (e.g. 1.1.1)
7. Send a request to
'/cgi-bin/koha/ilsdi.pl?service=LookupPatron&id=1&id_type=cardnumber'
7b. Note that your request is refused
8. Try a variety of permutations including bad values (e.g. 192.168.1.) or
multiple values
(e.g. 10.0.0.0/8,192.168.1.0/24) or multiple values including a mix of good and
bad values
Signed-off-by: David Nind
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 08:53:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Apr 2020 06:53:52 +0000
Subject: [Koha-bugs] [Bug 24537] Allow IP ranges in ILS-DI:AuthorizedIPs
using Net::Netmask
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24537
--- Comment #5 from David Cook ---
Thanks, David! You're a legend :).
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 08:59:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Apr 2020 06:59:25 +0000
Subject: [Koha-bugs] [Bug 12469] Add more information to the ILS-DI results
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12469
David Nind changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Failed QA
--- Comment #14 from David Nind ---
Sorry Arthur, now that I'm a bit more familiar with ILS-DI I've retested and
found some issues 8-(:
1) Showing the call number works fine.
2) The branch shows, but is incorrect when the item is checked out. In the
ILS-DI results below item 21 belongs to Centerville and item 22 belongs to
Fairview, but Centerville is shown for both.
3) The tests now fail:
root at d3e7d16216fc:koha(bz12469)$ prove t/db_dependent/ILSDI_Services.t
t/db_dependent/ILSDI_Services.t .. 7/10 Use of uninitialized value $charge in
numeric gt (>) at /kohadevbox/koha/C4/Circulation.pm line 3007.
t/db_dependent/ILSDI_Services.t .. 9/10 # Looks like you planned 10 tests but
ran 11.
t/db_dependent/ILSDI_Services.t .. Dubious, test returned 255 (wstat 65280,
0xff00)
All 10 subtests passed
Test Summary Report
-------------------
t/db_dependent/ILSDI_Services.t (Wstat: 65280 Tests: 11 Failed: 1)
Failed test: 11
Non-zero exit status: 255
Parse errors: Bad plan. You planned 10 tests but ran 11.
Files=1, Tests=11, 12 wallclock secs ( 0.04 usr 0.00 sys + 8.52 cusr 1.08
csys = 9.64 CPU)
Result: FAIL
4) Adding due dates: this seems to only show the current date and time - for a
record with 2 items, I checked both out (item 21 and 22 - due date 6 April 2020
for both); with the URL
cgi-bin/koha/ilsdi.pl?service=GetAvailability&id=21+22&id_type=item I get the
ILS-DI results returned below - availability status is 'available' and
'dateavailable' is the currentt date for both.
ILS-DI Results
--------------
21
available
Centerville
947.084/1092 B
2020-04-01T06:35:10
22
available
Centerville
947.084/1092 B
2020-04-01T06:35:10
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 09:24:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Apr 2020 07:24:07 +0000
Subject: [Koha-bugs] [Bug 5158] Koha needs its own cookie, ice cream,
and fudge flavors
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5158
David Cook changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |dcook at prosentient.com.au
--- Comment #10 from David Cook ---
(In reply to Martin Renvoize from comment #9)
> My submission is the wonderfully weird and tasty Peanut butter, Chocolate
> chip and Bacon cookie
>
> https://www.google.com/amp/s/www.foodnetwork.com/recipes/food-network-
> kitchen/peanut-butter-chocolate-chip-bacon-cookies-recipe-1973911.amp
I'm not much of a baker, but that sounds fun.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 09:35:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Apr 2020 07:35:12 +0000
Subject: [Koha-bugs] [Bug 24101] Due date to on-site loans according to the
calendar and possibility to renew on-site loans
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24101
Lari Taskula changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #102091|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 09:35:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Apr 2020 07:35:25 +0000
Subject: [Koha-bugs] [Bug 24101] Due date to on-site loans according to the
calendar and possibility to renew on-site loans
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24101
Lari Taskula changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #102092|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 09:36:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Apr 2020 07:36:43 +0000
Subject: [Koha-bugs] [Bug 24101] Due date to on-site loans according to the
calendar and possibility to renew on-site loans
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24101
--- Comment #3 from Lari Taskula ---
Initially I was thinking of duplicating the rules of normal
circulation the way maxissueqty and maxonsiteissueqty is currently
done, but in the end this would lead to duplicating almost all of the
circulation rules. That would not be very convenient and it seems like
a short-sighted way of solving this problem because it leaves no room
for possible new types of checkouts in the future. Who wants to see the
circulation rule table doubling in width? Not me.
Another, more elegant approach would be to define a new circulation
rule scope "circulationtype" that defines whether a rule applies to
normal or on-site checkout (or any other type of checkout someone may
come up with in the future). Now that we are able to explicitly define
a scope that a specific circulation rule follows, this would make
sense. No need for ugly duplication and we can get rid of
maxonsiteissueqty too.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 09:39:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Apr 2020 07:39:10 +0000
Subject: [Koha-bugs] [Bug 24101] Due date to on-site loans according to the
calendar and possibility to renew on-site loans
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24101
--- Comment #4 from Lari Taskula ---
In addition to Inkeri's original comment - there needs to be a way to define
separate rules regarding fines between normal and on-site checkouts.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 09:47:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Apr 2020 07:47:13 +0000
Subject: [Koha-bugs] [Bug 23015] Create a "GetPickupLocation" endpoint for
the ILS-DI Service
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23015
David Nind changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Patch doesn't apply
--- Comment #13 from David Nind ---
1) Details for the service don't display on
http://127.0.0.1:8080/cgi-bin/koha/ilsdi.pl but can be accessed from
http://127.0.0.1:8080/cgi-bin/koha/ilsdi.pl?service=Describe&verb=GetPickupLocation
2) The result returned doesn't seem to match up with what is shown in the
describe text, for example for
http://127.0.0.1:8080/cgi-bin/koha/ilsdi.pl?service=GetPickupLocation&patron_id=19&id=23&id_type=item
I get:
Centerville
CPL
Jefferson Summit
1
1
River Station
FFL
Fairfield
1
Hickory Squere
FPL
Fairview.....
3) Test patch no longer applies:
root at 5d9aac93ee4e:koha(bz23015)$ git bz apply 23015
Bug 23015 - Create a "GetPickupLocation" endpoint for the ILS-DI Service
96815 - Bug 23015: Implements a new ILS-DI service to get available pickup
libraries for an item or record
96816 - Bug 23015: Adding tests for GetPickupLocation method
Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 23015: Implements a new ILS-DI service to get available pickup
libraries for an item or record
Using index info to reconstruct a base tree...
M C4/ILSDI/Services.pm
M koha-tmpl/opac-tmpl/bootstrap/en/modules/ilsdi.tt
M opac/ilsdi.pl
Falling back to patching base and 3-way merge...
Auto-merging opac/ilsdi.pl
Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/modules/ilsdi.tt
Auto-merging C4/ILSDI/Services.pm
Applying: Bug 23015: Adding tests for GetPickupLocation method
Using index info to reconstruct a base tree...
M t/db_dependent/ILSDI_Services.t
Falling back to patching base and 3-way merge...
Auto-merging t/db_dependent/ILSDI_Services.t
CONFLICT (content): Merge conflict in t/db_dependent/ILSDI_Services.t
error: Failed to merge in the changes.
Patch failed at 0001 Bug 23015: Adding tests for GetPickupLocation method
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 10:14:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Apr 2020 08:14:01 +0000
Subject: [Koha-bugs] [Bug 21284] ILS-DI: Allow GetPatronInfo to tell if a
loaned item is on hold by someone else.
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21284
David Nind changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |david at davidnind.com
Status|Needs Signoff |Patch doesn't apply
--- Comment #8 from David Nind ---
Unit tests patch no longer applies - the rest of the test plan works as
expected:
root at 007e9492a1aa:koha(bz21284)$ git bz apply 21284
Bug 21284 - ILS-DI: Allow GetPatronInfo to tell if a loaned item is on hold by
someone else.
78269 - Bug 21284: Unit tests
90326 - Bug 21284: ILS-DI: Allow GetPatronInfo to tell if a loaned item is on
hold by someone else.
Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 21284: Unit tests
Using index info to reconstruct a base tree...
M t/db_dependent/ILSDI_Services.t
Falling back to patching base and 3-way merge...
Auto-merging t/db_dependent/ILSDI_Services.t
CONFLICT (content): Merge conflict in t/db_dependent/ILSDI_Services.t
error: Failed to merge in the changes.
Patch failed at 0001 Bug 21284: Unit tests
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 10:14:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Apr 2020 08:14:47 +0000
Subject: [Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936
--- Comment #53 from Jonathan Druart ---
Copy/pasting a comment from bug 24980 (I sent it to the wrong bug number):
"""
Hi Jonathan,
(In reply to Jonathan Druart from comment #11)
> 0. Dates look great now! :)
>
> 1. Why not having current holds in the table (behavior intranet-side,
> members/holdshistory.pl)
Controller uses object.search, and places order by in dbic.. to replicate
current behaviour in intranet I should one object.search for both current and
old holds, merge and sort both arrays depending on search column... I decided
to wait till requests and old_requests tables were merged to have current
intranet behaviour
>
> 2. Is there a plan to make existing intranet-side view using the REST API?
> ie. only 1 code to maintain.
>
Once we can replicate current intranet behaviour, we can think on changing
intranet-side
> 3. Why only 10 results displayed by default? Usually 20
>
ok, will change that
> 4. Why no way to modify the number of results displayed? Basically, why
> DataTable does not display as other table? (like no page number, search box,
> etc.)
> Is that the OPAC style?
>
OPAC has no style for DataTables.. only intranet has. What you see in other
tables in OPAC was coded outside DataTables. I thought it best to have a search
box and page number, but I'm open to suggestions.
> 5. Not translatable strings:
> 187 if(row.cancelation_date) return 'Canceled';
> 188 if (data == 'F') return 'Fulfilled';
> 189 if (data == 'W') return 'Waiting';
> 190 if (data == 'T') return 'In Transit';
> 191 return 'Pending';
>
Good catch.. will fix that
> 6. opac-holdsrecord.pl vs members/holdshistory.pl
> Should not we use the same script names?
copied the name from opac-readingrecord, but it can be changed
Comment 14 Agustín Moyano(reporter)(assignee) 2020-03-30 17:53:20 CEST
(In reply to Jonathan Druart from comment #12)
> 7. Should not deal with that in js-date-format.inc?
> (data&&$date(data))||'';
ok, it can be done
"""
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 10:16:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Apr 2020 08:16:45 +0000
Subject: [Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936
--- Comment #54 from Jonathan Druart ---
> (In reply to Jonathan Druart from comment #11)
> > 0. Dates look great now! :)
> >
> > 1. Why not having current holds in the table (behavior intranet-side,
> > members/holdshistory.pl)
>
> Controller uses object.search, and places order by in dbic.. to replicate
> current behaviour in intranet I should one object.search for both current
> and old holds, merge and sort both arrays depending on search column... I
> decided to wait till requests and old_requests tables were merged to have
> current intranet behaviour
This is not going to happen any time soon.
> > 2. Is there a plan to make existing intranet-side view using the REST API?
> > ie. only 1 code to maintain.
> >
>
> Once we can replicate current intranet behaviour, we can think on changing
> intranet-side
So waiting for tables to be merged?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 10:20:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Apr 2020 08:20:06 +0000
Subject: [Koha-bugs] [Bug 14367] History for MARC records. Roll back changes
on a timeline or per field.
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14367
David Nind changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 10:20:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Apr 2020 08:20:13 +0000
Subject: [Koha-bugs] [Bug 14367] History for MARC records. Roll back changes
on a timeline or per field.
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14367
David Nind changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #102065|0 |1
is obsolete| |
--- Comment #32 from David Nind ---
Created attachment 102173
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102173&action=edit
Bug 14367: Add MARC record history
This is a proof-of-concept implementation for adding history
support to MARC records. Every time a change is made a complete
copy of the record is stored along with the date/time and user
identity. The changes are listed under each field in the MARC
record editor and can be reverted with a click.
The changes are stored as a JSON array in a new column named
'history' in the database. The array is re-read from the database
before updating the record to prevent old data lingering in
the session from overwriting newer changes made by other users.
If we decide to implement this feature it might be better to
simply create a new table altogether and link it rather than
the clumsy JSON solution. That would eliminate a lot of bulky
code that transforms MARC-KOHA-JSON and back while ensuring
data integrity.
Also, there are plans to add permissions to the MARC records;
this likely requires more complex interactions that will scale
badly with the current JSON solution.
At present, the history is hardcoded to 10 entries.
This can easily be made into a syspref.
The current implementation should probably be refactored
into a 'BiblioHistory' class before deploying.
Documentation of the functions/methods are also needed.
Icon is ugly and needs to be improved.
Sponsored-By: Halland County Library & Catalyst IT
Test plan:
* Run updatedatabase.pl
* Log into Staff interface, search for a title, choose to edit it's MARC
record.
* Chose a MARC field and modify it, press Save.
* Open the MARC editor again for the same title.
* Next to the edited field a new icon should appear, looking like
a clock face with a encircling arrow; the history icon.
* Clicking the icon should open a table showing all changes done
to the record, including value change, date/time and user name.
* Clicking a record in the history log should revert that field to the
clicked value (a previous value)
* Run prove t/db_dependent/BiblioHistory.t and confirm all tests pass
Signed-off-by: David Nind
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 10:20:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Apr 2020 08:20:18 +0000
Subject: [Koha-bugs] [Bug 14367] History for MARC records. Roll back changes
on a timeline or per field.
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14367
David Nind changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #102066|0 |1
is obsolete| |
--- Comment #33 from David Nind ---
Created attachment 102174
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102174&action=edit
Bug 14367: (follow-up) Fixing merge conflicts...
...and other fixes to make patch work.
Signed-off-by: David Nind
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 10:20:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Apr 2020 08:20:24 +0000
Subject: [Koha-bugs] [Bug 14367] History for MARC records. Roll back changes
on a timeline or per field.
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14367
David Nind changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #102067|0 |1
is obsolete| |
--- Comment #34 from David Nind ---
Created attachment 102175
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102175&action=edit
Bug 14367: (follow-up) Rebasing to make patch work on master
Run through test plan and confirm everything still works as expected.
Signed-off-by: David Nind
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 10:25:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Apr 2020 08:25:50 +0000
Subject: [Koha-bugs] [Bug 24980] Date formatting from JS - use timezone only
with dates with offset
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24980
--- Comment #18 from Jonathan Druart ---
How do I test the timezone handling in real life? ie. without using the
console.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 10:29:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Apr 2020 08:29:15 +0000
Subject: [Koha-bugs] [Bug 25007] AmazonCoverImages doesnt check for ISBN in
details.tt
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25007
--- Comment #15 from Jonathan Druart ---
And what about OPAC? Should not we apply the same change to opac-detail?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 10:44:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Apr 2020 08:44:26 +0000
Subject: [Koha-bugs] [Bug 25004] Search results place hold button not
enabled when checking result checkboxes on opac-search.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25004
David Nind changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 10:44:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Apr 2020 08:44:30 +0000
Subject: [Koha-bugs] [Bug 25004] Search results place hold button not
enabled when checking result checkboxes on opac-search.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25004
David Nind changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #102145|0 |1
is obsolete| |
--- Comment #4 from David Nind ---
Created attachment 102176
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102176&action=edit
Bug 25004: Search results place hold button not enabled when checking result
checkboxes on opac-search.pl
This patch makes a minor correction to the markup of the OPAC search
results page so that the event handlers attached to the checkboxes work
correctly. The broken markup broke the jQuery selector used to control
the event.
An extra was added by mistake by Bug 14715.
To test, apply the patch and test the process of selecting multiple
titles by checking the checkbox. Doing so should activate the "Place
hold" and "Tag" controls.
Signed-off-by: David Nind
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 10:45:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Apr 2020 08:45:52 +0000
Subject: [Koha-bugs] [Bug 25004] Search results place hold button not
enabled when checking result checkboxes on opac-search.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25004
David Nind changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |david at davidnind.com
--- Comment #5 from David Nind ---
Note from testing: To enable Tag control enable the TagsInputOnList system
preference.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 10:49:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Apr 2020 08:49:45 +0000
Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com
|y.org |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 10:58:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Apr 2020 08:58:58 +0000
Subject: [Koha-bugs] [Bug 25024] OPAC incorrectly marks branch as invalid
pickup location when similarly named branch is blocked
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25024
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 10:59:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Apr 2020 08:59:02 +0000
Subject: [Koha-bugs] [Bug 25024] OPAC incorrectly marks branch as invalid
pickup location when similarly named branch is blocked
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25024
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #102146|0 |1
is obsolete| |
--- Comment #5 from Jonathan Druart ---
Created attachment 102177
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102177&action=edit
Bug 25024: Make grep match full string
To test:
1 - Create or have a branch with code CPL
2 - Create two new branches 'ACPL' and 'CPLA'
3 - In branch transfer limits disallow some itype or collection from another
branch (FPL) to ACPL and CPLA
4 - Set UseBranchTransferLimits to 'Enforce'
5 - Find a biblio with one item belonging to FPL
6 - On opac, attempt to place a hold
7 - Note that ACPL and CPLA don't show in dropdown, OK
8 - Note that CPL is disabled, NOT OK
9 - Apply patch
10 - Place hold
11 - CPL is now enabled
Signed-off-by: Andrew Fuerste-Henry
Signed-off-by: Joel Sasse
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 10:59:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Apr 2020 08:59:06 +0000
Subject: [Koha-bugs] [Bug 25024] OPAC incorrectly marks branch as invalid
pickup location when similarly named branch is blocked
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25024
--- Comment #6 from Jonathan Druart ---
Created attachment 102178
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102178&action=edit
Bug 25024: Do not escape $
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 10:59:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Apr 2020 08:59:40 +0000
Subject: [Koha-bugs] [Bug 25024] OPAC incorrectly marks branch as invalid
pickup location when similarly named branch is blocked
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25024
--- Comment #7 from Jonathan Druart ---
The test plan should have contained testing OPACHoldsIfAvailableAtPickup to be
complete.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 11:02:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Apr 2020 09:02:29 +0000
Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
QA Contact|tomascohen at gmail.com |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 11:15:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Apr 2020 09:15:50 +0000
Subject: [Koha-bugs] [Bug 23173] ILL should be able to search third party
sources prior to request creation
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23173
Andrew Isherwood changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 11:15:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Apr 2020 09:15:53 +0000
Subject: [Koha-bugs] [Bug 23173] ILL should be able to search third party
sources prior to request creation
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23173
Andrew Isherwood changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #95268|0 |1
is obsolete| |
--- Comment #37 from Andrew Isherwood ---
Created attachment 102179
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102179&action=edit
Bug 23173: Add ILLCheckAvailability syspref
This patch adds the new syspref "ILLCheckAvailability"
Sponsored-by: Public Health England
Signed-off-by: Niamh Walker-Headon
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 11:15:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Apr 2020 09:15:57 +0000
Subject: [Koha-bugs] [Bug 23173] ILL should be able to search third party
sources prior to request creation
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23173
Andrew Isherwood changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #95269|0 |1
is obsolete| |
--- Comment #38 from Andrew Isherwood ---
Created attachment 102180
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102180&action=edit
Bug 23173: Provide core infrastructure
This patch adds the required infrastructure to enable ILL availability
plugins to intercept the request creation process and, using the
supplied metadata, search for and display possible relevant items from
whichever availability plugins are installed.
Currently three availability plugins exist:
z39.50 - Searches any number of the Koha instance's configured Z targets
https://github.com/PTFS-Europe/koha-plugin-ill-avail-z3950
EDS - Searches the EBSCO Discovery Service
https://github.com/PTFS-Europe/koha-plugin-ill-avail-eds
Unpaywall - Searches the Unpaywall API for possible open access versions
of the requested item
https://github.com/PTFS-Europe/koha-plugin-ill-avail-unpaywall
The Unpaywall plugin is intended to serve as a "reference" plugin as the
API it deals with is extremely simple
Signed-off-by: Niamh Walker-Headon
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 11:16:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Apr 2020 09:16:00 +0000
Subject: [Koha-bugs] [Bug 23173] ILL should be able to search third party
sources prior to request creation
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23173
Andrew Isherwood changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #95270|0 |1
is obsolete| |
--- Comment #39 from Andrew Isherwood ---
Created attachment 102181
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102181&action=edit
Bug 23173: Add unit tests
Test Koha::Illrequests::Availability
Signed-off-by: Niamh Walker-Headon
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 11:16:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Apr 2020 09:16:04 +0000
Subject: [Koha-bugs] [Bug 23173] ILL should be able to search third party
sources prior to request creation
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23173
Andrew Isherwood changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #98521|0 |1
is obsolete| |
--- Comment #40 from Andrew Isherwood ---
Created attachment 102182
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102182&action=edit
Bug 23173: (follow-up) Allow for wide characters
The conversion of the metadata into Base64 for passing in the API call
to the plugin API routes was failing if the metadata contained a wide
character, so we now encode it into UTF-8 first
Signed-off-by: Niamh Walker-Headon
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 11:16:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Apr 2020 09:16:07 +0000
Subject: [Koha-bugs] [Bug 23173] ILL should be able to search third party
sources prior to request creation
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23173
Andrew Isherwood changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #100725|0 |1
is obsolete| |
--- Comment #41 from Andrew Isherwood ---
Created attachment 102183
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102183&action=edit
Bug 23173: (follow-up) Allow for customisable display name
We now allow for the service to return a name that can be specified in
the plugin config. This patch switches to using that, rather than just
the plugin name defined in the plugin's metadata hashref
Signed-off-by: Niamh Walker-Headon
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 11:16:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Apr 2020 09:16:11 +0000
Subject: [Koha-bugs] [Bug 23173] ILL should be able to search third party
sources prior to request creation
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23173
Andrew Isherwood changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #100740|0 |1
is obsolete| |
--- Comment #42 from Andrew Isherwood ---
Created attachment 102184
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102184&action=edit
Bug 23173: (follow-up) Display available partners
When selecting partners for search during the "Place request with
partner libraries" workflow, there was no indication of which partners
could actually be searched (i.e. are attached to a Z target and enabled
for partner search). We now list them
Signed-off-by: Niamh Walker-Headon
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 11:18:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Apr 2020 09:18:10 +0000
Subject: [Koha-bugs] [Bug 24163] Ability to define a CSV profile for late
orders export
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24163
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #98691|0 |1
is obsolete| |
Attachment #98692|0 |1
is obsolete| |
--- Comment #7 from Jonathan Druart ---
Created attachment 102185
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102185&action=edit
Bug 24163: Allow to define CSV profile for late orders export
This new enhancement adds the ability to create a CSV profile for the late
orders export.
Prior to this, the CSV profile was hardcoded in a template and not
editable (unless you modify the .tt file of course).
The main difficulty of the request was to make the multiple claims dates
accessible from the CSV profile. So far we only accept columns from the
database. However we would like to use the Koha::Acquisition::Order
object to make things easier (it had a ->claims method to access the
different claims).
To acchieve this, we are going to accept the TT syntax for that CSV profile.
It means that only CSV profiles created for 'late_orders' will have the
capability to use the TT syntax (can be extended later of course if
needed).
The alternative was to use specific placeholders, like %claims_count%,
%claimed_date%, but it sounded more powerful and flexible to allow the
TT syntax instead.
Note that the former export (template based) still exists and is the
default option.
Test plan:
0. Apply the patches and execute the update database entry
1. Create some orders, close the basket
2. Claim some of the orders
3. Note the new button at the bottom of the table that have several
entries.
=> The first entry will generate a CSV file using the previous method
=> The second entry will generate it using the new CSV profile, note
that the number of claims as well as the different claims date are
displayed.
4. Bonus point: Edit the CSV profile (Home › Tools › CSV export
profiles) that is named "Late orders (csv profile)", or create a new
one, and modify it.
Export the late orders using this CSV profile and confirm that the
generated CSV file is the one you expect.
Sponsored-by: Institute of Technology Tralee
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 11:18:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Apr 2020 09:18:15 +0000
Subject: [Koha-bugs] [Bug 24163] Ability to define a CSV profile for late
orders export
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24163
--- Comment #8 from Jonathan Druart ---
Created attachment 102186
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102186&action=edit
Bug 24163: Add the csv into the DB - as an example
Sponsored-by: Institute of Technology Tralee
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 11:21:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Apr 2020 09:21:27 +0000
Subject: [Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461
David Nind changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Patch doesn't apply
CC| |david at davidnind.com
--- Comment #114 from David Nind ---
Patch no longer applies 8-(:
root at 9512ab8ec1bb:koha(bz4461)$ git bz apply 4461
Bug 4461 - Context-sensitive report a problem screen
100506 - Bug 4461: Database and syspref changes
100507 - Bug 4461: Problem Report Koha objects
100508 - Bug 4461: Submit a problem report
100509 - Bug 4461: (follow-up) Redirect to 404 if OPACProblemReport not enabled
100510 - Bug 4461: (follow-up) Creating sample notice and other fixes
100511 - Bug 4461: Rename report date with created_on
100512 - Bug 4461: Use KohaAdminEmailAddress pref as 'from'
100513 - Bug 4461: Use our local_referer instead of HTTP_REFERER
100514 - Bug 4461: Redirect to 404 if KohaAdminEmailAddress is not defined
100515 - Bug 4461: Simplify recipients code
100516 - Bug 4461: Better error handling
100517 - Bug 4461: Remove hard requirement on OpacKohaUrl
100518 - Bug 4461: Drop 'from_address' use 'reply_address'
100519 - Bug 4461: Use get_effective_email from bug 22823
100520 - Bug 4461: Adding user flags for managing OPAC problem reports
100521 - Bug 4461: Add problem reports link to mainpage and admin home
100522 - Bug 4461: Manage problem reports on the staff client
100523 - Bug 4461: (follow-up) Add missing relationship accessor
100524 - Bug 4461: DBIC Schema Files
100619 - Bug 4461: Update license statements
100989 - Bug 4461: Fix status and borrowernumber fields in problem_reports and
more
100990 - Bug 4461: Checks on library email before enqueuing letter
Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 4461: Database and syspref changes
error: sha1 information is lacking or useless
(installer/data/mysql/kohastructure.sql).
error: could not build fake ancestor
Patch failed at 0001 Bug 4461: Database and syspref changes
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 11:27:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Apr 2020 09:27:46 +0000
Subject: [Koha-bugs] [Bug 24159] Short loan collection issues on a day
marked as closed (move useDaysMode to circ rules)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |martin.renvoize at ptfs-europe
| |.com
--- Comment #29 from Martin Renvoize ---
(In reply to Jonathan Druart from comment #28)
> Thanks for reporting that Simon, that seems a sandbox-related bug. I will
> ask Martin.
PTFS-E Sandboxes updated to use a newer MariaDB version with the auto-increment
fix.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 11:29:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Apr 2020 09:29:09 +0000
Subject: [Koha-bugs] [Bug 24740] use biblio title if available rather than
biblio number in OPAC search result cover images tooltips
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24740
ByWater Sandboxes changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #102096|0 |1
is obsolete| |
--- Comment #8 from ByWater Sandboxes ---
Created attachment 102187
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102187&action=edit
Bug 24740: Use biblio title rather than biblio number in OPAC search result
cover images tooltips
In OPAC biblionum doesn't mean much to patrons, use biblio title field if not
empty.
Test plan:
OPAC search
1) Apply the patch
2) For each cover images providers available to tester in:
/cgi-bin/koha/admin/preferences.pl?tab=&op=search&searchfield=Cover
OPACLocalCoverImages, AdlibrisEnabled, OPACAmazonCoverImages, GoogleJackets,
Coce provider.
3) Enable the provider.
4) Search a Library Catalog for a book with a cover image.
6) test mouse over cover image display biblio title.
OPAC Shelves
1) Enable OPAC virtualshelves preference
2) Create a list.
3) For each covers providers available.
4) Search the List
5) test mouse over cover image display biblio title.
Signed-off-by: Stina Hallin
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 11:30:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Apr 2020 09:30:13 +0000
Subject: [Koha-bugs] [Bug 24161] Late orders improvements - keeping track of
claims
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161
--- Comment #28 from Martin Renvoize ---
Updated PTFS-E sandboxes to support email.. emails will not be delivered
externally but will go into a log file which can be accessed via the 'Logs'
menu in the sandbox UI
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 11:32:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Apr 2020 09:32:14 +0000
Subject: [Koha-bugs] [Bug 24740] use biblio title if available rather than
biblio number in OPAC search result cover images tooltips
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24740
Stina Hallin changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |stina.hallin at ub.lu.se
Status|Needs Signoff |Signed Off
--- Comment #9 from Stina Hallin ---
Worked fine with books. Didn't get either title or biblionumber for e-books and
films.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 11:48:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Apr 2020 09:48:19 +0000
Subject: [Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Patch doesn't apply |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 11:48:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Apr 2020 09:48:24 +0000
Subject: [Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #100506|0 |1
is obsolete| |
Attachment #100507|0 |1
is obsolete| |
Attachment #100508|0 |1
is obsolete| |
Attachment #100509|0 |1
is obsolete| |
Attachment #100510|0 |1
is obsolete| |
Attachment #100511|0 |1
is obsolete| |
Attachment #100512|0 |1
is obsolete| |
Attachment #100513|0 |1
is obsolete| |
Attachment #100514|0 |1
is obsolete| |
Attachment #100515|0 |1
is obsolete| |
Attachment #100516|0 |1
is obsolete| |
Attachment #100517|0 |1
is obsolete| |
Attachment #100518|0 |1
is obsolete| |
Attachment #100519|0 |1
is obsolete| |
Attachment #100520|0 |1
is obsolete| |
Attachment #100521|0 |1
is obsolete| |
Attachment #100522|0 |1
is obsolete| |
Attachment #100523|0 |1
is obsolete| |
Attachment #100524|0 |1
is obsolete| |
Attachment #100619|0 |1
is obsolete| |
Attachment #100989|0 |1
is obsolete| |
Attachment #100990|0 |1
is obsolete| |
--- Comment #115 from Jonathan Druart ---
Created attachment 102188
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102188&action=edit
Bug 4461: Database and syspref changes
adding problem_reports table and OPACReportProblem syspref
Signed-off-by: David Nind
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 11:48:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Apr 2020 09:48:30 +0000
Subject: [Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461
--- Comment #116 from Jonathan Druart ---
Created attachment 102189
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102189&action=edit
Bug 4461: Problem Report Koha objects
Signed-off-by: David Nind
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 11:48:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Apr 2020 09:48:36 +0000
Subject: [Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461
--- Comment #117 from Jonathan Druart ---
Created attachment 102190
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102190&action=edit
Bug 4461: Submit a problem report
To test:
1) Apply patch, update database, rebuild schema file
2) Restart koha-common and memcached
3) Confirm that your user has an email address.
4) Confirm that your library does NOT have an email address.
5) Confirm that syspref KohaAdminEmailAddress and syspref ReplytoDefault are
not filled. Enable the OPACReportProblem syspref.
6) Log into OPAC
7) Click the 'Report a problem' link at the bottom of whatever page
you're on
8) Notice that there is no form is and there is an error message alerting that
reports cannot be submitted
9) Add an email address for your library (in either the email field or the
replyto field). Refresh the OPAC problem report page. The form should now show,
and the recipient field should say 'library'.
10) Complete the form and submit. Check the message_queue in the database and
confirm the to_address is correct. Confirm there is a success message.
11) Add an email address for the syspref KohaAdminEmailAddress and refresh the
OPAC problem report page again. The recipient field should now be a dropdown.
Select the Koha Administrator option.
12) Complete the form and submit. Check the message_queue in the database and
confirm the to_address is the value in KohaAdminEmailAddress. Confirm there is
a success message.
13) Ensure all details in the message_queue are correct.
14) Log out of the OPAC
15) Click the Report a problem link again and confirm you are forced to log in
Sponsored-by: Catalyst IT
Signed-off-by: David Nind
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 11:48:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Apr 2020 09:48:41 +0000
Subject: [Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461
--- Comment #118 from Jonathan Druart ---
Created attachment 102191
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102191&action=edit
Bug 4461: (follow-up) Redirect to 404 if OPACProblemReport not enabled
Signed-off-by: David Nind
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 11:48:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Apr 2020 09:48:47 +0000
Subject: [Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461
--- Comment #119 from Jonathan Druart ---
Created attachment 102192
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102192&action=edit
Bug 4461: (follow-up) Creating sample notice and other fixes
- filters
- capitalisation
- atomic update
Signed-off-by: David Nind
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 11:48:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Apr 2020 09:48:52 +0000
Subject: [Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461
--- Comment #120 from Jonathan Druart ---
Created attachment 102193
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102193&action=edit
Bug 4461: Rename report date with created_on
And make it a timestamp type column
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 11:48:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Apr 2020 09:48:58 +0000
Subject: [Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461
--- Comment #121 from Jonathan Druart ---
Created attachment 102194
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102194&action=edit
Bug 4461: Use KohaAdminEmailAddress pref as 'from'
We usually do not specify the from_address on enqueuing the notice, but
when sending it (from _send_message_by_email). That way a) the code is
centralized (as we must use $patron->notice_email_address) and b) the
email used is the one that is in the DB when the letter is effectively
sent.
Here I guess you need to give it when the notice is enqueued as you want
to default to the koha admin address.
I do not think it's a good idea, we should not send an email with "from"
if not really sent by the user.
We have the borrowernumber anyway to know who filled the form.
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 11:49:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Apr 2020 09:49:03 +0000
Subject: [Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461
--- Comment #122 from Jonathan Druart ---
Created attachment 102195
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102195&action=edit
Bug 4461: Use our local_referer instead of HTTP_REFERER
Cannot remember why exactly, but it seems that we should not use
HTTP_REFERER directly.
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 11:49:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Apr 2020 09:49:07 +0000
Subject: [Koha-bugs] [Bug 17703] Always add ISSN in serials claims issues
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17703
David Nind changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 11:49:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Apr 2020 09:49:08 +0000
Subject: [Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461
--- Comment #123 from Jonathan Druart ---
Created attachment 102196
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102196&action=edit
Bug 4461: Redirect to 404 if KohaAdminEmailAddress is not defined
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 11:49:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Apr 2020 09:49:11 +0000
Subject: [Koha-bugs] [Bug 17703] Always add ISSN in serials claims issues
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17703
David Nind changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #102000|0 |1
is obsolete| |
--- Comment #15 from David Nind ---
Created attachment 102197
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102197&action=edit
Bug 17703: Add unit tests
Run : prove t/db_dependent/Serials/Claims.t
Signed-off-by: David Nind
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 11:49:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Apr 2020 09:49:14 +0000
Subject: [Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461
--- Comment #124 from Jonathan Druart ---
Created attachment 102198
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102198&action=edit
Bug 4461: Simplify recipients code
As the feature is now turned off without KohaAdminEmailAddress, we only
need to check if the email address of the library if defined.
Not that we should not check for $library->branchreplyto or
ReplytoDefault, but only $library->branchemail, as we do everywhere else
(I think)
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 11:49:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Apr 2020 09:49:15 +0000
Subject: [Koha-bugs] [Bug 17703] Always add ISSN in serials claims issues
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17703
David Nind changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #102001|0 |1
is obsolete| |
--- Comment #16 from David Nind ---
Created attachment 102199
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102199&action=edit
Bug 17703: Always add ISSN in serials claims issues
Bug 11861 added ISSN column in serials claims table and a SQL query in
C4::Serials::GetLateOrMissingIssues().
But this SQL query is in a if $supplierid condition, the same change must be
done if $serialid to allow ISSN in CVS export of claims.
This patch rewrites the method to have a common SQL query with conditions only
on WHERE.
Removes the order input arg since it is never used, order in TT is managed by
DataTable and CSV export is generated with the order of selected rows.
Test plan:
- Make sure you have a subscription with some late or missing issues
- Go to Tool > CSV profils
- Create a profile :
Profile name = Issues to claim
Profile type = SQL
Usage = Late serial issues claims
Profile SQL fields =
SUPPLIER=aqbooksellers.name|TITLE=subscription.title|ISSN=subscription.issn|ISSUE
NUMBER=serial.serialseq|LATE SINCE=serial.planneddate
- Go to serials claims page : /cgi-bin/koha/serials/claims.pl
- Choose a vendor and click OK
- You see serials to claim, with ISSN column filled with subscription's ISSN
- Check all lines
- Select "Issues to claim" CSV profile
- Click on "Download selected claims"
=> With patch you have ISSN value
Signed-off-by: Katrin Fischer
Signed-off-by: David Nind
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 11:49:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Apr 2020 09:49:19 +0000
Subject: [Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461
--- Comment #125 from Jonathan Druart ---
Created attachment 102200
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102200&action=edit
Bug 4461: Better error handling
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 11:49:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Apr 2020 09:49:25 +0000
Subject: [Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461
--- Comment #126 from Jonathan Druart ---
Created attachment 102201
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102201&action=edit
Bug 4461: Remove hard requirement on OpacKohaUrl
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 11:49:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Apr 2020 09:49:31 +0000
Subject: [Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461
--- Comment #127 from Jonathan Druart ---
Created attachment 102202
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102202&action=edit
Bug 4461: Drop 'from_address' use 'reply_address'
This patch adds support for using the reply-to field added in bug 10269
and drops 'from_address' as it will get defined at a later stage in the
emailing process anyway.
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 11:49:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Apr 2020 09:49:36 +0000
Subject: [Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461
--- Comment #128 from Jonathan Druart ---
Created attachment 102203
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102203&action=edit
Bug 4461: Use get_effective_email from bug 22823
Use the get_effective_email from Koha::Library to get an appropriate
inbound address for the branch as aposed to using branchemail directly.
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 11:49:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Apr 2020 09:49:41 +0000
Subject: [Koha-bugs] [Bug 24980] Date formatting from JS - use timezone only
with dates with offset
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24980
--- Comment #19 from Martin Renvoize ---
I initially liked that final patch.. but do we believe it's correct consistency
wise given that dt_from_string (which we're using in KohaDates which with
function is emulating) will return 'now' when passed 'undef'. ?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 11:49:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Apr 2020 09:49:42 +0000
Subject: [Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461
--- Comment #129 from Jonathan Druart ---
Created attachment 102204
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102204&action=edit
Bug 4461: Adding user flags for managing OPAC problem reports
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 11:49:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Apr 2020 09:49:47 +0000
Subject: [Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461
--- Comment #130 from Jonathan Druart ---
Created attachment 102205
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102205&action=edit
Bug 4461: Add problem reports link to mainpage and admin home
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 11:49:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Apr 2020 09:49:52 +0000
Subject: [Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461
--- Comment #131 from Jonathan Druart ---
Created attachment 102206
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102206&action=edit
Bug 4461: Manage problem reports on the staff client
Test plan:
- Update database and upgrade schema files (if you haven't already).
Restart memcached
- Check your user's permissions and ensure the 'problem_reports'
permission is ticked. Confirm the OPACReportProblem syspref is enabled
- Log into the OPAC and submit a problem report
- Log into the staff client
- You should see a box at the bottom of the main page showing your
pending problem report
- Click the link and confirm it takes you to the new page for managing
problem reports
- Go to Administration
- Confirm you can see a link to 'OPAC problem reports' under the
'Additional parameters' heading
- Click 'OPAC problem reports'
- Confirm your problem report is showing in the table
- Open the OPAC in another tab and submit at least two more problem
reports (so you should have at least three in the table after
refreshing)
- Try the different buttons
- selecting multiple problem reports and using the big 'mark
viewed', 'mark closed', 'mark new' buttons. Confirm there are no
failures and that the number of selected problem reports is correct
- select all, clear all, hide viewed, hide closed, hide new, show
all
- individual 'mark viewed', 'mark closed', 'mark new' buttons for
each problem report. Confirm the status shows and the correct button
is disabled while others are enabled
- Confirm the problem page link works as expected
Sponsored-by: Catalyst IT
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 11:49:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Apr 2020 09:49:57 +0000
Subject: [Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461
--- Comment #132 from Jonathan Druart ---
Created attachment 102207
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102207&action=edit
Bug 4461: (follow-up) Add missing relationship accessor
I think this was a simple case of Aliesha missing a file when commiting.
So I could proceed with testing I just quickly re-implimented the patron
relationship accessor.
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 11:50:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Apr 2020 09:50:03 +0000
Subject: [Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461
--- Comment #133 from Jonathan Druart ---
Created attachment 102208
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102208&action=edit
Bug 4461: Update license statements
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 11:50:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Apr 2020 09:50:08 +0000
Subject: [Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461
--- Comment #134 from Jonathan Druart ---
Created attachment 102209
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102209&action=edit
Bug 4461: Checks on library email before enqueuing letter
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 11:50:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Apr 2020 09:50:13 +0000
Subject: [Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461
--- Comment #135 from Jonathan Druart ---
Created attachment 102210
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102210&action=edit
Bug 4461: DBIC Schema Files
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 11:50:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Apr 2020 09:50:19 +0000
Subject: [Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461
--- Comment #136 from Jonathan Druart ---
Created attachment 102211
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102211&action=edit
Bug 4461: Fix status and borrowernumber fields in problem_reports and more
status varchar(6) with readable statuses
borrowernumber not null default 0
hide form if message successfully sent
fixing hide viewed and hide closed filters
adding recipient column
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 12:01:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Apr 2020 10:01:53 +0000
Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
QA Contact| |jonathan.druart at bugs.koha-c
| |ommunity.org
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 12:15:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Apr 2020 10:15:12 +0000
Subject: [Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461
David Nind changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Failed QA
--- Comment #137 from David Nind ---
I'm now getting this error message when trying to submit the form, no matter
what I do:
[#% We really should avoid reaching this! %] Something wrong happened when
sending the report. Please contact your library.
Note: I'm following the test plan in Comment 117
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 12:16:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Apr 2020 10:16:14 +0000
Subject: [Koha-bugs] [Bug 25004] Search results place hold button not
enabled when checking result checkboxes on opac-search.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25004
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 12:16:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Apr 2020 10:16:17 +0000
Subject: [Koha-bugs] [Bug 25004] Search results place hold button not
enabled when checking result checkboxes on opac-search.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25004
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #102176|0 |1
is obsolete| |
--- Comment #6 from Nick Clemens ---
Created attachment 102212
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102212&action=edit
Bug 25004: Search results place hold button not enabled when checking result
checkboxes on opac-search.pl
This patch makes a minor correction to the markup of the OPAC search
results page so that the event handlers attached to the checkboxes work
correctly. The broken markup broke the jQuery selector used to control
the event.
An extra was added by mistake by Bug 14715.
To test, apply the patch and test the process of selecting multiple
titles by checking the checkbox. Doing so should activate the "Place
hold" and "Tag" controls.
Signed-off-by: David Nind
Signed-off-by: Nick Clemens
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 12:26:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Apr 2020 10:26:14 +0000
Subject: [Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461
--- Comment #138 from Jonathan Druart ---
(In reply to David Nind from comment #137)
> I'm now getting this error message when trying to submit the form, no matter
> what I do:
>
> [#% We really should avoid reaching this! %] Something wrong happened when
> sending the report. Please contact your library.
>
> Note: I'm following the test plan in Comment 117
Do you see something relevant in the Koha log file?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 12:28:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Apr 2020 10:28:33 +0000
Subject: [Koha-bugs] [Bug 24537] Allow IP ranges in ILS-DI:AuthorizedIPs
using Net::Netmask
In-Reply-To: