[Koha-bugs] [Bug 12469] Add more information to the ILS-DI results

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12469

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #14 from David Nind <david at davidnind.com> ---
Sorry Arthur, now that I'm a bit more familiar with ILS-DI I've retested and
found some issues 8-(:

1) Showing the call number works fine.

2) The branch shows, but is incorrect when the item is checked out. In the
ILS-DI results below item 21 belongs to Centerville and item 22 belongs to
Fairview, but Centerville is shown for both.

3) The tests now fail:

root at d3e7d16216fc:koha(bz12469)$ prove t/db_dependent/ILSDI_Services.t
t/db_dependent/ILSDI_Services.t .. 7/10 Use of uninitialized value $charge in
numeric gt (>) at /kohadevbox/koha/C4/Circulation.pm line 3007.
t/db_dependent/ILSDI_Services.t .. 9/10 # Looks like you planned 10 tests but
ran 11.
t/db_dependent/ILSDI_Services.t .. Dubious, test returned 255 (wstat 65280,
0xff00)
All 10 subtests passed 

Test Summary Report
-------------------
t/db_dependent/ILSDI_Services.t (Wstat: 65280 Tests: 11 Failed: 1)
  Failed test:  11
  Non-zero exit status: 255
  Parse errors: Bad plan.  You planned 10 tests but ran 11.
Files=1, Tests=11, 12 wallclock secs ( 0.04 usr  0.00 sys +  8.52 cusr  1.08
csys =  9.64 CPU)
Result: FAIL

4) Adding due dates: this seems to only show the current date and time - for a
record with 2 items, I checked both out (item 21 and 22 - due date 6 April 2020
for both); with the URL
cgi-bin/koha/ilsdi.pl?service=GetAvailability&id=21+22&id_type=item I get the
ILS-DI results returned below - availability status is 'available' and
'dateavailable' is the currentt date for both.

ILS-DI Results
--------------

<dlf:collection xmlns:dlf="http://diglib.org/ilsdi/1.1"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://diglib.org/ilsdi/1.1
http://diglib.org/architectures/ilsdi/schemas/1.1/dlfexpanded.xsd">
<dlf:record>
 <dlf:bibliographic id="7"/>
  <dlf:items>
   <dlf:item id="21">
   <dlf:simpleavailability>
    <dlf:identifier>21</dlf:identifier>
    <dlf:availabilitystatus>available</dlf:availabilitystatus>
    <dlf:location>Centerville</dlf:location>
    <dlf:callnumber>947.084/1092 B</dlf:callnumber>
    <dlf:dateavailable>2020-04-01T06:35:10</dlf:dateavailable>
   </dlf:simpleavailability>
  </dlf:item>
  </dlf:items>
</dlf:record>
<dlf:record>
 <dlf:bibliographic id="7"/>
  <dlf:items>
  <dlf:item id="22">
  <dlf:simpleavailability>
   <dlf:identifier>22</dlf:identifier>
   <dlf:availabilitystatus>available</dlf:availabilitystatus>
   <dlf:location>Centerville</dlf:location>
   <dlf:callnumber>947.084/1092 B</dlf:callnumber>
   <dlf:dateavailable>2020-04-01T06:35:10</dlf:dateavailable>
  </dlf:simpleavailability>
  </dlf:item>
 </dlf:items>
</dlf:record>
</dlf:collection>

-- 
You are receiving this mail because:
You are watching all bug changes.