[Koha-bugs] [Bug 23015] Create a "GetPickupLocation" endpoint for the ILS-DI Service

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23015

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply

--- Comment #13 from David Nind <david at davidnind.com> ---
1) Details for the service don't display on
http://127.0.0.1:8080/cgi-bin/koha/ilsdi.pl but can be accessed from
http://127.0.0.1:8080/cgi-bin/koha/ilsdi.pl?service=Describe&verb=GetPickupLocation

2) The result returned doesn't seem to match up with what is shown in the
describe text, for example for
http://127.0.0.1:8080/cgi-bin/koha/ilsdi.pl?service=GetPickupLocation&patron_id=19&id=23&id_type=item
I get: 

<GetPickupLocation>
<library>
<anon>
<branchname>Centerville</branchname>
<branchcode>CPL</branchcode>
<branchaddress1>Jefferson Summit</branchaddress1>
<pickup_location>1</pickup_location>
</anon>
<anon>
<pickup_location>1</pickup_location>
<branchaddress1>River Station</branchaddress1>
<branchcode>FFL</branchcode>
<branchname>Fairfield</branchname>
</anon>
<anon>
<pickup_location>1</pickup_location>
<branchaddress1>Hickory Squere</branchaddress1>
<branchcode>FPL</branchcode>
<branchname>Fairview</branchname>.....

3) Test patch no longer applies:

root at 5d9aac93ee4e:koha(bz23015)$ git bz apply 23015
Bug 23015 - Create a "GetPickupLocation" endpoint for the ILS-DI Service

96815 - Bug 23015: Implements a new ILS-DI service to get available pickup
libraries for an item or record
96816 - Bug 23015: Adding tests for GetPickupLocation method

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 23015: Implements a new ILS-DI service to get available pickup
libraries for an item or record
Using index info to reconstruct a base tree...
M       C4/ILSDI/Services.pm
M       koha-tmpl/opac-tmpl/bootstrap/en/modules/ilsdi.tt
M       opac/ilsdi.pl
Falling back to patching base and 3-way merge...
Auto-merging opac/ilsdi.pl
Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/modules/ilsdi.tt
Auto-merging C4/ILSDI/Services.pm
Applying: Bug 23015: Adding tests for GetPickupLocation method
Using index info to reconstruct a base tree...
M       t/db_dependent/ILSDI_Services.t
Falling back to patching base and 3-way merge...
Auto-merging t/db_dependent/ILSDI_Services.t
CONFLICT (content): Merge conflict in t/db_dependent/ILSDI_Services.t
error: Failed to merge in the changes.
Patch failed at 0001 Bug 23015: Adding tests for GetPickupLocation method

-- 
You are receiving this mail because:
You are watching all bug changes.