[Koha-bugs] [Bug 20936] Holds History for patrons in OPAC

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #57 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Some more QA comments:

1. Enabled by default?
At least it should not in the upgrade.

2. Users can still access their holds history using the REST API even if the
pref is off, is that expected?

3. in controller script:

 55 my $borr = Koha::Patrons->find( $borrowernumber )->unblessed;
 56 
 57 $template->param(%{$borr});

Sure we need that?

4. Too many use statements in controller script

5. return (data&&$date(data))||'';
Should be removed (see one of the follow-ups on bug 24980).

6.
koha-tmpl/opac-tmpl/bootstrap/en/includes/usermenu.inc:                [% IF (
OPACPrivacy || Koha.Preference('OPACHoldsPrivacy') == 1 ) %]

OPACHoldsPrivacy is coming from nowhere?

7. why do you need koha_objects_class for items and biblios in the schema? You
should not.

8. DBIC schema adds FK on old_reserves, that's wrong.

9. Even if Signed off already, please squash some patches when needed (rename
of the script for instance).

(In reply to Agustín Moyano from comment #56)
> Basically yes.. seeing that bug 20271 was moving, I suspected that it was
> going to happen in a reasonable time.
> 
> Is it far from happening?, what would you suggest?

Bug 20271 is far from happening, cannot imagine reserves/old_reserves...

-- 
You are receiving this mail because:
You are watching all bug changes.