[Koha-bugs] [Bug 22005] System preference DecreaseLoanHighHolds incorrectly counts the number of holds

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22005

Magnus Enger <magnus at libriotech.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |magnus at libriotech.no

--- Comment #2 from Magnus Enger <magnus at libriotech.no> ---
I wonder if this code is introducing a bit of a off-by-one problem: 

C4::Circulation::checkHighHolds(), line 1230-1234

     # If the number of holds is less than the count of items we have
     # plus the number of holds allowed above that count, we can stop here
     if ( $holds->count() <= $threshold ) {
         return $return_data;
     }

The comment says "less than" but the code says "less than or equal".

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.