[Koha-bugs] [Bug 22887] authorised_values is missing a unique constraint on category + authorised_value

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22887

--- Comment #15 from Lari Taskula <lari.taskula at hypernova.fi> ---
Comment on attachment 101890
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101890
Bug 22887: Warn if duplicates exist

Review of attachment 101890:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=22887&attachment=101890)
-----------------------------------------------------------------

::: installer/data/mysql/atomicupdate/bug_22887.perl
@@ +7,5 @@
> +            GROUP BY category, authorised_value
> +            HAVING c > 1
> +        |, { Slice => {} });
> +        if ( @$duplicates ) {
> +            warn "WARNING - Cannot create unique constraint on authorised_value(category, authorised_value)\n";

Nice to give a warning. We should still make sure the constraint actually gets
created for everyone.

Perhaps delete the duplicates and print & log what was deleted?

Or die instead of warn.

-- 
You are receiving this mail because:
You are watching all bug changes.