[Koha-bugs] [Bug 25078] Stop updatedatabase.pl when a database change cannot be applied

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078

Lari Taskula <lari.taskula at hypernova.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |In Discussion

--- Comment #1 from Lari Taskula <lari.taskula at hypernova.fi> ---
I start from where we left off at Bug 22887 comment 28.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22887#c28

(In reply to Jonathan Druart from comment #28)
> It is what we are doing for years.

I can find only one occurrence that conditionally either alters the schema or
not, and leaves the admin with only a warning. And that was 12 days ago by Bug
18177.

> Dying in the updatedatabase.pl will require more work than just adding a die
> statement. We need to handle the error, propagate it to the UI. The way it's
> done so far will make the change not trivial.

I tested updating via the GUI with a die() and it seems to display it well.

Also we do already have a die() statement in a database update, although a very
old one - but I'm not sure whether Koha handled it better then. I doubt it.

I'll add an attachment for you to see how it looks.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.