[Koha-bugs] [Bug 22778] Suggestions with no "suggester" can cause errors

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Wed Apr 8 11:23:24 CEST 2020


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22778

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Can you provide tests please?

What about doing that instead:

-    if ( $suggestion->{STATUS} ) {
+    if ( $suggestion->{STATUS} && $suggestion_object->suggestedby ) {

That will let us hit the expected "return 1" at the end of the subroutine.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list