[Koha-bugs] [Bug 25033] Counts of suggestions are confusing

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25033

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #14 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
1. Can you rename the "$option" parameter to something more meaningful?
$option let think it's a hashref.

2. Reading filter_by_user_branch I'd say there is a case where we return undef,
and it's not expected (chaining should be allowed).
I'd say the 'else' should be removed, to return $self in any cases.

3. Actually, maybe you should pass the logged in user instead of the
branchcode, that will allow to filter for someone else than the logged in user,
and that will make you remove the test on $userenv. What do you think?

-- 
You are receiving this mail because:
You are watching all bug changes.