[Koha-bugs] [Bug 24715] Cache repeatable subfield in TransformKohaToMarc

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24715

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #102992|0                           |1
        is obsolete|                            |
 Attachment #102993|0                           |1
        is obsolete|                            |
 Attachment #103006|0                           |1
        is obsolete|                            |

--- Comment #21 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 103010
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103010&action=edit
Bug 24715: Cache repeatable subfield in TransformKohaToMarc

Implemented by calling GetMarcSubfieldStructure.

Test plan:
Run t/db_dependent/Biblio/TransformKohaToMarc.t
Optionally, follow the test plan of bug 21800#comment7.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Ere Maijala <ere.maijala at helsinki.fi>

Bug 24715: Improve code of _check_split

This routine may check repeatability in a specific framework, and
return the framework hash. The handling of $mss2 to store that
hash is improved here.

Adding a test in TransformKohaToMarc.t to see if we hit the cache.

Test plan:
Run t/db_dependent/Biblio/TransformKohaToMarc.t

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Bug 24715: (QA follow-up) Remove $mss2 tric

As requested by QA, removing the $mss2 variable. This may lead
to repeated calls to the cache.

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Patches have been squashed for readability.
I also re-add the existing syntax for the _check_split call

-- 
You are receiving this mail because:
You are watching all bug changes.