[Koha-bugs] [Bug 15272] aqbookseller addresses are combined into "physical address" field

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15272

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #15 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I am not sure about this approach goes in the right direction.

I wonder if it wouldn't be better to split the information into multiple fields
in the GUI instead, making it match how we handle addresses for patrons and
libraries.

Pros:
- Allows more than 4 lines in addresses
- Doesn't lose data without notifying the user
- Makes physical and postal address consistent

Cons:
- Special handling is needed in HTML notices to keep line breaks
- Notices: Harder to parse the address if you want different formatting.
Probably possible with TT, but much more complex. Existing notices will have be
updated after update or break. 
- Reports: Existing reports will be broken and it will be much harder to report
on specific information. Example: a report on delivery time of vendors in and
outside the country.
- CSV export: People using serial letters or other ways to create order letters
will have to adapt (this would directly affect us as well)
- Creates inconsistency in address handling with patrons and libraries

Usually we try to avoid creating a need for changes to be made manually after
an update, but I don't think we could avoid that here (reports, notices, CSV
profiles for basket exports etc.)

Some notes for further testing beyond the test plan:
- Export reports on vendor data
- CSV basket and basket group exports
- PDF basket group printing
- Vendors API

Found some more occurrences of address3 in the PDF templates:
Koha/pdfformat/layout2pages.pm:    $text->text($bookseller->address3);
Koha/pdfformat/layout2pagesde.pm:    $text->text($bookseller->address3);
Koha/pdfformat/layout3pagesfr.pm:    $text->text($bookseller->address3);
...

Failing for the last - but maybe we should discuss this a bit more? I hope, I
didn't miss something important.

-- 
You are receiving this mail because:
You are watching all bug changes.