[Koha-bugs] [Bug 22005] System preference DecreaseLoanHighHolds incorrectly counts the number of holds

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22005

--- Comment #8 from Magnus Enger <magnus at libriotech.no> ---
Created attachment 103251
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103251&action=edit
Bug 22005 - DecreaseLoanHighHolds counts holds wrong

There is a small error in how holds are compared to thresholds in
the code related to DecreaseLoanHighHolds. This should fix the
problem.

To test:
- Apply the first patch from this bug, which fleshes out the tests
  a bit. Run the tests with something like this:
  $ sudo koha-shell -c "prove -v t/db_dependent/DecreaseLoanHighHolds.t"
kohadev
  The tests should fail
- Read through the tests and comments and make sure you agree they
  make sense
- Apply this second patch
- Run prove on the tests again
- Check that all tests pass

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.